Josh Stompro [Thu, 2 Mar 2023 18:12:17 +0000 (12:12 -0600)]
LP1744341 Hold targeter --retarget-frozen - upgrade script
Side effect is that frozen holds get checked to see if they are expired.
Normally expire_time is unset when a hold is frozen, but there may have
been some bugs in the past that have allowed frozen holds to have it set.
This will just fix those so no holds get unexpectedly canceled when the
new option is used.
New --retarget-frozen option allows the targeter to include frozen holds
in batch retarget mode. This lets admins periodically update hold copy
maps for frozen holds, which can accumulate links to deleted and
otherwise unholdable copies over time, skewing the hold queueu
positition calculation.
Commit includes release notes.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Josh Stompro <stomproj@larl.org>
Jane Sandberg [Thu, 4 Jan 2024 21:58:16 +0000 (13:58 -0800)]
LP1930099: Make generate_docs.pl Windows-compatible
* Use `npx` rather than relying on specific paths to
binaries within node_modules.
* Use the cross-platform $ENV and File::Copy provided
by Perl, rather than using the platform-specific
command-line syntax.
To test on Windows:
1) Use the instructions provided in the comment at
the top of generate_docs.pl.
2) Make sure that the locally generated documentation
displays correctly in your browser.
To test for regressions on Linux or MacOs:
1) `cd /path/to/Evergreen/docs && perl generate_docs.pl`
2) Make sure that the locally generated documentation
at /path/to/Evergreen/docs/output/index.html displays
correctly in your browser.
Release-note: Allow Windows users to generate the Evergreen manual locally.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org>
Jason Boyer [Mon, 9 Sep 2019 19:29:47 +0000 (15:29 -0400)]
LP1525394: Return Titles for All Hold Types in SIP
The SIP Patron Status Response message can include hold
titles if requested by the SIP client. This commit
adds Issuance holds to the previous commit addressing
part holds, and should finally represent full coverage
for our hold types.
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
blake [Fri, 11 Dec 2015 21:28:17 +0000 (15:28 -0600)]
LP1525394 SIP patron part level holds respond blank
Added code to flesh part level hold information in SIP/Patron.pm
In order to test this, you will need to identify a patron who has
a part level hold. Query SIP with a 63 message like:
6300120151211 104201 Y AOhidden|AApatronbarcode|AC|AY1AZF08D
and the server should respond with the title in the |CD field for that
part level hold.
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Stephanie Leary [Tue, 19 Dec 2023 23:33:32 +0000 (23:33 +0000)]
LP2046820 Add aria-current to current nav menu item
Adds the aria-current="page" attribute to the Angular staff navigation
menu item corresponding to the page being viewed, and styles that link
with a pale green background.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Shula Link <slink@gchrl.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Wed, 7 Feb 2024 14:02:29 +0000 (09:02 -0500)]
LP#2052567: allow Reports to load when BitWarden plugin is active
This patches works around an issue where the legacy Reports interface
can fail to load if the BitWarden plugin is installed on the
user's browser.
To test
-------
[1] Set up your browser with the BitWarden plugin. It looks like it's
necessary to create an account on the BitWarden service or on
a self-hosted instance in order to exercise the bug.
[2] Attempt to load the Reports interface. It should fail to load.
[3] Apply the patch and repeat step 2. This time, the interface should
load and function normally.
Release-note: Fixes issue where Reports interface would not load if the BitWarden browser plugin is installed
Steven Mayo [Thu, 30 Nov 2023 16:30:49 +0000 (11:30 -0500)]
LP#2028095: Fix typo in Library Setting Description for acq.default_owning_lib_for_auto_lids_strategy
Updated the description for acq.default_owning_lib_for_auto_lids_strategy to the text suggested in the ticket.
Release-note: Improves description of the "How to set default owning library for auto-created line item items" Library Setting
Steps to test:
[1] Run XXXX.data.default_owning_lib_for_auto_lids_strategy_typo_fix.sql or install the seed data anew
[2] Go to Administration -> Local Admin -> Library Settings Editor
[3] Search for acq.default_owning_lib_for_auto_lids_strategy
[4] Read description
Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Tue, 12 Dec 2023 17:49:24 +0000 (17:49 +0000)]
LP2023803 Replace btn-warning with appropriate color
Replaces all instances of .btn-warning, which has poor color contrast,
with other button colors. Actions that reset forms or delete data use
.btn-destroy; other instances may use .btn-info or btn-normal depending
on their context.
Terran McCanna [Wed, 24 Jan 2024 18:39:49 +0000 (13:39 -0500)]
LP2051156 Mark Item as Missing Pieces barcode field too wide
Prior to this change, the barcode input field was the full width of
the screen and the submit button was below it. This small change makes
it more consistent with other screens.
Release-note: Fixes overly large barcode field on Mark Item as Missing Pieces page.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
FMRecordEditorComponent was depending on the @reporter:datatype to
identify the primary key (identity) field for an FM class. Instead, it
should check the field name against the @oils_persist:primary attribute
of the <fields> element, which gets around the special case of org unit
id having a declared datatype of "org_unit", and future-proofs against
other possible edge cases.
This commit does that.
To test
-------
[1] Update the Organizational Units page's form to include "id" as
a visible field, a la bug 2051879.
[2] Note that the form display a selector.
[3] Apply the patch and recompile the Angular staff client.
[4] This time, the OU ID should display as a read-only number.
Release-notes: Makes it possible to display the org unit ID as a number on Angular record editor forms for editing org units
Josh Stompro [Thu, 3 Aug 2023 19:58:52 +0000 (14:58 -0500)]
LP#1329872 - marc_export exit when required IDs are missing
The marc_export script would handle being passed invalid or empty
IDs as if you had the --all flag selected. So if you accidentally
generated a file with a list of BIB id numbers that was empty and
passed it to the script, you would end up with an export of all bibs
in the system instead of an empty export.
Testing Notes:
=== Before fix ===
Create an empty file, or a file that just contains "id".
$ touch input1
$ echo "id" > input2
All these commands should result in a full export of all bibs.
Terran McCanna [Fri, 29 Dec 2023 19:58:14 +0000 (14:58 -0500)]
LP2047704 Patrons with Negative Balances - Grid Columns
This adjusts the negative balances grid so that it shows the most
useful columns by default and upon reset. (Before this change,
resetting the columns showed ALL available columns.)
It also adds local column sortability.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Stephanie Leary [Mon, 4 Mar 2024 20:40:15 +0000 (20:40 +0000)]
LP1803788 Gear icon for AngularJS grid settings menu
Changes the icon for the grid settings dropdown menu in AngularJS
screens from the default Bootstrap downward caret to the gear icon, to
match the Angular grid buttons.
Release-note: Ensures that both AngularJS and Angular grids use a gear icon for the grid settings menu.
Galen Charlton [Tue, 5 Mar 2024 20:27:13 +0000 (15:27 -0500)]
LP#2056204: support "Form of item" in MARC editor for electronic resources
This patch adds mappings to the Angular and AngularJS MARC editors
so that the "Form" (form of item) fixed field positions in the 006
and 008 fields are recognized and (in the case of the 008) editable
via the "Form" input when the record type is "m" (electronic resources/computer files).
Release-note: Fixes problem where "Form" value could not be saved in MARC editor for electronic resources.
To test
-------
[1] Open a bib record of type 'm' (electronic resource) in the Angular
MARC editor.
[2] Change the form value with the input labeled "Form".
[3] Note that the corresponding position in the 008 is not updated.
[4] Apply the patch and repeat steps 1-3. This type, the change
should stick.
[5] Bonus: do the same testing in the AngularJS MARC editor.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Stephenson [Thu, 22 Feb 2024 15:29:26 +0000 (10:29 -0500)]
LP2050227: Fix IDL after validation with xmllint
Fix "relteype" for "reltype" typo on line 1490.
Remove redundant (and empty) retrieve permission on old line 7339.
The above resolve errors reported by `xmllint --scheam fm_IDL.xsd
fm_IDL.xml`:
fm_IDL.xml:1490: element link: Schemas validity error : Element
'{http://opensrf.org/spec/IDL/base/v1}link', attribute 'relteype':
The attribute 'relteype' is not allowed.
fm_IDL.xml:1490: element link: Schemas validity error : Element
'{http://opensrf.org/spec/IDL/base/v1}link': The attribute
'reltype' is required but missing.
fm_IDL.xml:7339: element retrieve: Schemas validity error :
Element
'{http://open-ils.org/spec/opensrf/IDL/permacrud/v1}retrieve':
This element is not expected. Expected is one of (
{http://open-ils.org/spec/opensrf/IDL/permacrud/v1}update,
{http://open-ils.org/spec/opensrf/IDL/permacrud/v1}delete ).
fm_IDL.xml fails to validate
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Stephenson [Wed, 21 Feb 2024 15:09:22 +0000 (10:09 -0500)]
LP2050227: Update fm_IDL.xml required fields
Add the oils_obj:required="true" attribute to the IDL fields that are
actually required by the database. A required field is one that
derives from a base table column that has a "NOT NULL" constraint and does
not have a default value.
IDL objects that are virtual or read-only are skipped as are virtual
fields.
Fields that already have the oils_obj:required attribute set are not
changed, even if the fields do not meet our criteria for being
required.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Mon, 18 Mar 2024 15:09:17 +0000 (11:09 -0400)]
LP#1869971: (follow-up) also apply HTML::Defang in the OPAC templates
This patch ensures that HTML::Defang (via the defang_string() TT helper)
is applied to the value of the OPAC custom CSS library setting. This
provides additional protection in cases where questionable values
predate these patches or if another means (such as direct database entry)
is used to set the value of the setting.
Stephanie Leary [Tue, 12 Mar 2024 03:26:11 +0000 (03:26 +0000)]
LP2057432 Add shadows to dropdowns and active tabs
Release-Note: Adds drop shadows to open dropdown menus and active tabs
in the Angular staff interfaces to help set them apart from the contents
of the page.
LP#2034617: improve how AngularJS handles logout BroadcastChannel messages
This patch reduces the risk that if there are multiple tabs of the
AngularJS staff client open, that logging out from one of them will
cause a storm of logout messages on the eg.auth BroadcastChannel.
If the open staff client tabs are all AngularJS, the result of that
storm can freeze the user's browser. However, if one or more of
the tabs are running the Angular client, the Angular tabs can
_also_ make repeated open-ils.auth.session.delete calls at a high
rate of speed, thereby degrading the availability of the
open-ils.auth service.
Testing involves opening up 4 or 5 tabs running the staff client, with
at least three or four of them running the AngularJS client. It
is strongly recommended that testing of this patch be done only on
personal, isolated test Evergreen systems.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Galen Charlton [Tue, 30 Jan 2024 15:19:22 +0000 (10:19 -0500)]
LP#2051599: fix parsing of start and end dates by Cash Reports
This patch fixes a bug where if you open the Cash Reports at a
time of day where the date in the local time zone is different
from the date in UTC and do not interact with the date selectors,
the report will not display payments made during the current day.
The problem was due to the use of Date.toISOString() when
attempting to extract just the date component; since Date.toISOString()
forces the timestamp to UTC. The effect is that if you (say) open
the Cash Reports page in North America sufficiently late in the date,
the date selectors will display your current date, but the query
to fetch payment information will (silently) supply the following day.
To test
-------
[1] Make some patron bill payments.
[2] Open the Cash Reports at a time of day when an UTC clock would
report a different date from your local date. Observe that no
payments are listed or that payments from the previous day are
listed.
[3] Apply the patch and repeat step 2. This time, opening the Cash
Reports page should show the payments for the current day.
Release-note: Fix bug that could cause the Cash Reports page to display payments for the wrong day.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Tue, 23 Jan 2024 16:57:53 +0000 (11:57 -0500)]
LP#1779743: add privilege expiration date to Group Member Details
This patch adds the privilege expiration date to the list
of available columns in the AngularJS group member details
page. No equivalent change is needed to the experimental Angular
circ interface, as that column is already available there.
To test
-------
[1] Apply the patch.
[2] Navigate to a patron in the Evergreen staff interface
and view the Group Member Details page.
[3] Verify that the privilege expiration date is now available
in the column selector.
Release-note: Add privilege expiration date column to Group Member Details table
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Jane Sandberg [Mon, 11 Mar 2024 03:20:42 +0000 (20:20 -0700)]
LP2056480: docs: only index the latest version of the docs for lunr
This addresses a regression caused by bug 2056480.
To test:
* Build the docs using
cd docs
perl generate_docs.pl --base-url=http://example.com
* Open docs/output/index.html in your browser
* Type a search into the search box
* Note that you only get results for latest, rather than getting duplicate
results from multiple versions.
* Note that the file docs/output/search-index.js is now 3.3 MB, rather than
5.53 MB.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
* Update generate_docs.pl help text to note the new
default version
* Clean up more aggressively before installing Antora; I
discovered that if you switch from 2.3 to 3.1.7 without
doing so, the older version of the CLI still gets used
(and fails because 2.3 predates Antora's extension mechanism)
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
This patch updates the version of Antora used to build the documentation
to a supported release.
* Uses the new @antora/lunr-extension, rather than the antora 2 antora-lunr
* Fixes a few issues that are no longer supported in the new version of
asciidoctor
* Installs antora via the antora npm package, rather than installing
@antora/cli and @antora/site-generator separately
Release-note: Update the version of Antora used to build the documentation
Co-authored-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Co-authored-by: Robin Fitch <rfitch@biblio.org> Co-authored-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org> Co-authored-by: Debbie Luchenbill <debbie@mobiusconsortium.org> Co-authored-by: Lena Hernandez <lena.hernandez@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Terran McCanna [Mon, 29 Jan 2024 16:48:04 +0000 (11:48 -0500)]
LP2051566 Make Angular Grid Column Headers Bold Again
A recent update changed the Angular grid column headers from
A links to buttons, which broke the CSS chain and they lost
their bold weight. This restores that.
Release-note: Restores bold weight to eg-grid column headers
Galen Charlton [Mon, 29 Jan 2024 15:30:58 +0000 (10:30 -0500)]
LP#2051250: restore bold styling in PO summary when PO is paid off
This patch fixes a regression on bug 1999270 introduced by a patch
for bug 2000482.
To test
-------
[1] Create a purchase order whose full amount is paid off.
[2] View the order and note that the '$X Paid' text is red but not bold.
[3] Apply the patch and review the order again. This time, the text
in the PO summary should also be bold.
Release-note: Restore bold styling of paid off amount in purchase order summary.
Jane Sandberg [Wed, 28 Feb 2024 14:25:27 +0000 (06:25 -0800)]
LP1991103: incorporate feedback from review, address failing test
* Remove icon from tab
* Don't use warning styling
* Add spacing between the tab title and its number
* Make the test amenable to any number of spaces between the tab
title and number; it doesn't really matter how many there are,
but there needs to be at least one.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Sun, 18 Feb 2024 22:59:37 +0000 (14:59 -0800)]
LP1991103: Display a count of record notes in the staff catalog tab
To test:
1. Apply this patch.
2. Open a record in the staff catalog.
3. Add some record notes. Note that the tab updates with the number of
record notes on the record.
4. Delete some record notes. Note that the tab still updates
accordingly.
5. Leave and come back to the record. Note that the number still
persists in that tab.
Release-Note: Show the total number of record notes in the Record Note tab in the staff catalog.
Sponsored-by: PaILS Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 29 Feb 2024 14:26:45 +0000 (09:26 -0500)]
LP#2021862: (follow-up) improve visibility of inline help text
The font-weight and color are from a suggestion from Stephanie Leary
(and also fix a color contrast issue on the darker zebra-striped
rows); the italics are from me.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Stephanie Leary [Thu, 1 Jun 2023 15:56:05 +0000 (15:56 +0000)]
LP2021862 Remove placeholders from fm-editor
Removes placeholder attributes from the input fields in the fieldmapper
editor, to make it clearer to users which fields have not been filled
out.
Help text is moved from a tooltip to a persistent .form-text area, which
is placed first in the source order for screen reader users' benefit but
appears below the input visually.
Also attaches the Translate button to its input field and prevents it
from wrapping to the next line.
Release-note: Removes placeholder attributes from inputs in the Angular record editor and display field help directly rather than in a tooltip. Also moves the translate button next to text inputs for translatable fields.
Galen Charlton [Wed, 28 Feb 2024 12:35:53 +0000 (07:35 -0500)]
LP#1828463: (follow-up) tweak focus outlines for buttons that are dropdown items
This patch makes the focus outline for buttons that are dropdown items
(e.g., Retrieve Last Bib Record in the Cataloging menu) match the
new style. This avoids the opacity of the focus outline from changing
when navigating between items in the nav menus that can contain
a mixture of anchors and buttons.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Etheridge [Tue, 9 Jan 2024 14:50:29 +0000 (09:50 -0500)]
LP2012971 Item Alerts Not Editable
Release-notes: Fixes invocation of (Manage) Item Alerts dialog in Holdings Editor
Release-notes: Adds batch edit for Item Alerts in Holdings Editor. Alerts get grouped together for editing if they are mostly identical
Release-notes: Adds Manage Alerts button to Item Alerts dialog during alert display in Angular ("eg2") interfaces.
Release-notes: Fixes TypeError: defaults is null exception for missing Default Item Alert Type preference
Release-notes: Adds a Changes Pending indicator for Holdings Editor
Note that we do not address LP2044028 where multiple invocations of the
Item Alerts dialog in the Holdings Editor do not show pending changes
prior to a Save.
Example testing:
In staff client with Concerto dataset,
Cataloging -> Retrieve Bib Record By ID -> 1
Holdings View -> Show Copies
Select lines 5 and 6 (for CONC40000536 and CONC41000536)
-> Edit: Edit Items
-> Add Item Alerts: Item Alerts
Should see a dialog for "Managing alerts in common for 2 item(s)."
Normal Checkout, Test Note 123 -> Add New, Apply Changes
Should see a CHanges Pending label before Apply All & Save
Apply All, Save & Exit
Back in Holdings View,
Select lines 5 and 8 (for CONC40000536 and CONC4000036)
-> Edit: Edit Items
-> Add Item Alerts: Item Alerts
Should see a dialog for "Managing alerts in common for 2 item(s)."
Should not see the "Test Note 123" alert.
Close tab
Back in Holdings View,
Select lines 5 and 6 again
-> Edit: Edit Items
-> Add Item Alerts: Item Alerts
Should see a dialog for "Managing alerts in common for 2 item(s)."
Should also see the "Test Note 123" alert.
Close tab
Circulation -> Check Out 99999372363 -> Submit
In the URL, change /eg/ to /eg2/ for the experimental Angular circ interface
CONC40000536 -> Submit
Should see the Item Alerts dialog with the Test Note 123 alert.
Should also see a Manage Alerts button in the dialog.
Manage Alerts
Should see a new dialog, "Managing alerts for item CONC40000536",
which is the same Item Alerts dialog from the Holdings Editor.
Changes in this dialog are not reflected in the original Item Alerts
dialog from which it was spawned.
Signed-off-by: Jason Etheridge <jason@equinoxoli.org> Signed-off-by: Carol Witt <wittc@cwmars.org> Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Terran McCanna [Tue, 24 Oct 2023 21:26:52 +0000 (17:26 -0400)]
LP1909585 Use full title on book list csv download
Adds subfield n and subfield p to CSV download for lists in the OPAC
in order to match the screen display.
To test:
1 - Create a List in the OPAC
2 - Add a record to the list that has subfields n and/or p (Concerto record id 224 has both)
3 - Download the CSV for the list to confirm that the full title appears
Release-note: Adds 245$n and 245$p to the title field in public catalog list CSV download, to better distinguish between multiple titles in the same series.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Boyer [Tue, 16 Jan 2024 21:05:50 +0000 (16:05 -0500)]
LP1582720: Ignore Duplicate Scoped URIs - BPAC
When displaying scoped URI call numbers (subfield 9's), ignore duplicate
URIs that can be caused by multiple subfield 9's on the same link.
Release-note: (OPAC) Ignore duplicate links from 856 fields with multiple $9's Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Stephanie Leary [Mon, 12 Feb 2024 19:03:32 +0000 (19:03 +0000)]
LP2052960 Remove button markup from record actions
Removes errant <button> elements that were nested inside the Patron View
and Place Hold links (in the bib record actions row of buttons below the
summary box). Buttons inside links are unnecessary and created an extra
tab stop when navigating the page via keyboard. Classes have been moved
to the <a> element to retain styling.
Release-note: Remove extra tab stops when navigating bib record actions in staff client using keyboard
Galen Charlton [Sat, 17 Feb 2024 16:13:11 +0000 (11:13 -0500)]
LP#2054128: OPAC autosuggest now gets closed when input loses focus
This patch ensure that the autosuggest list goes away when
the basic search box in the OPAC loses focus. Otherwise, it
can obscure controls that the user is trying to interact with.
To test
-------
[1] Enter a search term in the OPAC and observe that the
dropdown of suggestions appears.
[2] Tab or click away from the input. Note that the dropdown
remains open.
[3] Apply the patch and repeat steps 2 and 3. This time, the
dropdown should get closed.
Release-note: Close autosuggest dropdown in the public catalog when it loses focus.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Tue, 13 Feb 2024 16:52:50 +0000 (11:52 -0500)]
LP#2053035: return ability to submit OPAC basic search via enter
This patch fixes an issue with the current autosuggest implementation
that prevented submitting the form while focus is on the main
text input.
To test
-------
[1] Apply patch. Do the following tests using both keyboard
and mouse navigation.
[2] Verify that submitting a search without selecting any
of the suggested terms works.
[3] Verify that submitting a search after selecting one
of the suggestions works.
[4] Verify that submitting the search after using the keyboard
to navigate the selections, but ultimately not choosing
any of them, works.
[5] Run automated tests, e.g., by running
Release-note: Restore ability to submit basic OPAC search by hitting enter in search input.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: blake <blake@mobiusconsortium.org>
Chris Sharp [Sun, 12 Nov 2023 17:19:24 +0000 (12:19 -0500)]
LP#1901932: Do not add unused org settings to enhanced dataset.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
blake [Wed, 17 May 2023 15:48:11 +0000 (10:48 -0500)]
LP#1901932 Enhancing the enhanced concerto dataset
- A date carry forward feature that carry's the various date columns
forward based upon the difference between today's date and the create_date
for asset.call_number in the dataset. Which is the default. This can be
skipped with with: psql -v skip_date_carry='1' -f load_all.sql
- Expansion of special cases for certain tables:
config.metabib_class, config.org_unit_setting_type, config.global_flag.
- Dropping these tables from consideration:
acq.acq_lineitem_history, acq.acq_purchase_order_history, permission.perm_list
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Adding seq
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
AccessHandler.pm did not look for the newer eg.auth.token session cookie
so it was not possible to clear the added content cache unless the old ses
cookie was somehow set first. Now AccessHandler.pm will look for both cookie
names.
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Wed, 31 Jan 2024 16:04:11 +0000 (11:04 -0500)]
LP#1939162: add option to clear added content cache to Angular staff catalog
This patch restores the ability to clear the added content cache
to the staff catalog by adding a "Clear Added Content Cache" item
to the Other Actions menu on the Angular staff catalog record page.
As with the former embedded staff catalog, clearing the added content
cache does not result in the staff catalog attempting to automaticaly
reload the cover image; the user will still need to reload the page
to see if the change has taken effect. Improving that behavior would
be for a separate bug.
This patch also includes a fix to tag an unrelated string for
localization.
To test
-------
[1] Ensure that at an added content handler is active.
[2] Install the patch.
[3] Navigate to a bib record in the Angular staff catalog.
[4] Observe that there is a Clear Added Content Cache item
in the Other Actions menu.
[5] Click it and note that a toast stating that the cache was
cleared is displayed.
[6] (extra credit) Test while making changes to the record (say
to the ISBN) that would result in a different cover image
being provided by the added content source.
[7] (extra credit) Update opensrf.xml to remove the added content
handler, restart services and Apache, then try the cache-clearing
action. This time, toast should be displayed stating that the
action failed.
Release-note: Adds a "Clear Added Content Cache" item to the Other Actions menu in the staff catalog record page.
Tiffany Little [Wed, 13 Dec 2023 21:30:21 +0000 (16:30 -0500)]
LP2040637 Reverse fund dropdown regression
Returns Dojo behavior of compiling fund view based on perms rather than work OU.
Release-note: The fund dropdowns for line items and direct charges on purchase orders now display funds that user has permission to use.
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
The patch for bug 2045581 ensured that eg-org-family-select's ariaLabel
attribute would propagate to the enclosed eg-org-select, but did not
update a mock in eg-org-family-select's tests. This patch fixes that.
Release-note: [Developer] Fixes test failure in Angular staff client
Galen Charlton [Wed, 14 Feb 2024 14:28:03 +0000 (09:28 -0500)]
LP#1890822: (follow-up) update comments and documentation
This patch adds a comment to clarify that the database transaction
isolation level must be "read committed" (as is the default for Pg)
in order for penalties created in one transaction to be seen by another
one. It also extends the documentation to cover behavior for SIP2
checkouts and renewals.
Jane Sandberg [Tue, 13 Feb 2024 21:44:37 +0000 (13:44 -0800)]
LP1890822: incorporate feedback from review
* Put the penalty calculation in its own transaction, so
applicable penalties remain on the patron account, even
if the circulation is canceled.
* Don't hard-code a list of threshold-based penalties in
the penalty calculation call. calculate_penalties only
concerns itself with threshold-based penalties anyway,
so there was no need to enumerate them (and I missed
two anyway).
* Update a comment to better match the new state of affairs.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Tue, 2 Jan 2024 03:33:58 +0000 (19:33 -0800)]
LP1890822: Don't checkout in cases where a patron is eligible for a penalty, but hasn't received it yet
To test:
1. In Local Admin > Group Penalty Threshold, set the
PATRON_EXCEEDS_OVERDUE_COUNT threshold to 1.
2. Find a patron who has more than 1 overdue.
3. Try to check another item out to the patron.
4. Confirm that you get an alert PATRON_EXCEEDS_OVERDUE_COUNT
and the item does not check out.
Note that this adds a penalty check to the checkout logic, rather than
to the patron retrieval logic as suggested in
https://bugs.launchpad.net/evergreen/+bug/1983621, since this will also
address SIP checkouts.
Also adds characterization tests for relevant stored procedures.
Release-note: Fix bug that allowed one checkout after a patron had reached a group penalty threshold, for example PATRON_EXCEEDS_OVERDUE_COUNT or PATRON_EXCEEDS_CHECKOUT_COUNT.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Sponsored-by: PaILS Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
projects / working / Evergreen.git / log