Joseph Lewis [Wed, 1 Jun 2011 01:19:57 +0000 (19:19 -0600)]
Nearly finished with both of the asset_call_numbers all that is left is db updating, i18n and adding the stuff to the evergreen staff client. Oh, and perhaps some sql to auto-generate functions, although I can't seem to figure that one out yet.
Add permission checking for updating and deleting volumes.
This addresses LP #784062 reported by Ben Shum, and I think others?
Creating volumes was already covered. The ability to delete volumes
without permission would be less often an issue in practice since you
would need permission to delete the volume's copies before you could
delete the volume itself.
Jason Etheridge [Wed, 18 May 2011 05:05:17 +0000 (01:05 -0400)]
Include call number prefix/suffix in display and sorting of holds for Print Full Pull List (Alternate strategy). Also fix things so that we're sorting on the label_sortkey for call number, and not the label. So, for this interface, the hard-wired sort order is Copy Location Order (as defined by Admin -> Local Administration -> Copy Location Order), Call Number Prefix, Call Number Label, Call Number Suffix, and Hold Request time.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Jason Etheridge [Wed, 18 May 2011 02:27:07 +0000 (22:27 -0400)]
have the call number checkbox for pocket labels include prefix/suffix. A %call_number% macro is still available for the bare call number label without affixes
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Jason Etheridge [Wed, 18 May 2011 02:24:21 +0000 (22:24 -0400)]
Can't use encodeURI and decodeURI for everything with persist_helper (in particular, something like "%macro1% %macro2%" as a custom entry in the label interface), so try/catch them and fall back to the original behavior.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Dan Scott [Tue, 17 May 2011 04:29:47 +0000 (00:29 -0400)]
LP#783486: Improve authority lookup performance
Testing showed that the two indexes added herein improve
authority lookup performance radically; on a 16 GB RAM
database server with 1.1M records, lookup times decreased
from 5500 ms to 0.223 ms. Recommended, would EXPLAIN ANALYZE
again.
Jason Etheridge [Mon, 16 May 2011 16:12:40 +0000 (12:12 -0400)]
persist partial changes to new copies in vol/copy editor has new copies are gathered.
In other words, you can do something like enter 5 in the "# of Copies" field, enter the first barcode (say b1), edit an attribute (say, set Circulate = No), and then enter a second barcode (b2). Previously, the changes made to b1 would be lost as b2 was entered (or as other movement around the barcode entry textboxes happened) and both copies would get a Circulate = Yes, but now in this scenario, you would see 1 copy set to No and 1 copy set to Yes for the Circulate attribute.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
miker [Fri, 13 May 2011 17:31:18 +0000 (17:31 +0000)]
Patch from Ben Ostrowsky (LP#782268) to simplify seed/example permission setup and move one step towards being able to rid ourselves of permission.perm_list.id
dbwells [Fri, 13 May 2011 16:02:18 +0000 (16:02 +0000)]
A bevy of MFHD bug fixes (and test cases)
1) Remove hard-coded 'gap' text from format_part()
2) Honor $ypm## for chron_to_date() for annuals
3) Removed overly simple check on $w as digit
4) Allow for combined chronologies other than 2nd level
5) Make calendar changes trump $u counts
6) Honor issue restarts at calendar changes
7) Rudimentary support of $u counts for non-restarting issue numbering
8) Special interpretation of $yps for early winters (i.e. winter is the first season of the calendar year)
9) Teach chron_to_date() about early winters
The last two points deserve some special attention. A large number of journals consider 'Winter' to be the first season of the year, so Winter 2011 means (roughly) January 2011, not December 2011. However, there is no explicit way to indicate this in the standard, and also the code relies in many ways on the fact that 24 (chronology code for winter) is greater than 21 (code for spring). To work around this, we are interpreting a certain ambiguous pattern in a particular way. Specifically, if you set $w to a digit, then set $y to 'ps24,21,22,23' (or some variation with '24' as the first value), you will get this winter-first behavior. Also, the season is treated internally as '20' then converted to '24' when processing is completed.
Author: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20447 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Thu, 5 May 2011 18:40:18 +0000 (18:40 +0000)]
Use valid JSON in Dojo i18n for Searcher.js
Dojo i18n processing scripts require valid JSON (quoted keys in hashes),
even though Dojo itself is more relaxed and accepts unquoted keys. So,
do the i18n dance here.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20438 dcc99617-32d9-48b4-a31d-7c20da2025e4
senator [Thu, 5 May 2011 16:44:23 +0000 (16:44 +0000)]
Patch from Niles Ingalls to make patron phone number searching more matchy.
With assistance from Mike Rylander on pointing out the needed indexes to keep
search fast, and from Mike Peters on arranging a last minute DCO :-)
Type numbers into a patron phone number field and get a match regardless of
the punctuation actually used in the database.
senator [Thu, 5 May 2011 15:43:09 +0000 (15:43 +0000)]
Add a feature authored by Joscha Filius for the International Institue of
Social History: a diacritical palette for the MARC editor!
Afelonne Doek of IISH wants the community to benefit from this code. To try
it out, press control S in the marc editor (reguarly non-flat-text view).
You can insert the characters you see, and you can right click on entries in
your palette to customize. Customizations /should/ persist through staff client
restart (untested by me so far).
This should make cataloging in multiple (Western-ish) languages at once easier.
Below I copy and paste some of Joscha's message to the list where he introduced
this code:
> *Bugs:*
> A known bug is that is you switch marc edit styles back and forth the
> listener trigger won't work anymore. Also for a far as I know there is at
> least another bug concerning layout which is as far as I know not the result
> of my doing.
>
> *Here comes a possibly nasty part*, to ensure that the diacriticals remain
> intact throughout the persist I've changed global_util.js to URL encode and
> URL decode all stored values. This might cause backwards incompatibility
> with values that are already stored for other purposes without encoding.
> This needs to be checked.
dbs [Thu, 5 May 2011 04:40:28 +0000 (04:40 +0000)]
Remove redundant plpgsql install step from README
PostgreSQL 9.0 includes plpgsql by default, and running the
createlang plpgsql step throws an error that could concern
the installer. Drop the step from the README.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20424 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Wed, 4 May 2011 04:43:48 +0000 (04:43 +0000)]
Change an ERROR to a DEBUG log message in mod_idlchunk
Reported by James Fournie at Sitka, this message was logged
as an error when it is simply a debug message; we drop the
level accordingly so that it will not appear in the Apache
logs during the normal course of operations.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20398 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Wed, 4 May 2011 03:47:19 +0000 (03:47 +0000)]
Prevent uninitialized var warnings in OpenILS::WWW::SuperCat::unapi
Given a tag URI like tag:localhost,2011:biblio-record_entry/1 with
no format, Evergreen was throwing uninitialized variable warnings
and attempting to invoke "open-ils.supercat..formats" due to the
unitialized $type variable, which resulted in an Apache error.
On the TT OPAC, this enables Zotero to successfully offer import
of all entries on the search results page. On the AjaxPAC, it seems
that Zotero parses the page before the unAPI hrefs have been supplied
by JavaScript.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20391 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Tue, 3 May 2011 16:32:52 +0000 (16:32 +0000)]
Avoid data loss by setting MARC::Charset->assume_unicode(1)
When using MARC::File::XML, MARC::Charset is used to perform character
conversions; however, MARC::File::XML does not tell MARC::Charset that it is
handling Unicode data. If we do not tell MARC::Charset that it is handling
Unicode data, it can return an error which results in the loss of data
(typically a subfield containing one or more characters which MARC::Charset
does not have an equivalent mapping outside of Unicode).
This problem could be reproduced in authority_control_fields.pl with a
subfield like "von Hans-Christian Müơller" - when this subfield was encountered
without assume_unicode(1), a null string was returned for that subfield, and
if the record was written back to the database due to an authority match being
found in a different field, the only recourse was to restore the record from
auditor.biblio_record_entry_history. The same sort of problems could occur
for any other script or function that modifies the data being handed to it
using MARC::File::XML and BinaryEncoding => UTF8.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20386 dcc99617-32d9-48b4-a31d-7c20da2025e4
miker [Tue, 3 May 2011 14:57:50 +0000 (14:57 +0000)]
Patch from Jason Stephenson ( LP#770261, https://bugs.launchpad.net/evergreen/+bug/770261 ) adding support for bibliographic level inspection in the hold and circ matrix matchpoint tests.
dbwells [Mon, 2 May 2011 21:00:18 +0000 (21:00 +0000)]
Add support for sre/distribution summary methods (including merge), advanced receiving, and unit-less receiving in the serial control items tab
This commit includes three new minor features for the Serial Control interface. First, you are now able to set the latent 'summary_method' field on distributions, with the most significant new setting being 'merge with sre'. This setting effectively combines the sre marc with the generated holdings to form a single unified statement. Second, the previous 'receive' functionality has been renamed to 'advanced receive', and 'receive' will now show items from an entire subscription, but not allow you to receive directly into a specific unit (you can still receive into new/auto units). Third, a basic menu entry has been added for receving into 'no unit', allowing items to be received not forcing them to be unitized.
phasefx [Mon, 2 May 2011 15:05:10 +0000 (15:05 +0000)]
flesh stat_cat_entries in the call number tree method used by Holdings Maintenance, since those copies get shoved into the copy editor and we want stat cat entries to show up there
phasefx [Mon, 2 May 2011 14:06:19 +0000 (14:06 +0000)]
Fix bug and typo in stat cat editor
Specifically, disabling the ability to select a stat cat type on no permissions on current type.
If you don't have permissions on ASSET you could never get to ACTOR.
If you picked ACTOR without rights you couldn't get back to ASSET.
Also, re-enable the library selector and new buttons when you do change to one you can add for.
Author: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20372 dcc99617-32d9-48b4-a31d-7c20da2025e4
phasefx [Mon, 2 May 2011 13:21:10 +0000 (13:21 +0000)]
fix "undefined is in transit"
https://bugs.launchpad.net/evergreen/+bug/773528
---
Fix bug squashing of params in checkin_via_barcode2 in circ/util.js.
Author: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20369 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Sun, 1 May 2011 12:12:48 +0000 (12:12 +0000)]
Slight optimization for authority_control_fields.pl
Instead of creating two CStoreEditors per bib record, reuse the global
CStoreEditor for read operations; this way we only have to create a new
CStoreEditor if a record has fields to authorize.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20357 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Sun, 1 May 2011 00:29:51 +0000 (00:29 +0000)]
Add excerpt AC and avoid rate-limiting for OpenLibrary content
OpenLibrary added rate-limiting (100 cover requests per 5 minutes)
for cover images requested by ISBN; using the OpenLibrary book
API to pull the list of direct cover URLs avoids the rate limit.
Also, add excerpt added content calls for OpenLibrary.
Signed-off-by: Dan Scott <gitorious@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20355 dcc99617-32d9-48b4-a31d-7c20da2025e4
Update Makefile.install and README for PostgreSQL 9.0
Along with cleaning out references to Debian Etch, Debian Lenny,
Ubuntu Hardy, add the Debian Squeeze, Ubuntu Lucid, and Fedora 14
PostgreSQL 9.0 repo locations, and convert the README to Asciidoc
syntax.
Remove references to Fedora 13 and genericize it for Fedora 14
(with the thought that Fedora 15 will probably be coming out
soon). Also add PostgreSQL 9.0 packages as a target for the
database server in Makefile.install.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Bill Erickson <berick@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20353 dcc99617-32d9-48b4-a31d-7c20da2025e4
For copy details change the barcode to a link to the item status.
This only applies to the staff client itself due to an isXUL check first.
This allows for a staff member to get more details on the copy with a single click, rather than copy/paste of the barcode.
Author: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20350 dcc99617-32d9-48b4-a31d-7c20da2025e4
Consolidate on checking for integers for -full / -uris
The check for an integer when $flesh eq 'uris' was throwing errors
and breaking authority browsing; rather than complicating matters
further, use an explicit integer for the return value when the format
ends with "-uris" so that we can simply test for an integer value
greater than 0.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20336 dcc99617-32d9-48b4-a31d-7c20da2025e4
Prevent a MARC::File::XML error from killing authority_control_fields.pl batch
Continuing to make this script bullet-proof, MARC::File::XML cares deeply
about things like whether datafields have indicators and throws exceptions
that, if not caught, kill a processing script - like this one.
Borrowing the approach from marc_export, wrap the new_from_xml() call in
a try / otherwise block and roll on.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20333 dcc99617-32d9-48b4-a31d-7c20da2025e4
Hold, Transit, and Hold/Transit Slips used to suppress the printer dialog, but we lost that when we moved to templated slips. This adds a sticky Printer Prompt checkbox to Check In for controlling that behavior.
Setting print.always_print_silent to false is a bad thing, since it trumps gPrintSettings.printSilent, and will cause a print dialog regardless of Printer Prompt or Auto-Print checkboxes. Let's clear it instead when toggling it off, and if we find it lingering as false from past code, let's clear it then too.
Protect against errors returned by open-ils.search
If open-ils.search returns an error rather than a result, prevent
authority_control_fields.pl from bombing out completely; instead,
flag the problem in STDERR and move on to the next record.
Make authority_control_fields.pl resistant to database timeouts
LP 771237 describes how on an underpowered system, the work that
authority_control_fields.pl tries to do on a per-record basis may hit the
CStore default timeout of 6 seconds for a transaction and automatically
end the transaction, resulting in no work being committed once the script tries
to update the bibliographic record. Searching each controlled field for a
matching authority record can be costly in a database with millions of
authority records.
To enable the script to accomplish its work on underpowered test systems, use a
regular read-only CStoreEditor session to accomplish the lookups and create a
separate CStoreEditor session to issue the update in a transaction if required.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20312 dcc99617-32d9-48b4-a31d-7c20da2025e4
Add i18n support to the User Editor / registration interface
Per LP # 754898, the Register Patron interface currently contains
many hardcoded strings. Given that the previous patron registration
interface supported translation, this is a regression in 2.0.
Accordingly, we extend the use of Dojo i18n support to provide the
strings for buttons and a number of labels on the Register Patron
interface. The bulk of the remaining text is provided by the fieldmapper
definitions, which should in theory be translated automatically for us.
Disable Save Columns in xul holds interface when Hold Details is being viewed. https://bugs.launchpad.net/evergreen/+bug/691599 Not the best fix, but the quickest fix
Specifically, we prune subplans that contain no nodes (empty parens), and avoid dropping out of the top level query context when we encounter a close-paren.
org unit setting for making unified Volume/Item interface optional. fix the volume interface in its standalone incarnation, and tweak the label for editing items in holdings maintenance
Don't disable the Create Volume/Item button when building the data structure from the form.
If you have say, a <textbox> with on onchange event that disables a <button> and re-enables it shortly thereafter, and the onchange event was triggered by you clicking on said button while the textbox has focus/changes, then the disable action will prevent any click on the button from registering.
Author: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20281 dcc99617-32d9-48b4-a31d-7c20da2025e4
Better call number prefix/support in opac. The copy count status/location summary methods now group by prefix, label, suffix instead of just label. Still need to update rdetailShowCNBrowse/open-ils.search.callnumber.browse, which is being fed an array, [ prefix label, label, suffix label ]
Add org unit settings for default status of newly added copies
These two new org unit settings enable sites to control the
default status of newly added copies. The defaults match
the behaviour of the "Add Volumes" ("In Process") and
"Fast Add" ("Available") interfaces as of Evergreen 1.6.1,
but sites can choose to have the copies go directly to
"Reshelving", "Available", or any other status defined in
config.copy_status.
projects / evergreen / joelewis.git / log