Jeff Davis [Tue, 28 Apr 2015 16:33:52 +0000 (09:33 -0700)]
Truncated totals on account summary due to bad regex
On the account summary page, OD API was using /\d+?/ to scrape item
totals. In Javascript, this regular expression matches the minimum
possible match, i.e. one digit, even when the total had more than one
digit. So, for example, if a patron had 10 items out, the checked out
totals on the account summary page in OD API would show 1 item out.
(The totals at the top right of the page are correct.)
This commit fixes the regex.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Jeff Davis [Wed, 7 Jan 2015 21:12:06 +0000 (13:12 -0800)]
Use jQuery.noConflict to avoid conflict with other libraries
jQuery's use of '$' as an alias was conflicting with Dojo's use of '$'
as a function name on the TPAC advanced search page. We can resolve
this by making OD API depend on a wrapper function that invokes
jquery.noConflict(). There's an "official" way to do this using the
require.js map config, but the approach we're using here is simpler (and
actually works!).
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Jeff Davis [Mon, 8 Dec 2014 18:36:35 +0000 (10:36 -0800)]
RT26522: Don't treat non-available items as a special case
Previously, when the 'available' element of a Library Availability API
response was undefined, we assumed that the title itself was no longer
part of the library's current Overdrive collection. Thus, the Place
Hold link was removed and a "No longer available" message was displayed
in the Status column. In fact, however, it may just be the case that
the item is currently in the collection, but all copies are checked out.
So it's preferable to retain the Place Hold link and show "0 of X
available" in the Status column -- in other words, don't treat undefined
availability as a special case.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Jeff Davis [Thu, 6 Nov 2014 20:36:13 +0000 (12:36 -0800)]
remove hard-coded URLs for JS libraries
For ease of configuration and maintenance, paths for various required JS
libraries (require.js, jQuery, etc.) have been moved to Evergreen -- see
templates/opac/parts/js.tt2.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Jeff Davis [Wed, 1 Oct 2014 16:57:17 +0000 (09:57 -0700)]
Add license and copyright
This software was originally published on Google Code with an MIT
License and no copyright statment. The present commit includes the
license within the source code (see LICENSE.txt) and assigns copyright
to the BC Libraries Cooperative.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Steven Chan [Thu, 18 Sep 2014 17:51:07 +0000 (10:51 -0700)]
Refine the rendering of myopac account summary table and dashboard
Before, the table and dashboard were built to show empty e-item entries
that would sit there while the user waits for the several API requests
to finish before the total values were available to be placed in the
entries. Now, the entries are built and shown after values are
available.
A solid gray bar shows in the dashboard during the wait interval. We
would have shown a progress bar, but it's too hard to get it to show
because of interference from the existing style sheet.
The first column of the summary table shows totals for physical items
and was suppressed until the arrival of totals for e-items, but in fact
the totals of physical items are already available from the old table.
Now, we show them immediately, and we don't show the second column at
all until it is filled with values.
Steven Chan [Sun, 14 Sep 2014 22:39:09 +0000 (15:39 -0700)]
Handle errors arising from downloading content
Any such errors will be embedded in the search parameters of the
myopac/circ page URL. We decode the various components and show them
inside a floating notification box, otherwise we render the page as
normally done.
Steven Chan [Sun, 14 Sep 2014 01:06:17 +0000 (18:06 -0700)]
Use action dialogue to guide download link process
1. Define and use a downloadLink action dialogue
2. Auto-close done content box after 59 seconds
3. For other actions, auto-close after 2 seconds
4. Auto-focus on close button to allow for quick manual close
Steven Chan [Wed, 10 Sep 2014 20:46:56 +0000 (13:46 -0700)]
Change how download button works to allow for right-clicking to work
On user clicking a download button, we convert the download URL to a content URL,
and then convert the button to a link with a new message. This will
allow the link to be used directly, ie, right-clicking to open in a new
tab.
The interaction is not perfect, for example, the content link will be
useful for only 60 seconds. A more elaborate interaction will need to be
devised.
Steven Chan [Mon, 8 Sep 2014 00:24:24 +0000 (17:24 -0700)]
Fix format type mismatch
The format type that is listed on search results, record details, and
place hold form doesn't match what is listed in the selection option
list of the checkout dialogue.
To remove the mismatch, we need to use the format types found in the
checkout action object, which is gotten from Availability, rather than
the basic list found from Metadata. The difference is presumably due to
Advantage accounts.
For search results or record details, we omit the call for Metadata and
substitute the format types from checkout action. For place hold form,
we cannot omit a call to Metadata, because it supplies title details as
well as format types. Therefore, we have to reschedule the asynchronous
calls to Metadata and Availability to run in parallel, wait for both
results, and then check to see if there is a checkout action in
Availability before being able to do the right thing.
Steven Chan [Tue, 2 Sep 2014 22:16:37 +0000 (15:16 -0700)]
Proxy URLs soon rather than late
This makes it easier to make the od_data module be primary over od_api. Signed-off-by: Steven Chan <steven3416@gmail.com>
Steven Chan [Sun, 31 Aug 2014 17:35:28 +0000 (10:35 -0700)]
Replace progress text with a progress bar
As a way to do it, we slightly generalized the set_message method of the
action dialogue, to default to using a progress bar for the body text if
there is no text string specified as an argument nor as a body property
of the scenario. Thus, for an intent scenario, it is sufficient to use
the default body.
Steven Chan [Sun, 31 Aug 2014 17:29:59 +0000 (10:29 -0700)]
Fix progress message in action dialogues
The jQuery ajax method does not implement the full promise interface; it
does not call notify and so the progress callback cannot work. As a
substitute, we pass the progress callback as the beforeSend callback,
which is executed before an ajax send.
Also, we use a progress bar instead of a progress text message.
Steven Chan [Sat, 30 Aug 2014 18:33:10 +0000 (11:33 -0700)]
Implement Overdrive data objects using data classes
A data class will make a new instance out of an OD object and endow it
with the methods to normalize the object so that it will be easier to use.
Currently, these methods are defined as ad-hoc functions within the
od_api module, making it lengthy and hard to understand.
projects / contrib / overdrive-eg-opac.git / log