]> git.evergreen-ils.org Git - contrib/Conifer.git/commit
LP#1379824 Make PermaCrud.js disconnect() actually disconnect
authorDan Wells <dbw2@calvin.edu>
Thu, 9 Oct 2014 21:32:42 +0000 (17:32 -0400)
committerBen Shum <bshum@biblio.org>
Fri, 10 Oct 2014 19:05:33 +0000 (15:05 -0400)
commit3d9b6a1ebabf3f557bdcf645c96fa0e53e19407f
tree84e700f3c124fb9c255a94cebed42bc2d9e34a4a
parentc5880895d159557120c3717d05b7390b7e677137
LP#1379824 Make PermaCrud.js disconnect() actually disconnect

The disconnect() method in PermaCrud.js was meant to wrap the
underlying session disconnect, but it never actually disconnected
the session.  This could lead to problems in long-living PermaCrud
objects, as they may think they are still connected when they are not
(the session remote_id is never cleared).

Also, remove a couple (now redundant) manual session.disconnect() calls.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/web/js/dojo/openils/PermaCrud.js