Evergreen.git
13 months agoLP#1678638: technical documentation for qstore
Galen Charlton [Sun, 2 Apr 2017 18:59:00 +0000]
LP#1678638: technical documentation for qstore

Technical documentation and sample stored queries for
the open-ils.qstore service, written by Scott McKellar
and copyright 2010 by the Equinox Open Library Initiative.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

13 months agoLP#1564508: disable selecting Hatch status menu item
Galen Charlton [Fri, 19 May 2017 13:37:49 +0000]
LP#1564508: disable selecting Hatch status menu item

Add the "disabled" class to the <li> for the navbar menu
item that displays Hatch's status, to avoid making users
think that there's an action available to them by selecting
that menu item.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

13 months agoLP#1564508 Hatch status in hamburger, remove statusbar
Bill Erickson [Thu, 17 Nov 2016 20:33:02 +0000]
LP#1564508 Hatch status in hamburger, remove statusbar

* Move the Hatch connectivity status indicator into the upper-right
  hamburger menu.

* Removes the long-hidden hatch/websockets statusbar.

* Since the Hamburger forces a re-digest of the interface when opened,
  the code no longer attempts to force the page to re-$apply() when
  the Hatch connection opens or closes.  It's no longer necesssary
  (and was buggy).

* The WebSockets connectivity status is not added to the hamburger.  The
  websockets connection will go up and down regularly as connections
  expire and reset.  Having the indicator flash could lead to
  unneccesary panic.  Plus, if websockets are down, staff can't log in
  anyway.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agoLP 1672519: Make marc_export descendants aware.
Jason Stephenson [Sat, 22 Apr 2017 12:17:53 +0000]
LP 1672519: Make marc_export descendants aware.

Add a --descendants option to marc_export to get records for an
org. unit and its descendants.

To test
-------
[1] Run marc_export with -i --library FOO. Verify that the resulting
    records have 852 fields only from FOO.
[2] Run marc_export with -i --descendants FOO. Verify that the resulting
    records have 852 fields from FOO *and* all descendants of FOO.
[3] Run marc_export using various combinations of --library and --descendants;
    verify that items from the expected libraries show up as 852 fields.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agodoc: fix location of a release note stub
Galen Charlton [Fri, 19 May 2017 02:55:42 +0000]
doc: fix location of a release note stub

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agoLP#1610246: add upgrade note
Galen Charlton [Fri, 19 May 2017 01:59:28 +0000]
LP#1610246: add upgrade note

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agoLP#1610246 Classic Circulation View excluding circulations
Chris Sharp [Fri, 5 Aug 2016 13:27:23 +0000]
LP#1610246 Classic Circulation View excluding circulations

The reporter.classic_current_circ view, which is available via
Open-ILS/src/sql/Pg/example.reporter-extension.sql, was excluding
circulations because it was assuming all users have a billing address
This branch corrects that with a LEFT JOIN.

No upgrade script will be included since these views are not assumed
to be installed by all Evergreen instances.  Please re-run the
example.reporter-extension.sql file to apply this change for your
instance.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agoLP#1491875: avoid erroneous "unsaved data" popup during MARC record creation
Jason Etheridge [Wed, 26 Apr 2017 21:23:26 +0000]
LP#1491875: avoid erroneous "unsaved data" popup during MARC record creation

Test plan
---------
[1] Navigate to Cataloging -> Create New MARC Record.
[2] Choose a template, click Load
[3] Enter data in a fixed field, for example, Date1
[4] Enter data in a MARC field such as 100
[5] Click Create Record:

    The "This tab may have unsaved data. ..." pop up will appear.
    Clicking OK will save the record and take the user to their default
    view of the record.
    Clicking Cancel will save the record and return the user to the MARC
    Edit screen.
    The behavior when clicking Cancel can lead to confusion as to
    whether the record has actually been saved.

[6] Apply the patch and repeats steps #1-#5.
[7] This time, no extraneous unsaved data warning should appear.

Note that this patch's kludge doesn't fix all possible instances
of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6
for details.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
SIgned-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agoLP#1677661 Hold targeter live test use API, etc.
Bill Erickson [Fri, 31 Mar 2017 14:21:45 +0000]
LP#1677661 Hold targeter live test use API, etc.

Teach the hold targeter live tests to call the open-ils.hold.targeter
API instead of calling the now-defunct Utils::HoldTargeter batch
targeter function.  Apart from the loss of this function, calling the
API allows the live tests to exercise more of the targeting code.

Teach the live tests to test --soft-retarget-interval instead of the
deprecated --skip-viable option.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

13 months agoLP#1677661 Targeter V2 remove unused batch API
Bill Erickson [Fri, 31 Mar 2017 14:21:25 +0000]
LP#1677661 Targeter V2 remove unused batch API

Remove the unusued batch target() function from Utils::HoldTargeter to
avoid code duplication.  The same (but more resilient) batch targeting
construct exists in the open-ils.hold-targeter API.

Move API docs from Utils::HoldTargeter to the open-ils.hold-targeter API
docs for added visbility / findability.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

13 months agoLP#1677661 Targeter V2 extras release notes
Bill Erickson [Thu, 30 Mar 2017 15:47:20 +0000]
LP#1677661 Targeter V2 extras release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

13 months agoLP#1677661 Hold Targeter V2 Repairs & Improvements
Bill Erickson [Wed, 22 Mar 2017 15:47:21 +0000]
LP#1677661 Hold Targeter V2 Repairs & Improvements

* Make the batch targeter more resilient to a single-hold failure.

* Additional batch targeter info logging.

* Set OSRF_LOG_CLIENT in hold_targeter_v2.pl for log tracing

* Removes the confusingly name --target-all option

* Adds a new --next-check-interval option for specifying when the
  targeter will next affect the currently processed holds, which may be
  different that now + retarget-interval in cases where the targeter is
  not constantly running.

* Replaces the --skip-viable option with a new --soft-retarget-interval
  option, allowing for time-based soft-targeting.

* Soft-targeting now updates hold_copy_maps for all affected holds, not
  just those requiring a full retarget.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

13 months agoLP1274999: Next Link Appears at "End" of Copy List
Jason Boyer [Tue, 21 Feb 2017 21:31:31 +0000]
LP1274999: Next Link Appears at "End" of Copy List

The total number of copies wasn't checked against the
copy_limit and copy_offset, so anytime that the
number of copies per page mod copy_limit == 0 the
Next link would appear, even if there were only
copy_limit copies total. Now the offset and limit are
compared to the total number of copies available at
the current depth to determine if the Next link
should appear.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

13 months agoLP#1618949 Required patron stats format repairs
Bill Erickson [Wed, 26 Apr 2017 16:42:21 +0000]
LP#1618949 Required patron stats format repairs

Fixes a broken div column class, which caused the patron stat cats to
stretch across the page.

Other div nesting/formatting fixes and additional inline code comments.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

13 months agoLP#1618949 Patron edit forces required stat cats
Billy Horn [Mon, 7 Nov 2016 22:29:53 +0000]
LP#1618949 Patron edit forces required stat cats

Display required stat cats as required form fields and prevent the
patron editor form from submitting when required stat cats do not have
values.

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

13 months agoLP#1670242 Webstaff checkin transit holds addr fix
Bill Erickson [Fri, 12 May 2017 20:22:14 +0000]
LP#1670242 Webstaff checkin transit holds addr fix

Gracefully handle cases where a checkin results in a transit to a branch
with no holds address.  Route dialog and print templates now display "We
do not have a holds address for this library. "

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

13 months agoWebstaff: hide behind-desk option when not supported
Bill Erickson [Thu, 6 Oct 2016 14:27:15 +0000]
Webstaff: hide behind-desk option when not supported

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

13 months agoLP1244354 Unnecessary user refresh after deletion can cause permission error
blake [Fri, 1 Jul 2016 17:01:04 +0000]
LP1244354 Unnecessary user refresh after deletion can cause permission error

obj.refresh_all() was being called no matter what. It needs to be called only when
there is an issue deleting the patron. On success, this patch will simply present an
informational message to the user.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

13 months agoLP#1641208: util.file no longer mangles UTF8 when writing JSON
Galen Charlton [Fri, 11 Nov 2016 19:52:11 +0000]
LP#1641208: util.file no longer mangles UTF8 when writing JSON

This patch ensures that JSON strings are converted to UTF8
before they are writing to XUL profile files by util.file. Doing this
fixes a bug where by OU names like "ბიზნესისა" can get mangled
in certain XUL client interfaces.

To test
-------
[1] Set an OU name to ბიზნესისა
[2] In the transit list, note that the OU selector displays
    the name as ÑØÖÜÔáØáÐ.
[3] Apply the patch (note that it's not necessary to rebuild
    the staff client to test this).
[4] Restart the staff client, clearing cache beforehand.
[5] Note that the OU name is now displayed correctly in the transit
    list.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

13 months agoLP#1673799 Stamping EDI query SQL update
Bill Erickson [Wed, 17 May 2017 17:14:17 +0000]
LP#1673799 Stamping EDI query SQL update

Signed-off-by: Bill Erickson <berickxx@gmail.com>

13 months agoLP#1673799: new acqedim index to speed up duplicate file check
Galen Charlton [Fri, 17 Mar 2017 15:47:46 +0000]
LP#1673799: new acqedim index to speed up duplicate file check

This patch adds a new index on acq.edi_message to speed up
the check for duplicate EDI messages that edi_fetcher.pl runs,
replacing use of "ilike" with invocations of the evergreen.lowercase()
stored procedure.

To test
-------
[1] Arrange to create or simulate an EDI message that failed
    processing.
[2] Run edi_fetcher.pl to have it attempt to download the
    failed message in step #1; verify that the file is
    /not/ downloaded again and that no additonal acq.edi_message
    rows are created for it.
[3] (Extra credit) Try steps 1 and 2 in a database that has a
    very large number of rows in acq.edi_message.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

13 months agoLP#1650807: fix rollover_phone_to_print.pl to ack failed calls
Josh Stompro [Wed, 21 Dec 2016 19:57:32 +0000]
LP#1650807: fix rollover_phone_to_print.pl to ack failed calls

This patch fixes a bug in rollover_phone_to_print.pl that kept
failed callfiles from being moved.

The list of new event ID's that the script created was being sent to the
mediator, which couldn't do anything with them.  The original event ID's
need to be sent to have those call files moved.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

13 months agoLP#1672824 A/T complete_time set on grouped events
Bill Erickson [Tue, 14 Mar 2017 17:57:12 +0000]
LP#1672824 A/T complete_time set on grouped events

Set the complete_time value on grouped Action/Trigger events when an
event's state reaches "complete", consisten with non-grouped events.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#117794 - Remove references to "Keep" field in Vandelay docs.
Chris Sharp [Sat, 20 Aug 2016 14:46:11 +0000]
LP#117794 - Remove references to "Keep" field in Vandelay docs.

Since the "Keep" field of Vandelay Import Item Attributes is
not implemented, remove references to it in the documentation.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

14 months agoLP#1177794 - remove "Keep" field from Vandelay Import Item Attributes.
Chris Sharp [Sat, 20 Aug 2016 14:36:57 +0000]
LP#1177794 - remove "Keep" field from Vandelay Import Item Attributes.

The "Keep" field in Vandelay Import Item Attributes is not
currently implemented, so remove from all user interfaces.
However, I didn't change the vandelay.import_item_attr_definition
table, leaving the option for this to be implemented in the future.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Conflicts:
build/i18n/po/fm_IDL.dtd/fm_IDL.dtd.pot

14 months agoLP1689576: Fix ALARM -> ALRM Typo
Jason Boyer [Tue, 9 May 2017 15:07:46 +0000]
LP1689576: Fix ALARM -> ALRM Typo

In Biblio.pm, when trying to set a timeout handler for $SIG{ALARM}
when retrieving cached facets as part of a catalog search,
a warning is dropped in the logs to this effect:
"No such signal: SIGALARM at
/usr/local/share/perl/5.18.2/OpenILS/Application/Search/Biblio.pm
line 1411"
When using $SIG{ALRM} instead the handler is set as expected.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1552861: stamp database update
Galen Charlton [Mon, 15 May 2017 21:03:28 +0000]
LP#1552861: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1552861: add upgrade script
Galen Charlton [Wed, 10 May 2017 17:00:46 +0000]
LP#1552861: add upgrade script

Also, a test plan for the fix:

[1] Set the vandelay.default_match_set setting for several
    org units. In at least one case, set it to the ID
    of a valid vandelay.match_set entry; in another case,
    set it to a numeric ID that doesn't match any existing
    vms rows; and finally, in another case set it to the
    name of a match set.
[2] Apply the patch and run the database update. Verify that
    the update script will indicate that there are invalid
    settings, then delete.
[3] Open the library settings editor and verify that in the
    case where a valid match set was used, the editor provides
    a drop-down with possible vms values with the correct
    one selected.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1552861: use correct datatype for vandelay.default_match_set org setting
Jeff Davis [Thu, 3 Mar 2016 18:55:34 +0000]
LP#1552861: use correct datatype for vandelay.default_match_set org setting

Values for this setting should be links to vandelay.match_set, not strings.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1170514 Stamping vandelay bib-overlay resync SQL
Bill Erickson [Mon, 15 May 2017 18:16:05 +0000]
LP#1170514 Stamping vandelay bib-overlay resync SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

14 months agoLP#1170514 - Upgrade script for vandelay.auto_overlay_bib_record
Chris Sharp [Tue, 11 Apr 2017 14:20:30 +0000]
LP#1170514 - Upgrade script for vandelay.auto_overlay_bib_record

This script got missed in the 2.1-2.2 era and finally makes it
in nearly six years later.  Not necessary for sites that began using
Evergreen since then, but harmless to run.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

14 months agoDocs: LP#1673841 Fix formatting in Apache docs
Jeanette Lundgren [Wed, 10 May 2017 21:00:39 +0000]
Docs: LP#1673841 Fix formatting in Apache docs

From Jeanette's comment on the bug:

"I converted into a simple unordered list and it is easier to read, but
the list bullet spacing makes for a long list.

To conserve some scrolling, do you want me to put it in a table instead
with 3 column headers (option | default | description)?"

Signed-off-by: Remington Steed <rjs7@calvin.edu>

14 months agoDocs: Update reporter_cloning_shared_templates.adoc
Jeanette Lundgren [Wed, 3 May 2017 20:17:19 +0000]
Docs: Update reporter_cloning_shared_templates.adoc

Small correction to match the new menu names and path in the web client.
Also fix the arrow character by changing from --> to ->.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

14 months agoLP#1648234 Retain myopac redirect and keep refs
Bill Erickson [Wed, 3 May 2017 14:48:49 +0000]
LP#1648234 Retain myopac redirect and keep refs

Leave the myopac.xml redirect in eg_vhost.conf since of all the
redirects it's the most likely to be used.  This version of the redirect
is proxy-proofed.

Additionally keep all of the original myopac redirects in
Open-ILS/examples/jspac_redirects.conf for reference.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1648234 Remove Apache JSPAC redirects
Bill Erickson [Mon, 17 Apr 2017 18:20:17 +0000]
LP#1648234 Remove Apache JSPAC redirects

Remove automatic URL redirects from JSPAC URLs to TPAC URLs in the
example Apache configuration files.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1648234 IP Redirect honors client port
Bill Erickson [Mon, 17 Apr 2017 18:09:10 +0000]
LP#1648234 IP Redirect honors client port

IP-based redirection now redirects the client to the same port number
originally requsted by the client, instead of using the port that the
Apache server is listening on.  This prevents internal Apache from
leaking to the caller when a proxy is used.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1648234: fix Apache 2.2 version of redirect rules
Galen Charlton [Wed, 22 Mar 2017 16:15:06 +0000]
LP#1648234: fix Apache 2.2 version of redirect rules

Apache 2.2 doesn't actually set a REQUEST_SCHEME variable,
so we'll simulate it.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1648234 Apache redirects to standard ports
Bill Erickson [Fri, 24 Feb 2017 22:09:17 +0000]
LP#1648234 Apache redirects to standard ports

Certain Apache redirects now send the browser to standard 80/443 ports
instead of defaulting to the internally configured Apache ports,
which may be non-standard, particularly in a proxied environment.

Leaking the non-standard ports to the browser causes the browser to
bypass the proxy and could cause the browser to request inaccessible
pages.

Paths affected by this patch:

/
/eg/staff
/opac/extras/slimpac/start.html
/opac/extras/slimpac/advanced.html
/opac/extras/slimpac/.*?locale=.*

To test:

1. Configure Apache to use non-standard ports for port 80/443 (e.g. 7080
and 7443).
2. Confirm the issue by navigatigating to http://HOST/
3. This should redirect to http://HOST:7080/eg/opac/home
4. Apply the Apache config changes and reload/restart Apache.
5. Clear the browser cache to reset any redirects
6. Navigate to http://HOST/
7. Confirm it redirects the browser to http://HOST/eg/opac/home

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoDocs: Update MARC editor docs for web client
blake [Tue, 2 May 2017 19:04:37 +0000]
Docs: Update MARC editor docs for web client

Provided Webby screen shots and updated the language to match the web based
staff client.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

14 months agoLP#1647852: Use correct method during adjust to zero on negative balance
Jeff Davis [Thu, 27 Apr 2017 20:54:12 +0000]
LP#1647852: Use correct method during adjust to zero on negative balance

Implementing Brent Mills' suggestion on Launchpad.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

14 months agoDocs typo: s/minimum/maximum/
Dan Scott [Tue, 9 May 2017 02:51:42 +0000]
Docs typo: s/minimum/maximum/

A small thing, but it means exactly the opposite. Thanks to _adb in IRC for
pointing this out!

Signed-off-by: Dan Scott <dscott@laurentian.ca>

14 months agoLP#1687649 Z39.50 CQL query parser honors bools
Bill Erickson [Tue, 2 May 2017 15:51:12 +0000]
LP#1687649 Z39.50 CQL query parser honors bools

To test with yaz-client, Z server on localhost, database=evergreen:

Z> open localhost:2210/evergreen
Z> find @or @attr 1=4 @attr 4=6 "potter" @attr 1=4 @attr 4=6 "piano"

"Number of hits:" value should be greater than zero (~38) using the
concerto data set.

Similarly, opensrf logs should contain the line:

SRU search string [(title = potter or title = piano)] converted to
[title:potter || title:piano]

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1646638 - Fix SIP timeouts due to invalid sessions
Dan Scott [Thu, 1 Dec 2016 22:24:01 +0000]
LP#1646638 - Fix SIP timeouts due to invalid sessions

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1667221: (follow-up) remove comment that is now a lie
Galen Charlton [Mon, 1 May 2017 18:47:58 +0000]
LP#1667221: (follow-up) remove comment that is now a lie

Also, here's a test plan:

[1] Edit /openils/conf/oils_sip.xml and set the currency
    defined in the implementation section to be something
    other than USD.
[2] Start the SIP server and perform a patron information
    request; note that the BH field in the response contains
    'USD'.
[3] Apply the patch and restart the SIP server.
[4] Repeat step 2; this time, the currency should be whatever
    is specified in oils_sip.xml.
[5] Comment out the currency section in oils_sip.xml and restart
    the SIP server.
[6] Repeat step 2; this time, the currency should be back to 'USD'.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1667221: use library currency as SIP patron currency instead of always using USD
Jeff Davis [Tue, 21 Feb 2017 01:20:26 +0000]
LP#1667221: use library currency as SIP patron currency instead of always using USD

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1378829 Stamp Upgrade Script & Add Release Note
Jason Stephenson [Sat, 6 May 2017 18:16:57 +0000]
LP#1378829 Stamp Upgrade Script & Add Release Note

Signed-off-by: Jason Stephenson <jason@sigio.com>

14 months agoLP#1378829 Fix long overdue override permission
Jeff Godin [Fri, 14 Apr 2017 14:21:40 +0000]
LP#1378829 Fix long overdue override permission

Fix override permission used when checking in a copy that is "long
overdue".

The existing permission was incorrectly created with a code of
COPY_STATUS_LONGOVERDUE.override, while the event thrown requires a
permission with a code of COPY_STATUS_LONG_OVERDUE.override

This commit updates the seed data and a few references to the
old/incorrect permission in documentation, and also includes an
upgrade script designed to accommodate the various likely ways in
which sites may have already locally addressed this issue.

A simple pgtap test is also included.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

14 months agoDocs: Remove stray bullet entry
Kathy Lussier [Fri, 5 May 2017 16:29:38 +0000]
Docs: Remove stray bullet entry

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoDocs: Add files to the list of tpac files that should be customized
Kathy Lussier [Fri, 5 May 2017 16:14:19 +0000]
Docs: Add files to the list of tpac files that should be customized

We have a list of tpac files that should be customized on an Evergreen system.
There are a couple of files related to password formats that should be included
here.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoLP#1685840 Release notes for Google Books Preview rewrite
Dan Scott [Wed, 3 May 2017 03:02:17 +0000]
LP#1685840 Release notes for Google Books Preview rewrite

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685840 Activate Google Preview "extras" bar on load
Dan Scott [Tue, 2 May 2017 04:37:17 +0000]
LP#1685840 Activate Google Preview "extras" bar on load

Thanks to Ben Shum for pointing out that users might expect the Google Preview
extras bar near the bottom of the screen to trigger loading the preview as
well. Another event listener handles this accordingly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685840: Dojoless Google Books Preview as external script
Dan Scott [Mon, 24 Apr 2017 16:18:12 +0000]
LP#1685840: Dojoless Google Books Preview as external script

Rather than including the JavaScript inline in each page, load the
JavaScript as a regular external JavaScript file so that browsers
can take advantage of caching, reduce network bandwidth, and reduce the
amount of TT2 processing required. Every little bit helps.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685840: Dojoless Google Books Preview: remove TT2 dependency
Dan Scott [Mon, 24 Apr 2017 15:53:24 +0000]
LP#1685840: Dojoless Google Books Preview: remove TT2 dependency

Rather than process the template with TT2 to specify the language in
which the Google Books Preview should be displayed, use the @lang
attribute on the <html> element--and fall back to 'en' if for some
reason that attribute has been removed from the template.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685840: Google Books Preview: responsive sizing
Dan Scott [Mon, 24 Apr 2017 15:29:37 +0000]
LP#1685840: Google Books Preview: responsive sizing

Use the viewport's actual height and width to display the book preview,
rather than hard-coding 600px x 800px. On a very wide screen, the book
will be centred; on a small screen such as a mobile device, the book
will not scroll indiscriminately off to the side, but instead stays
within the bounds of the viewport.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685840: Dojoless Google Books Preview does not need want_dojo
Dan Scott [Mon, 17 Apr 2017 22:42:11 +0000]
LP#1685840: Dojoless Google Books Preview does not need want_dojo

Now that Dojo is no longer needed for Google Books Preview, we can load
the associated JavaScript without having to enable want_dojo.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685840: Dojoless Google Books Preview
Dan Scott [Mon, 17 Apr 2017 02:27:52 +0000]
LP#1685840: Dojoless Google Books Preview

Avoid polluting the global namespace by wrapping the code in (function() {})().

Add event listeners to the DOM elements rather than the crufty
href=javascript:function approach.

Optimization: do not load the Google Books JSAPI unless there is a matching
embedded ISBN.

Use display style directly, rather than munging class names with hide_me

Supports IE 10/11, which does not handle responseType = 'json', through
the fallback to XHR responseText.

IE9 for now; it seems the new Google Books Loader wipes out the DOM in
IE9 instead of loading nicely in the <head>. Could go back to the old
Google JS loader, which still works, but is deprecated, so could
disappear at any point.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1427392: Stamping upgrade script for hard due date value fix
Ben Shum [Wed, 3 May 2017 01:51:13 +0000]
LP#1427392: Stamping upgrade script for hard due date value fix

Signed-off-by: Ben Shum <ben@evergreener.net>

14 months agoLP#1427392: Add release note for hard due date values fix
Michele Morgan [Tue, 2 May 2017 13:17:55 +0000]
LP#1427392: Add release note for hard due date values fix

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

14 months agoLP#1427392 - Allow deletion of Hard Due Date Values.
Michele Morgan [Wed, 15 Mar 2017 20:31:06 +0000]
LP#1427392 - Allow deletion of Hard Due Date Values.

Also, don't update hard due dates to ceiling dates that have passed.

Fixes two related issues with hard due dates.

- Exposes the selector in the Hard Due Date Values interface so past
  entries that are no longer valid can be deleted via the client.
- Prevents the current ceiling date from being updated to a past date
  based on an old hard due date value.

Testing plan:

To reproduce the issue:

- Create a Hard Due Date with a Current Ceiling Date in the future
- Create an associated Hard Due Date Value with an active date earlier
  than the current date and a ceiling date earlier than the current date.
- Run the hard due date updater

Note that:

- The Current Ceiling Date is updated to an earlier date based on
  the Hard Due Date Value entry.
- It is not possible to select and delete the Hard Due Date Value
  entry.

Apply the patch and retest

Note that:

- The Current Ceiling Date has not been updated to the past date.
- Past Hard Due Date Values can now be selected and deleted.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

14 months agoDocs: Reducing line length to 80 characters in using OPAC docs
Kathy Lussier [Wed, 3 May 2017 01:07:48 +0000]
Docs: Reducing line length to 80 characters in using OPAC docs

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoDocs: Sibling links documentation
Kathy Lussier [Tue, 2 May 2017 23:20:20 +0000]
Docs: Sibling links documentation

Adds documentation and a screenshot for the new sibling links that display
on the record details page. Also removes a bit of duplicated documentation.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoDocs: Reducing line size to 80 characters
Kathy Lussier [Tue, 2 May 2017 17:46:31 +0000]
Docs: Reducing line size to 80 characters

Reducing the line size in a couple of docs to 80 character. Makes for easier
editing for those who are working from a command line editor.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoDocs: Documentation for default metarecord search
Kathy Lussier [Tue, 2 May 2017 17:33:54 +0000]
Docs: Documentation for default metarecord search

Adding documentation on how to configure a default metarecord search in the
admin section. The catalog section also containts a tip about this option with
a link to the admin section for further details on how to configure it.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoLP#1257915: add live_t tests
Galen Charlton [Mon, 1 May 2017 20:45:29 +0000]
LP#1257915: add live_t tests

And here's a test plan for humans:

[1] Create a purchase order with, say, 3 lineitems and 2
    copies on each of these.
[2] Receive the first two lineitems outright.
[3] Receive one of the copies on the last lineitem and cancel
    the other with a cancellation reason that's permanent (e.g.,
    bad ISBN) rather than temporary (e.g., backordered).
[4] Note that the purchase order's state remains 'on-order'
[5] Apply the patch.
[6] Repeat steps #1-4. This time, the PO's state should be
    'received'.
[7] Repeat steps #1-4, but this time, choose backordered as
    the cancellation reason. This time, the PO's state should
    remain 'on-order'.

It should be noted that the patches for this bug do *not*
retrospectively mark purchase orders as being received.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1257915 Repair receive-when-cancel query
Bill Erickson [Wed, 12 Apr 2017 20:54:25 +0000]
LP#1257915 Repair receive-when-cancel query

Repaire the json_query used to determine if a PO is ready to be marked
received.

A PO is non-receiveable if it has any lineitems that are not in the
received/cancelled [sic] state OR any that are canceled with a
keep_debits=true cancel reason.

Prior to this change, simply having a state of "cancelled" was enough to
prevent receiving.

* Replace tabs w/ spaces
* Remove unnecessary "or return 0" clause which was causing Perl
  precedence warnings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1257915 - Also check whether to mark the PO received when canceling.
Chris Sharp [Fri, 7 Apr 2017 12:45:06 +0000]
LP#1257915 - Also check whether to mark the PO received when canceling.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1257915 - Mark POs received when all lineitems are received or canceled.
Chris Sharp [Wed, 5 Apr 2017 13:52:50 +0000]
LP#1257915 - Mark POs received when all lineitems are received or canceled.

Previously, Evergreen only considered lineitems not in a "received" status
when deciding whether to consider a purchase order to be "received".  Now
items with cancel reasons that do not keep debits (e.g. not backordered)
are considered "done".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1230301: add release notes
Galen Charlton [Mon, 1 May 2017 19:16:32 +0000]
LP#1230301: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1230301 - Add User/Working Location Map Link to the ILS User reports source.
Chris Sharp [Wed, 10 Feb 2016 00:12:11 +0000]
LP#1230301 - Add User/Working Location Map Link to the ILS User reports source.

For certain reports it is desirable to display or filter on staff Working Location.
This adds a link to the permission.usr_work_ou_map table/source in fm_IDL.xml.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1684984: stamp DB update
Galen Charlton [Mon, 1 May 2017 19:04:56 +0000]
LP#1684984: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.
Jason Stephenson [Sat, 22 Apr 2017 12:28:34 +0000]
LP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.

Add release note.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.
Jason Stephenson [Sat, 22 Apr 2017 00:42:49 +0000]
LP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.

Per discussion in IRC, the ingest.disable_metabib_field_entry internal
flag was obsoleted by the addition of the ingest.skip_browse_indexing,
ingest.skip_search_indexing, and ingest.skip_facet_indexing
flags. Since ingest.disable_metabib_field_entry is not used anywhere
in the database, this branch removes it.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1616220 Fixes for css errors that show up in the xul staff client console.
Josh Stompro [Mon, 29 Aug 2016 02:23:01 +0000]
LP#1616220 Fixes for css errors that show up in the xul staff client console.

To test
-------
[1] In the XUL client, try various interfaces including acquisitions,
    the patron editor, the reporter, the library settings editor,
    serials management and patron surveys. Using the error console,
    verify that applying this patch slightly reduces the number of
    CSS warnings reported.
[2] Repeat step 1 using the web staff client, in particular while
    looking at the embedded acquisitions interfaces.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoDocs: adding release notes regarding blanket orders
Jillianne Presley [Mon, 1 May 2017 01:45:01 +0000]
Docs: adding release notes regarding blanket orders

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

14 months agoDocs: New docs for in-house use settings
Debbie Luchenbill [Mon, 1 May 2017 01:24:13 +0000]
Docs: New docs for in-house use settings

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

14 months agoDocs: fixing broken link
Jane Sandberg [Mon, 1 May 2017 01:20:56 +0000]
Docs: fixing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

14 months agoLP#1628655: Do not show Patron Reviews if Chilifresh is not in use
Linda Jansova [Tue, 29 Nov 2016 13:49:52 +0000]
LP#1628655: Do not show Patron Reviews if Chilifresh is not in use

The Patron reviews header used for Chilifresh content displays in the catalog
even for Evergreen sites that do not use Chilifresh. This patch hides it if
a site is not using Chilifresh.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

14 months agoLP#1680142: Fix responsive design issue with ebook display
Kathy Lussier [Wed, 5 Apr 2017 21:25:49 +0000]
LP#1680142: Fix responsive design issue with ebook display

Fixes the following responsive design issues:
* Removes the e-book dashboard display when the screen size is reduced.
* Changes the table display for e-items currently checked out, e-items on hold,
and e-iterms ready for checkout interfaces to mimic the responsive behavior of
other My Account screens.
* Fixes a couple of Holds History CSS problems discovered while I was here.

Test Plan:
Enable ebook services. Log into your account and resize the screen to the size
of a mobile device. The ebook dashboard will display while the main account
dashboard disappears. Go into My Account, click Items checked out and then
click E-Items Currently Checked Out. The table has not reformatted itself for
responsive design view.

Post-patch: When you log in and resize the screen, the e-items dashboard
display will disappear along with the main account dashboard. When you access
the E-Items Currently Checked Out interface, the table will reformat itself
with column headers along the left side.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2

Signed-off-by: Ben Shum <ben@evergreener.net>

14 months agoLP#1691009: add release notes
Galen Charlton [Fri, 28 Apr 2017 14:39:55 +0000]
LP#1691009: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1691009 Cache the RTL and LTR stylesheets
Dan Scott [Thu, 27 Apr 2017 19:31:39 +0000]
LP#1691009 Cache the RTL and LTR stylesheets

To allow browsers to cache the correct version of the stylesheet, append a GET
param indicating the direction.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1681009 Merge the RTL style with the LTR style (part2)
Ben Shum [Thu, 27 Apr 2017 15:43:55 +0000]
LP#1681009 Merge the RTL style with the LTR style (part2)

Finishing up the rest of the file and removing the RTL specific one

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1681009 Merge the RTL style with the LTR style
Dan Scott [Thu, 27 Apr 2017 15:41:00 +0000]
LP#1681009 Merge the RTL style with the LTR style

Rather than adding the right-to-left stylesheet
Open-ILS/src/templates/opac/css/style-rtl.css.tt2 as something that
gets included in addition to the LTR style.css.tt2 when a RTL language is in
play, merge the logic directly into the stylesheet so that we save bytes over
the network, browser rendering time, and reduce the possibility that RTL will
be forgotten about when new features are added or styles are optimized.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1681466: move text to body of confirm dialog and add title
Galen Charlton [Mon, 24 Apr 2017 17:16:21 +0000]
LP#1681466: move text to body of confirm dialog and add title

This patch tweaks the opt-in confirm dialog to add a
title and move the text to the body of the dialog, making it
consistent with other dialogs that ask long questions.

Test case for the entire bug fix
--------------------------------
[1] Ensure that <opt_in> is set to true in opensrf.xml.
[2] In the web staff client, open the checkout page
    and do a barcode search for a patron is *not* the
    same system as the workstation that the staff user
    is registered to.
[3] Verify that a dialog box is presented asking the
    staff user to confirm that personal information can be
    shared with the workstation's library.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

14 months agoLP#1681466: Text for web client opt-in dialog
Jeff Davis [Wed, 19 Apr 2017 16:42:38 +0000]
LP#1681466: Text for web client opt-in dialog

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

14 months agoLP#1621178: fix fleshing of copy status for available items
Galen Charlton [Wed, 26 Apr 2017 13:59:07 +0000]
LP#1621178: fix fleshing of copy status for available items

Since copy status 0 means 'Available', test for null
explicitly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1621178: Tweaks to item status column picker option
Kathy Lussier [Fri, 3 Mar 2017 12:33:37 +0000]
LP#1621178: Tweaks to item status column picker option

This commit:
* Removes the copy status column from the Checkout page. The expectation is
that items will not appear in this grid unless they have a Checked out status.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1621178 Copy Status Picker
Kyle Huckins [Tue, 25 Oct 2016 17:12:56 +0000]
LP#1621178 Copy Status Picker

Add copy status field to patron items out, patron
checkout, patron hold, item holds pane, holds shelf, and item status grids.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Conflicts:
Open-ILS/src/templates/staff/cat/item/t_list.tt2

14 months agoDocs: Fix docs build warnings
Remington Steed [Wed, 19 Apr 2017 14:15:21 +0000]
Docs: Fix docs build warnings

This commit fixes the following kinds of warnings given by asciidoc when
building the docs HTML:

  - Incorrect header level
  - Incorrect list numbering
  - List numbering interrupted by an image (needs '+' on blank lines)
  - In one case, a list used '1)' style numbering, which AsciiDoc
    doesn't recognize. This commit corrects that, even though it caused
    no errors.

These are minor issues, but fixing them is easy and prevents future
confusion and errors.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

14 months agoLP#1545115: Stamping upgrade script for description field in matrix tables
Jason Stephenson [Tue, 25 Apr 2017 17:33:08 +0000]
LP#1545115: Stamping upgrade script for description field in matrix tables

Signed-off-by: Jason Stephenson <jason@sigio.com>

14 months agoLP#1545115: add release notes entry
Galen Charlton [Tue, 25 Apr 2017 16:36:27 +0000]
LP#1545115: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

14 months agoLP#1545115: consolidate schema update scripts into one
Galen Charlton [Tue, 25 Apr 2017 13:55:00 +0000]
LP#1545115: consolidate schema update scripts into one

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

14 months agoLP#1545115: add description field for policy matrix tables
Rogan Hamby [Mon, 25 Apr 2016 16:59:12 +0000]
LP#1545115: add description field for policy matrix tables

This patch adds description column for the
config.hold_matrix_matchpoint and circ_matrix_matchpoint tables
and pgTAP tests for them.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

14 months agoLP#1682447 Fix README symlink for server_installation.adoc
Bill Erickson [Tue, 25 Apr 2017 14:29:35 +0000]
LP#1682447 Fix README symlink for server_installation.adoc

Otherwise autoreconf fails on missing README file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>

14 months agoChange all docs filenames to .adoc
Remington Steed [Fri, 7 Apr 2017 18:15:54 +0000]
Change all docs filenames to .adoc

This commit renames all AsciiDoc files to have the ".adoc" extension.
Also, this commit updates all "include::" references in the root.adoc
file.

RATIONALE: Some editing tools, including GitHub, will auto-generate an
HTML preview for AsciiDoc files if they have the filename extension
".adoc" or ".asciidoc". The community agreed to this change in 2015 (see
http://markmail.org/thread/z2s7xnxavpjzirwx).

NOTE: The docs build script will need to change the reference from
"root.txt" to "root.adoc".

Signed-off-by: Remington Steed <rjs7@calvin.edu>

14 months agoLP#1684011: My Account summary ebook link correction
Kathy Lussier [Wed, 19 Apr 2017 06:02:33 +0000]
LP#1684011: My Account summary ebook link correction

The links on the My Account Summary page to the user's ebook checkouts and holds
go to the incorrect URL. The links are updated in this commit to the correct
URL.

Test Plan:
* If your test system is not configured for ebook access, enabled it in the
config.tt2 file by setting ebook_api_enabled to true and
ebook_api.ebook_test.enabled to true.
* Log into a patron account
* The Account Summary page will show links to E-Items Currently Checked out,
E-Items Currently on Hold, and E-Items ready for pickup. Pre-patch, clicking one
of those links will bring you to a 404 page. Post-patch, clicking those links
should bring you to the appropriate My Account tab.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1683562: Typo fix in bill payment receipt template
Kathy Lussier [Tue, 18 Apr 2017 02:57:11 +0000]
LP#1683562: Typo fix in bill payment receipt template

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoLP#1685232: fix egCore.pcrud.apply()
Galen Charlton [Fri, 21 Apr 2017 14:06:17 +0000]
LP#1685232: fix egCore.pcrud.apply()

This patch fixes egCore.pcrud.apply() method so that it
behaves as intended (i.e., process an array of fieldmapper
objects and either creates, updates, or deletes them based
on the value of the isnew(), ischanged(), and isdeleted()
flags).

To test
-------
Currently no code uses this method (but some will soon), but
it can be tested by writing some code like this:

   var notes = [];
   var n1 = new egCore.idl.aun();
   n1.usr(userid); // etc.
   n1.isnew(true);
   notes.push(n1);
   var n2 = new egCore.idl.aun();
   n2.usr(userid); // etc.
   n2.isnew(true);
   notes.push(n1);

   egCore.pcrud.apply(notes).then(...

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

14 months agoforward-port 2.12.0-2.12.1 database update
Galen Charlton [Fri, 21 Apr 2017 13:12:54 +0000]
forward-port 2.12.0-2.12.1 database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

14 months agoForward-port 2.11.4 upgrade script
Dan Wells [Wed, 19 Apr 2017 21:37:56 +0000]
Forward-port 2.11.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

14 months ago2.10.10-2.10.11 schema update
Galen Charlton [Wed, 19 Apr 2017 18:23:24 +0000]
2.10.10-2.10.11 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>