From 5ba306697e8f88fdc1492b0fde717c896a562665 Mon Sep 17 00:00:00 2001
From: Jason Stephenson <jason@sigio.com>
Date: Thu, 6 Dec 2018 13:29:29 -0500
Subject: [PATCH 1/1] LP 1833284: Option to send database id in LookupUser
 response

Autographics can track users who change barcodes or have more than one
barcode by using the user's unique ID.  To implement this feature, we
have added an option to return the user's unique database id instead
of the barcode in the LookupUser response message.  Autographics will
use the database id to track the user on their side, and use the
barcode that the patron entered in all other requests.

The new option is lookupuser_send_database_id and can be activated in
the patrons element of oils_ncip.xml.  See the updated example for
documentation comments.

Signed-off-by: Jason Stephenson <jason@sigio.com>
---
 examples/oils_ncip.xml.example |  6 ++++++
 lib/NCIP/ILS/Evergreen.pm      | 12 ++++++++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/examples/oils_ncip.xml.example b/examples/oils_ncip.xml.example
index 95b240d..abe3c2e 100644
--- a/examples/oils_ncip.xml.example
+++ b/examples/oils_ncip.xml.example
@@ -96,6 +96,12 @@
 	 configuration load times and still have the group name as a
 	 reminder to the person that edits the configuration.
     -->
+    <!--
+      Uncomment the below to return the patron's database id in
+      LookupUser responses, instead of the barcode.  This is an
+      Autographics extension.
+    -->
+    <!-- <lookupuser_send_database_id/> -->
   </patrons>
   <holds>
     <!--
diff --git a/lib/NCIP/ILS/Evergreen.pm b/lib/NCIP/ILS/Evergreen.pm
index 3fc3ff1..e0f3cc4 100644
--- a/lib/NCIP/ILS/Evergreen.pm
+++ b/lib/NCIP/ILS/Evergreen.pm
@@ -164,9 +164,12 @@ sub lookupuser {
     my $userdata = NCIP::User->new();
 
     # Use the user's main card as the UserId.
+    my $idType = ($self->{lookupuser_send_database_id}) ? 'UniqueID' : 'Barcode';
+    my $idValue = ($self->{lookupuser_send_database_id}) ? $user->id()
+        : $user->card->barcode() || $barcode;
     my $id = NCIP::User::Id->new({
-        UserIdentifierType => 'Barcode',
-        UserIdentifierValue => $user->card->barcode() || $barcode
+        UserIdentifierType => $idType,
+        UserIdentifierValue => $idValue
     });
     $userdata->UserId($id);
 
@@ -2917,6 +2920,11 @@ sub _init {
             }
             push(@{$self->{blocked_profiles}}, $pgt) if ($pgt);
         }
+        if ($self->{config}->{patrons}->{lookupuser_send_database_id}) {
+            $self->{lookupuser_send_database_id} = 1;
+        } else {
+            $self->{lookupuser_send_database_id} = 0;
+        }
     }
 
     # Load the bib source if we're not using precats.
-- 
2.43.2