From 4ae229d63b4f3ef4575bb46da4dbf32d18fa6b91 Mon Sep 17 00:00:00 2001 From: Jason Stephenson Date: Sat, 11 Oct 2014 12:46:41 -0400 Subject: [PATCH] Fix some warnings in NCIP::ILS::Evergreen. Try to fix thes: Use of uninitialized value in string eq at /home/opensrf/NCIPServer/lib/NCIP/ILS/Evergreen.pm line 2553. Use of uninitialized value in string eq at /home/opensrf/NCIPServer/lib/NCIP/ILS/Evergreen.pm line 2589. Signed-off-by: Jason Stephenson --- lib/NCIP/ILS/Evergreen.pm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/NCIP/ILS/Evergreen.pm b/lib/NCIP/ILS/Evergreen.pm index c03f77b..48fbc05 100644 --- a/lib/NCIP/ILS/Evergreen.pm +++ b/lib/NCIP/ILS/Evergreen.pm @@ -2551,7 +2551,8 @@ sub find_target_via_bibliographic_id { # First, let's look for a SYSNUMBER: my ($idobj) = grep - { $_->{BibliographicRecordIdentifierCode} eq 'SYSNUMBER' || $_->{BibliographicItemIdentifierCode} eq 'SYSNUMBER' + { ($_->{BibliographicRecordIdentifierCode} && $_->{BibliographicRecordIdentifierCode} eq 'SYSNUMBER') + || ($_->{BibliographicItemIdentifierCode} && $_->{BibliographicItemIdentifierCode} eq 'SYSNUMBER') || $_->{AgencyId} } @biblio_ids; if ($idobj) { @@ -2588,9 +2589,10 @@ sub find_target_via_bibliographic_id { # Build an array of id objects based on the other identifier fields. my @idobjs = grep { - $_->{BibliographicRecordIdentifierCode} eq 'ISBN' || $_->{BibliographicItemIdentifierCode} eq 'ISBN' - || - $_->{BibliographicRecordIdentifierCode} eq 'ISSN' || $_->{BibliographicItemIdentifierCode} eq 'ISSN' + ($_->{BibliographicRecordIdentifierCode} && $_->{BibliographicRecordIdentifierCode} eq 'ISBN') + || ($_->{BibliographicItemIdentifierCode} && $_->{BibliographicItemIdentifierCode} eq 'ISBN') + || ($_->{BibliographicRecordIdentifierCode} && $_->{BibliographicRecordIdentifierCode} eq 'ISSN') + || ($_->{BibliographicItemIdentifierCode} && $_->{BibliographicItemIdentifierCode} eq 'ISSN') } @biblio_ids; if (@idobjs) { -- 2.43.2