From 45baa02ca86009976351c9ffe96583596abe9099 Mon Sep 17 00:00:00 2001
From: Chris Cormack <chrisc@catalyst.net.nz>
Date: Wed, 2 Apr 2014 10:34:39 +1300
Subject: [PATCH] Template for RequestItemResponse

---
 lib/NCIP/Handler/RequestItem.pm            |  1 +
 lib/NCIP/ILS/Koha.pm                       | 13 +++++++------
 templates/includes/RequestItemResponse.inc |  4 ++++
 3 files changed, 12 insertions(+), 6 deletions(-)
 create mode 100644 templates/includes/RequestItemResponse.inc

diff --git a/lib/NCIP/Handler/RequestItem.pm b/lib/NCIP/Handler/RequestItem.pm
index 67aa8ff..f7e5ab2 100644
--- a/lib/NCIP/Handler/RequestItem.pm
+++ b/lib/NCIP/Handler/RequestItem.pm
@@ -50,6 +50,7 @@ sub handle {
             my $elements = $self->get_user_elements($xmldoc);
             $vars->{'elements'} = $elements;
 
+            $vars->{'messages'} = $messages;
             $output = $self->render_output( 'response.tt', $vars );
         }
         return $output;
diff --git a/lib/NCIP/ILS/Koha.pm b/lib/NCIP/ILS/Koha.pm
index ebac487..22a8566 100644
--- a/lib/NCIP/ILS/Koha.pm
+++ b/lib/NCIP/ILS/Koha.pm
@@ -142,15 +142,15 @@ sub renew {
 
 sub request {
     my $self      = shift;
-    my $carnumber = shift;
+    my $cardnumber = shift;
     my $barcode   = shift;
-    my my $borrower = GetMemberDetails( undef, $cardnumber );
+    my $borrower = GetMemberDetails( undef, $cardnumber );
     my $result;
     unless ($borrower) {
         $result = { success => 0, messages => { 'BORROWER_NOT_FOUND' => 1 } };
         return $result;
     }
-    my $Itemdata = GetItem( undef, $barcode );
+    my $itemdata = GetItem( undef, $barcode );
     unless ($itemdata) {
         $result = { success => 0, messages => {'ITEM_NOT_FOUND'} };
         return $result;
@@ -168,15 +168,16 @@ sub request {
 
         # Add reserve here
         AddReserve(
-            $branch,                   $borrower->{borrwerborrowernumber},
+            $branchcode,                   $borrower->{borrwerborrowernumber},
             $itemdata->{biblionumber}, 'a',
             [$biblioitemnumber],       1,
             undef,                     undef,
             'Placed By ILL',           '',
             $itemdata->{'itemnumber'}, undef
         );
-
-        $result = { success => 1, request_id => 'something' };
+        my ( $reservedate, $borrowernumber, $branchcode, $reserve_id, $wait ) =
+              GetReservesFromItemnumber( $itemdata->{'itemnumber'} );
+        $result = { success => 1, messages => {request_id => $reserve_id };
         return $result;
     }
     else {
diff --git a/templates/includes/RequestItemResponse.inc b/templates/includes/RequestItemResponse.inc
new file mode 100644
index 0000000..36d7d20
--- /dev/null
+++ b/templates/includes/RequestItemResponse.inc
@@ -0,0 +1,4 @@
+<RequestId>
+  <AgencyId>[% requestagency %]</AgencyId>
+  <RequestIdentifierValue>[% messages.request_id %]</RequestIdentifierValue>
+</RequestId>
-- 
2.43.2