From 291c9e5064f06cd8dc76ac30ad819b606cb9c9d7 Mon Sep 17 00:00:00 2001 From: Jason Stephenson Date: Sun, 5 Oct 2014 12:14:25 -0400 Subject: [PATCH 1/1] Last fix just gave us a different warning. Try to fix it for real this time. Signed-off-by: Jason Stephenson --- lib/NCIP/ILS/Evergreen.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/NCIP/ILS/Evergreen.pm b/lib/NCIP/ILS/Evergreen.pm index 2bd524d..1fda3cc 100644 --- a/lib/NCIP/ILS/Evergreen.pm +++ b/lib/NCIP/ILS/Evergreen.pm @@ -1592,8 +1592,8 @@ sub check_user_for_problems { # Next, check if the patron has one of the indicated blocks. unless ($problem) { foreach my $penalty (@{$user->standing_penalties()}) { - my @pblocks = split(/\|/, $penalty->standing_penalty->block_list()); - if (@pblocks) { + if ($penalty->standing_penalty->block_list()) { + my @pblocks = split(/\|/, $penalty->standing_penalty->block_list()); foreach my $block (@blocks) { if (grep {$_ =~ /$block/} @pblocks) { $problem = NCIP::Problem->new( @@ -1609,8 +1609,8 @@ sub check_user_for_problems { last; } } + last if ($problem); } - last if ($problem); } } -- 2.43.2