From 1a45c749125ccd12174e531cee75828b5a823a2a Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Tue, 28 Jan 2014 12:03:17 +1300 Subject: [PATCH] Working on RenewItem handler --- lib/NCIP/Handler/RenewItem.pm | 6 ++--- lib/NCIP/ILS/Koha.pm | 49 +++++++++++++++++++++++++---------- 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/lib/NCIP/Handler/RenewItem.pm b/lib/NCIP/Handler/RenewItem.pm index 91a9c8a..8096676 100644 --- a/lib/NCIP/Handler/RenewItem.pm +++ b/lib/NCIP/Handler/RenewItem.pm @@ -34,16 +34,16 @@ sub handle { my $vars; $vars->{'messagetype'} = 'RenewItemResponse'; $vars->{'barcode'} = $itemid; - if ( !$checkin->{success} ) { + if ( !$renewed->{success} ) { $vars->{'processingerror'} = 1; - $vars->{'processingerrortype'} = $checkin->{'messages'}; + $vars->{'processingerrortype'} = $renewed->{'messages'}; $vars->{'processingerrorelement'} = 'UniqueItemIdentifier'; $output = $self->render_output( 'problem.tt', $vars ); } else { $vars->{'elements'} = \@elements; - $vars->{'checkin'} = $checkin; + $vars->{'renewed'} = $renewed; $output = $self->render_output( 'response.tt', $vars ); } return $output; diff --git a/lib/NCIP/ILS/Koha.pm b/lib/NCIP/ILS/Koha.pm index f43f4a1..2595ddd 100644 --- a/lib/NCIP/ILS/Koha.pm +++ b/lib/NCIP/ILS/Koha.pm @@ -59,23 +59,26 @@ sub checkout { my $borrower = GetMemberDetails( undef, $userid ); my $error; my $confirm; - my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $branchprinter, $persona)= @_; + my ( + $usernum, $userid, $usercnum, $userfirstname, + $usersurname, $userbranch, $branchname, $userflags, + $emailaddress, $branchprinter, $persona + ) = @_; my @USERENV = ( - 1, - 'test', - 'MASTERTEST', - 'Test', - 'Test', - 'AS', #branchcode need to set this properly - 'Auckland', - 0, + 1, + 'test', + 'MASTERTEST', + 'Test', + 'Test', + 'AS', #branchcode need to set this properly + 'Auckland', + 0, ); -C4::Context->_new_userenv ('DUMMY_SESSION_ID'); -C4::Context->set_userenv ( @USERENV ); + C4::Context->_new_userenv('DUMMY_SESSION_ID'); + C4::Context->set_userenv(@USERENV); - - if ($borrower) { + if ($borrower) { ( $error, $confirm ) = CanBookBeIssued( $borrower, $barcode ); @@ -91,7 +94,7 @@ C4::Context->set_userenv ( @USERENV ); } else { my $datedue = AddIssue( $borrower, $barcode ); - return (0, undef, $datedue); #successfully issued + return ( 0, undef, $datedue ); #successfully issued } } else { @@ -100,4 +103,22 @@ C4::Context->set_userenv ( @USERENV ); } } +sub renew { + my $self = shift; + my $barcode = shift; + my $userid = shift; + my $borrower = GetMemberDetails( undef, $userid ); + if ($borrower) { + my $datedue = AddRenewal( $barcode, $borrower->{'borrowernumber'} ); + my $result = { + success => 1, + datedue => $datedue + }; + return $result; + + } + else { +#handle stuff here + } +} 1; -- 2.43.2