]> git.evergreen-ils.org Git - working/NCIPServer.git/commit
Add error handling to NCIP::ILS::Evergreen->cancelrequestitem.
authorJason Stephenson <jstephenson@mvlc.org>
Tue, 18 Aug 2015 13:27:54 +0000 (09:27 -0400)
committerJason Stephenson <jstephenson@mvlc.org>
Tue, 18 Aug 2015 13:27:54 +0000 (09:27 -0400)
commitbb1d2c5c3dc374ebf49adbc1579418b1ac8c6909
treec428bdd2db154264f1e38d8e3e97108163be5d8b
parente6a82bdecc0c1e33e00f195f93d9f1bcf2e8277a
Add error handling to NCIP::ILS::Evergreen->cancelrequestitem.

We did not check the return value of open-ils.circ.hold.cancel, because
why would it fail?  Turns out there are a couple of reasons it could
fail, including not setting up permissions for the staff user correctly.

The cancel_hold helper function now returns the return value of the
open-ils.circ.hold.cancel method.  This method returns 1 on succes or
a reference ot an event hash on failure.

The cancelrequestitem method now returns a Problem response message
of Temporary Processing Failure if cancel_hold returns a ref.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
lib/NCIP/ILS/Evergreen.pm