"Fix" templates/includes/problem.inc. During testing I noticed that the Problem messages had an extra newline in the ProblemType field. This apparently causes problems for Auto-Graphics' parser, so this commit removes it. Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Reimplement requestitem handler in NCIP::ILS::Evergreen. Testing with Auto-Graphics suggests that our original logic was too complicated, so we simplify it to only handle what Auto-Graphics sends us. We may want to implement a more generic handler in the future when NCIPServer is used with more vendors. However, it seems fairly typical for responders to also be vendor specific. While simplifying the logic, this commit gets rid of some unneeded funtions. We also fix a typo in the RequestItemResponse.inc template. Signed-off-by: Jason Stephenson <jason@sigio.com>
Changes to NCIP::ILS::Evergreen as a result of testing. These modifications are based on testing with Auto-Graphics and reflect how they say they will be sending data in production. They will return the ItemId that we are now returning in the response to RequestItem so we can use that to find the appropriate hold to cancel. The above necessitated some internal changes to the code that amounted to a simplification of placing holds (in some cases) as well as a simplification in canceling holds. There is still some cruft hanging around that should probably go away, but I think we're safe for now. We've also update some templates to fix issues while testing the above mentioned changes, specifically RequestItemResponse.inc and CancelRequestItemResponse.inc. Signed-off-by: Jason Stephenson <jason@sigio.com>
Alter the template includes so that fields are in xsd order. Signed-off-by: Jason Stephenson <jason@sigio.com>
Templates changes for Auto-graphics. They requested that we remove "carriage returns" from the output. I'm not 100% certain if he meant all carriage returns or if he just wanted the weird spacing that some elements had where the open tag is on one line followed by the value and the close tag on the next line. I don't really know exactly why that was happening, but it seemed to have something to do with trying to make the value come out on a line by its own between the open and close tags. This change puts those elements on one line. Signed-off-by: Jason Stephenson <jason@sigio.com>
Add NCIP::PhysicalAddress object. I started to add this to the code last night to make addresses even more abstract and extensible. Instead, I took a short cut. In the light of the new day, I decided to go back and add this class as the right thing to do. We modify NCIP::ILS::Evergreen, NCIP::User::AddressInformation, and the include for UserOptionalFields to make use of the new object. Signed-off-by: Jason Stephenson <jason@sigio.com>
Get rid of the namespace prefix in templates and includes. Signed-off-by: Jason Stephenson <jason@sigio.com>
Fixup a lot of stuff based on a first round of real testing. Add ncip: namespace qualifier in templates and includes. Reorder some fields because apparently the field order matters, at least to xmllint when using the schema. Make some code changes in NCIP::ILS::Evergreen to make sure that date fields have the proper format. (This still needs testing, so we'll see.) Signed-off-by: Jason Stephenson <jason@sigio.com>
Add handling of ItemElementType in NIP::ILS::Evergreen. This includes some template changes to output the ItemOptionalFields element data. Signed-off-by: Jason Stephenson <jason@sigio.com>
Add UserOptionalFields to more templates. Also add checks for it in more messages for NCIP::ILS::Evergreen. Signed-off-by: Jason Stephenson <jason@sigio.com>