From deb52e4c24ab9f0a87f0fe592bda968ca5e6d9ac Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Tue, 14 Jan 2014 11:00:38 -0500 Subject: [PATCH] LP#1269042: prevent acq seach from building dropdown of every copy ID in the DB This patch ensures that if a user sets a search field in the acquisitions general search form to the line item details copy ID (labeled "LID - Evergreen Copy ID"), the form presents a normal input widget rather than trying to build a drop-down containing every copy ID in the database. Except for very small databases, the previous behavior would mean that an open-ils.pcrud backend would eventually consume a great deal of memory trying to service a request for all copies in the system. Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander --- Open-ILS/web/js/ui/default/acq/search/unified.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Open-ILS/web/js/ui/default/acq/search/unified.js b/Open-ILS/web/js/ui/default/acq/search/unified.js index 1eaad19c81..926662fa1f 100644 --- a/Open-ILS/web/js/ui/default/acq/search/unified.js +++ b/Open-ILS/web/js/ui/default/acq/search/unified.js @@ -159,10 +159,13 @@ function TermSelectorFactory(terms) { ); } else if (term.hint == "acqlia" || (term.hint == "jub" && term.field == "eg_bib_id") || + (term.hint == "acqlid" && term.field == "eg_copy_id") || (term.datatype == "link" && target == "au")) { - /* The test for jub.eg_bib_id is a special case to prevent - * AutoFieldWidget from trying to render a ridiculous dropdown - * of every bib record ID in the system. */ + /* The tests for jub.eg_bib_id and acqlid.eg_copy_id are + * special cases to prevent AutoFieldWidget from trying + * to render a ridiculous dropdown of every bib or copy + * record ID in the system. + */ wStore[widgetKey] = dojo.create( "input", {"type": "text"}, parentNode, "only" ); -- 2.43.2