From ddbf7fc70d05d08c1fdceade812f9a26bc33d91a Mon Sep 17 00:00:00 2001 From: Ben Shum Date: Sat, 8 Feb 2014 03:42:07 -0500 Subject: [PATCH] LP1125471 - Use label instead of id in recording in-house use prompt When recording multiple in-house use with the library settings for threshold prompts, the prompt would bring up the ID as the variable instead of the name of the non-cataloged material. This caused confusion among staff members who might see a message like: "Are you sure you want to mark 9 as having been used 21 times?" (9 being the id, not the name of the non-cataloged material) This commit leverages existing code which had been commented out and under the ID to use the label name for the non-cataloged material instead. Also, minor bugfix with a missing semi-colon at the end of the function being used. Signed-off-by: Ben Shum Signed-off-by: Bill Erickson --- Open-ILS/xul/staff_client/server/circ/in_house_use.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Open-ILS/xul/staff_client/server/circ/in_house_use.js b/Open-ILS/xul/staff_client/server/circ/in_house_use.js index e3d7be529a..2287448b35 100644 --- a/Open-ILS/xul/staff_client/server/circ/in_house_use.js +++ b/Open-ILS/xul/staff_client/server/circ/in_house_use.js @@ -229,8 +229,7 @@ circ.in_house_use.prototype = { if ( obj.test_barcode(barcode) ) { /* good */ } else { /* bad */ return; } } } else { - barcode = ( obj.controller.view.in_house_use_menu.value ); - //barcode = obj.data.hash.cnct[ obj.controller.view.in_house_use_menu.value ].name() + barcode = obj.data.hash.cnct[ obj.controller.view.in_house_use_menu.value ].name(); } var multiplier = Number( obj.controller.view.in_house_use_multiplier_textbox.value ); -- 2.43.2