From dcc5475a0328da91ec7a006cd130b51422da3491 Mon Sep 17 00:00:00 2001 From: Blake Henderson Date: Tue, 1 Jul 2014 17:06:30 -0500 Subject: [PATCH] LP1277556 Fast Item Add no longer opens record after copy is created Altered save_attempt to handle undefined and true cases for replace_on_complete When fastItemAdd is not used, replace_on_complete is undefined When it is used, and successful, replace_on_complete will be set to true then we need it to execute result.on_complete() Signed-off-by: Blake Henderson Signed-off-by: Remington Steed Signed-off-by: Ben Shum --- Open-ILS/xul/staff_client/server/cat/marcedit.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Open-ILS/xul/staff_client/server/cat/marcedit.js b/Open-ILS/xul/staff_client/server/cat/marcedit.js index 8359afcef0..b404510fff 100644 --- a/Open-ILS/xul/staff_client/server/cat/marcedit.js +++ b/Open-ILS/xul/staff_client/server/cat/marcedit.js @@ -1228,7 +1228,10 @@ function save_attempt(xml_string) { if (result.id) { replace_on_complete = fastItemAdd_attempt(result.id); } - if (!replace_on_complete && typeof result.on_complete == 'function') { + // When fastItemAdd is not used, replace_on_complete is undefined + // When it is used, and successful, replace_on_complete will be set to true + // then we need it to execute on_complete() + if ((replace_on_complete==undefined || replace_on_complete ) && typeof result.on_complete == 'function') { result.on_complete(); } } -- 2.43.2