From c1cec9a95a25935d5f0e97d1c104ef5d093cef7e Mon Sep 17 00:00:00 2001 From: Dan Wells Date: Thu, 13 Feb 2014 11:56:19 -0500 Subject: [PATCH] LP#1526543 Truthiness check for reset_password is flawed We expect boolean options in config.tt2 to be 'true' or 'false', but the code was simple asking 'IF reset_password', which is true for either value. Instead, match on the string (as we do in other places). To test: - Load the stock catalog login page - Notice the "Forgot your password?" link staying no matter which way 'reset_password' is set in config.tt2 - Apply patch, and change 'reset_password' value in config.tt2 to 'false' - RESULT: Password reset link doesn't show up Signed-off-by: Dan Wells Signed-off-by: Remington Steed Signed-off-by: Ben Shum --- Open-ILS/src/templates/opac/parts/login/form.tt2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/templates/opac/parts/login/form.tt2 b/Open-ILS/src/templates/opac/parts/login/form.tt2 index 9b13f587a2..88d42c91eb 100644 --- a/Open-ILS/src/templates/opac/parts/login/form.tt2 +++ b/Open-ILS/src/templates/opac/parts/login/form.tt2 @@ -31,7 +31,7 @@ [% INCLUDE "opac/parts/login/password_hint.tt2" %] - [% IF reset_password %] + [% IF reset_password == 'true' %] [% l('Forgot your password?') %] [% END %] -- 2.43.2