From b59e7a08b7824bc3f22490f8a56076020312e0b6 Mon Sep 17 00:00:00 2001 From: miker Date: Wed, 9 Mar 2005 07:27:11 +0000 Subject: [PATCH] moving the rest of the (existing) API to the new fast_fieldmapper stuff git-svn-id: svn://svn.open-ils.org/ILS/trunk@290 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- .../Application/Storage/Publisher/actor.pm | 45 ++++--------------- .../Application/Storage/Publisher/biblio.pm | 12 ++--- 2 files changed, 14 insertions(+), 43 deletions(-) diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/actor.pm b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/actor.pm index 702c8a88b7..f98def7c15 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/actor.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/actor.pm @@ -11,32 +11,17 @@ sub get_user_record { my $client = shift; my @ids = @_; + my $search_field = 'id'; + $search_field = 'usrname' if ($self->api_name =~/userid/o); + $search_field = 'usrname' if ($self->api_name =~/username/o); + for my $id ( @ids ) { next unless ($id); $log->debug("Searching for $id using ".$self->api_name, DEBUG); - my $rec; - - if ($self->api_name =~/username/o) { - ($rec) = actor::user->search( usrname => "$id"); - } elsif ($self->api_name =~/userid/o) { - ($rec) = actor::user->search( usrid => "$id"); - } else { - $rec = actor::user->retrieve("$id"); - } - - if ($rec) { - - my $user = Fieldmapper::actor::user->new; - - for my $field (Fieldmapper::actor::user->real_fields) { - $user->$field($rec->$field); - } - - $client->respond( $user ); - - } + my ($rec) = actor::user->fast_fieldmapper($search_field => "$id"); + $client->respond( $rec ) if ($rec); last if ($self->api_name !~ /list$/o); } @@ -86,19 +71,8 @@ sub update_user_record { my $client = shift; my $user = shift; - my $rec = actor::user->retrieve(''.$user->id); + my $rec = actor::user->update($user); return 0 unless ($rec); - - $rec->autoupdate(0); - - for my $field ( Fieldmapper::actor::user->real_fields ) { - $rec->$field( $user->$field ); - } - - return 0 unless ($rec->is_changed); - - $rec->update; - return 1; } __PACKAGE__->register_method( @@ -113,10 +87,7 @@ sub delete_record_entry { my $client = shift; my $user = shift; - my $rec = actor::user->retrieve(''.$user->id); - return 0 unless ($rec); - - $rec->delete; + my $rec = actor::user->delete($user); return 1; } __PACKAGE__->register_method( diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/biblio.pm b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/biblio.pm index a84bdbbacf..c9550a0180 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/biblio.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/biblio.pm @@ -88,8 +88,8 @@ sub search_record_entry_one_field { for my $id ( @ids ) { next unless ($id); - for my $rec ( biblio::record_entry->search($search_field => "$id") ) { - $client->respond( $rec->to_fieldmapper ) if ($rec); + for my $rec ( biblio::record_entry->fast_fieldmapper($search_field => "$id") ) { + $client->respond( $rec ) if ($rec); } last if ($self->api_name !~ /list/o); @@ -119,8 +119,8 @@ sub get_record_entry { for my $id ( @ids ) { next unless ($id); - my $rec = biblio::record_entry->retrieve($id); - $client->respond( $rec->to_fieldmapper ) if ($rec); + my ($rec) = biblio::record_entry->fast_fieldmapper($id); + $client->respond( $rec ) if ($rec); last if ($self->api_name !~ /list/o); } @@ -201,8 +201,8 @@ sub get_record_node { for my $id ( @ids ) { next unless ($id); - my $rec = biblio::record_node->retrieve($id); - $client->respond( $rec->to_fieldmapper ) if ($rec); + my ($rec) = biblio::record_node->fast_fieldmapper($id); + $client->respond( $rec ) if ($rec); last if ($self->api_name !~ /list/o); } -- 2.43.2