From abefaa0dffe415bca9669de7a884ce22d6a9c2a3 Mon Sep 17 00:00:00 2001
From: Kathy Lussier <klussier@masslnc.org>
Date: Tue, 19 Jul 2016 14:02:12 -0400
Subject: [PATCH] LP#1604515: Remove Advanced Hold Options link when part holds
 are expected

This branch removes the Advanced Hold Options link from the Place Hold
screen in cases where all copies on the bib record contain parts. If a user
attempts to place a metarecord hold and all other copies in the group also
contain parts, the hold will fail. By removing the link, we are removing one
potential point of failure for the user.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---
 Open-ILS/src/templates/opac/parts/place_hold.tt2         | 2 +-
 .../OPAC/remove_advanced_hold_options_for_parts.adoc     | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc

diff --git a/Open-ILS/src/templates/opac/parts/place_hold.tt2 b/Open-ILS/src/templates/opac/parts/place_hold.tt2
index 55f11848db..c4f197d177 100644
--- a/Open-ILS/src/templates/opac/parts/place_hold.tt2
+++ b/Open-ILS/src/templates/opac/parts/place_hold.tt2
@@ -125,7 +125,7 @@
                         [% END %]
                     [% END %]
                     [% IF NOT metarecords.disabled %]
-                        [% IF CGI.param('hold_type') == 'T' AND hdata.record.metarecord %]
+                        [% IF CGI.param('hold_type') == 'T' AND hdata.record.metarecord AND !hdata.part_required %]
                         <!-- Grab the bre_id so that we can restore it if user accidentally clicks advanced options -->
                            [% bre_id = hdata.target.id %]
                             <a  id='advanced_hold_link'
diff --git a/docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc b/docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc
new file mode 100644
index 0000000000..3f2f642b1a
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc
@@ -0,0 +1,9 @@
+Removal of Advanced Hold Options link when part holds are expected
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+If a user attempts to place a metarecord hold when all eligible copies
+contain parts, the hold will fail. To help prevent the user from reaching
+a dead end while placing holds, the _Advanced Hold Options_ link is removed
+from the Place Hold page in cases where all copies on the record contain
+parts. The _Advanced Hold Options_ link will remain for records that have
+a mix of parted and non-parted copies.
+
-- 
2.43.2