From 98157770f0694d18aed9342367f4375dde599d3b Mon Sep 17 00:00:00 2001
From: Garry Collum <gcollum@gmail.com>
Date: Wed, 28 Apr 2021 15:26:39 -0400
Subject: [PATCH] LP1809157 SMS Carriers display not in alphabetical order

This alphabetizes the carrier display when editing the sms carrier in an existing hold.

It also adds the region to the name to make the interface consistent with other interfaces.

To Test:

1. Enable SMS options in the Library Settings.
2. Place a hold for a patron.
3. Use the Edit Notifications Settings.  Enter an SMS number, if needed.
4. Drop-down the Carrier list - the list is not in alphabetical order.
5. Apply the patch and repeat 3-4.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 .../templates/staff/circ/share/t_hold_notification_prefs.tt2    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Open-ILS/src/templates/staff/circ/share/t_hold_notification_prefs.tt2 b/Open-ILS/src/templates/staff/circ/share/t_hold_notification_prefs.tt2
index 7f2659d21e..3d1c712938 100644
--- a/Open-ILS/src/templates/staff/circ/share/t_hold_notification_prefs.tt2
+++ b/Open-ILS/src/templates/staff/circ/share/t_hold_notification_prefs.tt2
@@ -64,7 +64,7 @@
         <select id='sms-carrier'
           ng-model="args.sms_carrier" 
           ng-disabled="!args.update_sms_carrier"
-          ng-options="carrier.name() for carrier in sms_carriers">
+          ng-options="carrier.name() + ' (' + carrier.region() + ')' for carrier in sms_carriers | orderBy:'name()' ">
         </select>
       </div>
     </div>
-- 
2.43.2