From 78620f6c97ed88fa71444a61c06e5f5c34a9ef1e Mon Sep 17 00:00:00 2001 From: Jason Boyer Date: Fri, 25 Apr 2014 12:45:34 -0400 Subject: [PATCH 1/1] LP1312824 open-ils.circ.hold.change_title fix Add a capture_time => undef limit to both change_title APIs to prevent currently captured holds from being reset when moving holds from one title to another. More work is needed to prevent items currently in transit from having their transits canceled. Test plan --------- 1. Create a bib with multiple holdings 2. Add multiple holds to this title and capture one of them - Item will have a status of On Holds Shelf 3. Open another bib record, open Actions for this Record menu, Mark as Hold Transfer Destination 4. Return to the record that has a captured hold, open Actions for this Record, Transfer all Title Holds 5. Check Captured hold, Item status is Available, hold has been reset and now points to the new bib record. With the patch applied, steps 2-5 above should be repeated, but this time in step 5 the hold will still be on the original record and the item's status will still be On Holds Shelf. Signed-off-by: Jason Boyer Signed-off-by: Kathy Lussier Signed-off-by: Galen Charlton --- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm index 1825c71580..87e1baf6be 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm @@ -4037,6 +4037,7 @@ sub change_hold_title { my $holds = $e->search_action_hold_request( [ { + capture_time => undef, cancel_time => undef, fulfillment_time => undef, hold_type => 'T', @@ -4073,6 +4074,7 @@ sub change_hold_title_for_specific_holds { my $holds = $e->search_action_hold_request( [ { + capture_time => undef, cancel_time => undef, fulfillment_time => undef, hold_type => 'T', -- 2.43.2