From 697d260e3db01ccbce9862335f380689bef18b77 Mon Sep 17 00:00:00 2001 From: Chris Sharp Date: Wed, 31 May 2017 08:22:58 -0400 Subject: [PATCH 1/1] LP#1694696 - Check for blank SMS Carriers in A/T reactor Currently, the get_sms_gateway_email subroutine does not check for the truthiness of sms_carrier, which can result in catastrophic failure for a running server. This adds that check. Signed-off-by: Chris Sharp Signed-off-by: Galen Charlton --- .../src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm index 0df0ab08ba..f334f66ddd 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm @@ -380,7 +380,7 @@ $_TT_helpers = { my $sms_carrier = shift; my $sms_notify = shift; - if (! defined $sms_notify || $sms_notify eq '') { + if (! defined $sms_notify || $sms_notify eq '' || ! defined $sms_carrier || $sms_carrier eq '') { return ''; } -- 2.43.2