From 4a1488b028da074dc8c88a2cfa1a089e23891dd1 Mon Sep 17 00:00:00 2001
From: Dan Scott <dan@coffeecode.net>
Date: Wed, 29 Jun 2011 17:05:46 -0400
Subject: [PATCH] Don't include non-existent elements in search results

It does not make sense to clutter HTML output with table rows that are
destined to remain hidden and empty of any data; therefore, instead of
setting the class to "hide_me" when there is no value to display, just
do not display the row at all.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
---
 .../default/opac/parts/result/table.tt2        | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/Open-ILS/web/templates/default/opac/parts/result/table.tt2 b/Open-ILS/web/templates/default/opac/parts/result/table.tt2
index 6ab1b2b28f..580fefd81f 100644
--- a/Open-ILS/web/templates/default/opac/parts/result/table.tt2
+++ b/Open-ILS/web/templates/default/opac/parts/result/table.tt2
@@ -106,18 +106,22 @@
                                                     </div>
                                                     <table cellpadding="0" cellspacing="0" border="0"
                                                         class="results_info_table">
-                                                        <tr name="results_pub_tr" class="[% attrs.publisher ? '' : 'hide_me' %]">
+                                                    [% IF attrs.publisher %]
+                                                        <tr name="results_pub_tr">
                                                             <td valign="top">
                                                                 <strong>[% l('Publisher:') %]</strong>
                                                             </td>
                                                             <td>[% attrs.publisher; %]</td>
                                                         </tr>
-                                                        <tr name="results_isbn_tr" class="[% attrs.isbn ? '' : 'hide_me' %]">
+                                                    [% END %]
+                                                    [% IF attrs.isbn %]
+                                                        <tr name="results_isbn_tr">
                                                             <td valign="top">
                                                                 <strong>[% l('ISBN:') %]</strong>
                                                             </td>
                                                             <td>[% attrs.isbn %]</td>
                                                         </tr>
+                                                    [% END %]
                                                         [% IF openurl.enabled == 'true';
                                                             FOR issn IN args.issns;
                                                                 sfx = ResolverResolver.resolve_issn(issn, openurl.baseurl);
@@ -134,13 +138,16 @@
                                                             [% END %]
                                                         [% END %]
 
-                                                        <tr name="results_edition_tr" class="[% attrs.edition ? '' : 'hide_me' %]">
+                                                    [% IF attrs.edition %]
+                                                        <tr name="results_edition_tr">
                                                             <td valign="top">
                                                                 <strong>[% l('Edition:') %]</strong>
                                                             </td>
                                                             <td>[% attrs.edition %]</td>
                                                         </tr>
-                                                        <tr name="results_phys_desc_tr" class="[% attrs.phys_desc ? '' : 'hide_me' %]">
+                                                    [% END %]
+                                                    [% IF attrs.phys_desc %]
+                                                        <tr name="results_phys_desc_tr">
                                                             <td nowrap="nowrap" valign="top">
                                                                 <strong>[% l('Phys. Desc.:') %]</strong>
                                                             </td>
@@ -148,7 +155,8 @@
                                                                 [% args.phys_desc %]
                                                             </td>
                                                         </tr>
-                                                        [% FOR uri IN args.uris%]
+                                                    [% END %]
+                                                        [% FOR uri IN args.uris %]
                                                         <tr name='bib_uri_list' class='result_table_title_cell'>
                                                             <td valign='top'>
                                                                 <strong>[% l('Electronic resource') %]</strong>
-- 
2.43.2