From 48c1b5bcf4903b6705c981f5072ca8ce8537e343 Mon Sep 17 00:00:00 2001 From: Jeff Godin Date: Wed, 30 Oct 2013 15:29:24 -0400 Subject: [PATCH] Treat empty username as invalid in user editor There seems to be undesired interaction between the required attribute and the isValid method on a dojo/dijit ValidationTextBox. If both are set, isValid needs to check for an empty value, otherwise the field is considered valid the moment it gains focus. We don't want an empty username to be considered valid, because we know that we will be unable to save the user. We can work around this by teaching the isValid function to consider an empty value as invalid. Signed-off-by: Jeff Godin Signed-off-by: Melissa Ceraso Signed-off-by: Ben Shum --- Open-ILS/web/js/ui/default/actor/user/register.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js index aabdc3c203..daccc51620 100644 --- a/Open-ILS/web/js/ui/default/actor/user/register.js +++ b/Open-ILS/web/js/ui/default/actor/user/register.js @@ -1347,6 +1347,10 @@ function attachWidgetEvents(fmcls, fmfield, widget) { case 'usrname': widget.widget.isValid = function() { + // Not empty + if(this.attr("value") == '') { + return false; + } // No spaces if(this.attr("value").match(/\s/)) { return false; -- 2.43.2