From 3de90c3372f180481b0cff9a68cc7b4b8766dfd7 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Mon, 24 Apr 2017 13:16:21 -0400 Subject: [PATCH] LP#1681466: move text to body of confirm dialog and add title This patch tweaks the opt-in confirm dialog to add a title and move the text to the body of the dialog, making it consistent with other dialogs that ask long questions. Test case for the entire bug fix -------------------------------- [1] Ensure that is set to true in opensrf.xml. [2] In the web staff client, open the checkout page and do a barcode search for a patron is *not* the same system as the workstation that the staff user is registered to. [3] Verify that a dialog box is presented asking the staff user to confirm that personal information can be shared with the workstation's library. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson --- Open-ILS/src/templates/staff/circ/patron/index.tt2 | 1 + Open-ILS/web/js/ui/default/staff/circ/patron/app.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/templates/staff/circ/patron/index.tt2 b/Open-ILS/src/templates/staff/circ/patron/index.tt2 index a0ec497105..b017f19c9f 100644 --- a/Open-ILS/src/templates/staff/circ/patron/index.tt2 +++ b/Open-ILS/src/templates/staff/circ/patron/index.tt2 @@ -49,6 +49,7 @@ angular.module('egCoreMod').run(['egStrings', function(s) { s.PAYMENT_OVER_MAX = "[% l('Payments over $[_1] are denied by policy.', '{{max_amount}}') %]"; s.PATRON_NOTE_DELETE_CONFIRM_TITLE = "[% l('Delete Note?') %]"; s.PATRON_NOTE_DELETE_CONFIRM = "[% l('Delete the note titled \"[_1]\" created on [_2]?', '{{note_title}}', '{{create_date | date}}') %]"; + s.OPT_IN_DIALOG_TITLE = "[% l('Verify Permission to Share Personal Information') %]"; s.OPT_IN_DIALOG = "[% l('Does patron [_1], [_2] from [_3] ([_4]) consent to having their personal information shared with your library?', '{{family_name}}', '{{first_given_name}}', '{{org_name}}', '{{org_shortname}}') %]"; }]); diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/app.js b/Open-ILS/web/js/ui/default/staff/circ/patron/app.js index 2bdc540316..02ab395c57 100644 --- a/Open-ILS/web/js/ui/default/staff/circ/patron/app.js +++ b/Open-ILS/web/js/ui/default/staff/circ/patron/app.js @@ -798,7 +798,8 @@ function($scope , $location , egCore , egConfirmDialog , egUser , patronSvc) { .then(function(user) { // retrieve user var org = egCore.org.get(user.home_ou()); egConfirmDialog.open( - egCore.strings.OPT_IN_DIALOG, '', + egCore.strings.OPT_IN_DIALOG_TITLE, + egCore.strings.OPT_IN_DIALOG, { family_name : user.family_name(), first_given_name : user.first_given_name(), org_name : org.name(), -- 2.43.2