From 2c1c3b6443376e04fc5234569866d3214a9ada60 Mon Sep 17 00:00:00 2001
From: Galen Charlton <gmc@equinoxOLI.org>
Date: Mon, 20 Sep 2021 17:17:00 -0400
Subject: [PATCH] LP#1929242: (follow-up) additional tweaks

- remove console message upon deleting note
- flesh the creator and editor columns
- make notes grid filterable

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 .../eg2/src/app/staff/catalog/record/notes.component.html   | 1 +
 .../src/eg2/src/app/staff/catalog/record/notes.component.ts | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.html
index 9c7e2e91b6..a4052336ac 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.html
@@ -2,6 +2,7 @@
 
   <eg-grid #notesGrid idlClass="bren" [dataSource]="gridDataSource"
       [sortable]="true" persistKey="catalog.record.notes"
+      [filterable]="true"
       showFields="value,create_date" class="mt-3">
     <eg-grid-toolbar-button [disabled]="!permissions.CREATE_RECORD_NOTE"
       label="New Record Note" i18n-label [action]="createNew">
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.ts
index b489190892..f15cba9b89 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/record/notes.component.ts
@@ -71,7 +71,9 @@ export class NotesComponent implements OnInit {
             const searchOps = {
                 offset: pager.offset,
                 limit: pager.limit,
-                order_by: orderBy
+                order_by: orderBy,
+                flesh: 2,
+                flesh_fields: {bren: ['creator', 'editor']}
             };
 
             return this.pcrud.search('bren',
@@ -100,7 +102,7 @@ export class NotesComponent implements OnInit {
         this.deleteSelected = (notes: IdlObject[]) => {
             notes.forEach(note => note.isdeleted(true));
             this.pcrud.autoApply(notes).subscribe(
-                val => console.debug('deleted: ' + val),
+                val => {},
                 err => {},
                 ()  => this.notesGrid.reload()
             );
-- 
2.43.2