From 23e8de55bb283101ba046d40fbdc75c22e55741f Mon Sep 17 00:00:00 2001
From: Dan Scott <dscott@laurentian.ca>
Date: Tue, 24 Sep 2013 13:21:35 -0400
Subject: [PATCH] TPAC: Simplify opac-button styling

Conflicting padding declarations in the stylesheet, in an old attempt to
balance out the sizes of various INPUT types vs A elements in Chrome vs.
Firefox, were resulting in increasingly odd sizes for the buttons
(depending on which browser you used). Switching to a BUTTON instead of
an A tag and dropping all of the padding declarations improves the
situation on Firefox, Chrome, and IE8, while simplifying the CSS.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
---
 Open-ILS/src/templates/opac/css/style.css.tt2         | 11 -----------
 Open-ILS/src/templates/opac/parts/advanced/search.tt2 |  4 ++--
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/Open-ILS/src/templates/opac/css/style.css.tt2 b/Open-ILS/src/templates/opac/css/style.css.tt2
index 09eacb6206..76b9b64d56 100644
--- a/Open-ILS/src/templates/opac/css/style.css.tt2
+++ b/Open-ILS/src/templates/opac/css/style.css.tt2
@@ -1253,7 +1253,6 @@ div.opac-multiline-button > a,
 
 .opac-multiline-button > a, a.opac-button, input.opac-button {
     margin: 10px;
-    padding: 5px 10px 5px 10px;
 }
 
 #dash_wrapper .opac-button {
@@ -1737,16 +1736,6 @@ a.preflib_change {
     #simple-detail-view-links {
         display: none;
     }
-    .opac-button {
-        padding: 5px;
-        margin: 3px;
-    }
-
-    a.opac-button {
-        margin: 15px 5px;
-	padding: 2px 5px;
-    }
-
     #acct_tabs a, #acct_fines_tabs a {
        padding: 2px 4px 3px 4px;
        -moz-border-radius: 6px 6px 0px 0px;
diff --git a/Open-ILS/src/templates/opac/parts/advanced/search.tt2 b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
index 1228a39e89..d41c7e17c2 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/search.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
@@ -38,8 +38,8 @@
             <img id='search-submit-spinner' src='/opac/images/progressbar_green.gif' class='hidden' alt=''/>
         </span>
 
-        <a href="[% mkurl(ctx.opac_root _ '/advanced', {$loc_name => loc_value}, 1) %]"
-            class="pointer opac-button">[% l('Clear Form') %]</a>
+        <button href="[% mkurl(ctx.opac_root _ '/advanced', {$loc_name => loc_value}, 1) %]"
+            class="pointer opac-button">[% l('Clear Form') %]</button>
     </div>
 
     <div id='adv_search_filters'>
-- 
2.43.2