From 1c1bc36222e90f34a94e6ba38c8daf7f90775283 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Sun, 16 Sep 2018 18:48:59 -0400
Subject: [PATCH] LP#1792484 Patron preferred name in hold shelf dialog

Display the patron preferred name in addition to the primary name in the
route-to-holds-shelf dialog.  As with primary name, preferred name is
hidden when an alias is applied.

To test
[1] Add a primary first, middle, and/or last name value to a patron.
[2] Place a hold for the patron with the pickup library matching the
    login library.
[2] Capgture the hold via the Checkin interface (instead of the hold
    capture interface) and note the preferred name display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
---
 .../templates/staff/circ/share/t_hold_shelf_dialog.tt2   | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Open-ILS/src/templates/staff/circ/share/t_hold_shelf_dialog.tt2 b/Open-ILS/src/templates/staff/circ/share/t_hold_shelf_dialog.tt2
index 9611f99884..bb26ff4ce0 100644
--- a/Open-ILS/src/templates/staff/circ/share/t_hold_shelf_dialog.tt2
+++ b/Open-ILS/src/templates/staff/circ/share/t_hold_shelf_dialog.tt2
@@ -45,6 +45,15 @@
       {{patron.first_given_name}} {{patron.second_given_name}}
       [% END %]
     </div>
+    <div ng-hide="patron.alias">
+      <div ng-if="patron.pref_family_name || patron.pref_first_given_name || patron.pref_second_given_name">
+        [% l('Preferred name: [_1], [_2] [_3]', 
+          '{{patron.pref_family_name || patron.family_name}}',
+          '{{patron.pref_first_given_name || patron.first_given_name}}',
+          '{{patron.pref_second_given_name}}') 
+        %]
+      </div>
+    </div>
     <div>
       <span>[% l('Patron Barcode:') %]</span>
       <span>{{patron.card.barcode}}</span>
-- 
2.43.2