From 0575262008f19f16e9da5b1d56d0d9e7be884695 Mon Sep 17 00:00:00 2001 From: Remington Steed Date: Fri, 7 Mar 2014 13:56:25 -0500 Subject: [PATCH] Remove buggy, unused function get_leaders_from_usergroup Recent editing and testing of get_leaders_from_usergroup() uncovered an unrelated bug which renders the function useless (it returns all group members, not just the leader). It wasn't previously caught because Evergreen has no apparent references to this function. This commit removes the unused function. Signed-off-by: Remington Steed Signed-off-by: Dan Wells --- .../OpenILS/Application/Actor/UserGroups.pm | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm index 0a94956090..4d6913f337 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm @@ -63,33 +63,6 @@ sub get_users_from_usergroup { -__PACKAGE__->register_method( - method => 'get_leaders_from_usergroup', - api_name => 'open-ils.actor.usergroup.leaders.retrieve', - signature => q/ - Returns a list of ids for users that are leaders of the given usergroup - / -); - -sub get_leaders_from_usergroup { - my( $self, $conn, $auth, $usergroup ) = @_; - my $e = new_editor(authtoken=>$auth); - return $e->event unless $e->checkauth; - return $e->event unless $e->allowed('VIEW_USER'); # XXX reley on editor perm - my $users = $e->search_actor_user( - {usrgroup => $usergroup, deleted => 'f'}) - or return $e->event; - - my @res; - for my $u (@$users) { - push( @res, $u->id ) if $u->master_account; - } - - return \@res; -} - - - __PACKAGE__->register_method( method => 'get_address_members', api_name => 'open-ils.actor.address.members', -- 2.43.2