Galen Charlton [Tue, 1 Jun 2021 22:23:36 +0000 (18:23 -0400)]
LP#1904244: format: switch from CurrencyPipe to DecimalPipe
CurrencyPipe has no easy way of displaying the monetary amount
without a currency symbol, which means that currency amounts
display with a dollar sign -- which isn't a univeral assumption
for Evergreen.
Future work is indicated to (a) teach Evergreen a global flag
or a library setting for the system's base currency and (b) let
the format service be passed a currency code. Once both are in place,
CurrencyPipe can be restored.
This is a synonym of the 'required' attribute, as overloading
the HTML5 required attribute can lead the colored left border
indicated the state of the widget extending to the container
of the combobox.
LP#1904244: fm-editor: add a linkedSearchConditions field option
This option allows the caller to specify conditions to add
when retrieving values for a linked field, e.g., to specify
that only active values should be fetched.
If the underlying record has a value set for the linked field, that
value will be included when preloadLinkedValues and the value
doesn't otherwise meet the search conditions.
This patch also sorts the values if preloadLinkedValues is used.
Galen Charlton [Thu, 25 Mar 2021 17:44:44 +0000 (13:44 -0400)]
LP#1904244: teach grid columns how to start with a filter set
This adds initialFilterOperator and initialFilterValue inputs
to eg-grid-column to specify that the data set should start off
with a column filter set.
LP#1904244: update various IDL labels for acq columns
* Claiming and fund tables: "Org Unit" or "Org" to "Owner"
* "Claim Policy ID" to "Claim Policy" for links to claim
policies
* "Fund ID" to "Fund" for links to funds
* Fund allocation and fund debit times
Galen Charlton [Mon, 14 Jun 2021 15:34:51 +0000 (11:34 -0400)]
LP#1930933: fix issue with over-escaping in search results title attributes
This patch fixes an issue where a record with a title containing the
word "hidden" can have its title, ironically enough, not show up
on public catalog search results.
To test
-------
[1] Create an OPAC-visible record whose 245 is something like:
=245 04$aThe hidden one <script>alert('title!')</script>
[2] Search for the record in both the TPAC and Bootstrap skin. Note
that the title isn't displayed.
[3] Apply the patch and repeat step 2. This time, the full title
should be displayed.
[4] Verify that the OPAC does not display an alert box.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Bill Erickson [Mon, 4 Jan 2021 21:12:50 +0000 (16:12 -0500)]
LP1910145 Angular Hold Detail Notes & Notifications
The hold detail view now displays hold notes and hold notification
records. Notes and Notifications may be created by staff. Notes may be
deleted by staff.
The catalog under the Holds tab in the Checkout interface
doesn't load the default search or preferred library if
you haven't visited the main catalog page earlier in the
session.
This branch sets these settings as cookies in the
AngularJS wrapper for the catalog embedded in the Checkout
interface under the Holds tab.
Test:
1. Close browser, open browser, log into Evergreen
2. Admin->Workstation set search & preferred library
3. Open a patron record -> Holds tab -> Place Holds
4. Search for an item owned by your preferred library
5. Note the library's copies aren't separately indicated
6. Apply patch and repeat steps 1-5
7. Note the library's copies are separately indicated
Jason Etheridge [Thu, 1 Oct 2020 15:45:44 +0000 (11:45 -0400)]
lp1895738 need eg.orgselect.hopeless.wide_holds
This fixes the following:
ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.
However, it exposes a different (harmless?) error within the /eg2 holds grid:
ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Fri, 28 May 2021 02:32:27 +0000 (19:32 -0700)]
LP1922120: Add to carousel action in angular catalog
To test:
1) Create several manual carousels, and make sure they are
set to active.
2) Open a bib record in the Angular staff catalog.
3) Under Other Actions, choose the "Add to Carousel" action
4) Choose your preferred carousel.
5) Click Add to carousel.
6) Go back to carousel administration (or look at the carousel
itself), and confirm that the record has been added to the
carousel in question.
Jason Stephenson [Wed, 18 Dec 2019 18:11:55 +0000 (13:11 -0500)]
LP#1856868: Remove deprecated open-ils.circ.renew.auto API
The deprecated open-ils.circ.renew.auto API was removed. You will
want to use open-ils.circ.renew with the auto_renewal option set
to 1. This mainly affects those who have written custom code using
the open-ils.circ backend.
This removal was broadcast in the release notes for Launchpad bug 1835085: https://bugs.launchpad.net/bugs/1835085.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Bill Erickson [Thu, 28 Jan 2021 15:32:11 +0000 (10:32 -0500)]
LP1913338 Catalog search form visibility stickiness
On pages in the Angular staff catalog where the search form is collapsed
by default, users may now also manually expand and re-collapse the form.
The last used choice will be sticky via new workstation setting.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Garry Collum [Fri, 30 Oct 2020 19:55:35 +0000 (15:55 -0400)]
lp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.
The SMS Number field and Default Carrier field display when editing an
individual hold in the opac, regardless of the 'Enable features that send SMS text messages' setting.
This patch rectifies that behavior.
To test.
Set the 'Enable features that send SMS text messages' to False.
Place a hold for a patron.
Login to the opac as that patron and view the holds.
Edit the hold, and notice that the SMS and Carrier fields are displayed.
Apply the patch.
Refresh the edit form. The fields no longer display.
Set the 'Enable features that send SMS text messages' to True.
Refresh the edit form. The fields now display.
Jason Boyer [Fri, 30 Oct 2020 20:06:17 +0000 (16:06 -0400)]
LP1901710: Properly nest HTML tags and TT2 directives
This is a first pass at cleaning these up and the W3C's
HTML validator is a lot happier about some of the pages,
but the advanced search page at least needs some TLC.
I'm having trouble getting the shelving location selector
to appear at all and the aria complaints will require more
fixing.
Garry Collum [Thu, 25 Feb 2021 21:02:50 +0000 (16:02 -0500)]
LP1916936-Bootstrap opac: item tags display as separate copies on small screen.
This fixes the display of item tags and item notes in the bootstrap opac.
It also cleans up some <a> tags that had class defined twice.
To test.
1. Add an item tag and an item note to an item.
2. In the bootstrap opac make the screen as small as possible.
Notice that the display shows the tags and items as copies.
3. Apply the patch and repeat. The tags and notes should be displayed with the item that they are associated with.
Garry Collum [Tue, 5 Jan 2021 21:26:55 +0000 (16:26 -0500)]
LP1910288 Bootstrap opac: E-items lines always display in account summary.
The E-item summary of ckos and holds always display in the My Account Summary of the Bootstrap Opac
regardless of the ebook_api.enabled flag in config.tt2. This fixes that issue.
It also sets both the ebook_api.enabled and ebok_api.ebook_test.enabled flags to default to false.
To test:
1. Set ebook_api.enabled in config.tt2 to false.
2. Look at a patron's account summary and notice that it displays the e-item lines.
3. Apply the patch.
4. The E-item lines are now suppressed.
Garry Collum [Thu, 18 Mar 2021 17:49:32 +0000 (13:49 -0400)]
LP1920042 Bootstrap Opac: Simple Selector in Advanced Search
Fixes the simple selector in advanced search.
To Test:
1. Go to Administration - Server Administration - MARC Coded Value Maps
2. Assign the 'Is Simple Selector' option to some record attributes.
In concerto:
Lang - French, German
Type - Musical Sound Recording
Are good choices to test searching.
3. Notice in advanced search that these options no longer appear in the
Language or Item Type search filters.
4. Apply the patch.
5. The simple selector options should now appear at the top of each search
filter category.
6. Perform some searches using the simple selector options.
Jeff Davis [Mon, 26 Apr 2021 21:33:51 +0000 (14:33 -0700)]
LP#1923225: clean up some double-escaping of HTML in record display
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#1923225: have search highlighting stored procedure do HTML-escaping
This patch builds on the previous work to have the stored procedures
that produced highlighted and unhighlighted versions of display
attributes HTML-escape the source values, then adjusts the TPAC
and Bootstrap templates to avoid double-escaping.
Jeff Davis [Tue, 13 Apr 2021 23:05:41 +0000 (16:05 -0700)]
LP#1923225: fix handling of untruncated display fields in accordion
A previous commit used the TT2 "html" filter to escape strings to which the
accordion macro is applied, but which don't get truncated. But that's
incompatible with display fields, which contain embedded HTML and
therefore shouldn't be escaped in that way. This commit uses
HTML::Defang on untruncated accordion input instead (which is consistent
with how truncated strings are handled by the same macro).
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Briem [Thu, 20 May 2021 17:05:21 +0000 (13:05 -0400)]
LP#1928684 Catalog view holds tab sort by patron barcode error
This changes the Patron Barcode column name to ucard_barcode to
match the field name in the database.
Note: due to the name change, users who saved the column on the
grid will have to add it again.
To test:
1. Go to the View Holds tab on a record that has hold requests
2. Add the Patron Barcode column to the grid
3. Sort by the barcode column and note that it works
4. It's a good idea to test that the grid settings save properly
katiegmartin [Mon, 24 May 2021 19:52:32 +0000 (15:52 -0400)]
DOCS LP 1857917 Update glossary.adoc to include IDL
LP bug https://bugs.launchpad.net/evergreen/+bug/1857917
Add IDL definition to glossary, with synonym link to Fieldmapper IDL & change anchor point for F heading
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Tiffany Little [Sun, 17 Jan 2021 19:49:13 +0000 (14:49 -0500)]
LP1912097 Add timestamps
Adds timestamps to the date columns in Acquisitions Search.
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Dan Briem [Fri, 9 Apr 2021 22:19:02 +0000 (18:19 -0400)]
LP#1918362 Unchanged workstation settings applied on every checkin
* Stop attempting to save the Update Inventory setting on every
checkin - incorrect prefix & redundant (it's a modifier now)
* Stop saving the Strict Barcode setting on every checkin,
renewal, and checkout
* Save Strict Barcode on user interaction with its checkbox
To test:
1. confirm Strict Barcode and Do Inventory Update settings still
apply and are "sticky" on the Circulation->Checkin interface
2. confirm Strict Barcode still applies and is "sticky" on the
Circulation->Renew Items and Circulation->Checkout interfaces
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Tue, 27 Apr 2021 18:25:50 +0000 (11:25 -0700)]
LP#1924185: use preferred name before legal name in My Account
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
When available, the preferred name is used as the main name in the
patron summary (rather than as a less-prominent field beneath the main
name). The legal name is displayed further down in the summary, just
after the ID fields.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Wed, 23 Sep 2020 15:15:22 +0000 (11:15 -0400)]
LP1881607 Angular catalog located URIs
Display in-range located URIs in the staff catalog record summary pane.
Also applies a fix to the staff catalog to clear cached record detail
summaries on new searches to ensure the correct org-scoped version of
the record summary is retrieved on each new navigation to the detail
page.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Display electronic resource links (MARC 856's) in the Angular staff
catalog. The extraction logic, which matches the TPAC, has been put
into its own API.
To test in concerto, navigate to:
/eg2/staff/catalog/record/208
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Garry Collum [Fri, 15 Jan 2021 22:38:35 +0000 (17:38 -0500)]
LP1873539 Active column in SMS carrier configuration
This fixes the lack of values displaying in the Active column of the
SMS Carrier configuration screen. (Administration->Server Administration->SMS Carriers)
To test apply the patch.
Go to the Carrier Configuration screen and note that the 'Yes' and 'No'
boolean values now display for the Active column.
Mike Risher [Mon, 20 Jul 2020 22:10:55 +0000 (22:10 +0000)]
lp1615800 Accessibility on Patron Pages
Modify patron search, patron search results, and patron edit pages so
that they are compatible with screen readers. aria-labelledby can be
used to associate input fields with their labels.
(Rebased to master)
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified: Open-ILS/src/templates/staff/share/t_patron_search_form.tt2
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
projects / working / Evergreen.git / log