Dan Scott [Sun, 22 Jul 2012 22:58:11 +0000 (18:58 -0400)]
Fix / improve bookbag list paging
The prior code used CSS to hide elements, which is a bit weird given
that we can simply avoid creating the element in the first place and
keep the DOM a lot simpler.
Also, the previous code was subject to some bugs if it wasn't given
an explicit offset GET param or paging at the end of a list
(particularly given that the LIMIT parameter ensured that the number of
bookbags returned would always be equal to or less than the LIMIT
parameter).
Finally, the changes related the permanent bookbags didn't pass through
one of the context parameters we needed (bookbag_count) to enable
paging.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Wed, 18 Jul 2012 16:27:08 +0000 (12:27 -0400)]
TPAC: Refactor bookbag list actions into a common template
The "add to bookbag" actions in both the search results and record
details pages contained a large amount of duplicated code; consolidate
those into a single template that can be included into each page.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jason Stephenson [Wed, 11 Jul 2012 12:59:48 +0000 (08:59 -0400)]
Ability to add records to permanent bookbags in TPAC.
Add an actor usr setting for holding the name of a default book
list: opac.default_list.
Add a button on the my list interface to choose a list should as
the default list for adding titles. There is presently no way to
unset a default menu, though the default can be changed to any
other menu at any time by clicking that list's button.
Modify opac/record and opac/results so that if a patron is logged
in their my lists will populate a menu. This menu will include
options to add to a temporary list, the default list (if any), up
to 10 of the user's other lists, to add to a newly created list,
or to see all of their lists and add to one that does not appear
on the menu.
Adding to a temporary list will function the same as adding to a
list does prior to this enhancement.
Adding to a list chosen from the menu will add the record to that
list, and return the user to the search results or record page
that they were looking at.
Choosing to add to a new list will take the user to their "my
lists" page where they can create a new list. After the list is
created, the record they wanted to add will be added to the new
list and they will be returned to the search results or record
that they were looking at.
Choosing the "see all" menu option will also take the user to
their "my lists" page. However, all of their bookbags will be
visible and not just the normal limit of 10. Their will be a
button next to each list's name with the text "Add to this list."
When the user clicks one of those buttons, the record will be
added to that list and the user's session redirected back to
their search or result page.
The user will have the option to create a new list when viewing
all of their lists.
The user will also be able to use the "Add to this list" feature
when they have chosen the "Add to new list" menu option. This is
done from simplicity in the design, but also allows the user to
change their mind at the last second.
If a patron is not logged in, the add to my list will appear the
same as it does prior to this development. It will continue to
function as it does prior to this development.
Add coust for opac.patron_temporary_list_warn to let an ou enable
warning users when adding records to a temporary book bag.
Add cust opac.temporary_list_no_warn to let patrons disable
the warning for themselves.
Add the opac.default_list usr_setting_type. This will be used to track a
user's default bookbag.
Add the upgrade script to create new coust and custs.
Insert coust (opac.patron.temporary_list_warn) and cust
(opac.temporary_list_no_warn, opac.default_list) into the respective
tables.
Add release notes for add to permanent bookbag feature.
Add a warning when the user adds a record to a temporary list.
TPAC has been modified so that a user will see a warning before adding
a record to a temporary bookbag. This message serves to inform the
user that they are adding to a temporary list that will disappear when
their session ends.
A new org. unit setting has been added,
opac.patron.temporary_list_warn, that will enable this warning when
set. Sites may choose not to display this warning.
The user may also set a preference in their search preferences to
disable this warning. The setting only works when a user is logged
in, of course.
Add release notes for the temporary list warning feature.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 12 Jul 2012 03:37:11 +0000 (23:37 -0400)]
Add Journal Title search to stock TPAC filters
Academics need access to a quick and easy Journal Title search, this
gives it to them. Due to the requirement to combine search index + bib
level, we define a special search index that can then be acted upon
accordingly.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 17 Jul 2012 16:55:39 +0000 (12:55 -0400)]
TPAC: Use % font size + bold to highlight login failure
Loved the idea to call more attention to login failures, but wanted to
try to stick to % for font sizes where possible. Testing suggested that
font-weight:bold and a little padding on top would help the display as
well.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Dan Scott [Tue, 17 Jul 2012 16:39:37 +0000 (12:39 -0400)]
TPAC: Slightly more accessible user-visible account notes display
Rather than a table layout that resembles an unordered list, use a real
table with table header so that screen readers will know what to
associate each column with.
Also, move the table display into its own class so that we don't pick up
the uppercase transform, and move it out of the div box so that we can
use whatever screen real estate is given to us, rather than forcing
notes into the hard-coded 662px box.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Tue, 19 Jun 2012 18:24:33 +0000 (14:24 -0400)]
TPAC: show patron-visible notes in my-account
Notes display in the 'Account Summary' box on the first page of
my-account.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 16 Jun 2012 02:59:23 +0000 (22:59 -0400)]
TPAC: Physical description, now with spaces
Record details will regularly include physical descriptions like
"Physical Description: 1 sound disc :33 1/3 rpm, mono." where the colon
is jammed up against the content from the following subfield. Easily
fixed by using a space as the joiner for the subfields.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Ben Shum [Wed, 27 Jun 2012 18:01:24 +0000 (14:01 -0400)]
Move Prefix field ahead of Names in patron editor
In earlier versions of Evergreen (1.6 and earlier), the Prefix field
was used to enter title information, such as Mr., Mrs., etc. When the
field was eventually added to the newer patron registration screens
(2.0+), it was added before the patron's last name field. Ideally,
the prefix should be listed prior to the patron's first name instead.
In addition, address label issues by changing "Suffix/Title" back to
only "Suffix" and making "Prefix" into "Prefix/Title".
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jason Etheridge [Thu, 10 May 2012 18:18:37 +0000 (14:18 -0400)]
increase the default width for the xul list line number column
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
When a user views holds in their account, clicking "only available"
on the holds screen or "Ready for Pickup" in the navbar will add an
"available=1" parameter. However, if the user then attempts to return
to a list of all holds, the "available" parameter is not cleared, and
the user will only see holds available for pickup.
This commit will clear those parameters.
Signed-off-by: Kathy Lussier <kmlussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Content provided by Jennifer Turner at PALS. Converted to Asciidoc by Robert Soulliere. Robert also added indexing terms. Appendices for documentation cleaned up as well.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Dan Scott [Fri, 13 Jul 2012 13:56:54 +0000 (09:56 -0400)]
TPAC: Use .staff variant for MARC Expert Search
Inside the staff client, we want to use the .staff method to retrieve
records that match the MARC Expert Search, so that records with no
attached copies can be found and returned.
Bill Erickson [Mon, 11 Jun 2012 19:23:17 +0000 (15:23 -0400)]
Cache propagated funds in fund rollover action
Repair display of propagated funds grid which was likely broken with b9bb6d47. Propagated funds must be collected and added to the local
cache for grid getter functions to find them.
To make back buttons less likely to show sensitive info.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jeff Godin [Wed, 11 Jul 2012 15:54:34 +0000 (11:54 -0400)]
Fix titles/tabs in Account Preferences subpages
Adjust the value of myopac_page in the Notification Preferences and
Search Preferences pages so that the page title and tab
color/hilight will be correct.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Wed, 11 Jul 2012 22:41:55 +0000 (18:41 -0400)]
Get Z39.50 source names to be linked as expected
The direct thead/th approach appeared to be interfering with the JS
event that was supposed to link the Z39.50 source names; adding the
expected tr layer resolved that.
Bill Erickson [Tue, 19 Jun 2012 14:23:22 +0000 (10:23 -0400)]
Z39.50 attributes management interface
From the release notes:
There is a new interface for managing Z39.50 attributes on a Z39.50
source. The interface is linked from each source name in the Z39.50
Source administrative interface.
Cloning
~~~~~~
In addition to attribute creation, deletion, and editing, it's also
possible to clone a set of attributes from one source into another.
When cloning, any attributes present in the cloned source that are
not present in the destination source are copied into the destination
source.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Fri, 15 Jun 2012 17:25:29 +0000 (13:25 -0400)]
TPAC: Handle multiple matches for an XPath expression
Per LP 1009980, "If a record has multiple subfield b's in the 260 field,
tpac will not display the publisher or publication date in the record
details page and will not display the publisher on the search results
page".
This is because we're calling textContent on a nodeset, rather than an
individual node, and therefore get null back rather than any content.
To avoid this, always expect a nodeset and iterate over it to populate a
list of the strings. To maintain the same semantics of expecting a
single text string back for, say, args.pubdate, we define the list as
args.pubdates (plural name), and then grab the first item from the list
and populate that as args.pubdate (singular name).
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Ben Shum <bshum@biblio.org>
Bob Wicksall [Fri, 29 Jun 2012 18:33:22 +0000 (14:33 -0400)]
TPac: Add paging to My Lists
- Added paging to My Lists based on the code from the Checkout History tab.
- Fixed a bug where adding more than 10 items to the Temporary list failed
- After adding paging renaming a list on page 2+ would fail. Fixed.
- Redirect after saving a list now leaves you on the same page
- Paging was bleeding between My Lists, Holds History and Circ History.
Fixed.
List contents were also limited to the first 10. I have upped the limit to
1000 rather than having nested paging. This should be revisited.
CSV download of lists is still limited to the first 10. Not sure where to
fix this.
Signed-off-by: Bob Wicksall <bwicksall@pls-net.org> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Robert Soulliere [Tue, 19 Jun 2012 16:23:55 +0000 (12:23 -0400)]
Update Evergreen upgrade instructions to reflect the 2.2.0 release.
Update download reference to point to 2.2.0. Also moved
database updates to the end of the process. It seemed out of order since
the database update scripts were run before the download of the 2.2 tar file.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Bill Erickson [Mon, 12 Mar 2012 19:05:50 +0000 (15:05 -0400)]
Org unit retrieval cleanup
Clean up and consolidate the various org unit retrieval method (in Perl)
to reduce code/confusion and make it easier to integrate changes to the
org unit tree in the future.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Acq: fix widget choice for user-linked fields in Acquisitions Search
The Acquisitions Search interface (which also sits underneath the
Purchase Orders inteface, My Selection Lists, and one or two others)
stopped presenting the correct widget for search terms linked to
actor.usr. This was brought on when PCRUD control was added to
actor.usr, so that means the bug affects only master, not rel_2_2 or
earlier.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Thu, 14 Jun 2012 19:16:51 +0000 (15:16 -0400)]
Avoid file extensions on scripts
Borrowing from the Debian policy, you might reimplement the same
functionality using a different language such as Perl or Python. So
avoid having a file extension in the first place. What are we, Windows
users?
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Dan Scott [Sun, 3 Jun 2012 03:25:53 +0000 (23:25 -0400)]
git2cl mangles the changelog; let's just use git's log
git2cl does bizarre things to line wrapping. The log it generates looks
deranged. Let's just use what git gives us; it's clean and easy to
parse, even if it doesn't adhere to the GNU changelog standards
(www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html).
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
make_release.sh [-v VERSION] [-f PREV_BRANCH | -t | -b] [-F PREV_VERSION] [-n] [-p]
VERSION is auto-detected by default and is based on the currently checked out branch.
PREV_BRANCH is auto-detected by default but that isn't reliable. Include remote name!
PREV_VERSION Is auto-detected by default and is based on the PREV_BRANCH's name.
-n specifies that you don't want an upgrade script to be auto-generated.
-p specifies that this is a preview build.
-t turns on tag only mode.
-b turns on build only mode.
NOTE: -t and -b override PREV_BRANCH/PREV_VERSION, but -b overrides -t.
When building a release you should have git2cl in your PATH as well as
all packages needed for building i18n and staff clients.
Usage examples:
Tagging a major version root (no need for git2cl/staff client deps):
Release files are placed in a "release" folder one level up from your git
root directory.
Nothing is pushed to remote servers, but dojo and xulrunner files may be
downloaded. Dojo to install in the release tarball properly, xulrunner for
building the staff client and avoiding issues with xulrunner changes if
end-users build a custom staff client (say, for autoupdate purposes).
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Sat, 16 Jun 2012 02:10:15 +0000 (22:10 -0400)]
TPAC: Add record detail navigation to page bottom
A usability rule of thumb suggests that navigation on long pages should
not require you to scroll back up to the top of the page from the
bottom; that gets old fast. We already do this on search results pages;
bring the same good practice to record details.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Security fix: Prevent login by deleted and barred users
An existing comment in the code suggested that we thought we were already
keeping barred users out. LP #1010671 brings up that deleted users were
not being kept out.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Revoking the UPDATE_MARC permission doesn't actually seem to prevent a
user from editing a record. Our use case is that we would like a user
to create new records but not edit existing MARC records.
Changing CREATE_MARC to UPDATE_MARC in OpenILS::Application::Cat's
biblio_record_replace_marc() method seems to fix the problem.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Mike Rylander [Fri, 8 Jun 2012 13:26:25 +0000 (09:26 -0400)]
Remove unsafe thesaurus/control-set mapping
Evergreen 2.2 and beyond includes new Authority Control Set functionality
intended to allow the definition of locally defined authority control
headings. The primary mechanism for determining which Control Set is used
by any given authority record is to look at the thesaurus fixed field
(mnemonic: Subj), which currently must be uniquely linked to a Control Set.
Failing that (in the case of no thesaurus code at all), there is a backup
mechanism: if the thesaurus value for the authority record is missing or not
used by any configured Control Set then Evergreen will look at the first Main
Entry (1xx) field in the record, and find a control set which uses this field.
This is, obviously, not perfect, but for non-overlapping authority field
schemes, it works very well.
However, the seed data for Evergreen currently includes the "no attempt to
code" value of "|" in the set of thesauri that point to the LoC Control Set.
This value ("|") is also the default value for the Subj fixed field. This
means that the fallback mechanism is very likely never reached, and anything
short of fully specifying an appropriate thesaurus code for any non-LoC
authority record will run afoul of a similar outcome as the bib-data loss
situation described in bug #983487.
We can avoid this situation in most cases by /not/ tying the "|" thesaurus
value to the LoC control set.
This commit accomplishes this goal by allowing the Control Set for a thesaurus
to be NULL, removing the Control Set for "|" and removing the Control Set
recorded for records with "|" as the thesaurus value, thereby forcing Main
Entry inspection on any use of the authority record where Control Set is
required.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Tue, 12 Jun 2012 13:03:31 +0000 (09:03 -0400)]
Serial Note Sort Fix
Serial notes are currently sorting backwards from what is intended
(and what is expected based on other interfaces). This was caused
by adding a sort to the middle-layer code which resulted in an
unwanted double reverse.
[whitespace adjustment by LFW per request of DBS]
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
This accomplishes several things:
1 - Load the list of queues on page load
2 - Single-click access (rather than select and click) to queues
3 - Batch Deletion of Queues
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Mon, 11 Jun 2012 15:18:08 +0000 (11:18 -0400)]
Show Vandelay Buckets in Manage Record Buckets
The 'Manage Record Buckets' view is currently filtered to show
only 'staff_client' type buckets. This expands the filter to
include 'vandelay_queue' buckets.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Steven Callender [Thu, 19 Apr 2012 13:47:46 +0000 (09:47 -0400)]
Added a days_back parameter to authority_control_fields.pl in order to process bibs edited X amount of days ago.
The days_back parameter can be used to easily run the script through cron nightly and have it process all newly created or newly added bib records. Ideally it would be ran once a day at nighttime prior to midnight using the --days_back 0 option.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Thu, 7 Jun 2012 14:32:59 +0000 (10:32 -0400)]
Fix broken non-RSS bookbag feeds
This commit addresses LP#1010036 by defining a stub 'description()'
method. Lack of such a method was causing internal server errors
for other kinds of feeds.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Wed, 6 Jun 2012 21:43:33 +0000 (17:43 -0400)]
Add TPAC translations
We're still working out our translation update process; new PO files can
fairly easily slip through the net. Fix that for TPAC, which is a pretty
big deal for 2.2.
Dan Scott [Wed, 6 Jun 2012 20:39:10 +0000 (16:39 -0400)]
Import updated translations from Launchpad
Lebbeous Fogle-Weekley originally imported these updated translations
from Launchpad. Dan Scott just weeded out a few metadata-only changes
to PO files that didn't need to be pushed to git.
Address LP #983487: Avoid clobbering bib records at authority merge
If you've set up a relationship between bib record and authority records
based on arbitrary sets of controlling and controlled fields, but your
authority records don't have the right Subj fixed field value
corresponding to a control set that defines the controlling and
controlled fields you're using, authority merge operations may wipe out
lots of bib data.
Yamil Suarez encountered this bug in testing, and in his case what he
needed to do was set the Subj fixed field in his authority records to
'A' to match his Song Title Index (see the launchpad bug referened
above).
Previously, you could not actually save the Subj fixed field in the MARC
editor (which showed HeadSubj instead of Subj for authority records, and
didn't work). Now you can.
Thanks to Mike Rylander for help in figuring out the above.
To provide additional protection against merging authority records when
they might not be linked with the right control set, the Manage
Authorities interface will now also show you the linked control set for
any given records.
The implementation of that last bit incidentally meant making sure flesh
and flesh_fields get passed through to PermaCrud for retrieve() calls via
the Javascript openils.PermaCrud wrapper.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
It appears as though a copy-and-paste error introduced duplicate keys in
circ.properties, which in turn makes newer versions of the Translate
Toolkit unhappy and results in empty translated files. Tracing through
the pertinent code in xul/staff_client/server/circ/util.js, it looks
like the desired key was for "not_found" for the second "cataloging" key
- so change that accordingly.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Sun, 3 Jun 2012 05:09:26 +0000 (01:09 -0400)]
Improve Fedora prereqs and instructions
Fedora 16 and 17 need the makensis package.
As well, make the Makefile.install target "fedora" to match the OpenSRF
target, and adjust the docs accordingly. This should lead to fewer
changes in the future as Fedora 18, 19, etc roll out.
Bill Erickson [Thu, 3 May 2012 20:36:38 +0000 (16:36 -0400)]
TPAC: Prevent unitialized variable warnings in My Account (repair)
The logic in the second IF test was slightly altered by the fix. An
undef value for username_unlimit should result in executing the block.
Since org setting values are stored as real boolean values, I simplified
the test to a simple if(!username_unlimit) test.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dan@coffeecode.net>
Bill Erickson [Fri, 23 Mar 2012 19:17:50 +0000 (15:17 -0400)]
ACQ guarantee no PO re-activation
Prevent the possibility of double PO activation by preventing it within
the API. There have been reports in the wild of double-activation, even
though the UI is supposed to prevent it.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Dan Scott <dan@coffeecode.net>
Fix broken menu entries under "Other -> Booking" in patron interface
This issue was reported to me by Steve Callender. The menu entries
under "Other -> Booking" had all stopped working.
There's a catalog of URL constants under window.urls sometimes, and
formerly (or other times?) at xulG.urls for XUL-based staff client
interfaces. There's a new-tab-opening method that needed to be more
flexible when looking for that catalog.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 1 Jun 2012 14:28:28 +0000 (10:28 -0400)]
Override arguments parameter repairs
In some cases, the override arguments were passed as a paramater after
an @array or %hash argument. In such cases, any params following are
clumped into the array/hash and the trailing parameters get no values.
Let's explicitly push the $oargs into the preceeding structures.
In the case of Circulate.pm:new, no $oargs argument is needed, as all keys
within the %args hash are tacked onto the circulator object.
Also, for consistency, this change affects one of the hold API calls by
moving $oargs into $params even when not strictly necessary.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Galen Charlton [Fri, 1 Jun 2012 03:31:11 +0000 (23:31 -0400)]
lp#1007248: tweak order in which pgt rows are renumbered
Need to renumber from highest to lowest. Because the primary
key constraint is not deferred, doing the renumbering in a single
statement will fail if there is overlap between the set of
existing pgt.id values and the set of {pgt.id + 100}.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 25 May 2012 18:41:18 +0000 (14:41 -0400)]
TPAC bookbag CGI param changed to bbid
To avoid propagating a generic URL parameter like 'id', which can be
picked up by other pages and cause breakage, use 'bbid' instead. Also,
clear the 'bbid' param from the my-account tabs.
While we're in there, silence an uninitialized string warning.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jeff Davis [Wed, 11 Apr 2012 16:04:19 +0000 (12:04 -0400)]
LP#856708 - Scrolling/div size issues in action trigger interface
The event definition content pane does not properly accommodate its contents.
In the Event Definitions tab, the list of event definitions exceeds the height of the
pane, but you can't scroll all the way down to the bottom of the list -- some of the
content gets cut off. Likewise, when editing an event definition, you can't scroll
all the way to the bottom of the page; the Cancel and Save buttons are cut off, and
you have to use the Tab key to move the focus down to those buttons, which forces
the pane to scroll to the bottom so that they're visible.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Thu, 12 Apr 2012 01:56:56 +0000 (21:56 -0400)]
Group acquisition OU settings in a new "Acquisitions" group
As seen in LP867465, the current grouping of acquisition OU settings
under the generic "lib" group leads to confusion about which
context "default shelf location" and the like apply to. Creating a new
"Acquisitions" group will help clarify that current ambiguity.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Acq: Use scope to constrain choice of lineitem alerts
This commit addresses this launchpad bug:
https://bugs.launchpad.net/evergreen/+bug/996033
The controlled vocabulary of acq lineitem alert text is set up in an
interface labeled "Line Item Alerts" in the staff client admin menu. In
the PO and selection list interfaces (where alerts can be applied), we
will limit the user to selecting alerts from those owned at the user's
workstation org unit (or its ancestors).
When we display applied alerts, we can also display the shortname of the
org unit at which the alert text is defined (the owning_lib column).
This should help clarify what's going on with alerts that have already
been applied using alert text from another org unit.
[Amended since original reference on Launchpad to also show the
owning_lib's shortname when confirming alerts at receive time.]
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
projects / working / Evergreen.git / log