Before this commit, the context org unit for carousels was the same as
the physical_loc environment variable, or the client-passed physcial
location, or the search location, whichever was set in that order. This
commit provides the ability to specify a carousel_loc environment
variable in the apache vhost configuration, as an override to
physical_loc. This, in turn, allows hostname-segregated branches of the
org hierarchy in a resource sharing group to specify their own carousels
even when they want the top of the group to be the default search
location.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Mon, 9 Dec 2019 16:47:30 +0000 (11:47 -0500)]
LP1855737 Don't send error object across shared worker port
Data must be string-ifiable to pass across a shared web worker message
port. In Firefox, at least, errors encountered during IndexedDB /
Lovefield operations are not candidates for automatic stringification.
Avoid trying to send the error object back to the caller.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Unique indexes on nullable columns will allow multiple conceptually
unique rows if the nullable columns are, in fact, NULL because NULL does
not equal itself. This commit uses COALESCE to make sure that the
nullable email column in the reporter.schedule table gets a value of the
empty string for the purposes of the unique index. The upgrade script
now also takes this into account and ignores the email column.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field. This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.
The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Boyer [Wed, 14 Oct 2020 16:11:27 +0000 (12:11 -0400)]
LP1882828: (follow-up) Add static parameter to ViewChild decorator
While not strictly required in rel_3_6 and above, rel_3_5 uses
a version of Angular that requires specifying a value for the
static parameter when using the ViewChild decorator on an object.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Jason Boyer [Fri, 28 Aug 2020 21:13:14 +0000 (17:13 -0400)]
LP1893463: Prevent duplicated report outputs
When re-running recurring reports that are interrupted,
it's possible to end up with a duplicate copy of the next
recurrance of that report. This branch adds a unique index
to reporter.schedule and tells clark-kent.pl not to worry
about it.
For the purposes of this change a duplicate report is
one where report.schedule has identical values for report,
(output) folder, runner, run_time, and email.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Chris Burton [Fri, 25 Sep 2020 11:59:47 +0000 (07:59 -0400)]
LP1895398 Bootstrap OPAC Follow Up #1
Includes following changes:
1) Login modal Aria-labelledby removed. The modal doesn’t have a label.
2) Due to a slight change in versioning, an issue occurred where another
attribute had to be added.
3) Added Buttons back to the middle.
4) Fixed button clicking issues on results and summary.
5) Print and email separated (Still needs
https://bugs.launchpad.net/evergreen/+bug/1895676 resolved)
6) Tabindex removed and now the cart navigation can be controlled by
keyboard
7) Data Toggle added to disabled elements on staff OPAC
8) Not sure what details are missing in the "More Details" section. I
did some old/new comparisons with the OPAC and some of the default books
found in the search and their information was matching up)
9)Tooltips changed to allow keyboard navigation and popups
10) Name was missing from the buttons, so it wasn’t passing actions
properly.
11) Move Language to footer as links. This will make it widely
accessible and noticable. Having a dropdown was not appealing and
removing the submit button would cause it to not be acceptable. I think
they call it a "jump box" because as soon as you make the selection it
redirects you, giving no chance to change it. It's not expected
behaviour from a dropdown.
Signed-off-by: Chris Burton <cburton@nflibrary.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Wed, 5 Aug 2020 18:19:52 +0000 (14:19 -0400)]
LP1774008 Remove Hatch storage options
Remove option to store settings in Hatch from the AngJS Hatch admin
page. Update some Hatch labels to remove the term 'Storage'. Remove
deprecated JS code related to tracking this setting and the
long-deprecated offline file storage setting.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
LP#1896070: ensure that deatching course material doesn't delete non-temporary bibs
This patch fixes how the temporary_record field is checked; in Perl code,
non-NULL Boolean fields in Fieldmapper objects do /not/ evaluate as
Perl Boolean values; you have to use $U->is_true() or explictly
compare against 't' and 'f'.
This patch also tweaks live_t/31-courses.t so that it can be run
repeatedly.
To test
-------
[1] Run live_t/31-courses.t repeatedly; note that it will start failing
the second time.
[2] Reset the database and apply the patch, then repeat step 1.
[3] This time, the test should work when run repeatedly.