Remington Steed [Thu, 20 Feb 2020 21:13:20 +0000 (16:13 -0500)]
Docs: Fix section for Antora: "Circulation"
This commit does the known tasks to prepare each main docs section
for Antora:
- Add chapter labels to nav file items
- To match existing docs "chapter" level headings, combine adoc files as
needed so that each "chapter" from the old docs structure has a single
file linked from the nav
- Added advanced_holds.adoc to the end of basic_holds.adoc
- Upgrade all heading levels in each adoc file so that the top-most
heading is a "Level 1" heading (example: "= Chapter Name =")
- Add ":toc:" below top heading of each file
Remington Steed [Wed, 12 Feb 2020 14:31:36 +0000 (09:31 -0500)]
Docs: Fix section for Antora: "Serials"
This commit does the known tasks to prepare each main docs section for
Antora:
- Add chapter labels to nav file items
- (Not needed for this section.) Combine adoc files so that each
"chapter" from the old docs structure has a single file linked from
the nav
- Upgrade all heading levels in each adoc file so that the top-most
heading is a "Level 1" heading (example: "= Chapter Name =")
- Add ":toc:" below top heading of each file
Remington Steed [Wed, 15 Jan 2020 13:59:43 +0000 (08:59 -0500)]
Docs: Fix sections for Antora: "Developer Resources" and "Getting Data from Evergreen"
This commit does the known tasks to prepare each main docs section
for Antora:
- Add chapter labels to nav file items
- To match existing docs "chapter" level headings, combine adoc files as
needed so that each "chapter" from the old docs structure has a single
file linked from the nav
- Upgrade all heading levels in each adoc file so that the top-most
heading is a "Level 1" heading (example: "= Chapter Name =")
- Add ":toc:" below top heading of each file
NOTE: Previous commit had a duplicate title, but should have said "for
section 'Using the Public Access Catalog'".
Remington Steed [Wed, 15 Jan 2020 13:47:40 +0000 (08:47 -0500)]
Docs: Fix section for Antora: "System Configuration and Customization"
This commit does the known tasks to prepare each main docs section for
Antora:
- Add chapter labels to nav file items
- To match existing docs "chapter" level headings, combine adoc files as
needed so that each "chapter" from the old docs structure has a single
file linked from the nav
- In this case, the only change was in advanced_features.adoc,
where two sections had the top heading level (seems like a mistake).
I bumped the second one down ("Binary MARC21 Feeds") so it is a
subsection of the file. Ironically, since this commit also bumps
up all headings by one level, it means that heading is the only one
not changed in this commit.
- Upgrade all heading levels in each adoc file so that the top-most
heading is a "Level 1" heading (example: "= Chapter Name =")
- Add ":toc:" below top heading of each file
Remington Steed [Fri, 10 Jan 2020 13:47:25 +0000 (08:47 -0500)]
Docs: Fix section for Antora: "System Configuration and Customization"
This commit does the known tasks to prepare each main docs section for
Antora:
- Add chapter labels to nav file items
- To match existing docs "chapter" level headings, combine adoc files as
needed so that each "chapter" from the old docs structure has a single
file linked from the nav
- Upgrade all heading levels in each adoc file so that the top-most
heading is a "Level 1" heading (example: "= Chapter Name =")
- Add ":toc:" below top heading of each file
Remington Steed [Fri, 3 Jan 2020 17:15:01 +0000 (12:15 -0500)]
Docs: Convert subnav files to included partials
This commit adds labels to the Cataloging nav, and combines files from
subnav items that happen to have their own adoc files (but don't really
belong in the nav). This also bumps heading levels so that each file
starts with a "Level 1" (book title) heading, which Antora wants. And we
add a Table of Contents to the top of each file.
Remington Steed [Fri, 3 Jan 2020 16:10:17 +0000 (11:10 -0500)]
Docs: Use Antora syntax for including partials
These included snippets have been converted to Antora "partials", so we
need to use the special syntax (like we already do when including them
in the "Web Client Best Practices" section).
blake [Fri, 3 Jan 2020 20:38:15 +0000 (14:38 -0600)]
Navigation: Acq is done - headers were shifted up
Level 2 became level 1 and Table of contents added. Two files were merged
onto the "parent" as per the live docs layout. So it makes more sense when
viewed via Antora
Remington Steed [Thu, 12 Dec 2019 17:06:53 +0000 (12:06 -0500)]
Docs: Convert more links to Antora syntax
Antora requires that links to sections in a different file use the xref
syntax, not the double-angle-bracket shortcut syntax. As best as I can
tell, this commit changes all the links that go to other files (not the
file that the link is in).
- Remove numbering from install docs headers
- Link top-level nav items to each section's intro file
- Add a few missing _attributes.adoc files in pages/ subdirs
Remington Steed [Thu, 5 Dec 2019 16:06:27 +0000 (11:06 -0500)]
Docs: Draft of all nav files
Some files still contain 'leveloffset' commands which need to be
removed, and those previously offset files should probably have their
headings adjusted accordingly.
Remington Steed [Thu, 5 Dec 2019 14:23:06 +0000 (09:23 -0500)]
Docs: Add draft nav for "Software Installation" section
Note: I don't think "leveloffset" is allowed like this here. We could
pass it to "include" as an attribute, but I'd rather us standardize our
headings in our files.
with open(argv[1], 'r') as input_file:
prev_line = None
curr_line = None
for line in input_file.readlines():
prev_line = curr_line
curr_line = line
if prev_line is None:
continue
for pattern, heading in patterns:
if pattern.match(curr_line) and len(prev_line) == len(curr_line):
# remove newline so we can append suffix to heading
prev_line = prev_line.rstrip()
sys.stdout.write('%s %s %s\n' % (heading, prev_line, heading))
prev_line = None
curr_line = None
break
if prev_line is not None:
sys.stdout.write(prev_line)
# end for
if curr_line is not None:
sys.stdout.write(curr_line)
Remington Steed [Thu, 5 Dec 2019 14:06:46 +0000 (09:06 -0500)]
Docs: Remove Unicode Byte-Order Mark (BOM)
A few asciidoc files start with the BOM, which occasionally causes us
trouble. For example, it interfered with our python script converting
headings from two-line style to prefix/suffix style.
blake [Mon, 21 Oct 2019 15:23:20 +0000 (10:23 -0500)]
LP1848524_antora_ize_docs
This introduces the antora directory structure stub. Started a new folder
docs-antora. The sub folder "ui" contains a dump of the Antora-provided default
UI from https://gitlab.com/antora/antora-ui-default.git
Remington Steed [Tue, 22 Oct 2019 21:26:10 +0000 (17:26 -0400)]
Docs: Remove unused AsciiDoc files
NOTE: This commit should be carefully reviewed for any docs we might
be omitting accidentally!
This commit removes all AsciiDoc files that we don't currently include
in another AsciiDoc file (via "include::"), because that means they
never appear in the generated docs (HTML, PDF, or ePUB). Some files have
been left untouched, such as everything in the TechRef/ directory.
Remington Steed [Tue, 22 Oct 2019 21:20:39 +0000 (17:20 -0400)]
Docs: Delete unused docs images
This commit attempts to delete all images from the media/ directory that
aren't used within an AsciiDoc file (via "image:" or "image::"). This
commit also doesn't touch images that are known to be used in the HTML
template (such as the Evergreen logo, PDF/ePUB icons, NOTE icons, and
callout number icons).
This list of images was generated via multiple bash commands, grepping
and diffing. It would be great for us to have a standard command for
finding these periodically.
Jeff Davis [Thu, 30 Apr 2020 17:36:44 +0000 (10:36 -0700)]
LP#1873048: add scoped retrieve perms for booking resource types and resources
In the XUL client, when selecting a resource type, the list was limited
by owning library. But in the web client, the list would show all
resource types across all libraries. This commit addresses that
regression by adding a new VIEW_BOOKING_RESOURCE_TYPE permission with
context_field in the IDL. That way, users only see resource types owned
by org units where they have the permission.
While we're at it, a new VIEW_BOOKING_RESOURCE perm is also added for
resources.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Tue, 28 Apr 2020 20:52:52 +0000 (13:52 -0700)]
LP#1865533: save changes on Edit Hold in My Account
When editing a hold in the OPAC, changes are not saved if the SMS field
is blank. The sms_notify value is being passed as an empty string, and
this non-null value violates the "sms_check" constraint on
action.hold_request. Replacing the empty string with undef allows the
hold update to succeed.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Daniel Pearl [Wed, 13 Mar 2019 14:07:17 +0000 (10:07 -0400)]
LP1787636: Sort Libraries without Holdings In Holdings View
Empty libraries in holdings view are listed at the end of the library
list instead of integrated within the list. This patch sorts them
within the list.
Signed-off-by: Daniel Pearl <dpearl@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Thu, 26 Mar 2020 14:47:46 +0000 (10:47 -0400)]
LP1813088: Coerce Values to String in egGridValueFilter
Coerce values to string in the switch for Boolean columns in the main
egGridValueFilter function. This came about after an IRC conversation
with Mike Rylander who suggested this as a possible fix. It should
when field values are strings, integers, or Booleans.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Fri, 24 Apr 2020 18:22:25 +0000 (14:22 -0400)]
LP1873286: Fix Bad End Tags
Fix self-closing tags used in non-void HTML and non-empty XHTML tags.
These tags now cause errors with jQuery version 3.5.0 and were
technically wrong from the start.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Mon, 2 Dec 2019 17:26:22 +0000 (12:26 -0500)]
LP1848550 Cache org settings in IndexedDB (Angular)
Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.
Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Wed, 27 Nov 2019 00:12:37 +0000 (16:12 -0800)]
LP#1848550: client-side caching of org settings for AngularJS
The web client almost always does live lookups any time it needs to
check an org setting. But these settings rarely change, so it would
make sense to cache them. They're already cached using Lovefield in
order to support offline; this commit checks the cache first, and only
does a live lookup if the setting is uncached.
The settings cache is cleared on login to ensure stale values don't
stick around forever. To refresh the cache, simply logout and then
login; cached values will be deleted and the latest values will be
retrieved from the server when they are needed.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Change "TODO" to "1202" in versioned upgrade script. I'm not sure how
that didn't happen unless I forgot to save the file or doing an
--amend before pushing changed things.
Bill Erickson [Fri, 24 Apr 2020 14:42:42 +0000 (10:42 -0400)]
LP1858448 Disable inititial aged money migration
Modify the existing SQL upgrade scripts to prevent the automatic
migration of billings/payments to the new aged money tables. This is
done to prevent data loss for sites which have not yet upgraded to the
affected versions.
The schema changes are kept so both pre- and post-upgrade sites can
follow the same schema update path.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Stephenson [Wed, 11 Mar 2020 16:47:55 +0000 (12:47 -0400)]
LP1858448 More IDL fixups
Make IDL fixes as recommended in the Launchpad bug discussion.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Adds a srfsh script for manually aging money based on the
'history.money.retention_age' setting value.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Fri, 7 Feb 2020 20:52:19 +0000 (15:52 -0500)]
LP1858448 Aged payment fields release notes
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Fri, 7 Feb 2020 20:19:15 +0000 (15:19 -0500)]
LP1858448 Additional aged_payment fields
Adds accepting_usr, cash_drawer, and billing columns to the
money.aged_payment table.
Modifies the existing "xact" column for aged payments and billings in
the IDL to link to "mbt" instead of "acirc", since not all
payments/billings are linked to aged circs.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Almost complete implementation for LP1772053. To be done: items
relating to call numbers, prefixes and suffixes for Hold Pull Lists
and Transit Slips.
Signed-off-by: Daniel Pearl <dpearl@cwmars.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Michele Morgan [Fri, 20 Dec 2019 21:00:08 +0000 (16:00 -0500)]
LP1781274 Fix floating point issue preventing transactions from closing
Paying multiple bills with a single payment can lead to some
transactions not closing because of floating point math inaccuracies.
This branch resolves the issue by limiting pending payment amounts to
2 decimal places.
The bug can be reproduced using grocery bills as follows.
Retrieve a patron that owes no money.
Add a billing of $.90
Add a billing of $.10
Select both billings
Enter $1 in payment received and Apply the payment
Click on History in the billings screen. Turn on the Total Billed and
Transaction Finish Time column and note that the $.10 bill has zero
balance owed, but does not have a transaction finish time.
To test:
Use the steps above to reproduce, noting the lack of Transaction
Finish Time. Apply the patch.
Use the same steps above and note that the post patch payments
resulted in both transactions getting a Transaction Finish Time.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Kyle Huckins [Wed, 11 Mar 2020 21:07:11 +0000 (21:07 +0000)]
lp1801137 Item Status Precat Information
- Display precat title, author, and isbn in place of
regular title, author, and isbn fields in Item Status
list view when working with precat items.
- Add Dummy Title and Dummy Author fields to Item Status
Detail view when looking at a precat item.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Wed, 19 Feb 2020 20:36:30 +0000 (12:36 -0800)]
LP#1774268: handle opac.hold_notify empty string in AngJS patron editor
If a patron does not want either phone or email hold notifications,
their opac.hold_notify user setting will be an empty string. Let's
ensure that the hold notify checkboxes remain unchecked in the patron
editor when that is the case.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Boyer <JBoyer@eoli.info>
On patron edit screen set the email and phone notification
to true when patron doesn't have any prefernces. This mimics
the behavior in the xul client.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Boyer <JBoyer@eoli.info>