working/Evergreen.git
4 years agoLP#1478997 Items out display sort overdues to top
Bill Erickson [Tue, 28 Jul 2015 14:39:57 +0000 (10:39 -0400)]
LP#1478997 Items out display sort overdues to top

Sort overdue items to the top of the patron items out display in the XUL
client, consistent with pre-2.5 behavior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agolp1481844 Change Available Copies Display
Kathy Lussier [Wed, 5 Aug 2015 16:50:53 +0000 (12:50 -0400)]
lp1481844 Change Available Copies Display

The Show link in the available copies area of the record summary will now
display for any org unit that owns a copy of the title, even if those copies
are unavailable. This commit also changes the language in the display to read
"x of y copies available at z library."

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agolp1486252 Change label for acq admin menu
Kathy Lussier [Tue, 18 Aug 2015 17:55:26 +0000 (13:55 -0400)]
lp1486252 Change label for acq admin menu

Now that the acq admin menus have move outside of the Server Admin menu, it
should be called "Acquisitions Administration" to be consistent with other
options in this area.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1482400: add release notes
Galen Charlton [Tue, 18 Aug 2015 01:25:00 +0000 (01:25 +0000)]
LP#1482400: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1482400: UT for OpenILS::Application::Acq::BatchManager changes
Galen Charlton [Tue, 18 Aug 2015 01:18:28 +0000 (01:18 +0000)]
LP#1482400: UT for OpenILS::Application::Acq::BatchManager changes

This patch adds tests for the changes to how ::BatchManager()
calculates the request response freqency throttle.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1482400: when activating a PO, provide better progress updates
Galen Charlton [Thu, 6 Aug 2015 22:15:54 +0000 (22:15 +0000)]
LP#1482400: when activating a PO, provide better progress updates

This patch improves how progress is reported during the activation
of a purchase order that has a large number of assets (bibs and
copies) to create.  Specifically, it:

[1] Shows a progress bar during the asset creation phase.
[2] Calculates a linear throttle for updating the record counts
    widget. The value is based on the maximum number of bibs and
    items that could be created during the activation, divided by 20
    (which is an empirically derived number of streaming responses
    that can be sent back before the XUL client starts having
    difficulty).
[3] During the asset-creation phase, the number of records created is
    displayed above the progress bar.
[4] Adds a title to the progress bar that's displayed during the
    second phase of order activation.

To test, after applying the patch:

[1] Create a purchase order that has a large number of
    brief bibs and copies to create during activation.  For
    example, 30 line items and 60 copies.
[2] Activate the purchase order.  You should see the following
    after entering the record import queue and submitting:

    (a) Progress dialog whose title is "Creating bib, call number,
        and copy records.."
    (b) The progress dialog displays and updates text above the
        progress bar indicating how many records it has processed,
        e.g., "Bib Records Merged/Import: 25"
    (b) The record update counts should be updated at a regular
        frequency.
    (c) When the asset creation phase is done, the progress bar's
        title should change to "Activating purchase order..."

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1468404: Fix typo and ommissions in action_trigger_aggregator.pl help
Josh Stompro [Sun, 9 Aug 2015 18:12:53 +0000 (13:12 -0500)]
LP#1468404: Fix typo and ommissions in action_trigger_aggregator.pl help

 - ISO was mistyped as IDO in the help text.
 - Several arguments were missing from the help text.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1463097 - eg_db_config.in help text fix
Josh Stompro [Sat, 13 Jun 2015 11:38:10 +0000 (06:38 -0500)]
LP#1463097 - eg_db_config.in help text fix

Two of the descriptions of which config files are used were transposed.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1478123: fix leak of file descriptors by Apache workers
Josh Stompro [Fri, 24 Jul 2015 19:20:21 +0000 (14:20 -0500)]
LP#1478123: fix leak of file descriptors by Apache workers

Apache backends handling TPAC requests and making requests
of the added content handler were not properly closing
their sockets. This patch adds a close() after the shutdown()
to plug the leak.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#483502 PGTAP test for evergreen.xml_escape(TEXT)
Bill Erickson [Fri, 14 Aug 2015 16:02:54 +0000 (12:02 -0400)]
LP#483502 PGTAP test for evergreen.xml_escape(TEXT)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP1483509: tests for xml_famous5_to_text
Liam Whalen [Fri, 14 Aug 2015 20:25:11 +0000 (13:25 -0700)]
LP1483509: tests for xml_famous5_to_text

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1361900: Add release note for Acq Admin Menu move
Ben Shum [Mon, 17 Aug 2015 17:58:47 +0000 (13:58 -0400)]
LP#1361900: Add release note for Acq Admin Menu move

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1361900 Move Acquistions Admin Menu
Michael Peters [Wed, 10 Jun 2015 16:57:00 +0000 (12:57 -0400)]
LP#1361900 Move Acquistions Admin Menu

This patch fills a wishlist request to have the Acquisitions
Admin functions moved out of "Server Options" and into their own
adminitrative menu.

They can now be accessed via Admin > Acquisitions > Currency Type, etc.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1485240: More Legacy Circ Script Removal
Jason Stephenson [Sat, 15 Aug 2015 18:42:39 +0000 (14:42 -0400)]
LP 1485240: More Legacy Circ Script Removal

This commit removes the last few references to the script_runner
used by OpenILS::Application::Circ::Circulate::Circulator to run
JavaScript circ policies.  The script_runner is basically doing
nothing at this point.

To test this commit, apply it to a test system, install Evergreen,
start or restart the open-ils.circ service and check that check
outs and renewals still work.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1178377: Stamping upgrade script for unapi to include bib source
Ben Shum [Mon, 17 Aug 2015 16:59:21 +0000 (12:59 -0400)]
LP#1178377: Stamping upgrade script for unapi to include bib source

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1178377: Add release note for new bib source variable in catalog
Ben Shum [Mon, 17 Aug 2015 16:53:30 +0000 (12:53 -0400)]
LP#1178377: Add release note for new bib source variable in catalog

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1178377: Make bib source optional element from unapi.bre
Doug Kyle [Mon, 14 Apr 2014 16:31:11 +0000 (12:31 -0400)]
LP#1178377: Make bib source optional element from unapi.bre

also add cbs (config bib source) to flesh arg of get_records_and_facets

Change the baseline schema file

Signed-off-by: Doug Kyle <dkyle@grpl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1178377: Expose bib source in TPAC
Jeff Davis [Thu, 9 May 2013 19:03:58 +0000 (12:03 -0700)]
LP#1178377: Expose bib source in TPAC

- Add unapi.cbs database function to grab config.bib_source data, and
  include this in unapi.bre XML output.
- Make bib_source.id and bib_source.source available as record
  attributes in TPAC.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1433328: Add release note for new class attribute for e-resource links
Ben Shum [Mon, 17 Aug 2015 16:45:57 +0000 (12:45 -0400)]
LP#1433328: Add release note for new class attribute for e-resource links

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1433328: Add class attribute to e-resource links in TPAC
Jeff Davis [Tue, 17 Mar 2015 21:53:05 +0000 (14:53 -0700)]
LP#1433328: Add class attribute to e-resource links in TPAC

In the TPAC, links to electronic resources are not directly, uniquely
identifiable in the DOM. You can specify these links indirectly, with
something like '.result_table_title_cell > td > a' in search results
or '.rdetail_uri > a' on the record details page, but this is fragile
and a bit cumbersome. Adding a unique class attribute directly to the
link elements would make things easier for services built on top of
the TPAC, such as Overdrive API integration or JS-based analytics for
e-resources.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1435938: Add release note for clear Added Content cache link
Ben Shum [Mon, 17 Aug 2015 16:38:39 +0000 (12:38 -0400)]
LP#1435938: Add release note for clear Added Content cache link

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1435938: Set no_cache on AC clear response
Thomas Berezansky [Wed, 10 Jun 2015 16:41:45 +0000 (12:41 -0400)]
LP#1435938: Set no_cache on AC clear response

So that the clearing itself isn't cached.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1435938: Wrap auth check around clearcache URLs
Thomas Berezansky [Tue, 24 Mar 2015 15:13:36 +0000 (11:13 -0400)]
LP#1435938: Wrap auth check around clearcache URLs

Only allow staff to clear the cache values.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1435938: Add link to clear cache from staff client
Thomas Berezansky [Tue, 24 Mar 2015 14:37:41 +0000 (10:37 -0400)]
LP#1435938: Add link to clear cache from staff client

New functionality isn't all that useful without an access point, after all.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1435938: AddedContent: Add "clearcache" functionality
Thomas Berezansky [Tue, 24 Mar 2015 14:28:32 +0000 (10:28 -0400)]
LP#1435938: AddedContent: Add "clearcache" functionality

Intended use: When staff edit a record's identifiers they can manually clear
the AddedContent cashe.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1484655: ftp://ftp.mozilla.org moved to http://archive.mozilla.org
Jason Stephenson [Thu, 13 Aug 2015 19:22:33 +0000 (15:22 -0400)]
LP 1484655: ftp://ftp.mozilla.org moved to archive.mozilla.org

This commit changes the XULRUNNER_URL in Open-ILS/xul/staff_client/
Makefile.am from using ftp to talk to ftp.mozilla.org to using http
with archive.mozilla.org.  This is necessary because Mozilla.org
have apparently declared the former to be closed and the latter to
be the canonical location for downloads.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocumentation: Items out enhancements
Angela Kilsdonk [Tue, 11 Aug 2015 19:53:22 +0000 (15:53 -0400)]
Documentation: Items out enhancements

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoLP#1394989: Do not include deleted users when retrieving for Collections
Bill Ott [Tue, 28 Jul 2015 20:05:31 +0000 (16:05 -0400)]
LP#1394989: Do not include deleted users when retrieving for Collections

As a side effect of discovering that users with no cards were being retrieved
as part of the Collections API calls, those users ended up being mostly
made up of deleted users (merged with an actual lead record, etc.)

This patch contribued by Bill Ott changes the retrieval so that it skips
over those deleted users.

Signed-off-by: Bill Ott <bott@grpl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1394989: Make users_of_interest test for defined actor.usr.card values
Michael Peters [Thu, 20 Nov 2014 22:41:44 +0000 (17:41 -0500)]
LP#1394989: Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to provide "undef" in the event that there is
not a proper barcode associated with the user when retrieving results for the
API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoDocumentation: Add 2.8 docs for void on claims returned
Kathy Lussier [Fri, 7 Aug 2015 15:00:46 +0000 (11:00 -0400)]
Documentation: Add 2.8 docs for void on claims returned

Adding docs for void on claims returned feature. Also, adding a reference
to new "no billing activity on zero balance transaction" in one area of
circulation that was missed. Branch includes some other updates to old
information.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoForward-port 2.8 translation import
Bill Erickson [Fri, 27 Feb 2015 16:44:54 +0000 (11:44 -0500)]
Forward-port 2.8 translation import

Unfortunately, we had forgotten that translation changes for .pot files
need to be pushed to master for translators.

For the purpose of getting the ball started again, forward porting these
changes for 2.8 from rel_2_8 to master.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1479953: Stamping Upgrade Script
Jason Stephenson [Thu, 6 Aug 2015 15:42:39 +0000 (11:42 -0400)]
LP#1479953: Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1479953: Rename indexes to *_idx and add pgTAP test.
Jason Stephenson [Thu, 6 Aug 2015 15:13:00 +0000 (11:13 -0400)]
LP#1479953: Rename indexes to *_idx and add pgTAP test.

To make the new index names more consistent with existing indices,
I took the liberty of adding _idx to the new index names.

We also add a pgTAP test to verify that the new indices exist in
the database.  The test would fail before running the upgrade
script and succeed after.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1479953: Add indexes to vqbr foreign key references
Jeff Davis [Thu, 30 Jul 2015 20:12:35 +0000 (13:12 -0700)]
LP#1479953: Add indexes to vqbr foreign key references

Deleting a bib queue can be quite slow if it contains many queued
records.  This is because each queued record needs to be deleted, and
this in turn affects many tables that contain unindexed foreign key
references to vandelay.queued_bib_record.  Indexing those foreign keys
can speed up bib queue deletion substantially.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP 1198465: Load negative balance test transactions in load_all.sql
Dan Wells [Wed, 29 Jul 2015 15:30:51 +0000 (11:30 -0400)]
LP 1198465: Load negative balance test transactions in load_all.sql

This commit integrates the SQL needed to setup negative balance
testing into the load_all.sql which loads the rest of the test data.

It also separates out the "reset" commands into a separate SQL file.
They are useful when doing repeated testing, but unnecessary and
may eventually require manual tweaking, so they are provided here as a
convenience only.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoLP 1198465: Move negative balance test xacts into sample data
Dan Wells [Wed, 29 Jul 2015 15:04:24 +0000 (11:04 -0400)]
LP 1198465: Move negative balance test xacts into sample data

It makes more sense for this to live with the other sample data, so
let's put it there.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoLP 1198465: Add missing util function for tests
Dan Wells [Wed, 29 Jul 2015 14:48:28 +0000 (10:48 -0400)]
LP 1198465: Add missing util function for tests

do_checkin_override() is needed for the new tests, but was missing
from the branch.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoLP#1347807: Release note for "No Image" configuration examples
Ben Shum [Tue, 28 Jul 2015 21:04:03 +0000 (17:04 -0400)]
LP#1347807: Release note for "No Image" configuration examples

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1347807: Add example "No Image" configuration
Thomas Berezansky [Wed, 23 Jul 2014 13:46:32 +0000 (09:46 -0400)]
LP#1347807: Add example "No Image" configuration

To make it easy to see how to do that kind of thing.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1465385: Fix some syntax issues with make_release
Mike Rylander [Mon, 15 Jun 2015 19:32:20 +0000 (15:32 -0400)]
LP#1465385: Fix some syntax issues with make_release

Some versions of bash become confused when a unary = operator
is used in place of a binary == operator.  Also, some variables
live without the protection of quoting, and thus further confuse
the shell when their contents are not as simple as originally
expected.

Here we adress those issues.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1454879: Release notes for Account Expiration Date in OPAC
Ben Shum [Tue, 28 Jul 2015 20:49:23 +0000 (16:49 -0400)]
LP#1454879: Release notes for Account Expiration Date in OPAC

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP1454879: Add Account Expiration Date to OPAC
Terran McCanna [Fri, 15 May 2015 17:18:15 +0000 (10:18 -0700)]
LP1454879: Add Account Expiration Date to OPAC

Added Account Expiration Date to OPAC My Account display on
Account Summary page and Account Preferences page. This is in
response to patron requests to know when their accounts will
expire before the point at which they actually expire.

To test, log into My Account through the OPAC - a new table row
with account expiration date should appear on the main account
summary page, and another new row should appear on the main
account preferences page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1476370 Selfcheck inactivity warning release notes
Bill Erickson [Tue, 21 Jul 2015 14:00:41 +0000 (10:00 -0400)]
LP#1476370 Selfcheck inactivity warning release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP1476370 Selfcheck logout warning, checkout resets
Bill Erickson [Mon, 20 Jul 2015 20:26:30 +0000 (16:26 -0400)]
LP1476370 Selfcheck logout warning, checkout resets

* Show a logout warning dialog 20 seconds before discontinuing a
self-check patron login session.

* Reset the inactivity timer with each checkout.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1466201: Release note for disabling Google Analytics in staff interface
Ben Shum [Tue, 28 Jul 2015 20:40:55 +0000 (16:40 -0400)]
LP#1466201: Release note for disabling Google Analytics in staff interface

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agolp1466201 Disable Google Analytics in the staff client
Kathy Lussier [Fri, 10 Jul 2015 03:23:08 +0000 (23:23 -0400)]
lp1466201 Disable Google Analytics in the staff client

As Galen Charlton noted in bug 1452883, "I suggest disabling Google Analytics
outright in the staff client; there's far too much potential for leaking patron
information." This branch aims to do so.

Test plan: Enable Google Analytics in config.tt2. Access the catalog in the
staff client. Click Debug to view the source code. Pre-patch, you'll see
the Google Analytics javascript within the head element. Post-patch, that
javascript will be gone. Viewing the source of a catalog page in a browser
should continue to show the Google Analytics javascript within the head element.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1198465: Stamping upgrade script for conditional negative balance
Ben Shum [Tue, 28 Jul 2015 20:28:45 +0000 (16:28 -0400)]
LP#1198465: Stamping upgrade script for conditional negative balance

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Adapt some language in the negative balance branch
Kathy Lussier [Fri, 24 Jul 2015 00:53:33 +0000 (20:53 -0400)]
LP 1198465: Adapt some language in the negative balance branch

End users may see the term 'adjustment payment' and think that an actual
payment was made. Let's use 'account adjustment' instead. Also, remove any
references to credits in the description for the OU settings since it could
be confused with patron credits, which aren't prohibited by the code.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: More tests for conditional negative balances
Remington Steed [Tue, 21 Jul 2015 17:21:15 +0000 (13:21 -0400)]
LP 1198465: More tests for conditional negative balances

This commit adds the remaining test cases documented by Kathy Lussier on
this wiki page:

    http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

Test cases included in this commit are:

    6. Restores Overdue Fines Appropriately, No Previous "Voids", Patron
       Will Not Owe On Lost Item Return
    7. Restores Overdue Fines Appropriately, No Previous "Voids", Patron
       Will Still Owe On Lost Item Return
    9. Restore Overdue Fines Appropriately, Previous Voids, Negative
       Balance Allowed
   13. Prohibit negative balances on lost materials bills ONLY
   14. Prohibit negative balances on overdue bills ONLY

Note that test case 5 is omitted because it is a duplicate of case 2,
and case 11 is included but commented out because it is unclear how best
to handle the situation.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Make conditional negative balances test sql re-runnable
Dan Wells [Fri, 17 Jul 2015 20:45:16 +0000 (16:45 -0400)]
LP 1198465: Make conditional negative balances test sql re-runnable

Add some DELETEs and some more explicit setting of a few DB pieces such
that running the test SQL a second time will get everything back to
state where the tests will again proceed as expected (hopefully
successfully!).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Initial tests for conditional negative balances
Remington Steed [Fri, 17 Jul 2015 19:42:37 +0000 (15:42 -0400)]
LP 1198465: Initial tests for conditional negative balances

This is a first commit of work-in-progress for testing the conditional
negative balances features.  It covers 9 of the 14 test cases listed
here (as of today):

http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

TODO:
- The test is currently an SQL setup file plus a Perl live test file.
  One simple improvement would be to switch the setup process to
  cstore calls within the Perl test file.  This would be both more
  contained and more robust.
- A second step to more advanced and useful tests would be to use
  higher-level API calls to create portions of the setup rather than
  doing everthing manually.  However, some test conditions cannot be
  reasonably setup with the normal API calls (e.g. bills of a specific
  age, or bills using a legacy format no longer generated by current
  code), so certain areas will likely always require direct
  manipulation.

Signed-off-by: Daniel Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Clean up terminology
Dan Wells [Thu, 28 May 2015 18:10:50 +0000 (14:10 -0400)]
LP 1198465: Clean up terminology

Replace the "void payment" language with "adjustment" in variable names
and comments.  This commit should not make any functional difference.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Set restored overdue timestamp to time of last overdue
Dan Wells [Thu, 28 May 2015 17:54:26 +0000 (13:54 -0400)]
LP 1198465: Set restored overdue timestamp to time of last overdue

When we have our settings configured to generate new overdues on lost
item return, we start generation after the most recent overdue fine.
Because of this, we need the restored fine to be dated in the past,
which in turn allows the fine generator to apply catch-up fines as
expected.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Account for overdues voided the old way
Remington Steed [Wed, 18 Jun 2014 13:34:13 +0000 (09:34 -0400)]
LP 1198465: Account for overdues voided the old way

The code for the particular case of "void"-overdues-for-lost is incomplete.
This is the one case in the new code where it now always adjusts rather
than voids, but the new restore code still needs to recognize cases where
the voiding happened under the old code.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Delay creation of bill map for special bill handling
Dan Wells [Tue, 1 Apr 2014 19:13:00 +0000 (15:13 -0400)]
LP 1198465: Delay creation of bill map for special bill handling

We were making the map, then deciding whether we wanted to void or
adjust.  Since we only want the map if we adjust (and it creates havoc
when voiding), let's just get the bill IDs, then let the adjustment
code create the map it needs.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Fix and improve void/adjustment code
Dan Wells [Wed, 26 Feb 2014 22:44:45 +0000 (17:44 -0500)]
LP 1198465: Fix and improve void/adjustment code

This commit does three things:

- Replace ou_ancestor_setting() with ou_ancestor_setting_value() calls
  This also fixed a bug where we were expecting just the setting, not
  a HASH

- Reword interval checking
  This fix is two part.  First, we simplify the check to not require
  the whole payment map.  Second, we use this newfound simplicity to
  push this check up into the gatekeeper functions, further clarifying
  the code paths.

- make $note into $for_note for void_or_zero_bills_of_type()
  Because the function can both void and adjust, we can't supply a
  complete note, so let's just supply text of what the void/adjustment
  is for.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Refactor logic into gatekeeper functions
Dan Wells [Wed, 26 Feb 2014 16:12:21 +0000 (11:12 -0500)]
LP 1198465: Refactor logic into gatekeeper functions

The bulk of this commits take the logic from adjust_bills_to_zero() and
moves it up a layer into the "gatekeeper" void_or_zero* functions.
This move also allows us to simplify the logic, since some facts are
already known based on our function path.

Also:
- give void_or_zero_overdues() a new signature to better support
  multiple options
- add new 'force_void' and 'force_zero' options to this function
- rename real_void_bills() to simply void_bills() (since there is no
  other void_bills(), the "real" was redundant)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Rename internal functions for clarity
Dan Wells [Fri, 20 Feb 2015 22:19:42 +0000 (17:19 -0500)]
LP 1198465: Rename internal functions for clarity

These methods will now be the splitting point for void vs. adjustment,
so let's give them broader names.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Restore voiding code, rename adjustment function
Dan Wells [Tue, 25 Feb 2014 22:37:43 +0000 (17:37 -0500)]
LP 1198465: Restore voiding code, rename adjustment function

This commit restores the code we removed a few commits earlier, and
also renames "real_void_bills()" "adjust_bills_to_zero()" in order to
better delineate the split functionality.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Fix typo in BILL_ALREADY_VOIDED event
Jason Stephenson [Tue, 25 Feb 2014 19:47:47 +0000 (14:47 -0500)]
LP 1198465: Fix typo in BILL_ALREADY_VOIDED event

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Update CDBI/money.pm for adjustment_payment
Jason Stephenson [Wed, 8 Jan 2014 01:44:47 +0000 (20:44 -0500)]
LP 1198465: Update CDBI/money.pm for adjustment_payment

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od
Jason Stephenson [Sun, 6 Oct 2013 21:13:01 +0000 (17:13 -0400)]
LP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()
Jason Stephenson [Sun, 6 Oct 2013 15:09:10 +0000 (11:09 -0400)]
LP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()

Simplify it to use the new, CircCommon->void_bills_of_type() method.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Add code for adjustment payments
Jason Stephenson [Fri, 20 Feb 2015 22:17:46 +0000 (17:17 -0500)]
LP 1198465: Add code for adjustment payments

This new payment type complements the current void logic that flags
bills as voided.

This new payment type is needed because the current way that Evergreen
voids bills requires that all voids happen in the same increment as the
bills themselves.  This prevents voiding of a partial bill or a bill
that has had a partial payment applied.

This commit also adds the org. unit setting types for the conditional
negative balances enhancements:

bill.prohibit_negative_balance_default
bill.prohibit_negative_balance_on_overdues
bill.prohibit_negative_balance_on_lost
bill.negative_balance_interval_default
bill.negative_balance_interval_on_overdues
bill.negative_balance_interval_on_lost

Finally, create a helper function for checking intervals along the way,
and a handy little subroutine to void all bills of a given type on a
circulation transaction.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1478299: fix location for asset used in test
Jason Etheridge [Mon, 27 Jul 2015 20:04:17 +0000 (16:04 -0400)]
LP#1478299: fix location for asset used in test

specifically lp1277731_hold_permit_test.pg

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Tue, 2 Apr 2013 21:22:37 +0000 (17:22 -0400)]
LP#1155771 Copy location sample data additions

* added some new locations and better groups (thanks gdunbar)
* applying locations to copies in a slightly more sane fashion
* added todo comment about possible future improvement

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Mon, 18 Mar 2013 15:01:36 +0000 (11:01 -0400)]
LP#1155771 Copy location sample data additions

* Add/remove some locations
* Add some locations whose flags (circulate, etc.) vary along the org
  pathway.  Thanks to Thomas Berezansky for this suggestion.
* Ensure that copy location owner matches copy circ lib when applying
  locations to copies.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1155771 Sample data : copy locations, location groups
Bill Erickson [Fri, 15 Mar 2013 18:32:18 +0000 (14:32 -0400)]
LP#1155771 Sample data : copy locations, location groups

Adds a pile of sample copy location and location groups to the sample
data in Open-ILS/tests/datasets/sql.  Samples are loaded as part of
"load_all.sql"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat...
Jeff Davis [Mon, 1 Jun 2015 23:16:25 +0000 (16:16 -0700)]
LP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years ago2.8 doc image name change
Angela Kilsdonk [Mon, 6 Jul 2015 19:51:15 +0000 (14:51 -0500)]
2.8 doc image name change

Image name change to fix display

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoLP#1312308 circ scripts, penalty removal release notes
Bill Erickson [Fri, 22 May 2015 20:25:18 +0000 (16:25 -0400)]
LP#1312308 circ scripts, penalty removal release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1312308 remove deprecated open-ils.penalty service
Bill Erickson [Fri, 22 May 2015 20:07:29 +0000 (16:07 -0400)]
LP#1312308 remove deprecated open-ils.penalty service

open-ils.penalty service has not been used by Evergreen since before
version 2.0.  Instead of just cleaning out the script configuration,
clean out the entire application.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1312308 script circ and deps removal
Bill Erickson [Wed, 13 May 2015 17:14:21 +0000 (13:14 -0400)]
LP#1312308 script circ and deps removal

* Remove libjs and spidermonkey from prereq installer
* Remove references to spidermonkey and script runner
* Remove stock JS circ and catalog scripts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoDocs: 2.8 Patron Message Center
Angela Kilsdonk [Thu, 25 Jun 2015 15:42:14 +0000 (10:42 -0500)]
Docs: 2.8 Patron Message Center

Documentation for Patron Message Center development in 2.8

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoDocs: 2.6 Duplicate Serials Barcode Alert
Angela Kilsdonk [Wed, 24 Jun 2015 17:16:21 +0000 (12:16 -0500)]
Docs: 2.6 Duplicate Serials Barcode Alert

Documentation for new duplicate serials barcode alert in Serials Batch Receive.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Angela Kilsdonk [Wed, 24 Jun 2015 16:55:03 +0000 (11:55 -0500)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

4 years agoNew Documentation for 2.8
Angela Kilsdonk [Wed, 24 Jun 2015 16:49:00 +0000 (11:49 -0500)]
New Documentation for 2.8

2.8 Display Count of Existing Copies
2.8 Duplicate PO Name Alert
2.8 Negative Balances on Patron Accounts

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoLP#1468362 fix release me syntax and update acknowledgements
Yamil Suarez [Wed, 24 Jun 2015 15:09:04 +0000 (11:09 -0400)]
LP#1468362 fix release me syntax and update acknowledgements

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoDocs: Update action trigger docs to add missing fields.
Josh Stompro [Tue, 28 Apr 2015 13:16:54 +0000 (08:16 -0500)]
Docs: Update action trigger docs to add missing fields.

Rename heading to "Notifications / Action Trigger" so it matches
the staff client admin menu.

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agoLP#1465830: authority linker now ignores $e and $4 in bib name headings
Yamil Suarez [Fri, 19 Jun 2015 14:50:45 +0000 (10:50 -0400)]
LP#1465830: authority linker now ignores $e and $4 in bib name headings

presence of relator terms or codes in $e or $4 can prevent authority
headings linking

To test
-------
[1] Create an authority record with a name heading like this

    100 $a Example, Natalia $d 1945-

[2] Create a bib record that contains the name and a relator
    code or term, e.g.,

    100 $a Example, Natalia $d 1945- $4edt

[3] Run authority_control_fields.pl. Note that the
    heading in the bib is *NOT* linked, as evidence
    by no $0 being added to the bib heading and no
    rows added to authority.bib_linking for that bib
    and authority.

[4] Apply the patch and re-run step 3.  This time,
    the link gets established:

    100 $a Example, Natalia $d 1945- $4 edt $0 (CONS)xxx

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Change references to release 2.8.2 for server upgrade
Ben Shum [Thu, 18 Jun 2015 04:02:09 +0000 (00:02 -0400)]
Docs: Change references to release 2.8.2 for server upgrade

Since 2.8.2 is released, change references in upgrade docs to this newest
release.

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoPorting 2.8.1 -> 2.8.2 SQL upgrade
Bill Erickson [Wed, 17 Jun 2015 21:51:50 +0000 (17:51 -0400)]
Porting 2.8.1 -> 2.8.2 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1446816 HTML-escape notes in XUL patron alert page
Bill Erickson [Wed, 17 Jun 2015 17:27:05 +0000 (13:27 -0400)]
LP#1446816 HTML-escape notes in XUL patron alert page

Avoid rendering HTML contained in patron messages, etc. in the XUL
patron stop-sign page.

Thanks to Jason Etheridge, ESI for noting this problem and contributing
the original patch fix.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoRelease notes for 2.8.2
Kathy Lussier [Wed, 17 Jun 2015 20:19:58 +0000 (16:19 -0400)]
Release notes for 2.8.2

Adding a section for 2.8.2 bug fixes in the 2.8 Release Notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoRemove alpha and RC scripts for 2.3-2.4
Ben Shum [Tue, 3 Mar 2015 02:40:47 +0000 (21:40 -0500)]
Remove alpha and RC scripts for 2.3-2.4

These were in the repository from the testing phase of 2.3-2.4 during the
2.4 alpha/RC period. These script are not required and may be confusing if
run. Remove as unnecessary.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1205061: Add IF EXISTS to some DROP statements in 2.3-2.4 upgrade script
Ben Shum [Tue, 3 Mar 2015 02:34:53 +0000 (21:34 -0500)]
LP#1205061: Add IF EXISTS to some DROP statements in 2.3-2.4 upgrade script

To prevent potential issues, add IF EXISTS clauses to DROP statements in this
version upgrade script.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoDocumentation LP1369203 - Removed formatting around image link to
Josh Stompro [Fri, 9 Jan 2015 22:03:49 +0000 (16:03 -0600)]
Documentation LP1369203 - Removed formatting around image link to
re-enable the image.

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agoDocs: Updated opensearch example with new label format
Josh Stompro [Tue, 2 Jun 2015 18:09:10 +0000 (13:09 -0500)]
Docs: Updated opensearch example with new label format

The OpenSearch title now specifies the library name instead of the generic
"Evergreen OpenSearch" at every scope.

This is one of many TPAC Discoverability Enhancements included in
Evergreen 2.8.

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agoDocs: LP#1387639 - Barcode Completion Documentation
Josh Stompro [Wed, 3 Jun 2015 19:17:19 +0000 (14:17 -0500)]
Docs: LP#1387639 - Barcode Completion Documentation

Signed-off-by: Josh Stompro <stomproj@larl.org>
Conflicts:
docs/root.txt

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agofix live_t/08-lp1366964-libdbi-error.t
Jason Etheridge [Tue, 16 Jun 2015 16:30:38 +0000 (12:30 -0400)]
fix live_t/08-lp1366964-libdbi-error.t

from this:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods/live_t (lp902255test)$ prove 08-lp1366964-libdbi-error.t
08-lp1366964-libdbi-error.t .. # Tests libdbi transaction error reporting
08-lp1366964-libdbi-error.t .. 1/2
 #   Failed test 'CStoreEditor returns standard query error'
 #   at 08-lp1366964-libdbi-error.t line 31.
 #          got: 'DATABASE_UPDATE_FAILED'
 #     expected: 'DATABASE_QUERY_FAILED'
 # Looks like you failed 1 test of 2.
08-lp1366964-libdbi-error.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

Test Summary Report
-------------------
08-lp1366964-libdbi-error.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.82 cusr  0.11 csys =  0.96 CPU)
Result: FAIL

to this:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods/live_t (lp902255test)$ prove 08-lp1366964-libdbi-error.t
08-lp1366964-libdbi-error.t .. # Tests libdbi transaction error reporting
08-lp1366964-libdbi-error.t .. ok
All tests successful.
Files=1, Tests=2,  2 wallclock secs ( 0.02 usr  0.02 sys +  0.85 cusr  0.08 csys =  0.97 CPU)
Result: PASS

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP 902255: Fix upgrade script.
Jason Stephenson [Mon, 15 Jun 2015 20:29:02 +0000 (16:29 -0400)]
LP 902255: Fix upgrade script.

Run as-is, the upgrade script produces an error:

ERROR:  CREATE INDEX CONCURRENTLY cannot run inside a transaction block

Following this conversation in IRC, it was decided to remove the keyword
CONCURRENTLY from the create index statement.

http://irc.evergreen-ils.org/evergreen/2015-06-15#i_182857

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP 902255: Stamping upgrade script
Jason Stephenson [Mon, 15 Jun 2015 19:22:09 +0000 (15:22 -0400)]
LP 902255: Stamping upgrade script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#902255: Use simple alert box
Mike Rylander [Fri, 12 Jun 2015 18:29:02 +0000 (14:29 -0400)]
LP#902255: Use simple alert box

Instead of the generic communication error dialog, we'll use
the simple yns_alert box instead.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#902255: Correct "ILS Event at check in" logic
Mike Rylander [Thu, 11 Jun 2015 12:49:21 +0000 (08:49 -0400)]
LP#902255: Correct "ILS Event at check in" logic

In a classic case of "fix a bug to reveal another" it turn out that
there was a small logic bug hiding in the check in hold-capture code.
The result of this bug was that the wrong ILS Event object was being
returned when we ran into the double-scan hold-capture situation by
overwriting the correct one immediately after we construct it, which
in turn prevented the previous commit from working as designed.

We now return the correct ILS Event immediately so that we can
properly detect the situation.  Two birds with one branch.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#902255: Protect against hold double-capture
Mike Rylander [Mon, 8 Jun 2015 15:11:04 +0000 (11:11 -0400)]
LP#902255: Protect against hold double-capture

When the staff client is in Fast Scan (async) mode, it is possible
to double-scan at checkin and cause two holds to be captured by the
same item.  By creating a specially crafted unique index we ensure
that the database rejects this situation.

This protection would cause unhandled errors in the staff client, so
we also register a new string to be displayed when this particular
situation occurs, alerting staff to the possible double-scan of a
barcode at checkin IFF they are using async mode.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1463145 - Debian Jessie needs libexcel-writer-xlsx-perl
Ben Shum [Thu, 11 Jun 2015 00:57:29 +0000 (20:57 -0400)]
LP#1463145 - Debian Jessie needs libexcel-writer-xlsx-perl

Without this package, attempts to run clark-kent.pl will fail on Debian Jessie.

Also remove old libspreadsheet-writeexcel-perl package from pre-reqs as it is
no longer required.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1365661 Found patrons with same name not opening
Adam Bowling [Fri, 16 Jan 2015 22:18:24 +0000 (17:18 -0500)]
LP#1365661 Found patrons with same name not opening

This patch fixes the error, while registering a new patron
and clicking the link "Found {$0} patron(s) with the same
name" did not previously work in the staff client.

To reproduce the bug, register a new patron with the name of an
existing patron.  The little widget with the message described
above will appear.  The message is a hyperlink, but nothing
appears to happen if you click it.  The JavaScript console will
contain an error ReferenceError:js2JSON is not defined.

After applying this patch, clicking the hyperlink does a search
for matching patrons as intended.  The ReferenceError also
disappears.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1154656 MARC Expert Search "Add Rows" adds duplicate row
Michael Peters [Tue, 9 Jun 2015 14:10:04 +0000 (10:10 -0400)]
LP#1154656 MARC Expert Search "Add Rows" adds duplicate row

This patch changes the behavior of the "Add Search Row" link
(JavaScript function from simple.js "addExpertRow()") so that
we are always cloning the initial "empty" row instead of
potentially cloning a row -- by way of cloneNode() -- with user
input in place, and causing duplicate search rows.

To reproduce the bug, go to Advanced Search, fill in all three
search fields with some text, click on Add Search Row.  You wil
see that the Title search row along with the data in the text
box is duplicated and added to the search.

After this patch, the new row should be added with an empty
text box.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Rashma Kumaran <rkumaran@kcls.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1342227 - Allow EDI Ruby dependency installation on Ubuntu 14.04
Chris Sharp [Tue, 7 Apr 2015 00:17:30 +0000 (20:17 -0400)]
LP#1342227 - Allow EDI Ruby dependency installation on Ubuntu 14.04

Create a script for Ubuntu 14.04 ruby installation and installation
for EDI dependencies.  Remove 'rcov', which has been deprecated for
Ruby 1.9.1 and install Bill Erickson's GIR improvements.

In the future we will need to remove this dependency altogether (see
bug 1373690), but for now, at least get it working on Ubuntu 14.04.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations...
blake [Fri, 10 Apr 2015 19:29:08 +0000 (14:29 -0500)]
LP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations" Window

Edited the query inside the fm_IDL.xml file

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>