working/Evergreen.git
4 years agoLP 1198465: Restore voiding code, rename adjustment function
Dan Wells [Tue, 25 Feb 2014 22:37:43 +0000 (17:37 -0500)]
LP 1198465: Restore voiding code, rename adjustment function

This commit restores the code we removed a few commits earlier, and
also renames "real_void_bills()" "adjust_bills_to_zero()" in order to
better delineate the split functionality.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Fix typo in BILL_ALREADY_VOIDED event
Jason Stephenson [Tue, 25 Feb 2014 19:47:47 +0000 (14:47 -0500)]
LP 1198465: Fix typo in BILL_ALREADY_VOIDED event

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Update CDBI/money.pm for adjustment_payment
Jason Stephenson [Wed, 8 Jan 2014 01:44:47 +0000 (20:44 -0500)]
LP 1198465: Update CDBI/money.pm for adjustment_payment

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od
Jason Stephenson [Sun, 6 Oct 2013 21:13:01 +0000 (17:13 -0400)]
LP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()
Jason Stephenson [Sun, 6 Oct 2013 15:09:10 +0000 (11:09 -0400)]
LP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()

Simplify it to use the new, CircCommon->void_bills_of_type() method.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP 1198465: Add code for adjustment payments
Jason Stephenson [Fri, 20 Feb 2015 22:17:46 +0000 (17:17 -0500)]
LP 1198465: Add code for adjustment payments

This new payment type complements the current void logic that flags
bills as voided.

This new payment type is needed because the current way that Evergreen
voids bills requires that all voids happen in the same increment as the
bills themselves.  This prevents voiding of a partial bill or a bill
that has had a partial payment applied.

This commit also adds the org. unit setting types for the conditional
negative balances enhancements:

bill.prohibit_negative_balance_default
bill.prohibit_negative_balance_on_overdues
bill.prohibit_negative_balance_on_lost
bill.negative_balance_interval_default
bill.negative_balance_interval_on_overdues
bill.negative_balance_interval_on_lost

Finally, create a helper function for checking intervals along the way,
and a handy little subroutine to void all bills of a given type on a
circulation transaction.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1478299: fix location for asset used in test
Jason Etheridge [Mon, 27 Jul 2015 20:04:17 +0000 (16:04 -0400)]
LP#1478299: fix location for asset used in test

specifically lp1277731_hold_permit_test.pg

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Tue, 2 Apr 2013 21:22:37 +0000 (17:22 -0400)]
LP#1155771 Copy location sample data additions

* added some new locations and better groups (thanks gdunbar)
* applying locations to copies in a slightly more sane fashion
* added todo comment about possible future improvement

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Mon, 18 Mar 2013 15:01:36 +0000 (11:01 -0400)]
LP#1155771 Copy location sample data additions

* Add/remove some locations
* Add some locations whose flags (circulate, etc.) vary along the org
  pathway.  Thanks to Thomas Berezansky for this suggestion.
* Ensure that copy location owner matches copy circ lib when applying
  locations to copies.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1155771 Sample data : copy locations, location groups
Bill Erickson [Fri, 15 Mar 2013 18:32:18 +0000 (14:32 -0400)]
LP#1155771 Sample data : copy locations, location groups

Adds a pile of sample copy location and location groups to the sample
data in Open-ILS/tests/datasets/sql.  Samples are loaded as part of
"load_all.sql"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat...
Jeff Davis [Mon, 1 Jun 2015 23:16:25 +0000 (16:16 -0700)]
LP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years ago2.8 doc image name change
Angela Kilsdonk [Mon, 6 Jul 2015 19:51:15 +0000 (14:51 -0500)]
2.8 doc image name change

Image name change to fix display

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoLP#1312308 circ scripts, penalty removal release notes
Bill Erickson [Fri, 22 May 2015 20:25:18 +0000 (16:25 -0400)]
LP#1312308 circ scripts, penalty removal release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1312308 remove deprecated open-ils.penalty service
Bill Erickson [Fri, 22 May 2015 20:07:29 +0000 (16:07 -0400)]
LP#1312308 remove deprecated open-ils.penalty service

open-ils.penalty service has not been used by Evergreen since before
version 2.0.  Instead of just cleaning out the script configuration,
clean out the entire application.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1312308 script circ and deps removal
Bill Erickson [Wed, 13 May 2015 17:14:21 +0000 (13:14 -0400)]
LP#1312308 script circ and deps removal

* Remove libjs and spidermonkey from prereq installer
* Remove references to spidermonkey and script runner
* Remove stock JS circ and catalog scripts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoDocs: 2.8 Patron Message Center
Angela Kilsdonk [Thu, 25 Jun 2015 15:42:14 +0000 (10:42 -0500)]
Docs: 2.8 Patron Message Center

Documentation for Patron Message Center development in 2.8

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoDocs: 2.6 Duplicate Serials Barcode Alert
Angela Kilsdonk [Wed, 24 Jun 2015 17:16:21 +0000 (12:16 -0500)]
Docs: 2.6 Duplicate Serials Barcode Alert

Documentation for new duplicate serials barcode alert in Serials Batch Receive.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Angela Kilsdonk [Wed, 24 Jun 2015 16:55:03 +0000 (11:55 -0500)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

4 years agoNew Documentation for 2.8
Angela Kilsdonk [Wed, 24 Jun 2015 16:49:00 +0000 (11:49 -0500)]
New Documentation for 2.8

2.8 Display Count of Existing Copies
2.8 Duplicate PO Name Alert
2.8 Negative Balances on Patron Accounts

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
4 years agoLP#1468362 fix release me syntax and update acknowledgements
Yamil Suarez [Wed, 24 Jun 2015 15:09:04 +0000 (11:09 -0400)]
LP#1468362 fix release me syntax and update acknowledgements

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoDocs: Update action trigger docs to add missing fields.
Josh Stompro [Tue, 28 Apr 2015 13:16:54 +0000 (08:16 -0500)]
Docs: Update action trigger docs to add missing fields.

Rename heading to "Notifications / Action Trigger" so it matches
the staff client admin menu.

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agoLP#1465830: authority linker now ignores $e and $4 in bib name headings
Yamil Suarez [Fri, 19 Jun 2015 14:50:45 +0000 (10:50 -0400)]
LP#1465830: authority linker now ignores $e and $4 in bib name headings

presence of relator terms or codes in $e or $4 can prevent authority
headings linking

To test
-------
[1] Create an authority record with a name heading like this

    100 $a Example, Natalia $d 1945-

[2] Create a bib record that contains the name and a relator
    code or term, e.g.,

    100 $a Example, Natalia $d 1945- $4edt

[3] Run authority_control_fields.pl. Note that the
    heading in the bib is *NOT* linked, as evidence
    by no $0 being added to the bib heading and no
    rows added to authority.bib_linking for that bib
    and authority.

[4] Apply the patch and re-run step 3.  This time,
    the link gets established:

    100 $a Example, Natalia $d 1945- $4 edt $0 (CONS)xxx

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Change references to release 2.8.2 for server upgrade
Ben Shum [Thu, 18 Jun 2015 04:02:09 +0000 (00:02 -0400)]
Docs: Change references to release 2.8.2 for server upgrade

Since 2.8.2 is released, change references in upgrade docs to this newest
release.

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoPorting 2.8.1 -> 2.8.2 SQL upgrade
Bill Erickson [Wed, 17 Jun 2015 21:51:50 +0000 (17:51 -0400)]
Porting 2.8.1 -> 2.8.2 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1446816 HTML-escape notes in XUL patron alert page
Bill Erickson [Wed, 17 Jun 2015 17:27:05 +0000 (13:27 -0400)]
LP#1446816 HTML-escape notes in XUL patron alert page

Avoid rendering HTML contained in patron messages, etc. in the XUL
patron stop-sign page.

Thanks to Jason Etheridge, ESI for noting this problem and contributing
the original patch fix.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoRelease notes for 2.8.2
Kathy Lussier [Wed, 17 Jun 2015 20:19:58 +0000 (16:19 -0400)]
Release notes for 2.8.2

Adding a section for 2.8.2 bug fixes in the 2.8 Release Notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoRemove alpha and RC scripts for 2.3-2.4
Ben Shum [Tue, 3 Mar 2015 02:40:47 +0000 (21:40 -0500)]
Remove alpha and RC scripts for 2.3-2.4

These were in the repository from the testing phase of 2.3-2.4 during the
2.4 alpha/RC period. These script are not required and may be confusing if
run. Remove as unnecessary.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1205061: Add IF EXISTS to some DROP statements in 2.3-2.4 upgrade script
Ben Shum [Tue, 3 Mar 2015 02:34:53 +0000 (21:34 -0500)]
LP#1205061: Add IF EXISTS to some DROP statements in 2.3-2.4 upgrade script

To prevent potential issues, add IF EXISTS clauses to DROP statements in this
version upgrade script.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoDocumentation LP1369203 - Removed formatting around image link to
Josh Stompro [Fri, 9 Jan 2015 22:03:49 +0000 (16:03 -0600)]
Documentation LP1369203 - Removed formatting around image link to
re-enable the image.

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agoDocs: Updated opensearch example with new label format
Josh Stompro [Tue, 2 Jun 2015 18:09:10 +0000 (13:09 -0500)]
Docs: Updated opensearch example with new label format

The OpenSearch title now specifies the library name instead of the generic
"Evergreen OpenSearch" at every scope.

This is one of many TPAC Discoverability Enhancements included in
Evergreen 2.8.

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agoDocs: LP#1387639 - Barcode Completion Documentation
Josh Stompro [Wed, 3 Jun 2015 19:17:19 +0000 (14:17 -0500)]
Docs: LP#1387639 - Barcode Completion Documentation

Signed-off-by: Josh Stompro <stomproj@larl.org>
Conflicts:
docs/root.txt

Signed-off-by: Josh Stompro <stomproj@larl.org>
4 years agofix live_t/08-lp1366964-libdbi-error.t
Jason Etheridge [Tue, 16 Jun 2015 16:30:38 +0000 (12:30 -0400)]
fix live_t/08-lp1366964-libdbi-error.t

from this:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods/live_t (lp902255test)$ prove 08-lp1366964-libdbi-error.t
08-lp1366964-libdbi-error.t .. # Tests libdbi transaction error reporting
08-lp1366964-libdbi-error.t .. 1/2
 #   Failed test 'CStoreEditor returns standard query error'
 #   at 08-lp1366964-libdbi-error.t line 31.
 #          got: 'DATABASE_UPDATE_FAILED'
 #     expected: 'DATABASE_QUERY_FAILED'
 # Looks like you failed 1 test of 2.
08-lp1366964-libdbi-error.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

Test Summary Report
-------------------
08-lp1366964-libdbi-error.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.82 cusr  0.11 csys =  0.96 CPU)
Result: FAIL

to this:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods/live_t (lp902255test)$ prove 08-lp1366964-libdbi-error.t
08-lp1366964-libdbi-error.t .. # Tests libdbi transaction error reporting
08-lp1366964-libdbi-error.t .. ok
All tests successful.
Files=1, Tests=2,  2 wallclock secs ( 0.02 usr  0.02 sys +  0.85 cusr  0.08 csys =  0.97 CPU)
Result: PASS

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP 902255: Fix upgrade script.
Jason Stephenson [Mon, 15 Jun 2015 20:29:02 +0000 (16:29 -0400)]
LP 902255: Fix upgrade script.

Run as-is, the upgrade script produces an error:

ERROR:  CREATE INDEX CONCURRENTLY cannot run inside a transaction block

Following this conversation in IRC, it was decided to remove the keyword
CONCURRENTLY from the create index statement.

http://irc.evergreen-ils.org/evergreen/2015-06-15#i_182857

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP 902255: Stamping upgrade script
Jason Stephenson [Mon, 15 Jun 2015 19:22:09 +0000 (15:22 -0400)]
LP 902255: Stamping upgrade script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#902255: Use simple alert box
Mike Rylander [Fri, 12 Jun 2015 18:29:02 +0000 (14:29 -0400)]
LP#902255: Use simple alert box

Instead of the generic communication error dialog, we'll use
the simple yns_alert box instead.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#902255: Correct "ILS Event at check in" logic
Mike Rylander [Thu, 11 Jun 2015 12:49:21 +0000 (08:49 -0400)]
LP#902255: Correct "ILS Event at check in" logic

In a classic case of "fix a bug to reveal another" it turn out that
there was a small logic bug hiding in the check in hold-capture code.
The result of this bug was that the wrong ILS Event object was being
returned when we ran into the double-scan hold-capture situation by
overwriting the correct one immediately after we construct it, which
in turn prevented the previous commit from working as designed.

We now return the correct ILS Event immediately so that we can
properly detect the situation.  Two birds with one branch.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#902255: Protect against hold double-capture
Mike Rylander [Mon, 8 Jun 2015 15:11:04 +0000 (11:11 -0400)]
LP#902255: Protect against hold double-capture

When the staff client is in Fast Scan (async) mode, it is possible
to double-scan at checkin and cause two holds to be captured by the
same item.  By creating a specially crafted unique index we ensure
that the database rejects this situation.

This protection would cause unhandled errors in the staff client, so
we also register a new string to be displayed when this particular
situation occurs, alerting staff to the possible double-scan of a
barcode at checkin IFF they are using async mode.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1463145 - Debian Jessie needs libexcel-writer-xlsx-perl
Ben Shum [Thu, 11 Jun 2015 00:57:29 +0000 (20:57 -0400)]
LP#1463145 - Debian Jessie needs libexcel-writer-xlsx-perl

Without this package, attempts to run clark-kent.pl will fail on Debian Jessie.

Also remove old libspreadsheet-writeexcel-perl package from pre-reqs as it is
no longer required.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1365661 Found patrons with same name not opening
Adam Bowling [Fri, 16 Jan 2015 22:18:24 +0000 (17:18 -0500)]
LP#1365661 Found patrons with same name not opening

This patch fixes the error, while registering a new patron
and clicking the link "Found {$0} patron(s) with the same
name" did not previously work in the staff client.

To reproduce the bug, register a new patron with the name of an
existing patron.  The little widget with the message described
above will appear.  The message is a hyperlink, but nothing
appears to happen if you click it.  The JavaScript console will
contain an error ReferenceError:js2JSON is not defined.

After applying this patch, clicking the hyperlink does a search
for matching patrons as intended.  The ReferenceError also
disappears.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1154656 MARC Expert Search "Add Rows" adds duplicate row
Michael Peters [Tue, 9 Jun 2015 14:10:04 +0000 (10:10 -0400)]
LP#1154656 MARC Expert Search "Add Rows" adds duplicate row

This patch changes the behavior of the "Add Search Row" link
(JavaScript function from simple.js "addExpertRow()") so that
we are always cloning the initial "empty" row instead of
potentially cloning a row -- by way of cloneNode() -- with user
input in place, and causing duplicate search rows.

To reproduce the bug, go to Advanced Search, fill in all three
search fields with some text, click on Add Search Row.  You wil
see that the Title search row along with the data in the text
box is duplicated and added to the search.

After this patch, the new row should be added with an empty
text box.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Rashma Kumaran <rkumaran@kcls.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1342227 - Allow EDI Ruby dependency installation on Ubuntu 14.04
Chris Sharp [Tue, 7 Apr 2015 00:17:30 +0000 (20:17 -0400)]
LP#1342227 - Allow EDI Ruby dependency installation on Ubuntu 14.04

Create a script for Ubuntu 14.04 ruby installation and installation
for EDI dependencies.  Remove 'rcov', which has been deprecated for
Ruby 1.9.1 and install Bill Erickson's GIR improvements.

In the future we will need to remove this dependency altogether (see
bug 1373690), but for now, at least get it working on Ubuntu 14.04.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations...
blake [Fri, 10 Apr 2015 19:29:08 +0000 (14:29 -0500)]
LP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations" Window

Edited the query inside the fm_IDL.xml file

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoDocs LP#1371646: Add better screenshots
Remington Steed [Wed, 10 Jun 2015 21:07:43 +0000 (17:07 -0400)]
Docs LP#1371646: Add better screenshots

This commit borrows two screenshots from the Sitka Evergreen Training
Manual to replace one in the Alternate Serial Control View section.
Thanks Sitka!

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoLP1444623: Remove "Safe" CPAN dependency from Debian/Ubuntu Makefile.install files
Chris Sharp [Wed, 15 Apr 2015 18:05:23 +0000 (14:05 -0400)]
LP1444623: Remove "Safe" CPAN dependency from Debian/Ubuntu Makefile.install files

Following up on IRC discussion at http://irc.evergreen-ils.org/evergreen/2015-04-15#i_170386
it was agreed that it is no longer necessary to install Safe from CPAN
since it is included in the standard Perl package.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/extras/install/Makefile.debian-jessie

4 years agoLP#638509: Handle COPY_STATUS_LOST and COPY_STATUS_LONG_OVERDUE in renewal.
Jason Stephenson [Sat, 15 Feb 2014 17:56:58 +0000 (12:56 -0500)]
LP#638509: Handle COPY_STATUS_LOST and COPY_STATUS_LONG_OVERDUE in renewal.

Modify Open-ILS/xul/staff_client/server/circ/util.js so that the
above events are available for override.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#638509: Remove the stop_fines checks from do_renew's circulation search.
Jason Stephenson [Sun, 2 Feb 2014 20:59:34 +0000 (15:59 -0500)]
LP#638509: Remove the stop_fines checks from do_renew's circulation search.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1396263: Fix for 'Return to Record' link breaks after texting
Terran McCanna [Wed, 10 Jun 2015 19:44:46 +0000 (15:44 -0400)]
LP#1396263: Fix for 'Return to Record' link breaks after texting

If user is already logged into OPAC when texting a call number from
the record screen, the 'Return to Record' link works properly. However,
if user is not logged in and is prompted to log in first, the 'Return to
Record' link actually returns the user to 'My Account.' This patch
corrects that problem and returns the user to the record regardless of
whether they were initially logged in or not.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP1440148 Long overdue Items out TPAC OPAC display My Account
Blake Henderson [Fri, 10 Apr 2015 20:43:54 +0000 (15:43 -0500)]
LP1440148 Long overdue Items out TPAC OPAC display My Account

Removed Long overdue circs from the total_out count

Signed-off-by: Blake Henderson <blake@mobiusconsortium.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1463973: Use dollar-quoting for report literals
Mike Rylander [Wed, 10 Jun 2015 18:17:37 +0000 (14:17 -0400)]
LP#1463973: Use dollar-quoting for report literals

When inserting string literal into SQL for Clark, we quote
apostrophes with a backslash.  That worked fine until Postgres
changed its default for the standard_conforming_strings GUC to "on"
after which it no longer worked fine.

So, we will now use "dollar quoting" for string literals instead
in much the same way we do for our search queries.

Test plan
---------

Pre-patch: Try to run a report where a string value is required as
a filter parameter, and include an apostrophe in that string.  The
report will fail with an SQL error.

Post-patch: Do the same, it will not fail.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1446860 - Correct mistaken logic in previous fix.
Chris Sharp [Wed, 22 Apr 2015 13:54:11 +0000 (09:54 -0400)]
LP#1446860 - Correct mistaken logic in previous fix.

See https://bugs.launchpad.net/evergreen/+bug/1446860/comments/2
for reference.  The logic was not enforcing the "if the editing
staff member doesn't have permission to edit a user in this
permission group" check.  This corrects that.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1446860 Staff were able to edit their own accounts.
Chris Sharp [Tue, 21 Apr 2015 21:10:49 +0000 (17:10 -0400)]
LP#1446860 Staff were able to edit their own accounts.

This change reverses what appears to be a thinko in the
original programming.  If the editing user is the same
as the user being edited, disable the Save button.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1074096: Remove Bib Call Number from query type selector
Jeff Davis [Thu, 16 Apr 2015 15:58:17 +0000 (08:58 -0700)]
LP#1074096: Remove Bib Call Number from query type selector

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1452883: prevent staff client warnings w/ Google Analytics
Jason Etheridge [Thu, 7 May 2015 20:02:00 +0000 (16:02 -0400)]
LP#1452883: prevent staff client warnings w/ Google Analytics

In particular, the Security Warning that goes "You have requested an encrypted
page that contains some unencrypted information..."

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1403966: Remove publication-specific information from metarecord results page
Kathy Lussier [Thu, 28 May 2015 02:11:49 +0000 (22:11 -0400)]
LP#1403966: Remove publication-specific information from metarecord results page

The records that make up a matarecord search result typically contain different
publication information. Therefore, we should remove the master record's
specific publication information from that search results page.

Test plan
Prior to loading the patch, conduct a search on the Concerto dataset
for "brahms piano concerto no. 1" with "Group Formats and Editions" turned on.
In the brief view, you will see a call number and, in the more details view, you
will see publisher and physical description information. Run the same search
after loading the patch, and you will no longer see that information.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1194860: You have permission to override some of the failed holds. appearing when...
Blake Henderson [Mon, 8 Dec 2014 21:52:15 +0000 (15:52 -0600)]
LP#1194860: You have permission to override some of the failed holds. appearing when it should not for patrons in the OPAC Edit

A quick value check before assigning the override variable.
This should eliminate the OPAC showing the override option
for those who do not have the permission.

Signed-off-by: Blake Henderson <blake@mobiusconsortium.org>
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1456021 Enable apache modcgi during install for Debian Jessie
Josh Stompro [Sun, 31 May 2015 22:49:34 +0000 (17:49 -0500)]
LP#1456021 Enable apache modcgi during install for Debian Jessie

Apache mod cgi isn't enabled when installing apache2.4 on Debian Jessie,
this causes the /updates/manualupdate.html to not be processed and
to just return the raw code of that script since it uses mod cgi.

This adds 'cgi' to the list of apache modules to enable during the
dependency install.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1457094 Switch to package libtemplate-plugin-posix-perl for Debian Jessie
Josh Stompro [Sun, 31 May 2015 22:19:58 +0000 (17:19 -0500)]
LP#1457094 Switch to package libtemplate-plugin-posix-perl for Debian Jessie

Debian Jessie includes a package for Template::Plugin::Posix that was
being installed via CPAN.  This patch removes the CPAN install and adds
the Debian package.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#757533: adds scrollbars (when necessary) to the item status alternate view tab...
Bradley Bonner [Wed, 10 Jun 2015 21:26:57 +0000 (14:26 -0700)]
LP#757533: adds scrollbars (when necessary) to the item status alternate view tab box.

Signed-off-by: Bradley Bonner <bbonner@kcls.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1289486 Stamping upgrade for dropping acq audit fkey
Dan Wells [Wed, 10 Jun 2015 19:05:13 +0000 (15:05 -0400)]
LP#1289486 Stamping upgrade for dropping acq audit fkey

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1289486: Remove blocking constraint from audit table
Mike Rylander [Mon, 8 Jun 2015 21:30:52 +0000 (17:30 -0400)]
LP#1289486: Remove blocking constraint from audit table

The ACQ lineitem audit table was augmented with an fkey pointing
to the queued record that was related to the line item.  That's
bad because there are also triggers which attempt to manage that
table.  Hilarity ensues.  We should not have an fkey on an audit
table, so, we now remove that.

In order to test this, first attempt to delete an ACQ queue and
have that fail.  Apply the DB change, attempt again, and have it
succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1447168 Stamping upgrade script for index on ash record
Dan Wells [Wed, 10 Jun 2015 18:29:27 +0000 (14:29 -0400)]
LP#1447168 Stamping upgrade script for index on ash record

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1447168: add an index on authority.simple_heading.record
Galen Charlton [Wed, 22 Apr 2015 13:43:19 +0000 (13:43 +0000)]
LP#1447168: add an index on authority.simple_heading.record

This index is needed so that full table scans on ash aren't
needed during authority record reingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1449709: Always get a real hostname for the cache key
Mike Rylander [Fri, 22 May 2015 17:11:18 +0000 (13:11 -0400)]
LP#1449709: Always get a real hostname for the cache key

EGCatLoader overwrites $ctx->{hostname} when serving the staff client
version of TT-generated content.  This is bad for us because we use
that as part of the TT Processor cache key.  Instead, we'll just
always ask Apache, via $r.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1452366: allow EGWeb context loaders to have child_init actions
Galen Charlton [Tue, 5 May 2015 22:15:39 +0000 (22:15 +0000)]
LP#1452366: allow EGWeb context loaders to have child_init actions

This patch adds the ability for EGWeb to call
an initialization function for context loaders
during the child_init phase of Apache backend
startup.

In particular, portions of the R/O object cache
for EGCatLoader are now initialized when a backend
starts up; testing indicates that this can shave
a couple seconds off the time it takes for a
backend to render a bib details page the first time.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1452352: use fresh CStore editors when populating R/O cache
Galen Charlton [Wed, 6 May 2015 18:23:49 +0000 (18:23 +0000)]
LP#1452352: use fresh CStore editors when populating R/O cache

This change ensures that there's no longer a cached
editor with its original session locale grabbing
the wrong labels when a template invokes ctx.search_foo.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1452352: don't leak $ctx when initializing TPAC R/O object cache
Mike Rylander [Wed, 6 May 2015 15:10:44 +0000 (11:10 -0400)]
LP#1452352: don't leak $ctx when initializing TPAC R/O object cache

Create a closure over a simple scalar instead of the
whole $ctx object when all we need is the locale.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1452352: fix generation of locale-specific RO object fetchers
Galen Charlton [Wed, 6 May 2015 13:50:32 +0000 (13:50 +0000)]
LP#1452352: fix generation of locale-specific RO object fetchers

The TPAC R/O object cache is now keyed by locale.  This
fixes an issue where an OPAC session that starts in one
locale and gets switched to another could see (e.g.)
format labels for the original locale.

The issue fixed by this patch can be most readily reproduced
as follows:

[1] Enable both the en-US and fr-CA locales. Make sure
    that there are some translations for record format
    coded values in place as well.
[2] Run Apache in single-process mode
    (e.g., ". /etc/apache2/envvars && apache2 -X")
[3] Visit a record details page in the en-US locale. Note
    the label associated with the record format.
[4] Change the locale to fr-CA. Note that the label is
    still the English version.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1449709: add release notes
Galen Charlton [Tue, 5 May 2015 16:43:18 +0000 (16:43 +0000)]
LP#1449709: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1449709: caching compiled Template Toolkit templates
Galen Charlton [Tue, 28 Apr 2015 19:06:48 +0000 (19:06 +0000)]
LP#1449709: caching compiled Template Toolkit templates

This patch enables caching of compiled Template Toolkit
files on Evergreen web servers, which can provide a modest
improvement in the time it takes (say) TPAC to render
a page, particularly by a fresh Apache backend.

This is controlled by a new Apache virtualhost variable,
OILSWebCompiledTemplateCache, which can be set to a
directory on the webserver for storing compiled templates. This
is enabled by default for new installations.

This patch also adds OILSWebTemplateStatTTL, which can be
use to tweak the STAT_TTL Template Toolkit setting. Note this
bit works because of the caching of TT handlers added by
the previous patch.

Finally, this patch also fixes a bug where attempting to
disable OILSWebDebugTemplate would result in internal server errors;
it also sets the default value of this setting to false.

Note: the caching added by this patch and the previous one
mean that if a change to (say) TPAC templates is made on
the file system, it is now required to reload Apache to have
a guarantee that the change is visible, although one can also
wait the OILSWebTemplateStatTTL interval.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1449709: Persist template processor for speed
Mike Rylander [Mon, 4 May 2015 21:06:54 +0000 (17:06 -0400)]
LP#1449709: Persist template processor for speed

By persisting the Template Toolkit processor object per
vhost/locale/context-loader/xml-strictness instead
of creating a new one for every request, we allow TT
to maintain an in-memory cache of all the templates it
has compiled.  This increases speed by as much as 80%.

In addition, we reduce the number of times the TPAC checks
for the existance of a template by remembering the state
of the first readability probe.  This is most important
on systems where the templates are stored on NFS, where
stat(2) system calls can be particularly expensive.

We now pass the Apache object ($r) to the template processor
instead of relying on tied-STDOUT behaviour, because each
request gets a new tied file handle.  After the first one,
it's the wrong one.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoDocs: Replace broken link, go to new LSE section
Remington Steed [Wed, 10 Jun 2015 16:05:04 +0000 (12:05 -0400)]
Docs: Replace broken link, go to new LSE section

This commit fixes a newly broken link, caused by removing the old
Library Settings Editor docs section. The new link goes to the new LSE
section.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoDocs: Fix spelling errors in Library Settings docs
Remington Steed [Tue, 9 Jun 2015 20:12:36 +0000 (16:12 -0400)]
Docs: Fix spelling errors in Library Settings docs

This commit fixes some spelling errors only in the docs, not in the text
of the actual settings.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoDocs: New chapter for Library Settings Editor
Lynn Floyd [Tue, 9 Jun 2015 15:44:16 +0000 (11:44 -0400)]
Docs: New chapter for Library Settings Editor

This commit removes the old piecemeal documentation and adds a more
complete chapter on using the Library Settings Editor, including
categorized tables of the various library settings.

Thanks to Lynn Floyd for the documentation and screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoDocs: General improvements to EDI docs
Jane Sandberg [Tue, 19 May 2015 21:13:05 +0000 (17:13 -0400)]
Docs: General improvements to EDI docs

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoDocs: Added hard due dates docs
Jane Sandberg [Sun, 17 May 2015 16:32:21 +0000 (12:32 -0400)]
Docs: Added hard due dates docs

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoDocs: Added sub-section for permalink to 'using the catalog' section
Josh Stompro [Sun, 17 May 2015 01:20:50 +0000 (21:20 -0400)]
Docs: Added sub-section for permalink to 'using the catalog' section

Signed Off Josh Stompro (github@stompro.org)
Signed Off Amy Terlaga (terlaga@biblio.org)
Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoDocs 2.8: SMS Call Number new screenshots, improve wording
Christine Burns [Wed, 13 May 2015 23:36:34 +0000 (19:36 -0400)]
Docs 2.8: SMS Call Number new screenshots, improve wording

This commit includes updated screenshots and some minor wording edits to
the SMS Call Number / Copy Details feature.

New screenshots and edits provided by
* Christine Burns <christine.burns@bc.libraries.coop>
* Carol Yarrison

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoLP#1125270: Add a DROP FUNCTION for actor.usr_purge_data
Ben Shum [Tue, 3 Mar 2015 02:49:55 +0000 (21:49 -0500)]
LP#1125270: Add a DROP FUNCTION for actor.usr_purge_data

Apparently this caused problems on upgrading from 2.0 to 2.1 back in the day,
and adding a DROP FUNCTION ahead of the CREATE dealt with the situation.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP1406317: Stray Semicolons in OPAC Browse
Terran McCanna [Fri, 15 May 2015 17:02:17 +0000 (10:02 -0700)]
LP1406317: Stray Semicolons in OPAC Browse

Fixed display issue where semicolons were appearing at the end of
each result in browse title screen. Semicolon had been placed outside
of a bracket rather than inside a bracket. Moved semicolon to inside
bracket to correct.

URL of page showing error:
https://my-library/eg/opac/browse?blimit=10&qtype=title&bterm=m&locg=1

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Active date display in OPAC
Lynn Floyd [Wed, 13 May 2015 23:01:05 +0000 (19:01 -0400)]
Docs: Active date display in OPAC

Additional thanks to Debbie Luchenbill <debbie@mobiusconsortium.org>

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoDocs: Update mention of Schema.org use to include OPAC bib record views
Debbie Luchenbill [Wed, 13 May 2015 22:41:16 +0000 (18:41 -0400)]
Docs: Update mention of Schema.org use to include OPAC bib record views

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoDocs: config.tt2 option for "Show more details"
Yamil Suarez [Wed, 13 May 2015 00:48:13 +0000 (20:48 -0400)]
Docs: config.tt2 option for "Show more details"

Signed-off-by: Yamil Suarez <github@yamil.com>
4 years agoDocs: Removal of Bib Call Number Search
Yamil Suarez [Wed, 13 May 2015 01:27:28 +0000 (21:27 -0400)]
Docs: Removal of Bib Call Number Search

Signed-off-by: Yamil Suarez <github@yamil.com>
4 years agoLP#800706: Stamping upgrade script
Jason Stephenson [Wed, 13 May 2015 17:51:35 +0000 (13:51 -0400)]
LP#800706: Stamping upgrade script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#800706: add regression test
Galen Charlton [Tue, 12 May 2015 20:02:09 +0000 (16:02 -0400)]
LP#800706: add regression test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#800706: add index to serial.record_entry.record
Galen Charlton [Tue, 12 May 2015 19:27:07 +0000 (15:27 -0400)]
LP#800706: add index to serial.record_entry.record

This patch adds index on the record column of serial.record_entry,
which can improve performance when displaying record details pages
in databases that have a large number MFHDs.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#1445150: Symlink for 000.english.pg94.fts-config.sql
Ben Shum [Sat, 9 May 2015 02:10:19 +0000 (22:10 -0400)]
LP#1445150: Symlink for 000.english.pg94.fts-config.sql

We need this so that the eg_db_config script can make the Evergreen
database with PostgreSQL 9.4 systems.

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1445182 Changed Debian Jessie dependency install to use packages for dbi dbd-pgsql.
Josh Stompro [Thu, 30 Apr 2015 14:37:50 +0000 (09:37 -0500)]
LP#1445182 Changed Debian Jessie dependency install to use packages for dbi dbd-pgsql.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/extras/install/Makefile.debian-jessie

4 years agoLP#1362260 - Email::Sender/libemail-send-perl change in Jessie
Josh Stompro [Thu, 16 Apr 2015 16:21:13 +0000 (11:21 -0500)]
LP#1362260 - Email::Sender/libemail-send-perl change in Jessie

libemail-send-perl no longer exists in Debian Jessie.  Change
Makefile.debian-jessie to install cpan version instead of
debian package.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1445187 - Force disable of deflate
Josh Stompro [Thu, 16 Apr 2015 19:55:25 +0000 (14:55 -0500)]
LP#1445187 - Force disable of deflate

Add the -f (force) flag to a2dismod to remove the chance of getting
a confirmation prompt when removing deflate.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1447195 Updates for Debian Jessie in README
Josh Stompro [Mon, 20 Apr 2015 19:45:59 +0000 (14:45 -0500)]
LP#1447195 Updates for Debian Jessie in README

- Adding in a few missed references to Debian Jessie
- Noted instances where Jessie uses the same instructions as Trusty
- Debian Jessie includes Apache2.4 so needs to use those steps.
- Added Jessie to postgres server install

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1445150 Update Debian Jessie depend make to PG9.4
Josh Stompro [Thu, 16 Apr 2015 18:13:17 +0000 (13:13 -0500)]
LP#1445150 Update Debian Jessie depend make to PG9.4

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoDocs: Change references to release 2.8.1 for server upgrade
Ben Shum [Mon, 4 May 2015 16:58:22 +0000 (12:58 -0400)]
Docs: Change references to release 2.8.1 for server upgrade

Since 2.8.1 is released, change references in upgrade docs to this newest
release.

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1449283: fix auth when running under Apache 2.4
Galen Charlton [Thu, 30 Apr 2015 18:07:14 +0000 (11:07 -0700)]
LP#1449283: fix auth when running under Apache 2.4

When running under Apache 2.4 using the stock configuration
derived from apache_24/eg_vhost.conf.in, protected
URLs such as https://eghost/reporter/ that are meant to
require valid EG staff credentials were not in fact
requiring authentication.

This patch does the following to fix this:

[1] Removes several uses of "Require all granted" that
    was causing authentication to be ignored.
[2] Changes OpenILS::WWW::Proxy::Authen so that it always
    sets the username in the Apache request object if
    authentication was successful; it appears that starting
    with Apache 2.4, authentication handlers must ensure
    that a user name is set for a "Require valid-user"
    directive to work.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoForward-port 2.8.0 to 2.8.1 SQL upgrade
Bill Erickson [Fri, 1 May 2015 20:06:14 +0000 (16:06 -0400)]
Forward-port 2.8.0 to 2.8.1 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoAdd 2.8.1 release notes to the 2.8 release note file.
Kathy Lussier [Wed, 29 Apr 2015 03:09:57 +0000 (23:09 -0400)]
Add 2.8.1 release notes to the 2.8 release note file.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1427309 Fix Crash in Collections User Balance Summary
Jason Boyer [Mon, 2 Mar 2015 20:06:33 +0000 (15:06 -0500)]
LP#1427309 Fix Crash in Collections User Balance Summary

Previously a patron in collections that paid off all
transactions would cause a crash and stop processing
any balance summary file that they are supposed to
appear in. Now user balance summaries can be created
in full even if some users have a 0 balance.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP 1444130: Add max_chunk_size guards to Holds.pm.
Jason Stephenson [Tue, 14 Apr 2015 14:43:49 +0000 (10:43 -0400)]
LP 1444130: Add max_chunk_size guards to Holds.pm.

Web staff client fixes introduced a bug in using the Clear
Holds Shelf checkin modifier.  Commit 4ccbf980 added calls
to max_chunk_size on the client to use chunked responses for
better feedback during long operations.  Thise works just
fine when a regular OpenSRF AppRequest is used, but leads to
a network error when AppSubrequest is used, as apparently the
xul client does with the Clear Holds Shelf checkin modifier.

This commit adds code to check if the client object can do
the max_chunk_size call when the max_chunk_size call is
made.  This will prevent the network errors in cases where
the client is an AppSubrequest object and will still use
chunked responses when the client is capable of doing it.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1443952 Lost fine handling refactor
Dan Wells [Fri, 20 Feb 2015 22:36:25 +0000 (17:36 -0500)]
LP#1443952 Lost fine handling refactor

This commit moves the lost fine logic out of the lost processing
portion of Circulate.pm and into the new handle_fines() method.
This is accomplished through setting a new flag and lost
options hash on the main Circulator object.

This change improves the overall process flow, and in doing so
addresses a bug where overdue fines could be doubled if both
restore-overdue-on-lost-return and generate-new-overdues-on-lost-return
are enabled.  Before this change, the new fines would generate before
the old fines were unvoided, which effectively circumvented the max
fines setting.

A secondary change made here is that stop_fines is also now being set
during the handle_fines() stage. This improves any case where overdues
are being set on checkin, particularly lost returns, as the stop_fines
will end up as the proper value of MAX_FINES or CHECKIN.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1443952 Move overdue restore above lost void/adjustment
Dan Wells [Fri, 20 Feb 2015 22:28:44 +0000 (17:28 -0500)]
LP#1443952 Move overdue restore above lost void/adjustment

If a person loses something and has their overdues voided/zeroed,
then pays for part of it, then returns the item, the part they
actually paid should apply to the overdues.  In order for this to
happen, the overdues must exist *before* the lost fines are adjusted.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>