working/Evergreen.git
6 years agoLP#1218597 tpac self-reg refresh page for privacy
Bill Erickson [Wed, 28 Aug 2013 17:41:21 +0000 (13:41 -0400)]
LP#1218597 tpac self-reg refresh page for privacy

Adding a new org unit setting "opac.self_register.timeout" /
"Patron Self-Reg. Display Timeout" for determning how long the self-reg
page will remain open before reloading to the home page.  The goal is to
protect the privacy of those who enter values but fail to submit the
form.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:

Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1218597 TPAC self-reg DoB date format example message
Bill Erickson [Wed, 28 Aug 2013 17:27:52 +0000 (13:27 -0400)]
LP#1218597 TPAC self-reg DoB date format example message

Provide an example DoB date format message.  Since the message may need
translating, it is provided as a template string and not an org unit
setting.  Note, however, that the Dojo widget inside the patron
registration UI, where self-reg data ultimately goes, requires
incoming/default date values to be in ISO8601 format.  It will not
accept locale-shaped dates.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoRepair Vandelay async startup data retrieval
Bill Erickson [Mon, 23 Sep 2013 14:51:03 +0000 (10:51 -0400)]
Repair Vandelay async startup data retrieval

Increment the number of items retrieved at startup to ensure the UI
waits for all async requests to return before continuing with page
rendering.

The counter should have been updated with this commit, which adds bucket
retrieval to the startup sequence.

59cc4b9524bfcf9a56f54c5ed5a3d56a7d1b86e6

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoUpdate serials docs for 2.4
Remington Steed [Fri, 10 May 2013 13:57:31 +0000 (09:57 -0400)]
Update serials docs for 2.4

In version 2.4, the serials modules underwent significant changes that
require significant updates to the documentation. This commit provides
the necessary updates, including some new screenshots. And in a few
cases, existing documentation was corrected or improved in ways
unrelated to the 2.4 update.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoAdd altering rows colors to (cataloging) manage authorities interface
Yamil Suarez [Wed, 18 Sep 2013 19:01:21 +0000 (15:01 -0400)]
Add altering rows colors to (cataloging) manage authorities interface

To make it easier to use the (cataloging) manage authorities interface I added a tiny bit of CSS to have alternating row colors. The "height: 1.5em" part is needed because the enclosing authEntry div ends up with a height of zero because its children containers are all floating. Turns out this zero height behavior is not a bug, but a natural side affect of floating the div's children.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoFix typo in Makefile.ubuntu-precise.
Chris Sharp [Tue, 17 Sep 2013 17:55:29 +0000 (13:55 -0400)]
Fix typo in Makefile.ubuntu-precise.

Makefile.ubuntu precise was lacking a "install_postgres_server"
target.  This updates that file.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoNumber upgrade script for serial alert notes
Lebbeous Fogle-Weekley [Tue, 17 Sep 2013 18:53:47 +0000 (14:53 -0400)]
Number upgrade script for serial alert notes

(and fix trivial omission in XUL from that same work)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoRelease notes for Serial alert notes
Remington Steed [Tue, 17 Sep 2013 12:20:17 +0000 (08:20 -0400)]
Release notes for Serial alert notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoSerials: alert notes when receiving
Dan Wells [Tue, 10 Sep 2013 22:33:23 +0000 (18:33 -0400)]
Serials: alert notes when receiving

This commit adds the ability to flag serial notes as receive-time
alerts, and also adds the interface widgets necessary to check for
and see these alerts in the serial control receiving interface.

notes.xul was modified extensively to allow for an arbitrary pile of
notes to be displayed, rather than just displaying the notes for a
single object (which it still can do).

As it stands, the notes are compiled locally from already retrieved
objects, but it would also be reasonable to add a middle-layer
function to do roughly the same thing.  Depending on how this is done
it could require a fair amount of logic duplication, so it might be
better done as part of a larger interface/back-end combined
refactoring.

This commit also tidies up a few other minor things in
manage_items.js, including adding automatic refresh when notes are
added/edited/deleted, and also removing a duplicate function.

Alerting the notes in the batch-receive interface is still TODO, but
should be fairly simple to add once this commit is in place.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoHave TPAC put user input at the end in all cases
Mike Rylander [Fri, 30 Aug 2013 15:22:27 +0000 (11:22 -0400)]
Have TPAC put user input at the end in all cases

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
6 years agoStream facet data
Mike Rylander [Wed, 28 Aug 2013 19:05:36 +0000 (15:05 -0400)]
Stream facet data

For certain shapes of facet datasets, the .atomic version of the
json_query call can produce an XMPP message large enough to cause
ejabberd to fall over unceremoniously.  Switch to a streaming
CStoreEditor-based call instead to avoid this.

Ideally, this would use message bundling (aka, chunking) as well,
but the C parts of OpenSRF don't seem to support that yet.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoMove list delete check from onclick to onsubmit
Dan Wells [Mon, 16 Sep 2013 20:50:53 +0000 (16:50 -0400)]
Move list delete check from onclick to onsubmit

Cause Brendan Eich says it's better :)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
6 years agoLP1164674 - OPAC - Too easy to delete a list
Kyle Tomita [Fri, 24 May 2013 18:52:49 +0000 (11:52 -0700)]
LP1164674 - OPAC - Too easy to delete a list

Added an onClick action to prompt for confirmation before
deleting a list.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoBrowse catalog shortcut links should clear the search query
Pasi Kallinen [Wed, 11 Sep 2013 08:46:07 +0000 (11:46 +0300)]
Browse catalog shortcut links should clear the search query

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years ago'Opportunistic' Acq In-process Copy Overlay
Dan Wells [Fri, 6 Sep 2013 20:36:47 +0000 (16:36 -0400)]
'Opportunistic' Acq In-process Copy Overlay

It is both normal and common to overlay brief acquisitions bib
records with more complete records, and it is simple to create
copies as part of the overlay process, but there is no *simple* way
to have the imported copies overlay the acq copies.

This code builds off the existing copy overlay code (which matches
and overlays using specified IDs), but uses broader matching criteria.
By selecting the new option, "Auto Overlay In-process Acquisitions
Copies", the system will potentially overlay copies which:
  * have associated lineitem details (that is, they were created
    by the acquisitions process), and
  * that lineitem detail has the same owning_lib as the incoming
    copy's owning_lib
  * the current copy associated with that lineitem detail is "In
    process"

Also, fix two small bugs, one which prevented overlay using the
'Available' status (change 'if $val' to 'if defined $val', since
'Available' is '0'), and another which prevented item overlay when
selecting the match record manually (as_imported was null in the DB).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping long overdue penalty upgrade script
Mike Rylander [Mon, 16 Sep 2013 16:47:46 +0000 (12:47 -0400)]
Stamping long overdue penalty upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP1210291 Long Overdue Standing Penalty
Bill Erickson [Thu, 8 Aug 2013 20:47:28 +0000 (16:47 -0400)]
LP1210291 Long Overdue Standing Penalty

Adds a new PATRON_EXCEEDS_LONGOVERDUE_COUNT patron standing penalty.
It behaves the same as the PATRON_EXCEEDS_LOST_COUNT penalty for
long-overdue circulations.

Release notes included.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts [resolved, normal seed data order stuff]:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAdd Finnish bib tooltips to marc editor.
Pasi Kallinen [Thu, 8 Aug 2013 07:41:39 +0000 (10:41 +0300)]
Add Finnish bib tooltips to marc editor.
Original translations from The Finnish National Library (http://www.kansalliskirjasto.fi/extra/marc21/)

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoTweaks to 'my lists' paging code
Dan Wells [Fri, 13 Sep 2013 16:59:59 +0000 (12:59 -0400)]
Tweaks to 'my lists' paging code

1) Don't set and refetch the 'my lists' settings if nothing changed.
(minor nit)

2) Get the count through the same code where we get the bookbag data.

For #2, I am concerned with the current duplication of logic. At best
we are doing things twice, and at worst we end up counting a set which
is slightly different than our actual bookbag search results.

In the updated code, I think the count accuracy is subject to
search/superpage limit settings, so lists are effectively limited by
the search settings. If that is a valid concern, we can beef up the
settings for this query.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1206649 un-cancel received lineitems / copies
Bill Erickson [Tue, 20 Aug 2013 13:33:49 +0000 (09:33 -0400)]
LP#1206649 un-cancel received lineitems / copies

Clear the cancel reason when a canceled lineitem is marked as received.
With items, clear the cancel reason and re-generate fund debits if they
were removed during cancelation (because the keep_debits flag in the
cancel reason was set to false).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoBilling UI style lost and longoverdue circulations
Bill Erickson [Wed, 14 Aug 2013 13:44:45 +0000 (09:44 -0400)]
Billing UI style lost and longoverdue circulations

When a LOST or LONGOVERDUE circulation, which has not yet been returned,
appears in the patron's list of billed transactions, style them
differently from other not-yet-returned items.

Similar to regular not-yet-returned items, display a helpful message to
staff indicating what colors map to what types of circulations.

The default colors are maroon for LOST and organge for LONGOVERDUE.

To change the colors, a change to circ.css (for the style) and lang.dtd
(for the hint) are required.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoInter-authority linking script
Lebbeous Fogle-Weekley [Thu, 22 Aug 2013 21:19:52 +0000 (17:19 -0400)]
Inter-authority linking script

Modeled after authority_control_fields.pl.in, but different.  The script
has POD which you can consult for more information.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade for 'my list' lists-per-page
Dan Wells [Fri, 13 Sep 2013 20:35:31 +0000 (16:35 -0400)]
Stamping upgrade for 'my list' lists-per-page

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTrivial changes to configurable bookbag paging
Dan Wells [Fri, 13 Sep 2013 20:30:55 +0000 (16:30 -0400)]
Trivial changes to configurable bookbag paging

1) use class for highlight styling of current page
2) correct minor logic error ('<=' should be '<')

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1164197 - Add page number navigation to my lists and setting for number of lists...
Kyle Tomita [Thu, 4 Apr 2013 00:07:51 +0000 (17:07 -0700)]
LP1164197 - Add page number navigation to my lists and setting for number of lists per page

Added a user setting for the number of lists per page.
Added code for page number navigation.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTrivial changes to 'my list' paging code
Dan Wells [Fri, 13 Sep 2013 16:41:11 +0000 (12:41 -0400)]
Trivial changes to 'my list' paging code

1) Remove unneeded comment
2) un-CamelCase variables
3) Add 'my list' paginator selection to stylesheet

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoStamping upgrade for 'my list' items per page
Dan Wells [Fri, 13 Sep 2013 18:34:11 +0000 (14:34 -0400)]
Stamping upgrade for 'my list' items per page

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1160596 - Add pagination for items in My Lists
Kyle Tomita [Wed, 3 Apr 2013 21:37:41 +0000 (14:37 -0700)]
LP1160596 - Add pagination for items in My Lists

Added pagination with page numbers when viewing the items in
a list.  Also made the number of list items per page a user
setting, per the suggestions of Pasi Kallinen and Jason
Stephenson.

The setting is located in, Account Preferences -> My Lists Preferences

Update: Added i18n part to allow for translation.  Removed hard-coded
bre.source.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFix PCrudFilterPane generating illegal queries when using the "not like" and "not...
Pasi Kallinen [Thu, 29 Aug 2013 14:36:37 +0000 (17:36 +0300)]
Fix PCrudFilterPane generating illegal queries when using the "not like" and "not between" operators.

Make the window remember the user-input value even when changing the operator.

[LFW: whitespace fixes - the original commit had real tabs, which we avoid
in some files, including .js ones.]

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoLP#856688 OUS to disable org unit as hold pickup lib
Bill Erickson [Fri, 30 Aug 2013 20:49:58 +0000 (16:49 -0400)]
LP#856688 OUS to disable org unit as hold pickup lib

YAOUS that removes an org unit from consideration as a hold pickup
library.  This setting only affects the OPAC display and does not
otherwise affect the display of the org unit in the OPAC.  (In other
words, it's not the same thing as actor.org_unit.opac_visible).  It also
has no affect on hold targeting / capturing.

[LFW: Numbered upgrade script.]

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoAllow translation of acq.cancel_reason texts.
Pasi Kallinen [Tue, 11 Jun 2013 06:57:19 +0000 (09:57 +0300)]
Allow translation of acq.cancel_reason texts.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoStamping upgrade script for repeatable events
Mike Rylander [Thu, 12 Sep 2013 17:58:14 +0000 (13:58 -0400)]
Stamping upgrade script for repeatable events

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoRelease notes for Action Trigger Event Repeatability
Remington Steed [Thu, 5 Sep 2013 20:48:38 +0000 (16:48 -0400)]
Release notes for Action Trigger Event Repeatability

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAllow action trigger events to be repeated
Remington Steed [Mon, 5 Aug 2013 13:57:04 +0000 (09:57 -0400)]
Allow action trigger events to be repeated

Currently, there is no way to repeat an event (action/trigger) when a
real-world event occurs more than once for the same target. This only
matters for targets that are persistent (such as a library card)
combined with events that can reoccur (such as expiration, if the
expiration can be removed). To address this, we add a new field to the
action_trigger.event_definition table that sets the amount of time
after which the event is allowed to repeat.

This commit adds the new field to the IDL, database schema and template
files and also provides the simple db upgrade script. It is worth noting
that we chose to base the repeatability on the start_time of the previous
event, which is more predictable than complete_time (which could be null
if the event fails).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping P.V. SUPA upgrade scripts
Mike Rylander [Thu, 12 Sep 2013 17:48:47 +0000 (13:48 -0400)]
Stamping P.V. SUPA upgrade scripts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoP.V. SUPA GoodStuff integration
Jason Etheridge [Wed, 12 Dec 2012 01:02:38 +0000 (20:02 -0500)]
P.V. SUPA GoodStuff integration

This impliments a "Server Add-ons" module for integrating P.V. Supa's RFID
product known as GoodStuff with the Evergreen staff client.

To activate it, you should add the identifier "pv_supa_goodstuff" (without the
quotes) to the list managed by the Admin->Workstation Administration->Server
Add-ons menu action within the staff client.  You will need the
ADMIN_SERVER_ADDON_FOR_WORKSTATION permission to do this.

After doing this and clicking the Update Active Add-Ons button, the interface
will refresh and show a GoodStuff tab in the Add-on Preferences section.  Within
this tab you will have the option of specifying the hostname and port for the
GoodStuff hardware. There is also an "Enabled" setting that needs to be checked.

Currently three interfaces have been integrated:
* Circulation -> Check In Items
* Circulation -> Check Out Items (where you scan the patron barcode)
* Circulation -> Check Out Items (where you scan the item barcodes)

Each interface gets an RFID checkbox if the "Enabled" preference has been set,
that can activate/deactivate the functionality on a per interface basis.  The
checkbox states persist (i.e. are sticky).

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoJSAN module autoloader for "add-ons"
Jason Etheridge [Fri, 21 Dec 2012 05:19:37 +0000 (00:19 -0500)]
JSAN module autoloader for "add-ons"

This adds a "Server Add-ons" menu entry under Admin -> Workstation
Administration in the staff client.  Choosing this allows you to edit or set a
list of identifiers that correspond to JSAN-style modules found in
/server/addons/, and is meant mainly for activating 3rd party modules within the
staff client on a per-workstation basis.  You need the
ADMIN_SERVER_ADDON_FOR_WORKSTATION permission to use it.

Configuration options for activated add-ons may also show up in this interface.

More technical details:

This Server Add-ons list is stored as a JSON array in the Mozilla preference
'oils.addon.autoload.list'.

We also add an addon.autoloader module that gets called in most XUL interfaces
via the util_overlay file.  This autoloader will loop through the modules
specified in 'oils.addon.autoload.list' and instantiate each, storing a
reference to each of the newly created objects in a data structure in
window.oils_autoloaded.

So, as an example, let's say there is a module: /xul/server/addon/uber_scan.js
And we have the identifier 'uber_scan' in our Server Add-ons list.  Then, on
every page load of a XUL interface using the stock util overlay, we will
effectively call:

    new addon.uber_scan();

Causing the code in the module to execute.  It is up to the module to determine
whether it needs to do anything within a given interface.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Conflicts [permission numbering]:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

6 years agointernal: JSAN socket library
Jason Etheridge [Mon, 10 Dec 2012 11:30:33 +0000 (06:30 -0500)]
internal: JSAN socket library

Leverages Mozilla's nsISocketTransportService, nsIScriptableInputStream, and
nsIInputStreamPump XPCOM, and the NetUtils javascript module.

    Usage example:

    Install netcat on a server and as root do:  nc -l -p 5000

    Then, in the staff client, load Admin -> For Developers -> Javascript Shell

    Enter:

    JSAN.use('util.socket');
    var s = new util.socket('server hostname or IP address here', 5000);
    s.write('hello\n');

    On the server, reply with world<enter>

    Back in the javascript shell, use

    s.read();

This is geared to help with implementing future functionality, but shouldn't
result in any end-user visible changes by itself.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agointernal: an alternative to default_focus
Jason Etheridge [Thu, 20 Dec 2012 22:17:24 +0000 (17:17 -0500)]
internal: an alternative to default_focus

Interfaces can now set event listeners on their window for 'tab_focus' instead
of defining a single default_focus function.

We also include a change to browser.js so that embedded interfaces also get
their default_focus function called (and a tab_focus event sent).

This is geared to help future functionality, but shouldn't produce any end-user
visible changes by itself.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agointernal: default_focus not called
Jason Etheridge [Thu, 20 Dec 2012 21:10:57 +0000 (16:10 -0500)]
internal: default_focus not called

Minor bug. Was being called in an else clause dependent on some help context
logic for new tabs, but should be called for every new tab. Shouldn't result
in any end-user visible change, but if interfaces wrapped in browser.js were
to have a default_focus function, then this could come into play.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agointernal: allow checkout ui to set statusbar
Jason Etheridge [Wed, 26 Dec 2012 11:33:47 +0000 (06:33 -0500)]
internal: allow checkout ui to set statusbar

Minor bug fix and geared toward future functionality

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoOptimize container filters in QueryParser
Mike Rylander [Thu, 12 Sep 2013 17:13:23 +0000 (13:13 -0400)]
Optimize container filters in QueryParser

When a container filter is used at the top level of a QueryParser
query (that is, in a simple query with no OR-logic branches or explicit
nesting groups) we can use an INNER join instead of LEFT + IS NOT NULL.

On some production datasets this showed an increase in performance from
20+ seconds to 1ms for the core query.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoLP#1084758 store staff client tpac (etc) zoom pref
Bill Erickson [Wed, 11 Sep 2013 17:49:07 +0000 (13:49 -0400)]
LP#1084758 store staff client tpac (etc) zoom pref

Staff client pages loaded via browser.xul which have a name (via
internal XUL URL param) now have the ability to store and load a per-
page zoom value preference.  This includes (at minimum) the embedded
TPAC.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAdd Zoom support to browser views
Thomas Berezansky [Tue, 8 May 2012 14:56:08 +0000 (10:56 -0400)]
Add Zoom support to browser views

Currently tied to CTRL with +/-/0 like Firefox uses.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP1193095 lineitem batch actions sanity filters
Bill Erickson [Thu, 20 Jun 2013 19:46:33 +0000 (15:46 -0400)]
LP1193095 lineitem batch actions sanity filters

Avoid applying the following actions to lineitems which are in a state
where each action makes no sense.

The following actions are affected.  For each, the set of states for
which a lineitem must be in for the action to proceed is listed.

create PO
    - new selector-ready order-ready approved
add to PO
    - new selector-ready order-ready approved
create invoice
    - !cancelled
add to invoice
    - !cancelled
cancel lineitem
    - !cancelled
mark selector ready
    - new
mark order ready
    - new selector-ready
mark received
    - pending-order on-order

Depending on the interface, some top-level lineitem actions may be
globally disabled.  The list of states listed above represent the bare
minimum requirements.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1220387 silence deprecation warning in Normalizer
Bill Erickson [Tue, 3 Sep 2013 20:15:21 +0000 (16:15 -0400)]
LP#1220387 silence deprecation warning in Normalizer

Avoid the following error:

UNIVERSAL->import is deprecated and will be removed in a future perl at
Open-ILS/src/perlmods/lib/OpenILS/Utils/Normalize.pm line 6

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoStamping upgrade script for biblio A/T title variable fix
Ben Shum [Sat, 7 Sep 2013 03:20:16 +0000 (23:20 -0400)]
Stamping upgrade script for biblio A/T title variable fix

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoreset title variable when looping with biblio A/T
Jason Etheridge [Thu, 8 Nov 2012 16:27:13 +0000 (11:27 -0500)]
reset title variable when looping with biblio A/T

Two templates that I'm concerned with, though there may be others that could use
this treatment: biblio.record_entry.email and biblio.record_entry.print

Basically, they can group events from the same user and consolidate bibs, but as
they loop through the bibs they're not clearing the temporary variable that
contains the bib title, so we get duplicated and run-on titles in the output.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

6 years agoLP1183553 (continued) - Fix applied filters
Pasi Kallinen [Thu, 23 May 2013 20:24:04 +0000 (13:24 -0700)]
LP1183553 (continued) - Fix applied filters

The filter dialog kept the previous filter around and then joined the
new one with it. This repairs that issue and applies the new filter
options on subsequent loading.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP1183553 - Default filter option for configuration screens
Steven Chan [Thu, 23 May 2013 20:24:04 +0000 (13:24 -0700)]
LP1183553 - Default filter option for configuration screens

In the staff client, the AutoGrid widget is used to render configuration
lists, and by default, the setting 'showLoadFilter' is turned off.  It
seems more useful to turn it on by default so that any configuration
screen can use it unless its template sets it off.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoThe ILS User reports source branches to an All Hold Requests linked source
Chris Sharp [Mon, 19 Aug 2013 18:29:23 +0000 (14:29 -0400)]
The ILS User reports source branches to an All Hold Requests linked source
that was marked class="circ" instead of class="ahr".  This corrects that problem.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFix some bad break syntax
Ben Shum [Thu, 29 Aug 2013 18:58:20 +0000 (14:58 -0400)]
Fix some bad break syntax

Change </br> to a more appropriate <br/>

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years ago.gitignore installed files more generically
Bill Erickson [Tue, 3 Sep 2013 15:10:12 +0000 (11:10 -0400)]
.gitignore installed files more generically

Avoid naming specific versions to ignore when possible.

* Ignore any files in root directory (Evergreen/) that match js
  or JavaScript (from the installer).
* Ignore all xulrunner*.bz2 and xulrunner*.zip

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoAdd xulrunner 14, built libmar tools, and some javascript files to .gitignore
Ben Shum [Thu, 22 Aug 2013 17:56:25 +0000 (13:56 -0400)]
Add xulrunner 14, built libmar tools, and some javascript files to .gitignore

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoAdd some 'make check' objects to .gitignore
Bill Erickson [Thu, 22 Aug 2013 16:36:17 +0000 (12:36 -0400)]
Add some 'make check' objects to .gitignore

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd more built things to .gitignore for master
Lebbeous Fogle-Weekley [Thu, 22 Aug 2013 16:29:51 +0000 (12:29 -0400)]
Add more built things to .gitignore for master

Tired of seeing all this meaningless red from `git status`

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoUnify appellee/appellant relators
Pasi Kallinen [Wed, 4 Sep 2013 06:07:47 +0000 (09:07 +0300)]
Unify appellee/appellant relators

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoadd src/Pg/live_t/
Jason Etheridge [Tue, 3 Sep 2013 18:30:22 +0000 (14:30 -0400)]
add src/Pg/live_t/

for tests that assume stock test data

Moving 0824.item_import_defaults.pg from t/ to live_t/

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
6 years agoPgTAP tests for 0824
Mike Rylander [Tue, 3 Sep 2013 15:45:25 +0000 (11:45 -0400)]
PgTAP tests for 0824

As promised at the August 2013 dev meeting, I'll be adding PgTAP tests
for any database work that I create, and where possible for any that
I commit for others.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade script for Vandelay item import defaults
Mike Rylander [Fri, 30 Aug 2013 13:32:02 +0000 (09:32 -0400)]
Stamping upgrade script for Vandelay item import defaults

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP1209291 vandelay item defaults release notes
Bill Erickson [Thu, 8 Aug 2013 13:16:19 +0000 (09:16 -0400)]
LP1209291 vandelay item defaults release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoLP1209291 vandelay item import defaults
Bill Erickson [Wed, 7 Aug 2013 16:05:30 +0000 (12:05 -0400)]
LP1209291 vandelay item import defaults

Via org settings, support auto-generation of call numbers and barcodes
for items imported via Vandelay's Item Import interface.  Support
settings for applying a local prefix string to auto-generated call
numbers and barcodes.  For both, the prefix defaults to "VAN".

Similarly, support default copy location and circ modifiers.

The new org unit settings:

vandelay.item.barcode.auto
vandelay.item.barcode.prefix
vandelay.item.call_number.auto
vandelay.item.call_number.prefix
vandelay.item.copy_location.default
vandelay.item.circ_modifier.default

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoSave times in HH:MM format for hours of operation
Pasi Kallinen [Wed, 17 Jul 2013 16:07:45 +0000 (19:07 +0300)]
Save times in HH:MM format for hours of operation

When editing Hours of Operation, save the times in HH:MM format,
as that is what the database wants.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFixing LP 1203796.
Chris Sharp [Mon, 22 Jul 2013 16:35:46 +0000 (12:35 -0400)]
Fixing LP 1203796.

The alternate view in the Item Status screen shows a "Total Circs"
field that was under-counting circulations because UNION filtered
out duplicates.  This commit replaces UNION with UNION ALL, which
allows duplicate rows.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoSchema.org authors: relate properties to the right context
Dan Scott [Sun, 25 Aug 2013 04:41:37 +0000 (00:41 -0400)]
Schema.org authors: relate properties to the right context

While the approach of using the existing <a href> to launch a new search
based on the author name was workable, it may have been confusing for
schema.org processors such as Google Rich Snippets who expected that URI
to identify a resource for the author, not a set of search results.

Using @resource / @about attribute pairing, and wrapping the whole type
in an extra <span> element, enables us to avoid associating the
properties within the <a href> with the implicitly chained type.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoSchema.org: relate offers to record explicitly
Dan Scott [Thu, 22 Aug 2013 22:30:34 +0000 (18:30 -0400)]
Schema.org: relate offers to record explicitly

Although schema.org defines the nested child elements as implicit
relationships that should be good enough for the Offer-to-Product
relationship, defining that relationship explicitly can't hurt.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoMap the bound-with relationship in schema.org
Dan Scott [Tue, 20 Aug 2013 16:45:44 +0000 (12:45 -0400)]
Map the bound-with relationship in schema.org

We don't know what type the target record is, so fall back to Product
and just point at it. At least this way schema.org processors will know
that the target bib is related to the current bib.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd structured data for holdings via http://schema.org/Offer
Dan Scott [Sun, 25 Aug 2013 04:40:46 +0000 (00:40 -0400)]
Add structured data for holdings via schema.org/Offer

Map library name to Offer/seller, shelving location to
Offer/availableAtOrFrom, call number to Offer/sku, barcode to
Offer/serialNumber, copy status to Offer/availability, and ISBN-13 to
gtin13. Use the additionalType of Product to give these offers an
obvious relationship.

Surface copy counts as AggregateOffer instances.

Cut over to RDFa Lite instead of microdata for schema.org, as RDFa Lite
is more easily extensible with other vocabularies, and is as accepted as
microdata by schema.org processors.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoSchema.org: improve MusicGroup vs. Person parsing
Dan Scott [Sun, 25 Aug 2013 04:39:46 +0000 (00:39 -0400)]
Schema.org: improve MusicGroup vs. Person parsing

Take a stricter approach to defining MusicGroups instead of Persons for
the main authors of MusicAlbums. Music groups are generally catalogued
as a 110 or 710 tag, and this avoids defining birthDates and deathDates
for groups (which, however valid that might be in the real world, is not
valid for schema.org).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoStamping upgrade for patron self-reg
Dan Wells [Fri, 23 Aug 2013 23:33:58 +0000 (19:33 -0400)]
Stamping upgrade for patron self-reg

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTrivial changes
Dan Wells [Fri, 23 Aug 2013 23:25:06 +0000 (19:25 -0400)]
Trivial changes

-Fix (conform) whitespace in IDL
-Fix "county" typo in settings label
-Restore mysteriously absent "Bottom Link 2" :)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 Patron Self-Register Release Notes
Bill Erickson [Tue, 6 Aug 2013 16:08:00 +0000 (12:08 -0400)]
LP1207396 Patron Self-Register Release Notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 pending patron reg show requestor
Bill Erickson [Tue, 6 Aug 2013 17:52:24 +0000 (13:52 -0400)]
LP1207396 pending patron reg show requestor

Show a link to the requesting user, when present, for pending patrons in
the staff client patron registration form.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 TPAC org_selector supports org filter
Bill Erickson [Tue, 6 Aug 2013 13:31:11 +0000 (09:31 -0400)]
LP1207396 TPAC org_selector supports org filter

When building and org unit selector via the build_org_selector MARCO,
the caller can now pass in a "valid_org_list" array which contains org
unit IDs.  When such a list is provided, any org units in the selector
which are not in the list are marke as disabled.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 Patron self-registration web form
Bill Erickson [Thu, 1 Aug 2013 20:52:18 +0000 (16:52 -0400)]
LP1207396 Patron self-registration web form

Web form for allowing patrons to submit thier own library registration
requests.  The form collects various bits of user data and creates a
pending user account, which has no privileges.  These pending accounts
must be approved and completed by staff from the staff client "Pending
Patrons" action in the Cirulation menu.

Control of whether to show a field, treat a field as required, show
example text, and validate the field format is managed with existing org
unit settings.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 user stage allows username selection
Bill Erickson [Tue, 6 Aug 2013 14:10:19 +0000 (10:10 -0400)]
LP1207396 user stage allows username selection

The caller may now pass a value for username.  If unset, it still falls
back to using a uuid.  If the username clashes with an existing staged
username, a USERNAME_EXISTS event is returned.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 purge old pending users
Bill Erickson [Tue, 6 Aug 2013 15:09:45 +0000 (11:09 -0400)]
LP1207396 purge old pending users

Script to delete pending user accounts based on the interval defined in
the opac.pending_user_expire_interval org unit setting.

Add /openils/bin/purge_pending_users.srfsh to opensrf's CRON.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1207396 DB / IDL for patron self-reg
Bill Erickson [Thu, 1 Aug 2013 17:30:52 +0000 (13:30 -0400)]
LP1207396 DB / IDL for patron self-reg

Updating pending addr tables to track requesting user and address county.

Adding org settings:

* opac.allow_pending_user -- allow self-registration
* opac.pending_user_expire_interval - delete pending user interval
* ui.patron.edit.aua.county.require - indicate if county is required

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1182519 Stamping DB upgrade 0822 user/berick/lp1182519-hold-behind-desk-staging
Bill Erickson [Fri, 23 Aug 2013 14:35:12 +0000 (10:35 -0400)]
LP#1182519 Stamping DB upgrade 0822

Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoLP1182519 Per-Hold Behind Desk Value
Bill Erickson [Tue, 21 May 2013 15:59:36 +0000 (11:59 -0400)]
LP1182519 Per-Hold Behind Desk Value

The true/false value for behind_desk is now stored directly on the hold
object for more accurate tracking of the location of captured holds.
If configured, patrons can now set their preferred value for behind the
desk holds.

 * DB/IDL changes to support the new column
 * API support for loading the setting from the patron for cases when no
   value is provided by the caller.
 * Staff client grid column definition for the Behind Desk field
 * Hold counts in the staff client now show total, available, and
   behind-desk (at the workstation).
 * Printed hold receipt now uses the behind_desk value on the hold to
   decide if a hold is behind the desk.
 * Release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm

Resolved 2 conflicts in Actor.pm sub hold_request_count
Retained the parameters as:
  my( $self, $client, $authtoken, $user_id, $ctx_org) = @;

And retained:

my @ready = grep { .... } @$holds code.

Signed-off-by: Garry Collum <gcollum@gmail.com>
6 years agoAdd placeholder file for 0821 upgrade script
Ben Shum [Thu, 22 Aug 2013 16:16:39 +0000 (12:16 -0400)]
Add placeholder file for 0821 upgrade script

0821 was added as a backport fix for 2.3 and 2.4, but not master.

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoCorrectly mark nested INNER joins as such
Mike Rylander [Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)]
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoFix A/T object cache
Thomas Berezansky [Thu, 1 Nov 2012 13:08:38 +0000 (09:08 -0400)]
Fix A/T object cache

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP1183467 ACQ view funding source list permissions
Bill Erickson [Thu, 23 May 2013 17:30:43 +0000 (13:30 -0400)]
LP1183467 ACQ view funding source list permissions

Limit the set of funding sources visible in the funding source list
interface by those the user has view permissions for, not just those the
user has edit permissions for.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade script for series title normalizer improvement
Mike Rylander [Thu, 22 Aug 2013 15:26:20 +0000 (11:26 -0400)]
Stamping upgrade script for series title normalizer improvement

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoRemove [ and ] characters from seriestitle index LP#1187521
Steven Callender [Tue, 4 Jun 2013 18:11:50 +0000 (14:11 -0400)]
Remove [ and ] characters from seriestitle index LP#1187521

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoRepair remaining Authority Fixed Field editor entries
Mike Rylander [Fri, 12 Jul 2013 18:43:57 +0000 (14:43 -0400)]
Repair remaining Authority Fixed Field editor entries

The "Item" fixed field is only valid for MFHD records, so we remove
that entirely from AUTH records.  The "GeoSubd" fixed field is
spelled "GeoDiv" everywhere, so we align that naming so that it can
be saved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoPropagating 2.3.10 DB upgrade script
Bill Erickson [Thu, 22 Aug 2013 14:24:57 +0000 (10:24 -0400)]
Propagating 2.3.10 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoRemove JSPAC-oriented PasswordReset.pm interface
Dan Scott [Thu, 11 Jul 2013 17:04:53 +0000 (13:04 -0400)]
Remove JSPAC-oriented PasswordReset.pm interface

A native TPAC interface for resetting passwords arrived some time ago,
and the i18n for PasswordReset.pm predated the more standardized
approach taken by TPAC. So... kill the JSPAC interface and save
ourselves a little bit of Apache overhead in the process.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoAcq: Honor new dist forumula fields in old method of applying formulae
Lebbeous Fogle-Weekley [Tue, 2 Jul 2013 19:27:39 +0000 (15:27 -0400)]
Acq: Honor new dist forumula fields in old method of applying formulae

The batch updater came with new fields on distribution formulae, but we
didn't teach the pre-existing code for applying formulae from the
lineitem copies interface to apply values from the new fields.

Reported by Jennifer Pringle in Launchpad bug report #1195521.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agosilence some unitialized warnings
Jason Etheridge [Thu, 1 Aug 2013 16:34:21 +0000 (12:34 -0400)]
silence some unitialized warnings

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoInvoke skull-and-crossbones popup in batch receive for server-side errors
Lebbeous Fogle-Weekley [Mon, 23 Jan 2012 23:44:00 +0000 (18:44 -0500)]
Invoke skull-and-crossbones popup in batch receive for server-side errors

And introduce a minor bumper rail to guide serials users who might try
to hand-edit a holding code.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
    Open-ILS/xul/staff_client/server/serial/batch_receive.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoMake C unit tests more robust
Dan Scott [Wed, 21 Aug 2013 15:57:40 +0000 (11:57 -0400)]
Make C unit tests more robust

Adding -I@abs_top_srcdir@/Open-ILS/include will pull in the source tree
header files, so that the C unit tests can run before Evergreen has been
installed (and thus will be a valid test of the source header files
instead of relying on the installed versions that might be different).

Build c-apps before recursing into c-apps/tests:
This ensures that the required libraries are built before the C unit
tests are built, thus preventing "make check" on a just-configured
source tree from failing due to missing dependencies.

Also, link to the source tree directories first rather than last, to
ensure that we pull in the correct source (if possible). And remove the
cargo-cultish $(TMP) linking/including.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
6 years agoMove HTML tags out of translatable strings in toolkit templates.
Pasi Kallinen [Mon, 10 Jun 2013 05:42:18 +0000 (08:42 +0300)]
Move HTML tags out of translatable strings in toolkit templates.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoCopying 2.3.8-2.3.9 SQL upgrade script
Bill Erickson [Wed, 21 Aug 2013 13:51:10 +0000 (09:51 -0400)]
Copying 2.3.8-2.3.9 SQL upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoAcq general search: improve searching for negative comparisons
Lebbeous Fogle-Weekley [Wed, 19 Sep 2012 19:27:03 +0000 (15:27 -0400)]
Acq general search: improve searching for negative comparisons

This aims to address Launchpad bug #1031535.  I think the bug only
really shows up when searches involve invoices either as the core type
or with filter fields.  If a search doesn't involve invoices, the
problematic joins aren't present.

Could use more testing though.  Seems to make the problem go away, and
other basic searches seem to work, but I certainly haven't tested
everything.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoMove exchange_rate seed data to 950 file
Dan Wells [Fri, 12 Jul 2013 21:20:07 +0000 (17:20 -0400)]
Move exchange_rate seed data to 950 file

Since currency_type is a foreign key of acq.exchange_rate, if we move
currency_type to the seed data file, exchange rate must follow.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoMove acq.currency_code entries and wrap for i18n
Pasi Kallinen [Tue, 11 Jun 2013 08:53:42 +0000 (11:53 +0300)]
Move acq.currency_code entries and wrap for i18n

Fix LP#1107834 by moving the acq.currency_code entries into
950.data.seed-values.sql and wrapping the texts with oils_i18n_gettext.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFedora: remove source installs for packaged dependencies
Dan Scott [Tue, 20 Aug 2013 17:02:23 +0000 (13:02 -0400)]
Fedora: remove source installs for packaged dependencies

The Perl MARC packages, Library::CallNumber::LC, and libdbi / libdbd
drivers have been available as packages on Fedora since Fedora 18 (which
is now the oldest supported Fedora version), so don't install these from
source.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoLP 1190279 Modularize Makefile.install fedora target
Bill Erickson [Mon, 19 Aug 2013 15:23:14 +0000 (11:23 -0400)]
LP 1190279 Modularize Makefile.install fedora target

make -f Makefile.install fedora

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>