4 years agoLP#1378575: teach action::hold_request about behind_desk
Galen Charlton [Tue, 7 Oct 2014 23:42:18 +0000 (16:42 -0700)]
LP#1378575: teach action::hold_request about behind_desk

This patch teaches the CDBI class for the action.hold_request
table about the newish behind_desk column, preventing errors
like this from being thrown if a recent OpenSRF version is in

Processing of hold failed:  Can't locate object method "behind_desk"
via package "action::hold_request" at /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/ line 181.

Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
4 years agoLP#1314827: On login, don't allow referer-based redirect to external site
Jeff Davis [Fri, 16 May 2014 22:14:43 +0000 (15:14 -0700)]
LP#1314827: On login, don't allow referer-based redirect to external site

On /eg/opac/login, if no redirect_to param is provided, the TPAC will
attempt to use the referer (if any) as the redirect destination. This
leads to undesirable behavior if the referring URL is from an external

Signed-off-by: Jeff Davis <>
Signed-off-by: Ben Shum <>
4 years agoDocumentation bug: corrected image file
Angela Kilsdonk [Thu, 2 Oct 2014 15:41:35 +0000 (10:41 -0500)]
Documentation bug: corrected image file

Signed-off-by: Angela Kilsdonk <>
4 years agoWhitespace and non-weird emdash in docs
Dan Scott [Wed, 1 Oct 2014 19:37:08 +0000 (15:37 -0400)]
Whitespace and non-weird emdash in docs

Signed-off-by: Dan Scott <>
4 years agoDocs: Change all internal links to correct format
Josh Stompro [Mon, 15 Sep 2014 01:08:40 +0000 (20:08 -0500)]
Docs: Change all internal links to correct format

Resolves LP#1294347

I just deleted one link since I couldn't find any trace of where it was intended to go.

"or use the link:federated.txt[View/Place Orders] menu item in the catalog."

If anyone ever finds where that is supposed to go, let me know and I'll fix it.

Signed-off-by: Josh Stompro <>
Signed-off-by: Remington Steed <>
4 years agoLP#1347774 CStoreEditor anonymous PCRUD additions
Bill Erickson [Fri, 1 Aug 2014 17:29:41 +0000 (13:29 -0400)]
LP#1347774 CStoreEditor anonymous PCRUD additions

* Exporter repairs : use export_to_level
* pcrud personality call argument mod repair
* log pcrud personality json_query attempts loudly to ease transition
* CStoreEditor anon/pcrud personality live test

* CStoreEditor anon pcrud default to undef authtoken:
The presence of an authtoken ("ANONYMOUS") in the editor can be
misleading at higher levels of the code, since it implies a
presumably functional authtoken has been provided somewhow.
Apply ANONYMOUS only as needed to API calls instead.

Signed-off-by: Bill Erickson <>
Signed-off-by: Mike Rylander <>
4 years agoLP#1347774 Anonymous PCRUD mode
Mike Rylander [Thu, 24 Jul 2014 19:03:37 +0000 (15:03 -0400)]
LP#1347774 Anonymous PCRUD mode

Support for anonymous access to public (field_safe=true) IDL data
via PCRUD without requiring an authtoken.  To use, pass an authtoken of

Includes initial CStoreEditor plugin for anon pcrud.

Signed-off-by: Mike Rylander <>
Signed-off-by: Bill Erickson <>
4 years agoLP#1373693: Speed up call number browse search at top level org.
Chris Sharp [Thu, 25 Sep 2014 15:45:44 +0000 (11:45 -0400)]
LP#1373693: Speed up call number browse search at top level org.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
5 years agoDocs: Removed redundant phrase as mentioned in bug #1294299
Snigdha Dagar [Thu, 25 Sep 2014 03:02:54 +0000 (23:02 -0400)]
Docs: Removed redundant phrase as mentioned in bug #1294299

Signed-off-by: Yamil Suarez <>
5 years agoDocs: Updated 2 links that pointed to the old subversion repository
Snigdha Dagar [Thu, 25 Sep 2014 02:42:35 +0000 (22:42 -0400)]
Docs: Updated 2 links that pointed to the old subversion repository

Signed-off-by: Yamil Suarez <>
5 years agoDocs: Removed a redundant phrase as mentioned in bug #1294299
Snigdha Dagar [Thu, 25 Sep 2014 02:26:55 +0000 (22:26 -0400)]
Docs: Removed a redundant phrase as mentioned in bug #1294299

Signed-off-by: Yamil Suarez <>
5 years agoTidy search section of Using the OPAC
Dan Scott [Wed, 24 Sep 2014 03:29:42 +0000 (23:29 -0400)]
Tidy search section of Using the OPAC

Primarily focused on restructuring the information around Boolean
searching, particularly as I find librarians want to know what the
Boolean operators are that they should use. However, cleaned up some
typos and formatting along the way.

Signed-off-by: Dan Scott <>
5 years agoDocs: for new "Imported As" column in Vandelay queue results view
Yamil Suarez [Fri, 19 Sep 2014 18:56:47 +0000 (14:56 -0400)]
Docs: for new "Imported As" column in Vandelay queue results view

Added explanation of the new "Imported As" menu in "MARC Batch Import/Export"
queue results view, also updated screenshots.

Thanks to Joan Kranich of C/W MARS, for helping research were to make these

Signed-off-by: Yamil Suarez <>
5 years agoSmall typo fix for Blu-Ray spelling
Kathy Lussier [Fri, 19 Sep 2014 16:07:11 +0000 (12:07 -0400)]
Small typo fix for Blu-Ray spelling

Signed-off-by: Kathy Lussier <>
5 years agoUpdated formats
Snigdha Dagar [Thu, 18 Sep 2014 16:27:13 +0000 (21:57 +0530)]
Updated formats

Updated the formats under basic search according to version 2.6

Signed-off-by: Kathy Lussier <>
5 years agoUpdate core committer information on the staff client's About Page
Ben Shum [Thu, 11 Sep 2014 21:42:26 +0000 (17:42 -0400)]
Update core committer information on the staff client's About Page

senator has not contributed anything new for the past six months and is
therefore moved to the "Past Core Committer" listing per policies on:

berick belongs to a new organization and this has been updated accordingly.

Signed-off-by: Ben Shum <>
5 years agoLP#1234927: Pluralizing link names to follow convention.
Chris Sharp [Thu, 18 Sep 2014 16:49:45 +0000 (12:49 -0400)]
LP#1234927: Pluralizing link names to follow convention.

Based on feedback from Mike Rylander on the Launchpad ticket.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
5 years agoLP#1234927 Reporter needs Item -> Combined Aged and Active Circulations link
Chris Sharp [Thu, 18 Sep 2014 14:16:20 +0000 (10:16 -0400)]
LP#1234927 Reporter needs Item -> Combined Aged and Active Circulations link

There is a need for item usage statistics that include more than just active
circulations.  I have included links to both Aged (patronless) Circulations
and to Combined Aged and Active Circulations sources.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
5 years agoLP#1371173: Reporter: Classic Item List needs link to Item source
Chris Sharp [Thu, 18 Sep 2014 15:08:18 +0000 (11:08 -0400)]
LP#1371173: Reporter: Classic Item List needs link to Item source

Add a link on the reporter.classic_item_list fieldmapper definition
to asset.copy.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
5 years agoMore additions to 2.7 Release Notes (part 2)
Ben Shum [Fri, 19 Sep 2014 00:39:05 +0000 (20:39 -0400)]
More additions to 2.7 Release Notes (part 2)

Add Steve Callender and move Yamil Suarez to the correct position alphabetically.

Also, note the location of the web client README.install file, but also
promise to update this by the next minor release of 2.7 series as a new
section of the primary README file.

Signed-off-by: Ben Shum <>
5 years agoMore additions to 2.7 Release Notes
Kathy Lussier [Thu, 11 Sep 2014 17:10:21 +0000 (13:10 -0400)]
More additions to 2.7 Release Notes

Additions include a brief description of the web client preview, the
addition of Sprint 1 funding partners in the acknowledgements section,
the addition of NC Cardinal in the acknolwedgements section for
funding an acq funds transfer fix, and the addition of another code
contributor whose patch was just merged over the past few days.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agolp1271198 Strip browse and facet parameters from links
Kathy Lussier [Tue, 26 Aug 2014 19:49:45 +0000 (15:49 -0400)]
lp1271198 Strip browse and facet parameters from links

Browse and facet parameters were sticking to links to author, subject and
series links on record and result pages, as well as some other links where
the search parameters were no longer necessary. This commit:

1. Adds browse_search_parms and facet_search_parms to header.tt2 as new
classes of search parameters that one may want to remove.

2. Removes these parameters from the author and subject links on the
record page. It also uses the same method for removing search parameters
from the author link on the search results page and on the searchbar
Browse link.

3. Fixes an issue where the advanced search links were inadvertently
stripping general search parameters.

4. Adds more parameters to the general_search_parms group so that we can
have cleaner URLs.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Jason Stephenson <>
5 years agoLP 1319560: Another fix for summary.tt2.
Jason Stephenson [Mon, 19 May 2014 13:19:49 +0000 (09:19 -0400)]
LP 1319560: Another fix for summary.tt2.

Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/record/summary.tt2 line 56.

It was apparently coming from the .size and not where I thought.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
5 years agoLP 1319560: Fix the disappearing hold button.
Jason Stephenson [Thu, 15 May 2014 15:31:56 +0000 (11:31 -0400)]
LP 1319560: Fix the disappearing hold button.

Staff discovered an issue with the tt2 changes that caused the
place hold button to disappear when it shouldn't. Changing an &&
back to || seems to fix this.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
5 years agoLP 1319560: Silence template error messages in Apache error log.
Jason Stephenson [Wed, 14 May 2014 19:46:29 +0000 (15:46 -0400)]
LP 1319560: Silence template error messages in Apache error log.

We get a number of messages like the following in our Apache error
logs on a constant basis:

Argument "" isn't numeric in addition (+) at
/openils/var/templates/opac/parts/record/navigation.tt2 line 6.
Argument "" isn't numeric in division (/) at
/openils/var/templates/opac/results.tt2 line 1.
Argument "" isn't numeric in numeric ge (>=) at
/openils/var/templates/opac/parts/record/navigation.tt2 line 38.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/myopac/holds/edit.tt2 line 106.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/myopac/holds.tt2 line 42.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/place_hold.tt2 line 98.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/record/summary.tt2 line 56.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/result/table.tt2 line 87.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/hold_history.tt2 line 122.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopa/result/table.tt2 line 87.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/hold_history.tt2 line 122.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/holds.tt2 line 215.

This commit adds some sanity checking to make those messages go

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1251347: Get the most recent session locale for Event description translation
Mike Rylander [Thu, 14 Nov 2013 18:36:25 +0000 (13:36 -0500)]
LP#1251347: Get the most recent session locale for Event description translation

Signed-off-by: Mike Rylander <>
Signed-off-by: Ben Shum <>
5 years agoFix LP904860, Cannot print a patron address label
Steven Chan [Mon, 29 Jul 2013 23:27:13 +0000 (16:27 -0700)]
Fix LP904860, Cannot print a patron address label

The sequence of events for printing an address label is as follows.
Staff client Code in the util/print.js file builds an HTML page of the
address label.  The page includes two vital components, 1) a source tag
to pull 'print_win.js' file from the server, and 2) an onload event
handler bound to the body tag to execute a 'print_init()' function that
is defined in the source tag.

However, print_init() is undefined because the source tag contains a
badly formed URL. It needs to be prefixed by 'oils://remote' so that the
new 'oils:' protocol can be used to pull the file remotely from the

Signed-off-by: Steven Chan <>
Signed-off-by: Ben Shum <>
5 years agoLP#1231634: Mark Floating Groups Config UI strings translatable.
Pasi Kallinen [Thu, 7 Nov 2013 17:37:42 +0000 (19:37 +0200)]
LP#1231634: Mark Floating Groups Config UI strings translatable.

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Ben Shum <>
5 years agoLP#1331127 Repair sort logic of previous issuances
Bill Erickson [Tue, 17 Jun 2014 19:14:12 +0000 (15:14 -0400)]
LP#1331127 Repair sort logic of previous issuances

Ensure that the list of previous issuances is sorted correctly (on
date_published) when looking for the previous serial.unit to update its
copy location (when serial.prev_issuance_copy_location is enabled).

The data comes sorted from the DB, but the sorting was lost during the
process of unique-ifying the list.  Ultimately, it was relying on the
order of hash keys, which is undefined.

Signed-off-by: Bill Erickson <>
Signed-off-by: Dan Wells <>
5 years agoLP 1369128: Add delete permission to fm_IDL.xml for class bre.
Jason Stephenson [Thu, 18 Sep 2014 20:49:20 +0000 (16:49 -0400)]
LP 1369128: Add delete permission to fm_IDL.xml for class bre.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1370630: don't log mod_deflate actions by default
Galen Charlton [Wed, 17 Sep 2014 17:22:15 +0000 (10:22 -0700)]
LP#1370630: don't log mod_deflate actions by default

This patch comments out logging of mod_deflate actions,
as this is needed only for debugging.  Otherwise,
deflate_log will grow without bound, as it isn't dealt
with by typical default logrotate configs.

Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
5 years agoLP#1361801: Add required fields to serial issuance form
Remington Steed [Fri, 29 Aug 2014 18:45:50 +0000 (14:45 -0400)]
LP#1361801: Add required fields to serial issuance form

This commit prevents issuances from being created without a date_published
or holding_code. This has two benefits:

  1. Prevents uncaught exceptions related to submitting null values for
     either of those fields.
  2. Requiring date_published prevents an ugly error when trying to
     predict new issuances from an issuance without a date_published.

This commit does NOT provide any feedback to the user about which fields
are required. That would require further investigation into the Dojo/Dijit
objects being used for the edit form fields.

Signed-off-by: Remington Steed <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
5 years agoLP#1246859: Improve username flow for staged users
Jeff Godin [Wed, 30 Oct 2013 20:41:06 +0000 (16:41 -0400)]
LP#1246859: Improve username flow for staged users

Staged users in most cases have a username that consists of a UUID.

Rather than leave the UUID as their username or require staff to
clear the field and replace it with a barcode or other value, it
would be better to remove this username when loading the staged user
in the user editor.

This commit clears the username when loading a stage user if the
username looks like a UUID.

If a barcode has been staged for the loaded staged user, the
username will be populated with that value.

If there is no staged barcode, the username will remain blank and
will be populated using the standard method after staff enters a
value in the barcode field.

Signed-off-by: Jeff Godin <>
Signed-off-by: Ben Shum <>
5 years agoLP#1356576 repair sip date_format config typo
Bill Erickson [Wed, 13 Aug 2014 20:44:50 +0000 (16:44 -0400)]
LP#1356576 repair sip date_format config typo

Avoids "Use of uninitialized value in bitwise or (|)" error.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP1309131 - Fix series link
Kathy Lussier [Tue, 12 Aug 2014 21:33:16 +0000 (17:33 -0400)]
LP1309131 - Fix series link

Clicking on a series link with a hyphen failed because the hyphen was
stripped and the two words are joined together. This branch changes
series.tts to replace special characters with a space, which is similar to
the links we build for authors.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agoLP#1325720 Repair fund rollover year selector query
Bill Erickson [Mon, 2 Jun 2014 20:14:38 +0000 (16:14 -0400)]
LP#1325720 Repair fund rollover year selector query

Dojo dojo stores track values as strings, so values used in data store
queries must be coerced into strings before performing the query.

This fixes the year query in the fund rollover UI so that the page is
able to render the results of a rollover without dying from an JS error
before completing.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1292129: Removed deleted call numbers from the search results to properly show...
Steven Callender [Thu, 13 Mar 2014 17:34:23 +0000 (13:34 -0400)]
LP#1292129: Removed deleted call numbers from the search results to properly show copy count.

The SQL in fm_IDL.xml for setting up the reporter source "Hold/Copy
Ratio per Bib" includes deleted call numbers which in turn can give
an incorrect copy count. The ratio appears to still be correct because
deleted copies are considered in the ratio calculation, but not the
copy count that is displayed.

Signed-off-by: Steven Callender <>
Signed-off-by: Ben Shum <>
5 years agoLP 1350345: marc_export blows up on bad records.
Jason Stephenson [Wed, 30 Jul 2014 13:26:38 +0000 (09:26 -0400)]
LP 1350345: marc_export blows up on bad records.

Add some eval blocks around calls to MARC::Record->as_usmarc and
MARC::Record->as_xml_record to trap errors in bibliograpic and
authority records.

If MARC::Record reports an error, print the record id and the
error message and continue the export.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1358916: refuse to retrieve over-large MARC records via Z39.50
Galen Charlton [Tue, 19 Aug 2014 20:19:20 +0000 (13:19 -0700)]
LP#1358916: refuse to retrieve over-large MARC records via Z39.50

At least one malformed record discovered in the wild can
cause backends to balloon to over 3G of memory
consumption.  This patch works around that by refusing
to process any (MARC) Z39.50 results that are larger than the
MARC record maximum of 99,999 octets.

Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
5 years agoLP#1340947: Finish support in for -y and -z options
Jason Boyer [Mon, 14 Jul 2014 12:35:39 +0000 (08:35 -0400)]
LP#1340947: Finish support in for -y and -z options

Signed-off-by: Jason Boyer <>
Signed-off-by: Ben Shum <>
5 years agoLP#1357364: Explictly create the extension in the "public" schema.
Chris Sharp [Fri, 15 Aug 2014 12:58:04 +0000 (08:58 -0400)]
LP#1357364: Explictly create the extension in the "public" schema.

Thanks to Thomas Berezansky for the suggestion!

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
5 years agoLP#1357364: Allow for sites that may have the intarray extension already installed.
Chris Sharp [Fri, 15 Aug 2014 12:51:44 +0000 (08:51 -0400)]
LP#1357364: Allow for sites that may have the intarray extension already installed.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
5 years ago2.7 doc asciidoc fix
Angela Kilsdonk [Thu, 18 Sep 2014 13:29:37 +0000 (08:29 -0500)]
2.7 doc asciidoc fix

Signed-off-by: Angela Kilsdonk <>
5 years agoDocs: updated root.txt to point to 2.7 release notes
Yamil Suarez [Wed, 17 Sep 2014 21:35:30 +0000 (17:35 -0400)]
Docs: updated root.txt to point to 2.7 release notes

Signed-off-by: Yamil Suarez <>
5 years ago2.7 documentation from ESI
Angela Kilsdonk [Wed, 17 Sep 2014 20:54:31 +0000 (15:54 -0500)]
2.7 documentation from ESI

Documentation for Delayed vs Canceled Items, Report Editing, Report Hints, and Copy View/Edit Links.  Documentation written by Erica Rohlfs, Equinox Software, and Sally Fortin, Athenaeum Educational Services.

Signed-off-by: Angela Kilsdonk <>
5 years agoRelease notes repair to fix PDF build
Kathy Lussier [Tue, 16 Sep 2014 21:14:39 +0000 (17:14 -0400)]
Release notes repair to fix PDF build

Commit bb0aed2 did not fix our problem with the PDF build. Removing
quotes from the problem area to see if it fixes the issue.

Signed-off-by: Kathy Lussier <>
5 years agoDocumentation: Lost and Paid Status
Kathy Lussier [Sat, 13 Sep 2014 03:37:41 +0000 (23:37 -0400)]
Documentation: Lost and Paid Status

Adding docs for lost and paid status. These changes also moves the copy
statuses documentation up from the old 1.6 docs with the addition of the
long overdue and lost and paid statuses and includes some fixes to the
bills documentation.

Signed-off-by: Kathy Lussier <>
5 years agoDocs: EDI admin section updated with new screenshots and SANs info
Jennifer Pringle [Sat, 13 Sep 2014 03:41:57 +0000 (23:41 -0400)]
Docs: EDI admin section updated with new screenshots and SANs info

EDI admin section updated to include screenshots and information
regarding entering the SANs required for EDI to work.

Signed-off-by: Jennifer Pringle <>
Signed-off-by: Yamil Suarez <>
5 years agoDocs: Fix filenames to match references in the docs - second time
Josh Stompro [Sat, 13 Sep 2014 02:53:38 +0000 (22:53 -0400)]
Docs: Fix filenames to match references in the docs - second time

This is just like the fix that Remington Steed sent in on Sept 4th.

These images were creating errors for me when I try to create
an epub version of the docs because they are all referenced as .jpg
but the filenames were .JPG.

Signed-off-by: Josh Stompro <>
Signed-off-by: Yamil Suarez <>
5 years agoDocs: Staff generated penalties documentation
Kate Butler [Fri, 12 Sep 2014 21:45:43 +0000 (17:45 -0400)]
Docs: Staff generated penalties documentation

Signed-off-by: Kate Butler <>
Signed-off-by: Yamil Suarez <>
5 years agoDocs: Staff initials settings for patron notes
Kate Butler [Fri, 12 Sep 2014 20:39:32 +0000 (16:39 -0400)]
Docs: Staff initials settings for patron notes

Signed-off-by: Kate Butler <>
Signed-off-by: Yamil Suarez <>
5 years agoDocs: Documented change to Holds Shelf Expire Report
Yamil Suarez [Fri, 12 Sep 2014 19:51:28 +0000 (15:51 -0400)]
Docs: Documented change to Holds Shelf Expire Report

Thanks Joan Kranich

Signed-off-by: Yamil Suarez <>
5 years agoMinor reparis to release notes and merge parts doscs
Kathy Lussier [Fri, 12 Sep 2014 19:20:59 +0000 (15:20 -0400)]
Minor reparis to release notes and merge parts doscs

We broke the Evergreen docs build and think it may be related to starting
a line with ``++V.1++''. This is an attempt to fix it.

Signed-off-by: Kathy Lussier <>
5 years agoBitesize doc change: .xlsx report output
Angela Kilsdonk [Fri, 12 Sep 2014 19:01:03 +0000 (14:01 -0500)]
Bitesize doc change: .xlsx report output

Signed-off-by: Angela Kilsdonk <>
5 years agoLP#1350042 browser unit tests use repo fm_IDL2js.xsl
Bill Erickson [Thu, 11 Sep 2014 17:56:32 +0000 (13:56 -0400)]
LP#1350042 browser unit tests use repo fm_IDL2js.xsl

Generate JS-friendly IDL2js for browser client unit tests from the .xsl
file within the repo instead of referencing the installed version, which
may not yet exist on the machine.

Signed-off-by: Bill Erickson <>
Signed-off-by: Jason Etheridge <>
5 years agoLP#1294269 Docs: Fixed small documentation formatting bugs
SnigdhaD [Thu, 11 Sep 2014 21:07:24 +0000 (17:07 -0400)]
LP#1294269 Docs: Fixed small documentation formatting bugs

Signed-off-by: SnigdhaD <>
Signed-off-by: Yamil Suarez <>
5 years agoAcknowledge new contributor in 2.7 release notes
Ben Shum [Thu, 11 Sep 2014 06:35:42 +0000 (02:35 -0400)]
Acknowledge new contributor in 2.7 release notes

One more person to recognize now! Suzanne Paterno from 167f7f5

Signed-off-by: Ben Shum <>
5 years agoTranslation updates - newpot
Ben Shum [Thu, 11 Sep 2014 06:22:17 +0000 (02:22 -0400)]
Translation updates - newpot

Signed-off-by: Ben Shum <>
5 years agoTranslation updates - po files
Ben Shum [Thu, 11 Sep 2014 06:06:05 +0000 (02:06 -0400)]
Translation updates - po files

Signed-off-by: Ben Shum <>
5 years agoLP#1241644: Remove xact_finish IS NULL checks from CLAIMSRETURNED and LONGOVERDUE
Jason Boyer [Fri, 18 Oct 2013 14:26:26 +0000 (10:26 -0400)]
LP#1241644: Remove xact_finish IS NULL checks from CLAIMSRETURNED and LONGOVERDUE

Makes results agree with results.

Signed-off-by: Jason Boyer <>
Signed-off-by: Michele Morgan <>
Signed-off-by: Ben Shum <>
5 years agoLP#1081551 Serials batch recv. dupe barcode check
Bill Erickson [Fri, 11 Apr 2014 19:51:53 +0000 (15:51 -0400)]
LP#1081551 Serials batch recv. dupe barcode check

Exit processing and return an event if the barcode on a new serial.unit
collides with an existing serial.unit or asset.copy barcode in the
serial receive API.

In the UI, detect the dupe barcode event and provide an error message to
the user.

Signed-off-by: Bill Erickson <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
5 years agolp1335958 Remove parameters from current checkouts link
Kathy Lussier [Mon, 30 Jun 2014 18:57:29 +0000 (14:57 -0400)]
lp1335958 Remove parameters from current checkouts link

The limit and offset parameters can cause patrons to be stuck in a small
section of their current checkout lists. Let's remove those two parameters
when linking to that list from the patron dashboard.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Jim Keenan <>
Signed-off-by: Ben Shum <>
5 years agoLP#1190508: Rename certain image files to avoid Ad Block Plus's blacklist
Dan Pearl [Tue, 26 Aug 2014 20:07:41 +0000 (16:07 -0400)]
LP#1190508: Rename certain image files to avoid Ad Block Plus's blacklist

Ad Block Plus was blocking images with /images/adv_ in their pathname. It is
presumed that "adv" was short for "advertisement".  I have renamed the files
and the references to avoid the ABP blacklist.

Signed-off-by: Dan Pearl <>
Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 grid print CSV repair; all cols repair
Bill Erickson [Tue, 9 Sep 2014 18:39:51 +0000 (14:39 -0400)]
LP#1350042 grid print CSV repair; all cols repair

* repaired grid Print CSV action, which had not been updated with the
  latest print API.

* repair grid show/hide all columns actions.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoMove new color note to release notes 2.7
Ben Shum [Wed, 10 Sep 2014 21:03:11 +0000 (17:03 -0400)]
Move new color note to release notes 2.7

Signed-off-by: Ben Shum <>
5 years agolp1261791 Adjustment to background color for mobile search links
Kathy Lussier [Fri, 5 Sep 2014 23:26:22 +0000 (19:26 -0400)]
lp1261791 Adjustment to background color for mobile search links

Adding an id for the div surrounding mobile search links so that the
background color matches the color of the rest of the header.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agoRelease notes entry for new mobile-header-text-color
Kathy Lussier [Fri, 5 Sep 2014 23:08:25 +0000 (19:08 -0400)]
Release notes entry for new mobile-header-text-color

Adding a release notes entry for the addition of mobile-header-text-color
in colors.tt2.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agoLP 1261791 - Mobile Search links for my account screens
Suzanne Paterno [Wed, 20 Aug 2014 16:25:18 +0000 (12:25 -0400)]
LP 1261791 - Mobile Search links for my account screens

Added links for Basic, Advanced and Browse Searching from all my Account pages in a less than 600px view.:

Added a new color for the mobile search links, so users can modify based on their background color.

Signed-off-by: Suzanne Paterno <>
Signed-off-by: Jason Stephenson <>
5 years agoDocs: Fixed small typo in docs/reports/reporter_daemon.txt
Josh Stompro [Tue, 9 Sep 2014 19:32:55 +0000 (15:32 -0400)]
Docs: Fixed small typo in docs/reports/reporter_daemon.txt

Signed-off-by: Josh Stompro <>
Signed-off-by: Yamil Suarez <>
5 years agoDocs: Updated usage of to not use param 'u'
Josh Stompro [Tue, 9 Sep 2014 19:30:28 +0000 (15:30 -0400)]
Docs: Updated usage of to not use param 'u'

Signed-off-by: Josh Stompro <>
Signed-off-by: Yamil Suarez <>
5 years agoDocs: update to 'Address Alerts' feature content
Josh Stompro [Tue, 9 Sep 2014 19:13:47 +0000 (15:13 -0400)]
Docs: update to 'Address Alerts' feature content

Signed-off-by: Josh Stompro <>
Signed-off-by: Yamil Suarez <>
5 years agoRelease notes cleanup
Kathy Lussier [Fri, 5 Sep 2014 13:15:45 +0000 (09:15 -0400)]
Release notes cleanup

Cleanup to the 2.7 release notes, to include spelling corrections, moving
some content to the official docs, and adding acknowledgements at the end.

Signed-off-by: Kathy Lussier <>
5 years agoDocs: Fix filenames to match references in the docs
Remington Steed [Thu, 4 Sep 2014 19:21:06 +0000 (15:21 -0400)]
Docs: Fix filenames to match references in the docs

These image files were not displaying in the docs because the filenames
and the references used different capitalization. Web URLs are
case-sensitive, so this commit changes the image filenames to be all

Signed-off-by: Remington Steed <>
5 years agoLP#1350042 add missing ui-bootstrap dep to Gruntfile
Bill Erickson [Wed, 13 Aug 2014 16:41:40 +0000 (12:41 -0400)]
LP#1350042 add missing ui-bootstrap dep to Gruntfile

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 Browser client templates/scripts (phase 1)
Bill Erickson [Mon, 4 Aug 2014 18:06:02 +0000 (14:06 -0400)]
LP#1350042 Browser client templates/scripts (phase 1)

 * Templates in Open-ILS/src/templates/staff/
 * JS files in Open-ILS/web/js/ui/default/staff/
 * Also includes a few TPAC modifications for embedded mode
 * Resurrects the pre-XUL user permission editor

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 make_release -c for building browser client
Bill Erickson [Mon, 4 Aug 2014 18:03:07 +0000 (14:03 -0400)]
LP#1350042 make_release -c for building browser client

Adds support for fetching JS dependencies, minification, and
building of the experimental browser client via new -c option.
Browser client building is disabled by default.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 link opensrf websockets JS scripts
Bill Erickson [Mon, 4 Aug 2014 18:02:22 +0000 (14:02 -0400)]
LP#1350042 link opensrf websockets JS scripts

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 browser client apache config additions
Bill Erickson [Mon, 4 Aug 2014 17:24:37 +0000 (13:24 -0400)]
LP#1350042 browser client apache config additions

* Location configuratoin for /eg/staff templates
* Support for "stop-at-index" in EGWeb, so that navigating to "/eg/foo"
  can result in /eg/index.tt2 getting served.
* Cache and compress additions for /js files.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 detect is-staff mode for browser client
Bill Erickson [Mon, 4 Aug 2014 17:16:02 +0000 (13:16 -0400)]
LP#1350042 detect is-staff mode for browser client

The browser client does not pass an OILS-Wrapper header to the embedded
catalog (etc.) so consider the presence of a workstation an indication
that the TPAC should operate in staff mode.

NOTE: this may require some additional thought, since this means all
TPACs within an authenticated browser will run in staff mode, which may
not be desired.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 streaming holds pull list API
Bill Erickson [Mon, 4 Aug 2014 17:12:56 +0000 (13:12 -0400)]
LP#1350042 streaming holds pull list API

Adds an API name-based option to the standard holds pull list API to
respond with a stream of fleshed users, so the caller is not forced to
make additional fetch-by-ID calls to collect the holds data.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 streaming patron search API
Bill Erickson [Mon, 4 Aug 2014 17:10:49 +0000 (13:10 -0400)]
LP#1350042 streaming patron search API

Adds an API name-based option to the standard patron search API to
respond with a stream of fleshed users, so the caller is not forced to
make additional fetch-by-ID calls to collect the user data.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1350042 PCRUD access for various IDL classes
Bill Erickson [Mon, 4 Aug 2014 17:08:22 +0000 (13:08 -0400)]
LP#1350042 PCRUD access for various IDL classes

These changes are mostly data retrieval and help support
PCRUD/auto-grid-style retrieval of certain patron data.

Classes affected:


Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoDocs: added Address Alert documentation for local admin menu feature
Josh Stompro [Fri, 29 Aug 2014 17:43:22 +0000 (13:43 -0400)]
Docs: added Address Alert documentation for local admin menu feature

Signed-off-by: Yamil Suarez <>
5 years agoFix broken prereq installer for debian wheezy user/dbs/fix_broken_Makefile_install
Dan Scott [Thu, 28 Aug 2014 13:40:54 +0000 (09:40 -0400)]
Fix broken prereq installer for debian wheezy

Problem found by live-tester scripts. Yay for live tests!

Signed-off-by: Dan Scott <>
5 years agoLP#1282783: Use patron hold notification defaults for KPAC
Terran McCanna [Tue, 26 Aug 2014 21:58:52 +0000 (17:58 -0400)]
LP#1282783: Use patron hold notification defaults for KPAC

Since the KPAC interface doesn't display a patron's email/phone notification
preferences, we had initially assumed it was pulling in the patron's default
notification info, but we've found that it does not.

Emails are not sent to patrons who have their notification preferences set to
email, and hold slips print out without phone numbers or email addresses. This
causes extra work for Circ staff in processing incoming holds as they need to
look up each account number to get the patron's contact information.

This patch pulls in the patron's email & phone notification preferences and
related values in hidden fields and allows the patron to choose their pickup
library at time of hold placement (defaults to their preferred pickup location).

Signed-off-by: Terran McCanna <>
Signed-off-by: Ben Shum <>
5 years agolp949101 Hold Columns for Item Status
Michele Morgan [Wed, 27 Aug 2014 19:25:24 +0000 (15:25 -0400)]
lp949101 Hold Columns for Item Status

Fixes display of hold columns in Item Status Holds/Transit tab.

Signed-off-by: Michele Morgan <>
Signed-off-by: Ben Shum <>
5 years agoLP#1362210: Install PostgreSQL packages where we can
Dan Scott [Mon, 25 Aug 2014 18:16:35 +0000 (14:16 -0400)]
LP#1362210: Install PostgreSQL packages where we can

Rather than relying on purely manual installation, carve out a common
set of packages that are needed by both the Evergreen server and the
standalone PostgreSQL server and add them as dependencies to both
scenarios. In the worst case, the package manager will see a package
that it has already installed and skip it (if the database server is on
the same OS instance as the Evergreen server).

It sure beats upgrading your database server and wondering why things
like the addition of call numbers fails with database query errors when
it turns out that you're missing the Library::CallNumber::LC Perl module

It also makes the README shorter and requires fewer steps for users to
follow to install successfully. Win win win?

Signed-off-by: Dan Scott <>
Signed-off-by: Ben Shum <>
5 years agoLP#1306675 TPAC maketext default handler
Bill Erickson [Thu, 15 May 2014 15:22:16 +0000 (11:22 -0400)]
LP#1306675 TPAC maketext default handler

Fall back to an unitialized maketext handler, which defaults to the
template language, when OpenILS::WWW::EGWeb::I18N->get_handle fails to
return a response.

Note that why get_handle() returns undef is not yet known.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
5 years agoLP#1233757 Correct Spelling Error in Checkout Override Exception
Elliot Voris [Fri, 7 Mar 2014 02:55:56 +0000 (20:55 -0600)]
LP#1233757 Correct Spelling Error in Checkout Override Exception

Correcting a few misspellings of "overridden" in the staff client
override exception.

Signed-off-by: Elliot Voris <>
Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agoLP#1010027: tweak patron columns in patron search interface
Jason Etheridge [Mon, 1 Oct 2012 20:49:04 +0000 (16:49 -0400)]
LP#1010027: tweak patron columns in patron search interface

specifically, remove the Mailing Address and Billing Address columns that come
off the actor table, since they are redundant with the Mailing Addr: Address ID
and Billing Addr: Address ID columns that come off the address table.

Also, alphabetize the columns coming directly off of the user table. The columns
coming off the library card and address tables remain unsorted; I believe their
order is as listed in the fm_IDL.xml file for their corresponding fieldmapper

Signed-off-by: Jason Etheridge <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
5 years agoLP#1010027: more internal options for xul lists
Jason Etheridge [Mon, 1 Oct 2012 20:46:56 +0000 (16:46 -0400)]
LP#1010027: more internal options for xul lists

specifically, give fm_columns a sort_headers flag for alphabetizing the columns
returned by label; and delete_me flag for omitting a column definition entirely

Not all xul lists are using fm_columns yet

Signed-off-by: Jason Etheridge <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
5 years agoLP#1189556: stamping upgrade script for URL_VERIFY description typo fix
Ben Shum [Wed, 27 Aug 2014 04:49:48 +0000 (00:49 -0400)]
LP#1189556: stamping upgrade script for URL_VERIFY description typo fix

Signed-off-by: Ben Shum <>
5 years agoLP#1189556: Fix typo in URL_VERIFY permission description
Chris Sharp [Tue, 11 Jun 2013 14:09:20 +0000 (10:09 -0400)]
LP#1189556: Fix typo in URL_VERIFY permission description

The description for the URL_VERIFY permission contained a typo,
fixed here.

Added an upgrade sql to update the text.

Signed-off-by: Chris Sharp <>
Signed-off-by: Pasi Kallinen <>
Signed-off-by: Ben Shum <>
5 years agoLP#1322341: Count part holds on records
Thomas Berezansky [Fri, 23 May 2014 19:40:23 +0000 (15:40 -0400)]
LP#1322341: Count part holds on records

Also fix a small mistake in metarecord matching

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
5 years agoLP#1277551: Limit simplified pull list to available copies
Thomas Berezansky [Fri, 18 Apr 2014 13:46:13 +0000 (09:46 -0400)]
LP#1277551: Limit simplified pull list to available copies

Copies that are targeted by a hold but are not in available or reshelving
statuses should not show up on a pull list.

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Michele Morgan <>
Signed-off-by: Ben Shum <>
5 years agoLP#1314370: Enable dojo all the time in the catalog
Ben Shum [Wed, 30 Apr 2014 06:02:49 +0000 (02:02 -0400)]
LP#1314370: Enable dojo all the time in the catalog

Because we rely on the dojo framework for the shelving location filter in the
advanced search, we should choose to use dojo everywhere and not just when
autosuggest, google books, or novelist are enabled.

This is a quick change to toggle the flag for want_dojo to be set all the time.

Signed-off-by: Ben Shum <>
Signed-off-by: Liam Whalen <>
5 years agoLP1277556 Fast Item Add no longer opens record after copy is created
Blake Henderson [Tue, 1 Jul 2014 22:06:30 +0000 (17:06 -0500)]
LP1277556 Fast Item Add no longer opens record after copy is created

Altered save_attempt to handle undefined and true cases for replace_on_complete
When fastItemAdd is not used, replace_on_complete is undefined
When it is used, and successful, replace_on_complete will be set to true
then we need it to execute result.on_complete()

Signed-off-by: Blake Henderson <>
Signed-off-by: Remington Steed <>
Signed-off-by: Ben Shum <>
5 years agoLP1084269, LP1050043 Expert Search Fixes
Liam Whalen [Sat, 28 Jun 2014 22:37:28 +0000 (15:37 -0700)]
LP1084269, LP1050043 Expert Search Fixes

Sorting Expert Search corrected

LP1050043 was issued because attempting to sort the MARC expert search
results, in the staff client, caused the staff client to return to the
basic search page rather than sort the results.

To fix the sorting I had to modify two perl files. had to be changed in a number of ways.

1. The way the sort works currently assumes the user is doing a full
text search.  So, it passes in the values of titlesort and authorsort as
the sort variable in the URL.  However, in the expert search, it is
looking for the values 'title' and 'author'.  This resulted in the title
sort and author sort never being executed and returning the relevance
sort instead. I modified the search to use a regex instead of eq.

2. If a record has no value associated with it e.g. no 260 c for
pubdate, no 245 $a for title, no 1xx $a for author, then the SQL is
supposed to replace those values with either 'AAAA' or 'zzzz' depending
on the order of the sort.  This should cause records without the
relevant sort values to be pushed to the bottom of the sort results.

But, the PgSQL function COALESCE, which is supposed to do the
replacing, does not do anything if no rows are returned for a record's
relevant value.  To work around this, I surrounded the relevant values
with the MAX() function call, which returns NULL if no row is returned.

Because author sort works on any 1xx value, it sorts those values in
numerical order when there is more than one 1xx in a record.  This
requires the use of an ORDER BY statement, which seems to nullify
the effect of MAX().  So, I had to move the MAX() into a second SELECT
statement in the case of author sort.

3. I added the variables number_default_sort and string_default_sort
to the metabib code because the current code hard codes values of
'9999' and 'zzzzzzzz' into the sort. had to be changed to pass the sort values from the TPAC
into the relevant sort subroutines.  This was done with the addition of
an $arghash variable that checks the cgi parameters for the sort

As well, Expert search puts the tag and _special params in the
search form.  This causes all other searches to perform Expert searches
afterwords.  To fix this, is modified to look for an empty
query value before it conducts an Expert search.  If it is empty and
the Expert search variables are present, then the Expert search is
performed.  Otherwise, a normal search is done.

Finally, to fix the problem reported by LP1050043, I had to modify
searchbar.tt2.  Currently, searchbar.tt2 does not have the values from
the Expert search entered into the <form> where the sort functionality
is located.  This means, when a sort option is chosen, the TPAC no
longer knows which values were used for the Expert search.

This is not obvious at first because after choosing to sort, the
user is returned to a page where the URL has the Expert search values
in it.  This happens because the sort is submitting a form without a
query value, so the TPAC redirects the user to the referring page,
which is the initial Expert search.

To fix this, I added the Expert search values as hidden variables
into the <form> where the sort functionality is located.  I also
removed the use of the "_adv" hidden variable from the <form> when
not in the advanced search.

[LP1094269] Retrive past 100 records in Expert Search

Currently, when paging through the results of the Expert search, the
system will not return more than 100 records.  Going past page 10
causes a no results screen.

This is due to the offset and limit values not being passed into the
argument hash used to create the SQL for the search.  Once the SQL
returns, it returns record ids within the range of the offset and
the limit. So, if the offset is 100 and the limit is 10, the record
ids for search results 100 to 109 are returned.

But, because offset and limit are not being passed into the arghash,
they default to 0 and 100 respectively.  This means the first 100
records are always returned regardless of where in the search pages
you are viewing.  These 100 results were then pruned to the relevant
10 results in  However, if the offset starts beyond 100
then no results are returned because the results passed 100 are not
returned by

This commit passes the offset and limit as arguments in the search
hash.  It also removes offset and limit as parameters of the
search.biblio.marc call. Because offset and limit are needed in the
arghash to limit the number of records returned, it is better to
pass them only via the arghash to ensure that no more than the
necessary number of records are returned.

Offset and limit could be kept as parameters, but it would require
modifying metabib as well to look for those parameters, so I think
forcing the Expert search to pass them as argument parameters is the
better option.

As well, this commit removes the pruning in that was based
on the offset and limit because that is handled in now
that offset and limit are being supplied in the argument hash.

I have checked the source code and the marc_search function in is only called via the Expert search in
WWW/EGCatLoader/, so modifying in this manner
will only affect the Expert search and nothing else.

Signed-off-by: Liam Whalen <>
Signed-off-by: Sarah Childs <>
Signed-off-by: Ben Shum <>
5 years agolp1182605 Add sort value for holds interfaces
Kathy Lussier [Tue, 19 Aug 2014 18:29:56 +0000 (14:29 -0400)]
lp1182605 Add sort value for holds interfaces

Holds interfaces were still sorting incorrectly, so let's add a sort value

Signed-off-by: Kathy Lussier <>
Signed-off-by: Remington Steed <>
Signed-off-by: Dan Wells <>
5 years agolp1182605 Abstracting out common functionality from code that sorts call numbers...
Victoria Lewis [Wed, 30 Apr 2014 22:09:07 +0000 (15:09 -0700)]
lp1182605 Abstracting out common functionality from code that sorts call numbers by label_sortkey

Code had been added to insure that LC call numbers are sorting as they should by asset.call_number.label_sortkey.
Code was duplicated in the 'call_number column' in the 'columns' group and in the 'hold_columns'group.

I abstracted the logic out of 'sort_value' and 'render' in the 'call_number' column in the 'columns' group and from
'render' in the 'call_number' column in the 'hold_columns' group to a utility function  called

Signed-off-by: Victoria Lewis <>
modified:   xul/staff_client/server/circ/util.js
Signed-off-by: Kathy Lussier <>
Signed-off-by: Remington Steed <>
Signed-off-by: Dan Wells <>