Jason Stephenson [Thu, 26 Jul 2012 17:45:06 +0000 (13:45 -0400)]
Make the ContainerCSV reactor output more than 10 records.
Call AppUtils->bib_container_items_via_search with an args hashref
that hard codes the search limit to 1,000 records instead of using
the biblio.multiclass search default of 10.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 7 Aug 2012 20:39:37 +0000 (16:39 -0400)]
Allow some buttons in Import via Z39.50 to wrap lines
Some of our technicians with 4:3 ratio monitors and a reasonable
font-size are unable to see the "Import Record" button on the Import via
Z39.50 screen, because the buttons in that row are laid out in a single,
non-wrapping row, and there is no affordance for scrolling over to the
side.
Simply changing the containing "hbox" element to a "description" element
allows enough of the buttons to overflow to resolve the problem in our
experience.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Steven Chan [Wed, 25 Jul 2012 23:12:19 +0000 (16:12 -0700)]
Fix LP949249, Edit, then Create button creates a new item in all cases
This fix also resolves the following:
* https://bugs.launchpad.net/evergreen/+bug/806585,
Item Attributes saved on Close
* https://bugs.launchpad.net/evergreen/+bug/644753,
check for duplicate barcode during a create session in copy/volume editor
1. The Copy Editor screen is launched from the Volume Copy Creator,
which is launched from the Holdings Maintenance screen. If the default
interface is set, CE is shown in a separate window; if the 'unified'
interface is set, CE is embedded in the same window as VCC. Upon the
user clicking Save or Close in the Copy Editor, the intent is to create
a new item record or not, respectively. However, it happens that a new
record is always created, because VCC instructs CE to let VCC update the
item, which will occur whether the user has clicked either button.
To fix 1, if the default interface is set, we reconfigure CE to update
the item or not, depending on the button clicked; otherwise, in the
unified interface, we allow VCC to update the item or not.
2. Upon updating the item, if the barcode is a duplicate, the ensuing
sequence of events is problematic: a database-level alert message is
shown, Copy Editor is closed, and Volume Copy Creator is closed, thus
forcing the user to re-formulate the request from Holdings Maintenance.
To fix 2, we show a higher-level alert message to the user. If the
default interface is set, we stay within CE, reconfigure the barcode to
be an input field, and focus the user on it; otherwise, in the unified
interface, we return the user to an area of the screen where the barcode
field is available. In either case, the user can re-enter a barcode
value and re-submit without losing any values previously entered into CE.
3. We also take the opportunity to enhance the coding performance of
Copy Editor, by delegating the handling of the button and key clicks to
the parent groupbox element. Previously, the event handler was attached
to several child elements, which is not performant.
And adjust the comment to make more sense. There is no higher level filter
that prevents copy holds on parted items, so there is no filter for them to
"slip through".
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Michael Peters [Thu, 15 Mar 2012 13:49:06 +0000 (09:49 -0400)]
TTPAC image directory cleanup
There are a significant number of images remaining in TTPAC
that are no longer used, leftover from KCLS, etc.
This branch does a little cleanup on the image directory
and nets us about a 200KB savings overall.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Thu, 16 Aug 2012 19:40:58 +0000 (15:40 -0400)]
Sanity check cstore limit/offset param values
Certain cstore calls (direct / json_query) that support limit/offset
params called with a non-string / non-numeric value
e.g. { "limit": null }
result in a cstore segfault as it tries to call atoi(NULL) under the
covers. This patch prevents this by verifying that the limit/offset
values are actual strings or numbers (i.e. return a value from
jsonObjectGetString) and not JSON_NULL, etc.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Wed, 15 Aug 2012 11:18:53 +0000 (07:18 -0400)]
TPAC: Move "Export to RefWorks" into utility area
When the RefWorks functionality was being added to TPAC, the design and
layout were very much in flux. Now that the layout has been established
with utilities like "Place Hold" on the right hand side, move the
"Export to RefWorks" button into the same location.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Tue, 21 Aug 2012 21:23:26 +0000 (17:23 -0400)]
Protect against installs with no locales
Installs from source outside of tarballs may not have a built locale,
which would result in a make error and an aborted install. Protect
against that by checking for the existence of the locale install
directory before trying to copy the files into place.
In the weird case that Open-ILS/src/data/locale has been generated but
there are no files in it, protect against erroring out via the judicious
application of the - flag.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 20 Aug 2012 18:11:50 +0000 (14:11 -0400)]
TPAC: Standardize i18n file installation
Make TPAC i18n files act like any other i18n file. In short:
1. When in build/i18n, a 'make LOCALE=fr-CA install' will copy
the i18n file into the Open-ILS/src/data/locale directory.
2. In the build root, a 'make install' will copy all files from
Open-ILS/src/data/locale into (by default) the
/openils/var/data/locale directory.
This also means that when tarballs are created, all of the locales will
get packaged appropriately.
This commit also updates eg_vhost.conf to provide working out-of-the-box
examples for any installed locales, by using the names of the actual
PO files, and adds some contextual comments to explain how the
configuration directives work.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 17 Aug 2012 21:15:25 +0000 (17:15 -0400)]
ACQ return-to-[search/invoice] buttons repair
With changes in place to support newer version of xulrunner, several
buttons no longer work in the staff client. These include:
Return to Search in PO and Selection List pages
Return to Invoice in PO and Selection List pages
Return in lineitem worksheet page
This fix avoids using document.referrer (which is no longer available)
with an explicit 'source' CGI parameter, which contains the path and
params of the source page.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 30 Jul 2012 15:30:50 +0000 (11:30 -0400)]
TPAC: Autosuggest focus() throws a JS error
On page load, the Dojo autosuggest code tries to set focus to the
element with the ID "search_box" - which is fine, except when the page
does not have said ID. Therefore, test for the existence of the ID
before setting focus to it.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Sat, 4 Aug 2012 14:26:25 +0000 (10:26 -0400)]
TPAC locale picker: use POST instead of GET
Users could (deliberately or not) change another's language
preferences by sharing links with the "set_eg_locale" GET param given
the locale picker's current behaviour. By switching to a POST param, we
prevent this result from accidentally occurring.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Mike Rylander [Thu, 16 Aug 2012 17:45:23 +0000 (13:45 -0400)]
Provide permission for copy editor field hiding
We can adjust what fields are available in the copy editor in 2.2+, but that
requires the general UPDATE_ORG_SETTING permission. The YAOUS-specific
permission here allows more granular control, so that staff can be given the
ability to adjust only that one OU setting.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Dan Scott [Mon, 16 Jul 2012 17:27:54 +0000 (13:27 -0400)]
Hide OPAC-invisible holdings from SRU/Z39.50
The basic_holdings Supercat method filtered out deleted call numbers and
copies, but didn't filter out copies based on the OPAC visibility status
of copy location / status / the copy itself. This has undesired results
when third-party services request copies via SRU or Z39.50 and expose
copies that should not be visible to the public.
We wrap all of the visibility and deletedness checks for a given copy up
into a subroutine so that we can avoid repeating ourselves in the
basic_holdings logic. Also, if we missed a test, we can add it in one
handy place :)
(Thanks to Galen Charlton for finding two missing tests: circ lib
visibility and owning lib visibility!)
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Mon, 13 Aug 2012 16:32:26 +0000 (12:32 -0400)]
TPAC: Centralize font size definitions
The TPAC CSS had a mix of absolute and proportional font size
definitions, making it impossible to define a single base size and have
the layout adjust appropriately, as well as making it difficult to tweak
sizes to, say, eliminate the distinction between 11px and 12px text.
Accordingly, create a separate TT2 file to define standard font sizes,
define one base font size, and then use proportional percentage-based
size definitions for a set of standard font sizes. This way, a site
could easily adjust the base font size to 15px and the rest of the
layout should automatically adjust, and/or revert to using absolute font
sizes for different categories if they prefer.
Note that I did simplify some of the categories of font sizes, as the
distinction between 111% and 110% was probably not evident to most
humans at most font sizes, and even the distinction between 120% and
125% would be 14.4px vs. 15px given a base size of 12px - which
different user agents could render differently anyway.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Trying to update patron CSS color fails here, so don't try
After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
TypeError: patron.display is undefined.
We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
...penalties[i].standing_penalty().name is not a function.
Which probably has something to do with unfleshed data. Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Sometimes it seems that child_init has not run properly for supercat.
This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sat, 4 Aug 2012 15:04:17 +0000 (11:04 -0400)]
Silence warnings in search results for holdable copies
Have not yet determined the exact reason the holdable copies size is not
defined in some instances in the search results only, but this commit
prevents warnings from being spewed by apache about undefined variables.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 13 Aug 2012 17:53:22 +0000 (13:53 -0400)]
TPAC: Give login boxes a border
For some reason, the boxes for the login form were stripped of
their default border style. Let the natural input box formatting for the
border shine through and give users an easier target when logging in.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Ben Shum [Tue, 7 Aug 2012 17:48:31 +0000 (13:48 -0400)]
TPAC - fix pickup locations for edit holds
When a patron goes to edit a hold in TPAC, they have the option to
choose a different pickup location. Unfortunately, it looks like that
dropdown does not prevent them from selecting locations that aren't
normally allowed for pickups, such as system groups or consortium
itself.
This patch adds a check for 'can_have_vols_only' to the edit holds
screen.
Credit to Melissa Lefebvre for finally nailing down the source of
the issue.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 10 Aug 2012 18:06:36 +0000 (14:06 -0400)]
Fiscal year selector in ACQ order record upload
* Support a 'fiscal_year' parameter to ACQ order record upload API.
* Adds a new "Fiscal Year" selector to the upload form to facilitate
uploading orders to different fiscal years.
This partially resolves LP 1031927 by allowing manual selection of the
correct fiscal year.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Ben Shum [Mon, 13 Aug 2012 22:08:53 +0000 (18:08 -0400)]
Change "Reset form" to "Clear Form"
As suggested by Thomas Berezansky in the comments on LP 994058, change
the button from "Reset form" to "Clear form" to be absolutely clear
that the button now removes all previous search variables.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 8 Aug 2012 19:08:24 +0000 (15:08 -0400)]
TPAC: Reset Form and New Search should clear queries
Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.
Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.
Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Sun, 12 Aug 2012 07:25:49 +0000 (03:25 -0400)]
TPAC - add library scoping to shelf browser
The shelf browser currently uses the 'loc' variable to define scoping and
limit browsing to specific org units. However, since much of the scoping
actually uses 'locg', the scoping was broken for the shelf browser.
Additionally, under Advanced Search's Numeric Search, the option for
'Call Number (Shelf Browse)' only applies the 'cn' variable to searches
and never adds the search scope, despite the search library now being
an available filter choice.
Based on suggestion by Dan Scott in IRC, this patch uses the function for
_get_search_lib() to retrieve the search library and add it to both parts
of the shelf browser.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jason Stephenson [Wed, 25 Jul 2012 17:43:38 +0000 (13:43 -0400)]
Make opac/results.tt2 remember facet when sorting, etc.
Add a hidden field in the search form and set its value to the value
of the CGI 'facet' param if the facet parameter is set. This appears
to work for multiple facets. Clearing a facet is as simple as clicking
on the gray-backgounded facet name.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Thu, 9 Aug 2012 16:27:57 +0000 (12:27 -0400)]
TPAC - fix alignment of "You are now browsing..." in shelf browser
The "You are now browsing..." message does not align to the center of the
page. Changing the <div> to a <p> seems to properly align the text.
Along the way, we should remove the extra <span> and <strong> (the strong
is redundant with the css being inherited by color_4 class) and make the
new single line message more i18n-friendly for future translations.
Credit to Michael Peters for noticing the problem and thanks to Dan Scott,
Lebbeous Fogle-Weekley, and Thomas Berezansky for help via IRC for the
i18n-bits.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Dan Scott <dscott@laurentian.ca>
The cnoffset was strictly checking for values that start with a digit.
But negative numbers start with a "-" instead. Once this check was
changed, the previous link will continue to move further into negative
offsets.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 9 Aug 2012 22:25:00 +0000 (18:25 -0400)]
Authorities: Fix broken UI due to new XUL/Dojo/regressions
New versions of XUL, since Firefox 10, hate dojo.query("foo bar"), so we
have to refactor it to use dojo.query("foo").query("bar") instead. At
least until we upgrade to a new version of Dojo.
In addition, 522d8d82 introduced a regression meaning that the text of
the authorities was no longer wrapped in a SPAN element with a class of
"text". That in turn meant that the Dojo queries weren't picking up the
labels for the merge box, leaving no visual indication to the user as to
what authorities exactly were being merged. So, repair that.
Also, similar to a fix for the MFHD editor, set the initial height of
the spawned MARC Editor for an authority record to something reasonable.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 9 Aug 2012 20:31:44 +0000 (16:31 -0400)]
Set a sane initial MFHD Editor size
For most MFHD records, the size of the MARC Editor window when spawned
fits into the confines of a normal desktop. However, for MFHD records
with dozens or more rows, the window chrome can be inaccessible because
it is bumped off the top of the Windows desktop. This makes it
impossible for users to close the window without a workaround like
hitting ALT+F4
This branch sets the window to an initial height of 40 pixels less than
the height of the entire staff client window. This should be enough to
enable the chrome on top to be visible. In addition, we have to set the
width to something reasonable because XUL seems to otherwise set the
window to be extremely skinny once an explicit height is set, so we set
that to be half the width of the staff client window.
Finally, we allow the new window to be resizable according to the user's
preference.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Simplified Hold Pull List: Fix several sorting bugs
First of all, sorting on most columns was broken due to a bug in the way
that the flattener methods of the open-ils.fielder service were
constructing their SQL JOINs. We were coming up with way too many
joins, and then losing track of which JOIN's alias to refer to when
building the ORDER BY clause later. This is fixed.
Secondly, the shelving location column now sorts automatically by the
shelving location *ordering* values, when avaiable. These are the
values that you set up in the drag-and-drop staff client interface
titled "Copy Location Order." When these values are not set for the org
unit whose pull list you're viewing, the sorting will fall back to
alphabetical.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Sat, 4 Aug 2012 15:24:15 +0000 (11:24 -0400)]
TPAC: Remove explicit width on "View my list" button
.cached_list_div, which defines the style for the "View my list" button
on the TPAC button bar once an item has been added to a temporary list,
is given an explicit width of 111px, which is problematic for a number
of reasons:
1. If the font-size of the base style is increased, then the text will
likely wrap.
2. Translations tend to be longer than English, and indeed in fr-CA
"Afficher ma liste" ends up wrapping onto a second line, which makes
the button bar look weird.
Accordingly, remove the explicit "width:111px" from the style definition
for .cached_list_div.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Fri, 3 Aug 2012 14:59:33 +0000 (10:59 -0400)]
Add dependencies for Fedora
Noted by Net Wolf on the mailing list, some core dependencies were
missing from the Fedora Makefile.install installer. As some of them have
recently been packaged for Fedora 17, add them to the package
collection; others are still unpackaged, so leave them there.
Note: the packages are not available on Fedora 16, but that has a
limited remaining shelf life anyway, so consider this a shift to
supporting only the latest stable version of Fedora.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Thu, 2 Aug 2012 16:09:42 +0000 (12:09 -0400)]
Add simple README to RELEASE_NOTE_NEXT
Without something in the directory, it will dissappear each time we
create release notes from the contents and delete them, since Git
removes empty directories. That would likely just lead to confusion.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jeff Godin [Tue, 19 Jun 2012 19:10:07 +0000 (15:10 -0400)]
Pass authtoken to OpenILS::SIP::Patron objects
To support retrieval of billing details, OpenILS::SIP::Patron
objects need an auth token.
Teach OpenILS::SIP->find_patron to pass patron objects an auth
token, and also move existing "find patron by what key: barcode or
database id?" logic into find_patron (and out of
OpenILS::SIP::Patron->new).
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Thu, 31 May 2012 13:27:40 +0000 (09:27 -0400)]
Search filter groups release notes
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Thu, 31 May 2012 13:37:58 +0000 (09:37 -0400)]
Search filter groups admin UI staff menu entry
Admin -> Local Administration -> Search Filter Groups
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Fri, 25 May 2012 13:22:36 +0000 (09:22 -0400)]
Search filter groups admin UI / API
UI for managing search filter groups and group entries.
This inclues a new API call for performing CRUD actions on filter
group entries:
open-ils.actor.filter_group_entry.crud
This new API call was necessary because entries link to
actor.search_query's, whose write access cannot be controled by pcrud.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Fri, 27 Jul 2012 15:39:14 +0000 (11:39 -0400)]
Block "Place Hold" link in TPAC if item is available
Suppress the display of the "Place Hold" link based on whether an item
is available. This is set as a preference in config.tt2. Some sites
may want the ability to place holds regardless of availability.
Signed-off-by: Art Rhyno <art632000@yahoo.ca> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/summary.tt2
Open-ILS/src/templates/opac/parts/result/table.tt2
projects / working / Evergreen.git / log