working/Evergreen.git
8 years agoTPac: Removed errant 'html' almost-filter
Bill Erickson [Wed, 17 Aug 2011 20:55:43 +0000 (16:55 -0400)]
TPac: Removed errant 'html' almost-filter

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTpac: more html output sanitizing
Bill Erickson [Wed, 17 Aug 2011 20:50:50 +0000 (16:50 -0400)]
Tpac: more html output sanitizing

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMark a string for i18n support in the TPAC
Dan Scott [Wed, 17 Aug 2011 20:43:46 +0000 (16:43 -0400)]
Mark a string for i18n support in the TPAC

Even alt strings deserve translation support...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTpac: more html output scrubbing
Bill Erickson [Wed, 17 Aug 2011 19:45:44 +0000 (15:45 -0400)]
Tpac: more html output scrubbing

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoEscape TPAC "myopac" output to protect against XSS attacks
Dan Scott [Wed, 17 Aug 2011 19:36:15 +0000 (15:36 -0400)]
Escape TPAC "myopac" output to protect against XSS attacks

We're using the Template::Toolkit html and uri filters to ensure that
the usual suspects are escaped at output time to prevent trivial XSS
attacks.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: more aggressive dynamic output filtering
Bill Erickson [Wed, 17 Aug 2011 19:28:53 +0000 (15:28 -0400)]
TPac: more aggressive dynamic output filtering

Making heavier user of html/uri filters to prevent accidental or
malicious rendering of html from dynamic data.  More to follow.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAssume username, not barcode, in TPAC login
Dan Scott [Wed, 17 Aug 2011 17:01:08 +0000 (13:01 -0400)]
Assume username, not barcode, in TPAC login

In the absence of a barcode regex OU setting (opac.barcode_regex), the
TPAC was assuming that the entered value was a barcode. However, the
default JSPAC assumption was that the entered value was a username. This
commit makes the TPAC continue to function with the same assumptions as
the default JSPAC in the absence of a barcode regex OU setting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAddress ISBN issues in T-PAC
Dan Scott [Tue, 16 Aug 2011 20:44:16 +0000 (16:44 -0400)]
Address ISBN issues in T-PAC

A few problems fixed here:

* Refer to args.isbns (plural) consistently; at times we were referring
  to args.isbn which did not exist
* Grab the textContent of the SFX ISBN node rather than the raw
  XML::LibXML Element
* Use an assignment operation when regex'ing the SFX ISBN, as the
  in-place was interpreted as a "print me" stmt and displaying the raw
  SFX ISBN.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoT-PAC: Do not display a call number if we don't have one
Dan Scott [Tue, 16 Aug 2011 20:02:17 +0000 (16:02 -0400)]
T-PAC: Do not display a call number if we don't have one

Electronic records might not have a call number, so don't try to display
one if there isn't one (in search results).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMerge branch 'collab/berick/template-toolkit-opac-master-merge' of git.evergreen...
Bill Erickson [Tue, 16 Aug 2011 19:33:03 +0000 (15:33 -0400)]
Merge branch 'collab/berick/template-toolkit-opac-master-merge' of git.evergreen-ils.org:working/Evergreen into template-toolkit-opac-master-merge

8 years agoTTPac: another merge casulty -> title_extended attribute
Bill Erickson [Tue, 16 Aug 2011 19:32:57 +0000 (15:32 -0400)]
TTPac: another merge casulty -> title_extended attribute

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerge branch 'collab/berick/template-toolkit-opac-master-merge' of git.evergreen...
Dan Scott [Tue, 16 Aug 2011 19:11:49 +0000 (15:11 -0400)]
Merge branch 'collab/berick/template-toolkit-opac-master-merge' of git.evergreen-ils.org:working/Evergreen into dbs/ttopac-master-merge

8 years agoDelete templates_kcls from core
Dan Scott [Tue, 16 Aug 2011 19:09:58 +0000 (15:09 -0400)]
Delete templates_kcls from core

The KCLS templates, while a useful demonstration of how to skin the
T-PAC, should be maintained outside of the core repository as they
contain branding elements, etc, that are specific to KCLS.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTTPac: move some templates into the right place
Bill Erickson [Tue, 16 Aug 2011 19:09:50 +0000 (15:09 -0400)]
TTPac: move some templates into the right place

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerged esi/template-toolkit-opac and repaired some merge conflicts
Bill Erickson [Tue, 16 Aug 2011 15:34:11 +0000 (11:34 -0400)]
Merged esi/template-toolkit-opac and repaired some merge conflicts

Note to self: the simple/detail view options on the results page will
need some tweaking, particularly since many/most will want to see the
detail view by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac...
Bill Erickson [Tue, 16 Aug 2011 15:14:41 +0000 (11:14 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

8 years agoVandelay: don't clear match-set when creating new queue
Bill Erickson [Tue, 16 Aug 2011 14:55:39 +0000 (10:55 -0400)]
Vandelay: don't clear match-set when creating new queue

This avoids the problem of: enter match set in the UI => enter name for
new queue => match set is cleared.  Match set is still cleared/set when
an existing queue is selected, since existing queues already have a
match set.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoKeep the logging output of the EDI translator by default
Lebbeous Fogle-Weekley [Tue, 16 Aug 2011 13:10:45 +0000 (09:10 -0400)]
Keep the logging output of the EDI translator by default

There is valuable troubleshooting information there that is otherwise hard to
find.  This particularly matters when the output of an EDI
Action/Trigger template (JEDI) doesn't successfully get translated to
EDIFACT for nonobvious reasons.

In production environments, you might instead pipe to logger so that you can
collect output with syslog, rather than in a flat file.  As long as
output goes *somewhere.*

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoLP#820409 fix org unit admin UI
Jason Etheridge [Mon, 15 Aug 2011 19:34:07 +0000 (15:34 -0400)]
LP#820409 fix org unit admin UI

This reverts part of 17e659eec3e23caf5d301b33aa5019b672ecd0e8, which was
tightening checks against null and '' to avoid implicit type-casting.

This line var modified_ou = new aou().fromStoreItem( current_ou ); was
producing a fieldmapper object where certain fields were being set to
contain the string "undefined" rather than a null.

The update method would take isdeleted == "undefined" as True.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoStamped upgrades for LP#825303
Mike Rylander [Tue, 16 Aug 2011 13:00:43 +0000 (09:00 -0400)]
Stamped upgrades for LP#825303

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoreturn only the one applicable OU setting value
Galen Charlton [Fri, 12 Aug 2011 20:09:11 +0000 (16:09 -0400)]
return only the one applicable OU setting value

Correct actor.org_unit_ancestor_setting so that it returns
at most one setting value, rather than the entire set
 of values defined for the OU and its ancestors.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agolp#825303: fix cat.default_classification_scheme lookup
Galen Charlton [Fri, 12 Aug 2011 16:18:54 +0000 (12:18 -0400)]
lp#825303: fix cat.default_classification_scheme lookup

Fixes a bug where the wrong default classification scheme
could be chosen when adding a new volume whose classification
scheme was not explicitly set.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoTTPac: Hide pagination for 1-page hits
Bill Erickson [Tue, 16 Aug 2011 12:24:38 +0000 (08:24 -0400)]
TTPac: Hide pagination for 1-page hits

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: added simple/detailed record view option to results page
Bill Erickson [Mon, 15 Aug 2011 21:38:12 +0000 (17:38 -0400)]
TTpac: added simple/detailed record view option to results page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTPac: move results pageing chunk to new template
Bill Erickson [Mon, 15 Aug 2011 18:56:50 +0000 (14:56 -0400)]
TTPac: move results pageing chunk to new template

table.tt2 and paging are complex enough and will likely result in much
local customization.  Break them up into 2 page to simplify.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: show page range in results paging display
Bill Erickson [Mon, 15 Aug 2011 18:42:45 +0000 (14:42 -0400)]
TTpac: show page range in results paging display

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTPac: change default any-format to 'All Formats'
Bill Erickson [Mon, 15 Aug 2011 15:28:19 +0000 (11:28 -0400)]
TTPac: change default any-format to 'All Formats'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: option to override no-choice label in coded value selector
Bill Erickson [Mon, 15 Aug 2011 15:28:01 +0000 (11:28 -0400)]
TTpac: option to override no-choice label in coded value selector

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: Chilifresh reviews panel occupies the width of the table
Bill Erickson [Mon, 15 Aug 2011 15:18:33 +0000 (11:18 -0400)]
TTpac: Chilifresh reviews panel occupies the width of the table

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoStamped upgrade script for "lp 823496: do not fail to index personal names that have...
Mike Rylander [Sat, 13 Aug 2011 01:07:41 +0000 (21:07 -0400)]
Stamped upgrade script for "lp 823496: do not fail to index personal names that have relators"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agolp 823496: don't fail to index personal names that have relators
Galen Charlton [Tue, 9 Aug 2011 19:30:56 +0000 (15:30 -0400)]
lp 823496: don't fail to index personal names that have relators

The default definition for the author|other index inadvertantly
excluded names from 600, 700, 720, and 800 fields that have
relator values ($e) or codes ($4).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoVandelay: capture one match per catalog record
Bill Erickson [Fri, 12 Aug 2011 21:03:11 +0000 (17:03 -0400)]
Vandelay: capture one match per catalog record

When searching for matches to existing catalog records
(biblio.record_entry's), Vandelay can in some cases result in multiple
like matches for the same record (with the same match score).  This
trims it down to 1 match per record.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAdd some additional logging in SIP/Transaction/Feepayment.pm.
Jason Stephenson [Thu, 4 Aug 2011 20:02:15 +0000 (16:02 -0400)]
Add some additional logging in SIP/Transaction/Feepayment.pm.

This should help with debugging, etc.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd OILS_SIP_MSG_BILL_ERR for when an error occurs getting bills.
Jason Stephenson [Thu, 4 Aug 2011 16:31:49 +0000 (12:31 -0400)]
Add OILS_SIP_MSG_BILL_ERR for when an error occurs getting bills.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd event textcode as alternative to descr in FeePayment.pm.
Jason Stephenson [Thu, 14 Jul 2011 17:59:47 +0000 (13:59 -0400)]
Add event textcode as alternative to descr in FeePayment.pm.

Some events have no descr, it seems.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoBail from fee payment if no bills are found.
Jason Stephenson [Wed, 13 Jul 2011 22:28:26 +0000 (18:28 -0400)]
Bail from fee payment if no bills are found.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd SIP2 fee payment, the 37/38 message/response pairs.
Jason Stephenson [Thu, 30 Jun 2011 15:48:28 +0000 (11:48 -0400)]
Add SIP2 fee payment, the 37/38 message/response pairs.

* Pay individual bill if a fee id is given by the SC.

* Pay multiple bills in batch so if one fails the whole transaction
  is aborted and a failure response is sent to the SC.

* Reject payments outright if the SC sends an overpayment.

* Add constants for bill not found and overpayment messages.

* Whole lotta logging goin' on (maybe too much).

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoDon't escape_html numbers in util/print.js
Thomas Berezansky [Fri, 12 Aug 2011 19:47:25 +0000 (15:47 -0400)]
Don't escape_html numbers in util/print.js

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoEscape HTML characters in template subs
Thomas Berezansky [Thu, 11 Aug 2011 01:37:54 +0000 (21:37 -0400)]
Escape HTML characters in template subs

This prevents injection of random HTML from various sources.

Like bad bib records, org unit settings, patron info, etc.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoUse openDialog to make go_print workaround vanish
Thomas Berezansky [Thu, 11 Aug 2011 01:03:46 +0000 (21:03 -0400)]
Use openDialog to make go_print workaround vanish

By passing params and the go_print function into openDialog we get
to ignore race conditions, as the window is created with the passed
in arguments.

Oh, and we can stop using js2JSON and such.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoAdd openDialog to window class
Thomas Berezansky [Thu, 11 Aug 2011 01:02:51 +0000 (21:02 -0400)]
Add openDialog to window class

Uses window.openDialog instead of window.open.
https://developer.mozilla.org/en/DOM/window.openDialog

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoNo more lightpink for disabled copy editor
Jason Etheridge [Fri, 12 Aug 2011 20:04:43 +0000 (16:04 -0400)]
No more lightpink for disabled copy editor

Folks can still provide custom CSS against those class hooks if desired

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoin lieu of Ready Item Editor
Jason Etheridge [Thu, 11 Aug 2011 18:16:24 +0000 (14:16 -0400)]
in lieu of Ready Item Editor

We're trying to prevent folks from using the item attribute editor in the
unified interface when the volume pane is still updating its information
(i.e. building the copies to feed to the attribute editor), so that a
given editing widget isn't ripped out from under staff while its being
used.  This change removes the heavy-handed Ready Item Editor button and
instead tries to more gracefully manage the editor state based on change
and keypress events.  Also change the color scheme for a disabled editor
from red to light pink.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoStamped upgrade script for "For vandelay bib matching, make 020, 022, 024 tags case...
Mike Rylander [Fri, 12 Aug 2011 19:06:01 +0000 (15:06 -0400)]
Stamped upgrade script for "For vandelay bib matching, make 020, 022, 024 tags case-insensitive"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFor vandelay bib matching, make 020, 022, 024 tags case-insensitive
Lebbeous Fogle-Weekley [Fri, 12 Aug 2011 15:35:16 +0000 (11:35 -0400)]
For vandelay bib matching, make 020, 022, 024 tags case-insensitive

For user convenience.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoRemoved errant '-' causing sql syntax failure
Bill Erickson [Fri, 12 Aug 2011 12:40:31 +0000 (08:40 -0400)]
Removed errant '-' causing sql syntax failure

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac...
Bill Erickson [Thu, 11 Aug 2011 21:50:09 +0000 (17:50 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

9 years agoMerge esi/template-toolkit-opac and repaired some conflicts
Bill Erickson [Thu, 11 Aug 2011 21:48:00 +0000 (17:48 -0400)]
Merge esi/template-toolkit-opac and repaired some conflicts

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: minor i18n and other cleanup
Bill Erickson [Thu, 11 Aug 2011 21:21:03 +0000 (17:21 -0400)]
TTpac: minor i18n and other cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: removed last bits of propagator; minor cleanup
Bill Erickson [Thu, 11 Aug 2011 21:17:40 +0000 (17:17 -0400)]
TTpac: removed last bits of propagator; minor cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: Added Expand/Collaps all 'extras' tabs in detail page
Bill Erickson [Thu, 11 Aug 2011 20:59:22 +0000 (16:59 -0400)]
TTpac: Added Expand/Collaps all 'extras' tabs in detail page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: more use of mkurl() and general cleanup
Bill Erickson [Thu, 11 Aug 2011 20:30:11 +0000 (16:30 -0400)]
TTpac: more use of mkurl() and general cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoForce-encode CGI param values to prevent decode errors
Bill Erickson [Thu, 11 Aug 2011 20:25:50 +0000 (16:25 -0400)]
Force-encode CGI param values to prevent decode errors

CGI.pm decode()'s parameter values, so if it encounters a value that
is already decoded, it will croak and kill the page.  Proactively encode
paramter values so decode() won't fail.

The better solution may be to determine how we get such data, but
until then, let's allow the t-pac to work on funky data.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: start using mkurl(); more todo..
Bill Erickson [Thu, 11 Aug 2011 15:56:41 +0000 (11:56 -0400)]
TTpac: start using mkurl();  more todo..

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTopac: cgi-based replacement for url 'propagator'
Bill Erickson [Thu, 11 Aug 2011 15:56:15 +0000 (11:56 -0400)]
TTopac: cgi-based replacement for url 'propagator'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: show MARC callnumber in record detail page
Bill Erickson [Wed, 10 Aug 2011 21:21:50 +0000 (17:21 -0400)]
TTpac: show MARC callnumber in record detail page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: option to view larger sets of copies on record page
Bill Erickson [Wed, 10 Aug 2011 21:07:36 +0000 (17:07 -0400)]
TTpac: option to view larger sets of copies on record page

On record details page, added a "Show More Copies" option to show more
(50) copies per page of copies than the default (10).  Also added a
"Show Fewer Copies" option to return to the default copy page size.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: show full 245 for title on record details page
Bill Erickson [Wed, 10 Aug 2011 19:26:53 +0000 (15:26 -0400)]
TTpac: show full 245 for title on record details page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTTpac: Capture and show all ISBNs on record details page
Bill Erickson [Wed, 10 Aug 2011 19:22:46 +0000 (15:22 -0400)]
TTpac: Capture and show all ISBNs on record details page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoShow more subject data in the expanded ttopac subjects display
Bill Erickson [Wed, 10 Aug 2011 19:07:40 +0000 (15:07 -0400)]
Show more subject data in the expanded ttopac subjects display

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdded support for series display in ttopac record details
Bill Erickson [Wed, 10 Aug 2011 19:01:58 +0000 (15:01 -0400)]
Added support for series display in ttopac record details

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAccommodate multiple 520a's in tt-opac summary display
Bill Erickson [Wed, 10 Aug 2011 18:16:13 +0000 (14:16 -0400)]
Accommodate multiple 520a's in tt-opac summary display

MARC args.summary is now an array of summary entries.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTweak Override Dialog so that the text can wrap
Jason Etheridge [Wed, 10 Aug 2011 18:04:11 +0000 (14:04 -0400)]
Tweak Override Dialog so that the text can wrap

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoTweak wording for Checkout's Override Once feature
Jason Etheridge [Wed, 10 Aug 2011 18:03:37 +0000 (14:03 -0400)]
Tweak wording for Checkout's Override Once feature

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoAdd note that overrides will stay for the session
Thomas Berezansky [Wed, 27 Jul 2011 21:14:43 +0000 (17:14 -0400)]
Add note that overrides will stay for the session

Same way other overrides get an additional note.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoAllow "override once per patron" at checkout
Thomas Berezansky [Mon, 18 Jul 2011 15:35:08 +0000 (11:35 -0400)]
Allow "override once per patron" at checkout

Specifically for patron-derived overrides:
PATRON_EXCEEDS_OVERDUE_COUNT
PATRON_BARRED
PATRON_EXCEEDS_CHECKOUT_COUNT
PATRON_EXCEEDS_FINES

This is done by:
Adding support for a list of "reported" overrides to util/network.js
Using that in Checkout to build an auto-override list for the current patron
Passing that list in at Checkout

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoMerge branch 'master' into template-toolkit-opac
Lebbeous Fogle-Weekley [Wed, 10 Aug 2011 14:36:27 +0000 (10:36 -0400)]
Merge branch 'master' into template-toolkit-opac

9 years agoStream records to ML for Vandelay queue export
Bill Erickson [Wed, 10 Aug 2011 14:23:32 +0000 (10:23 -0400)]
Stream records to ML for Vandelay queue export

Since queued records, with their marcxml blobs, are fairly large, avoid
fetching them atomically when possible.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoGranular invalid data detection for Vandelay item import
Bill Erickson [Mon, 8 Aug 2011 19:05:47 +0000 (15:05 -0400)]
Granular invalid data detection for Vandelay item import

When an import item contains any data for a field, the code now verifies
the data is valid for the selected field.  When the data is not valid,
we capture information on which field is invalid and what data was used
for the field (import_error, error_detail) so it can be reported in the
interface.

This adds new import_errors:

import.item.invalid.status
import.item.invalid.price
import.item.invalid.deposit_amount
import.item.invalid.owning_lib
import.item.invalid.circ_lib
import.item.invalid.copy_number
import.item.invalid.circ_as_type

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoShow copy status/location names in Vandelay items grid
Bill Erickson [Thu, 4 Aug 2011 22:14:00 +0000 (18:14 -0400)]
Show copy status/location names in Vandelay items grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoStamping upgrade scripts for LP#818740
Thomas Berezansky [Tue, 9 Aug 2011 18:14:18 +0000 (14:14 -0400)]
Stamping upgrade scripts for LP#818740

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoOrg setting for the result cap for Patron Search
Jason Etheridge [Sun, 31 Jul 2011 05:39:39 +0000 (01:39 -0400)]
Org setting for the result cap for Patron Search

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoFix stop sign page race condition with checkout
Jason Etheridge [Mon, 8 Aug 2011 18:06:57 +0000 (14:06 -0400)]
Fix stop sign page race condition with checkout

This would happen most often when retrieving multiple patrons at the same time
from patron search--the stop sign page would show but then get trampled by the
checkout interface, which normally loads first.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoTell OPAC to use checkin date, not stop_fines date
Thomas Berezansky [Mon, 25 Jul 2011 19:58:40 +0000 (15:58 -0400)]
Tell OPAC to use checkin date, not stop_fines date

The column is labeled "Date Returned", not "Date we stopped generating fines".

This does lead to "(fines accruing)" for an item that has hit max fines, or stopped fines for some other reason.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agousername login for web selfcheck
Jason Etheridge [Mon, 8 Aug 2011 19:22:34 +0000 (15:22 -0400)]
username login for web selfcheck

Changes the behavior for the patron-login component (after staff login) to match
the OPAC.  By default, it assumes you are logging in with a usrname, but if the
org unit setting 'opac.barcode_regex' is enabled and the incoming value matches,
then it gets treated as a library card barcode instead. If usrname is used, then
the card referenced by actor.usr.card is checked in lieu of a specified barcode.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoaction for marking items claimed never checked out
Jason Etheridge [Tue, 2 Aug 2011 03:07:24 +0000 (23:07 -0400)]
action for marking items claimed never checked out

Menu action in Patron Items Out for marking items as Claimed Never Checked Out.
Note that this action behaves differently than Claimed Returned, in that the
item is actually checked in and the transaction closed, and will not continue
to show up in Items Out for the patron.

If decide later to provide an option for making the two actions consistent,
there is code in the original working branch, collab/phasefx/claimed_never_cko,
which modifies the patron display and the .checked_out methods to look for
open CLAIMSNEVERCHECKEDOUT transactions.  Some cleanup would be needed to avoid
merge conflicts.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoStamped upgrade scripts for LP#797409
Mike Rylander [Tue, 9 Aug 2011 17:26:17 +0000 (13:26 -0400)]
Stamped upgrade scripts for LP#797409

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoIgn Reshelving->Available for status_changed_time
Jason Etheridge [Mon, 8 Aug 2011 13:07:40 +0000 (09:07 -0400)]
Ign Reshelving->Available for status_changed_time

This solves a complication when wanting to check status_changed_time against
offline xact_time when processing offline transactions.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoRobustify SKIP_ASSET_CHANGE functionality
Jason Etheridge [Thu, 4 Aug 2011 16:11:49 +0000 (12:11 -0400)]
Robustify SKIP_ASSET_CHANGE functionality

by skipping status_changed_time test if a barcode has been encountered in prior
offline transaction within a given session.  Also return the SKIP_ASSET_CHANGE
event for a given barcode if a prior test resulted in SKIP_ASSET_CHANGE

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoOffline checkin & renewal checks, & ou settings
Jason Etheridge [Thu, 4 Aug 2011 02:32:51 +0000 (22:32 -0400)]
Offline checkin & renewal checks, & ou settings

Augmented edoceo's patch for checking an offline checkout against an item's
Status Changed Time and throwing a SKIP_ASSET_CHANGED event if warranted as
follows:

1) include checkin and renewal transactions
2) add org unit settings for each, and a corresponding upgrade script
3) removed the description from the payload and created a dedicated ils_event

However, there are two issues affecting this functionality, even before my
meddling:

1) the Reshelving -> Available rollover updates an item's Status Changed Time,
   and can thus trigger this event
2) if an item is manipulated more than once in an offline session, then its
   Status Changed Time can be updated as the transactions are being processed,
   causing related transactions after the initial transaction to fail

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#797409: Offline Transaction - Option to Skip Old Records
Atom Edoceo [Tue, 2 Aug 2011 05:54:37 +0000 (22:54 -0700)]
LP#797409: Offline Transaction - Option to Skip Old Records

Skip Copy with later Status Change Time on offline checkout import
Requires the following option in offline-config.pl
  $main::config{skip_late} = 1;

Signed-off-by: David Busby <code@edoceo.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoWhoops. Do that availability test regard of whether hold_boundaries are used.
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 20:01:09 +0000 (16:01 -0400)]
Whoops. Do that availability test regard of whether hold_boundaries are used.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoIn a middle-layer method for returning holdable formats on a metarecord,
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 18:31:03 +0000 (14:31 -0400)]
In a middle-layer method for returning holdable formats on a metarecord,

Do a better test of copy holdability than we were doing previously.
We can't do a perfect test: we don't really know what patron we're doing
this for, and even if we did, from here it's nontrivial to figure out
whether we're doing indb holds or script-based, much less run the tests.

Still, we can test whether a copy's in a holdable status, a holdable
location, and is itself not explicitly marked unholdable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Bill Erickson [Fri, 5 Aug 2011 18:58:50 +0000 (14:58 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac...
Bill Erickson [Fri, 5 Aug 2011 18:57:03 +0000 (14:57 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

9 years agoMerge remote branch 'esi/template-toolkit-opac' into template-toolkit-opac-master...
Bill Erickson [Fri, 5 Aug 2011 18:56:11 +0000 (14:56 -0400)]
Merge remote branch 'esi/template-toolkit-opac' into template-toolkit-opac-master-merge

9 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Bill Erickson [Fri, 5 Aug 2011 17:53:54 +0000 (13:53 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

9 years agoSpeed up t-pac record details copy retrieval
Bill Erickson [Fri, 5 Aug 2011 17:52:17 +0000 (13:52 -0400)]
Speed up t-pac record details copy retrieval

Using JOIN filters instead of WHERE clauses, drastically speed up
paged/sorted copy retrieval, particularly for items with many copies, in
the record details page.

Thanks for the suggestions, Mike.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoThis doesn't need to be lying around any more
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 17:32:55 +0000 (13:32 -0400)]
This doesn't need to be lying around any more

Its purpose was superceded by another upgrade script in master.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agomrpeters caught this; wrong variable fed to error dialog
Jason Etheridge [Fri, 5 Aug 2011 02:27:45 +0000 (22:27 -0400)]
mrpeters caught this; wrong variable fed to error dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoRepaired copy private/public note vandelay bug
Bill Erickson [Thu, 4 Aug 2011 20:46:54 +0000 (16:46 -0400)]
Repaired copy private/public note vandelay bug

Previously, all copy notes imported through vandelay were coming in as
public copy notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoMerge remote branch 'esi/template-toolkit-opac' into template-toolkit-opac-master...
Bill Erickson [Thu, 4 Aug 2011 19:41:32 +0000 (15:41 -0400)]
Merge remote branch 'esi/template-toolkit-opac' into template-toolkit-opac-master-merge

9 years agoRevert "remove the unfinished id_as_barcode functionality"
Thomas Berezansky [Thu, 4 Aug 2011 19:25:08 +0000 (15:25 -0400)]
Revert "remove the unfinished id_as_barcode functionality"

This reverts commit 5fa01d69f7374c0c8710db4a951edb80ed5ae733.

Bit too soon, actually. Staff client still uses the function to
verify credentials.

Maybe I skipped this the first time on purpose.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoremove the unfinished id_as_barcode functionality
Jason Etheridge [Sun, 31 Jul 2011 04:01:31 +0000 (00:01 -0400)]
remove the unfinished id_as_barcode functionality

remove the unfinished id_as_barcode setting for open-ils.actor and remove unused open-ils.actor.user.retrieve_id_by_barcode_or_username method

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoStamped upgrade script for ACQ_INVOICE_REOPEN permission addition
Mike Rylander [Thu, 4 Aug 2011 19:10:36 +0000 (15:10 -0400)]
Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUpgrade script for LP818311 branch.
Jason Stephenson [Thu, 4 Aug 2011 14:13:56 +0000 (10:13 -0400)]
Upgrade script for LP818311 branch.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#818311: ACQ_INVOICE_REOPEN is missing
Michael Peters [Thu, 4 Aug 2011 12:59:15 +0000 (08:59 -0400)]
LP#818311:  ACQ_INVOICE_REOPEN is missing

This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions
Administrator user.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoSpeed up holds history retrieval
Bill Erickson [Thu, 4 Aug 2011 19:01:09 +0000 (15:01 -0400)]
Speed up holds history retrieval

Consistent w/ circ history retrieval, use the longer column 'transform'
stored proc invocation to limit retrieval to historical holds IDs
instead of entire objects, which are later fetched/fleshed anyway.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoFix i18n build
Dan Scott [Fri, 29 Jul 2011 20:09:58 +0000 (16:09 -0400)]
Fix i18n build

Two problems thrown at the i18n build:

  * $$ quoting is not understood by db-seed-i18n.py; simple approach is
    to use standard single-quote escaping of the single-quote in
    950.data.seed-values.sql (warning: this might lead to other problems
    with the regular expression in db-seed-i18n.py)
  * authority.js includes Unicode values (shock!) and so we must treat
    the incoming strings as unicode() instead of plain old str()

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFaster T-pac circ history retrieval
Bill Erickson [Thu, 4 Aug 2011 18:53:36 +0000 (14:53 -0400)]
Faster T-pac circ history retrieval

* Take advantage of the new default sorting behavior of
action.usr_visible_circs to perform limit/offset within the DB instead
of fetching the whole circ history in the mod_perl code and sorting
through it.

* Also use the  more powerful/verbose column transform syntax for
calling stored procedures to retrieve only the historical circ IDs
instead of the full circ objects, since we are re-fetching fleshed circ
objects later in the code.

Signed-off-by: Bill Erickson <berick@esilibrary.com>