working/Evergreen.git
9 years agoUpdate for corrected cmc.name -> cmc.label marking in seed data
dbs [Tue, 19 Apr 2011 02:57:23 +0000 (02:57 +0000)]
Update for corrected cmc.name -> cmc.label marking in seed data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20195 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMark cmc.label for translation, not cmc.name, in seed data
dbs [Tue, 19 Apr 2011 02:52:48 +0000 (02:52 +0000)]
Mark cmc.label for translation, not cmc.name, in seed data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20192 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMark cmf and cmc labels as translatable
dbs [Tue, 19 Apr 2011 02:19:53 +0000 (02:19 +0000)]
Mark cmf and cmc labels as translatable

We went to the effort of extracting the translatable text from
950.data.seed-values.sql, but had not marked the fields as
translatable in the IDL. Now at least the out-of-the-box
fields and classes will easily be able to have translations.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20189 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoCheck in the POT files so that translation interface can be satisfied
dbs [Tue, 19 Apr 2011 02:14:04 +0000 (02:14 +0000)]
Check in the POT files so that translation interface can be satisfied

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20188 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd openils.widget.Searcher Dojo NLS to the i18n build
dbs [Tue, 19 Apr 2011 01:48:43 +0000 (01:48 +0000)]
Add openils.widget.Searcher Dojo NLS to the i18n build

Necessary for the "advanced" searchbar on the Evergreen
AjaxPAC.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20185 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoCorrect encoding issue with authority_control_fields.pl
dbs [Tue, 19 Apr 2011 01:03:58 +0000 (01:03 +0000)]
Correct encoding issue with authority_control_fields.pl

Is there ever a time when MARC::File::XML would be invoked with
anything other than BinaryEncoding => 'utf-8'? Not here, at
least. Addresses LP# 764582.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20182 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoImprovements to search tuning
miker [Mon, 18 Apr 2011 19:57:01 +0000 (19:57 +0000)]
Improvements to search tuning

 * Move to in-core fts function, instead of the compat wrapper provided by the tsearch2 contrib
 * Provide default cover density tuning (config file)
 * Move default preferred language settings from storage to search, where they make more sense

More on the CD tuning:

  Evergreen uses a cover density algorithm for calculating relative ranking of matches.  There
  are several tuning parameters and options available.  By default, no document length normalization
  is applied.  From the Postgres documentation on ts_rank_cd() (the function used by Evergreen):

      Since a longer document has a greater chance of containing a query term it is reasonable
      to take into account document size, e.g., a hundred-word document with five instances of
      a search word is probably more relevant than a thousand-word document with five instances.
      Both ranking functions take an integer normalization option that specifies whether and how
      a document's length should impact its rank. The integer option controls several behaviors,
      so it is a bit mask: you can specify one or more behaviors using | (for example, 2|4).

          0 (the default) ignores the document length

          1 divides the rank by 1 + the logarithm of the document length

          2 divides the rank by the document length

          4 divides the rank by the mean harmonic distance between extents (this is implemented only by ts_rank_cd)

          8 divides the rank by the number of unique words in document

          16 divides the rank by 1 + the logarithm of the number of unique words in document

          32 divides the rank by itself + 1

      If more than one flag bit is specified, the transformations are applied in the order listed.

      It is important to note that the ranking functions do not use any global information, so it
      is impossible to produce a fair normalization to 1% or 100% as sometimes desired. Normalization
      option 32 (rank/(rank+1)) can be applied to scale all ranks into the range zero to one, but of
      course this is just a cosmetic change; it will not affect the ordering of the search results.

  In Evergreen, these options are set via search modifiers.  The modifiers are mapped in the
  following way:

      * #CD_logDocumentLength  => 1  :: rank / (1 + LOG(total_word_count))   :: Longer documents slightly less relevant
      * #CD_documentLength     => 2  :: rank / total_word_count              :: Longer documents much less relevant
      * #CD_meanHarmonic       => 4  :: Word Proximity                       :: Greater matched-word distance is less relevant
      * #CD_uniqueWords        => 8  :: rank / unique_word_count             :: Documents with repeated words much less relevant
      * #CD_logUniqueWords     => 16 :: rank / (1 + LOG(unique_word_count))  :: Documents with repeated words slightly less relevant
      * #CD_selfPlusOne        => 32 :: rank / (1 + rank)                    :: Cosmetic normalization of rank value between 0 and 1

  Adding one or more of these to the default_CD_modifiers list will cause all searches that use QueryParser to apply them.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20180 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoone more fix, for Show in Catalog on issuance holds
phasefx [Mon, 18 Apr 2011 19:45:27 +0000 (19:45 +0000)]
one more fix, for Show in Catalog on issuance holds

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20178 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agodisplay issuance label, not subscription label
phasefx [Mon, 18 Apr 2011 19:35:16 +0000 (19:35 +0000)]
display issuance label, not subscription label

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20176 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd Part Holds to Actions for this Record -> View Holds. Also add xul support for...
phasefx [Mon, 18 Apr 2011 18:40:30 +0000 (18:40 +0000)]
add Part Holds to Actions for this Record -> View Holds.  Also add xul support for displaying issuance holds (needs testing)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20174 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agosupport Part Holds in xul lists
phasefx [Mon, 18 Apr 2011 18:03:41 +0000 (18:03 +0000)]
support Part Holds in xul lists

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20171 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agono need to flesh the record here
phasefx [Mon, 18 Apr 2011 18:03:38 +0000 (18:03 +0000)]
no need to flesh the record here

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20170 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotypo
phasefx [Mon, 18 Apr 2011 17:30:11 +0000 (17:30 +0000)]
typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20168 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoimprove comments on a couple config tables
gmc [Mon, 18 Apr 2011 15:41:20 +0000 (15:41 +0000)]
improve comments on a couple config tables

Based on suggestions from Mike Rylander and Thomas Berezansky.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20162 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoscript to update DB object comments
gmc [Mon, 18 Apr 2011 15:41:18 +0000 (15:41 +0000)]
script to update DB object comments

New script, update-db-comments.sh, to be run as part of upgrades
to refresh comments on database schema objects.  Usage is:

  update-db-comments.sh db-host db-port db-name db-user db-pass

The helper script grab-db-comment.pl is what actually parses out
the comment statements.

To avoid repetition, the list of default SQL scripts to use when
initializing an Evergreen database has been moved to a new file
called sql_file_manifest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20161 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agominor improvements to database object comments
gmc [Mon, 18 Apr 2011 15:41:16 +0000 (15:41 +0000)]
minor improvements to database object comments

* remove copyright, license verbiage, and C-style comment marking
  from the comments; these can live in the SQL scripts
* updated several copyright headers
* minor improvements to documentation of a couple tables

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20160 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofixes Edit Volumes action by flattening the volume objects before updating them
phasefx [Mon, 18 Apr 2011 15:37:12 +0000 (15:37 +0000)]
fixes Edit Volumes action by flattening the volume objects before updating them

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20158 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoin the MARC Editor, put the callnumber and barcode textboxes for Fast Item Add on...
phasefx [Mon, 18 Apr 2011 05:27:15 +0000 (05:27 +0000)]
in the MARC Editor, put the callnumber and barcode textboxes for Fast Item Add on a separate row

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20151 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEnable relative paths in i18n testing scripts
dbs [Mon, 18 Apr 2011 05:14:41 +0000 (05:14 +0000)]
Enable relative paths in i18n testing scripts

We were 98% of the way there; now we no longer need to
cd into the same directory as the i18n testing scripts
to run them with meaningful output. Should be useful
for adding these to the CI server.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20148 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDon't check .js files for entities
dbs [Mon, 18 Apr 2011 04:38:46 +0000 (04:38 +0000)]
Don't check .js files for entities

Must have asked this script to check JS files for valid entities
for a reason at some point in the dark past, but it couldn't have
been a very good reason; we're getting a false positive that needs
to be hushed now. Better to just stop looking for XML entities in
JavaScript.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20145 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEmpty strings in oils_i18n_gettext() throw i18n errors
dbs [Mon, 18 Apr 2011 03:32:04 +0000 (03:32 +0000)]
Empty strings in oils_i18n_gettext() throw i18n errors

When you run 'make newpot', if you have an empty string in an
oils_i18n_gettext() function, you'll see errors like:

Error in line 1712 of SQL source file: 'NoneType' object has no attribute 'group'

This satisfies the i18n build process and also serves as a
more evident placeholder for expanded descriptions if someone
feels so inclined in the future.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20139 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd new macros for print templates.
phasefx [Sun, 17 Apr 2011 19:25:38 +0000 (19:25 +0000)]
Add new macros for print templates.

%-TRIM%
Trims whitespace before the macro

%TRIM-%
Trims whitespace after the macro

%SUBSTR(#)%...%SUBSTR_END%
Take substring starting at position # to end of string.
If # is negative count backwards from end of string.

%SUBSTR(#,#)%...%SUBSTR_END%
Same as previous, but limit to second provided number characters after start point.
If second number is negative, count backwards instead of forwards.

TRIM macros inside of SUBSTR will be replaced first, then SUBSTR, then TRIM outside of SUBSTR.

Author: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20137 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofix Add Items off of volumes by changing the label key in copy_shortcut to callnumber...
phasefx [Sat, 16 Apr 2011 21:35:46 +0000 (21:35 +0000)]
fix Add Items off of volumes by changing the label key in copy_shortcut to callnumber composite key

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20136 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotrace statements. need to change how copy_shortcut is constructed in parent interfaces
phasefx [Sat, 16 Apr 2011 21:35:44 +0000 (21:35 +0000)]
trace statements.  need to change how copy_shortcut is constructed in parent interfaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20135 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotrace statements
phasefx [Sat, 16 Apr 2011 21:35:42 +0000 (21:35 +0000)]
trace statements

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20134 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotrace statements
phasefx [Sat, 16 Apr 2011 21:35:40 +0000 (21:35 +0000)]
trace statements

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20133 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agocomment tweak
phasefx [Sat, 16 Apr 2011 21:35:38 +0000 (21:35 +0000)]
comment tweak

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20132 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAllow NULL "use restriction" fields for located URIs
dbs [Sat, 16 Apr 2011 03:26:11 +0000 (03:26 +0000)]
Allow NULL "use restriction" fields for located URIs

The asset.uri.use_restriction field, which is really a sort of public notes
field for 856 fields, was grabbing the $u subfield (URL) as a sort of last-gasp
effort to give it some data. However, the effect was rather odd and led to
workarounds like Conifer's skin to avoid displaying the use restriction field
if its value was identical to the URL, etc.

Instead, stop grabbing $u and handle the case where use_restriction column is
NULL gracefully, just like the schema intended.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20123 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDo not clear auri links in default skin
dbs [Sat, 16 Apr 2011 03:18:53 +0000 (03:18 +0000)]
Do not clear auri links in default skin

The dojo orphan() call which attempted to wipe any non-located 856s
was actually wiping the located 856s in the record detail display.

Removing the extra call makes this work in Firefox and Chromium,
at least.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20120 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDelete ##URI## call numbers and uri_call_number_map entries on bib reingest
dbs [Sat, 16 Apr 2011 02:16:05 +0000 (02:16 +0000)]
Delete ##URI## call numbers and uri_call_number_map entries on bib reingest

This approach will lead to some acn/auricnm ID inflation, but it works.

Addresses LP# 761130 (immortal ##URI## entries in asset.call_number) reported
by Ben Shum and LP# 761085 (cannot delete bib with ##URI## volumes) reported
by Jason Etheridge.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20117 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoprune unused script; purpose now served by eg_db_config.pl
gmc [Fri, 15 Apr 2011 20:50:59 +0000 (20:50 +0000)]
prune unused script; purpose now served by eg_db_config.pl

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20115 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoProtect dumb JavaScript engines from having to deal with actual Unicode
dbs [Fri, 15 Apr 2011 20:13:46 +0000 (20:13 +0000)]
Protect dumb JavaScript engines from having to deal with actual Unicode

The holdings_xml format did not include an XML declaration, but adding that
as we do here still does not make the Firefox and Chromium JS engines capable
of consuming XML that contains Unicode content outside of the base ASCII
range.

So, we invoke entityize() to convert anything outside of the realm of
ASCII to XML entities. An alternative would be to invoke entityize() in
OpenILS::Application::SuperCat::unAPI::acn but it's not clear if that
would interfere with any other uses.

With this change, library names / copy location names with Unicode content
can be displayed correctly on the search results page.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20112 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMORE: Properly support extracting MARC21 fixed fields from the leader, not just the...
miker [Fri, 15 Apr 2011 16:27:46 +0000 (16:27 +0000)]
MORE: Properly support extracting MARC21 fixed fields from the leader, not just the 00x controlfields, in the "all fixed fields" version

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20107 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoProperly support extracting MARC21 fixed fields from the leader, not just the 00x...
miker [Fri, 15 Apr 2011 16:13:32 +0000 (16:13 +0000)]
Properly support extracting MARC21 fixed fields from the leader, not just the 00x controlfields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20104 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agothinko in for-in-array loop, uncovered by error testing from Ben Shum
miker [Fri, 15 Apr 2011 15:38:13 +0000 (15:38 +0000)]
thinko in for-in-array loop, uncovered by error testing from Ben Shum

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20101 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSupport mulitiple subfield-9 values in a single 856 tag
miker [Fri, 15 Apr 2011 14:49:34 +0000 (14:49 +0000)]
Support mulitiple subfield-9 values in a single 856 tag

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20100 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoProtect pcrud-ish retrieve from an empty result set
miker [Fri, 15 Apr 2011 13:55:20 +0000 (13:55 +0000)]
Protect pcrud-ish retrieve from an empty result set

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20094 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRestore URIs in marcxml-uris unAPI format
dbs [Thu, 14 Apr 2011 21:09:32 +0000 (21:09 +0000)]
Restore URIs in marcxml-uris unAPI format

At some point (r16750) we started doing a numeric comparison of
$flesh instead of just checking to see if $flesh was defined; this
returned false when $flesh == 'uris', preventing URIs from being
included in the marcxml-uris unAPI format.

This restores URIs to marcxml-uris and so we can revert the extra
BibTemplate call in rdetail_summary.xml.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20091 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSpecify the holdings_xml unAPI format for URI calls
dbs [Thu, 14 Apr 2011 20:38:04 +0000 (20:38 +0000)]
Specify the holdings_xml unAPI format for URI calls

The unAPI marcxml-uris format is not returning URIs at the moment.
While we're getting that fixed, use the holdings_xml format to
get the URI job done; requires an extra JS call, but that's
better than not working at all.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20088 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEscape rather than filter SIMILAR TO metacharacters in patron crazy search
dbs [Thu, 14 Apr 2011 18:18:37 +0000 (18:18 +0000)]
Escape rather than filter SIMILAR TO metacharacters in patron crazy search

The filtering I introduced in r19983 was overly aggressive, and included
characters that weren't actually SIMILAR TO metacharacters. Instead, escape
each character, carefully going through the list of metacharacters listed at
http://www.postgresql.org/docs/8.4/interactive/functions-matching.html

Works for email addresses like "foo.bar+baz@example.com".

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20085 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAddress LP #754880, where printing happens before the progress dialog can be
senator [Thu, 14 Apr 2011 17:57:32 +0000 (17:57 +0000)]
Address LP #754880, where printing happens before the progress dialog can be
cleared in the alternate holds pull list print interface

Additionally, provide the usual "print page" button so that the list can be
reprinted at will

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20082 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoupgrade script for consistency w/ schema change in r20073
erickson [Thu, 14 Apr 2011 16:50:20 +0000 (16:50 +0000)]
upgrade script for consistency w/ schema change in r20073

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20079 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotweaks to quick_metarecord_map.sql
gmc [Thu, 14 Apr 2011 15:48:55 +0000 (15:48 +0000)]
tweaks to quick_metarecord_map.sql

* used version from wiki, which provides same results as the
  previous version but performs better on large databases
* now works without editing (a vacuum cannot run inside of a transaction)
* don't do vacuum full, just a regular vacuum analyze

[1] http://evergreen-ils.org/dokuwiki/doku.php?id=scratchpad:random_magic_spells#how_to_generate_metarecords_for_a_newly_loaded_bib_batch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20075 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agorely on search_path to locate the extract_marc_field() function which is now installe...
erickson [Thu, 14 Apr 2011 14:23:30 +0000 (14:23 +0000)]
rely on search_path to locate the extract_marc_field() function which is now installed in the 'evergreen' schema by default

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20073 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoThinko in the delete query for copy visibility caching
miker [Wed, 13 Apr 2011 18:03:54 +0000 (18:03 +0000)]
Thinko in the delete query for copy visibility caching

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20070 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoProtect search against all-deleted bibs by pinning the estimation ratios in that...
miker [Wed, 13 Apr 2011 16:15:11 +0000 (16:15 +0000)]
Protect search against all-deleted bibs by pinning the estimation ratios in that case

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20069 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agostrip useless whitespace from XML output for transfer size reduction
miker [Wed, 13 Apr 2011 15:34:24 +0000 (15:34 +0000)]
strip useless whitespace from XML output for transfer size reduction

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20065 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd SVF data to in-db unAPI
miker [Wed, 13 Apr 2011 15:14:40 +0000 (15:14 +0000)]
add SVF data to in-db unAPI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20063 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agorepaired SQL upgrade syntax error
erickson [Tue, 12 Apr 2011 21:55:43 +0000 (21:55 +0000)]
repaired SQL upgrade syntax error

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20060 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd support for Multi-Homed Items (aka Foreign Bibs, aka Linked Items)
miker [Tue, 12 Apr 2011 19:51:54 +0000 (19:51 +0000)]
Add support for Multi-Homed Items (aka Foreign Bibs, aka Linked Items)

Evergreen needs to support the ability to attach a barcoded item to more than one bibliographic record.  Use cases include:
  1. Barcoded E-Readers with preloaded content
    * Readers would all be items attached to a single "master" bib record in the traditional way, through call numbers that define their ownership
    * Each reader, as a barcoded item, can be attached through Multi-homed Items to records describing the list of preloaded content
    * These attached Multi-homed Items can be added and removed as content is swapped out on each reader
  2. Dual-language items
    * Cataloger decides which of several alternate languages is the primary, and attaches the barcoded item to that record in the traditional way
    * Alternate language records are attached to this item through Multi-homed Items
  3. "Back-to-back" books -- two books printed upside down relative to one another, with two "front" covers
    * Cataloger decides which of the two titles is the primary, and attaches the barcoded item to that record in the traditional way
    * Alternate title record is attached to this item through Multi-homed Items
  4. Bound Volumes -- Sets of individual works collected into a single barcoded package
    * Cataloger decides which of the titles is the primary (or creates a record for the collection as a whole), and attaches the barcoded item to that record in the traditional way
    * Remaining title records for the collected peices are attached to this item through Multi-homed Items

Functionality funded by Natural Resources Canada -- http://www.nrcan-rncan.gc.ca/com/

Please see http://git.esilibrary.com/?p=evergreen-equinox.git;a=shortlog;h=refs/heads/multi_home for the full commit history.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20056 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd a trigger function to simulate FKEY constraints on inherited tables
miker [Tue, 12 Apr 2011 18:16:07 +0000 (18:16 +0000)]
Add a trigger function to simulate FKEY constraints on inherited tables

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20053 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFinal cleanup for the base schema, re search_path ... I hope
miker [Tue, 12 Apr 2011 17:29:26 +0000 (17:29 +0000)]
Final cleanup for the base schema, re search_path ... I hope

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20052 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFix functions stranded in the evergreen schema without a search path reference (ugly...
miker [Tue, 12 Apr 2011 17:13:25 +0000 (17:13 +0000)]
Fix functions stranded in the evergreen schema without a search path reference (ugly but mechanical)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20047 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd missing upgrade script
gmc [Tue, 12 Apr 2011 16:53:04 +0000 (16:53 +0000)]
add missing upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20044 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoLet's not be picky about permissions here; an item needs to go where it needs to...
phasefx [Mon, 11 Apr 2011 16:55:56 +0000 (16:55 +0000)]
Let's not be picky about permissions here; an item needs to go where it needs to go :)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20040 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofix my overzealous editing of configure.ac
gmc [Mon, 11 Apr 2011 16:31:38 +0000 (16:31 +0000)]
fix my overzealous editing of configure.ac

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20039 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agopatch from jamesrf for lp#756880 for Grocery Billing Location in Bill Patron wizard
phasefx [Sun, 10 Apr 2011 21:34:50 +0000 (21:34 +0000)]
patch from jamesrf for lp#756880 for Grocery Billing Location in Bill Patron wizard

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20036 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofor lp bug#756838, consistent copy status for new items. jamesrf++
phasefx [Sun, 10 Apr 2011 20:52:49 +0000 (20:52 +0000)]
for lp bug#756838, consistent copy status for new items.  jamesrf++

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20033 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agorepaired bug in prepayment_required check. property -> method
erickson [Fri, 8 Apr 2011 19:27:51 +0000 (19:27 +0000)]
repaired bug in prepayment_required check.  property -> method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20030 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFor transit_slip template, %item_title%, %item_barcode%, etc. need to be in the Heade...
phasefx [Fri, 8 Apr 2011 18:22:27 +0000 (18:22 +0000)]
For transit_slip template, %item_title%, %item_barcode%, etc. need to be in the Header, not the Line Item

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20027 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd Net::IP dependency for Fedora per r20023
dbs [Fri, 8 Apr 2011 17:00:43 +0000 (17:00 +0000)]
Add Net::IP dependency for Fedora per r20023

Required for the new ability of the Apache redirect module to optionally read
redirect skin and domain from the library IP's configuration file

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20025 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agopatch from Ben Ostrowsky (w/ input) to add support to the Apache redirect module...
erickson [Fri, 8 Apr 2011 16:30:04 +0000 (16:30 +0000)]
patch from Ben Ostrowsky (w/ input) to add support to the Apache redirect module to also optionally read redirect skin and domain from the library IP's configuration file.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20023 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotest for pre-cat slightly off in OPAC My Account, spotted by Steve Callender
phasefx [Thu, 7 Apr 2011 18:40:35 +0000 (18:40 +0000)]
test for pre-cat slightly off in OPAC My Account, spotted by Steve Callender

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20017 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofurther fixes to maintain_901
gmc [Thu, 7 Apr 2011 15:50:28 +0000 (15:50 +0000)]
further fixes to maintain_901

Now correctly handles &, <, or > appearing in the tcn_value
or tcn_source.  Also introduces a trivial utility stored
function, evergreen.xml_escape():

evergreen.xml_escape(TEXT) returns TEXT: converts '&', '<',
and '>' to XML entities

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20014 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEnable marc2sre.pl to run reasonably fast with a large set of bibs
dbs [Thu, 7 Apr 2011 04:47:00 +0000 (04:47 +0000)]
Enable marc2sre.pl to run reasonably fast with a large set of bibs

Our previous iteration of marc2sre.pl used an ILIKE stanza
beginning with a wildcard to match system control numbers
without having to specify the institution's MARC code.
This worked, but was painfully slow in large bib sets as
the database needed to use a bitmap index scan to find matches.

By adding a --prefix flag, the user can specify the institutional
MARC code for the set of records and we can use an exact match
against metabib.full_rec.value, which is immeasurably faster.
This is, of course, a problem if there are multiple institutional
MARC codes in use for a given set of bibliographic records.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20012 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoinstall command-line MARC import tools in @prefix@/bin
gmc [Wed, 6 Apr 2011 22:06:42 +0000 (22:06 +0000)]
install command-line MARC import tools in @prefix@/bin

(corrected version after dealing with apparent git stash breakage)

No longer need to keep the source tree around to use marc2are.pl,
marc2sre.pl, marc2bre.pl, and parallel_pg_loader.pl.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20010 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRevert "install command-line MARC import tools in @prefix@/bin"
gmc [Wed, 6 Apr 2011 22:06:40 +0000 (22:06 +0000)]
Revert "install command-line MARC import tools in @prefix@/bin"

This reverts commit 7125758576667feeff054ceb4b79d7d1510bbc6f.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20009 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoinstall command-line MARC import tools in @prefix@/bin
gmc [Wed, 6 Apr 2011 21:49:06 +0000 (21:49 +0000)]
install command-line MARC import tools in @prefix@/bin

No longer need to keep the source tree around to use marc2are.pl,
marc2sre.pl, marc2bre.pl, and parallel_pg_loader.pl.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20008 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoImprove error handling in marc2sre.pl when bib ID is not found
dbs [Wed, 6 Apr 2011 21:03:32 +0000 (21:03 +0000)]
Improve error handling in marc2sre.pl when bib ID is not found

If we can't find a bibliographic record ID to use in our load, then
skip that MFHD record and move on to the next one. Using the counter
gives sites a chance to identify which record caused the problem.

Aside: bitmap index scans for leading '%' LIKE searches make the
--bibfield / --bibsubfield extremely slow in large datasets. If
at all possible, avoid this path!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20006 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofix crash when importing/saving bib with '&' in TCN value
gmc [Wed, 6 Apr 2011 20:51:38 +0000 (20:51 +0000)]
fix crash when importing/saving bib with '&' in TCN value

Also fix similar glitch if ampersand is present in the TCN
source.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20003 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobump xulrunner version
phasefx [Wed, 6 Apr 2011 20:15:49 +0000 (20:15 +0000)]
bump xulrunner version

git-svn-id: svn://svn.open-ils.org/ILS/trunk@20001 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPatch from Thomas Berezansky to support patron priv expiration information in SIP2
miker [Wed, 6 Apr 2011 18:36:38 +0000 (18:36 +0000)]
Patch from Thomas Berezansky to support patron priv expiration information in SIP2

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19998 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd Item Attribute Editor to patron Items Out
phasefx [Wed, 6 Apr 2011 15:28:12 +0000 (15:28 +0000)]
add Item Attribute Editor to patron Items Out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19996 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMake the bib record lookup in marc2sre.pl more specific
dbs [Wed, 6 Apr 2011 03:58:36 +0000 (03:58 +0000)]
Make the bib record lookup in marc2sre.pl more specific

Don't strip the identifier down to a bare integer if we are doing
a lookup of the value in the bib record. Otherwise, identifiers
such as ABC1001 and ABC001 will overlap ('%001' will return both
records).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19993 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoWhitespace
dbs [Wed, 6 Apr 2011 03:30:31 +0000 (03:30 +0000)]
Whitespace

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19991 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoOverhaul the marc2sre.pl script for importing MFHD records
dbs [Wed, 6 Apr 2011 03:28:39 +0000 (03:28 +0000)]
Overhaul the marc2sre.pl script for importing MFHD records

Add --bibfield / --bibsubfield options to support retrieving the
bib record ID by searching the specified field/subfield for the
identifier, instead of assuming that the identifier =
biblio.record_entry.id. Avoiding the lookup will be much faster, but
some sites want to start clean with their bibliographic record IDs,
so this supports them.

Remove the need for passing in the owning user's password and simply do
a lookup by username in the actor.usr table. This is a bit more secure
as the password isn't exposed on the command line and you can easily set
someone else as the owner of the records without having to know their
password.

Add significant internal help via Pod::Usage.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19989 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEven more PermaCrud error handling cleanup, this time in .apply()
miker [Tue, 5 Apr 2011 20:11:57 +0000 (20:11 +0000)]
Even more PermaCrud error handling cleanup, this time in .apply()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19988 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMore PermaCrud error handling cleanup
miker [Tue, 5 Apr 2011 19:59:44 +0000 (19:59 +0000)]
More PermaCrud error handling cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19987 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoimprove the ability of PermaCrud callers to deal with errors not of the ils_event...
miker [Tue, 5 Apr 2011 17:06:09 +0000 (17:06 +0000)]
improve the ability of PermaCrud callers to deal with errors not of the ils_event shape

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19986 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPrevent patron search from returning horrible errors on regexian input
dbs [Tue, 5 Apr 2011 03:22:16 +0000 (03:22 +0000)]
Prevent patron search from returning horrible errors on regexian input

Add a utility method, _clean_regex_chars(), to filter common regex
characters out of input values.  When these characters are passed to
database SIMILAR searches, strange things (generally ugly errors) can
happen - so filter them out.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19983 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMore robust fix for edit highlighting in Serial Control View
dbwells [Mon, 4 Apr 2011 19:45:56 +0000 (19:45 +0000)]
More robust fix for edit highlighting in Serial Control View

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19980 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFix edit highlighting in Serial Control View
dbwells [Mon, 4 Apr 2011 18:05:46 +0000 (18:05 +0000)]
Fix edit highlighting in Serial Control View

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19975 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoreorder tabindex for horizontal patron search. non-flex the search button. thanks...
phasefx [Mon, 4 Apr 2011 17:33:47 +0000 (17:33 +0000)]
reorder tabindex for horizontal patron search.  non-flex the search button.  thanks to sylvar and others for poking

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19968 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agotweak to default suggestion for low-hits search
gmc [Mon, 4 Apr 2011 17:26:31 +0000 (17:26 +0000)]
tweak to default suggestion for low-hits search

Rather than show a suggestion for every word in the
original search phrase, only display suggestions
for words not found in the dictionary.  For example,
rather than having a search for "Amesh paradise" return
a suggestion of "Amish paraders", return "Amish paradise"
as the suggestion (assuming the default dictionaries are used).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19964 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoorder line items in PO display by line item ID
gmc [Mon, 4 Apr 2011 17:05:23 +0000 (17:05 +0000)]
order line items in PO display by line item ID

Order was effectively random otherwise.  Use case from at least
one library indicates this change, but doesn't preclude later work
to make the sort order more flexible.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19962 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agore-fix senator's fixes that I mangled
phasefx [Mon, 4 Apr 2011 16:49:37 +0000 (16:49 +0000)]
re-fix senator's fixes that I mangled

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19954 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoClient Permission Overhaul
phasefx [Mon, 4 Apr 2011 16:38:40 +0000 (16:38 +0000)]
Client Permission Overhaul

Menu/Toolbar commands can have a perm= attribute added, containing a space-seperated list of permissions.
Without it they stay enabled at all times (or disabled if they are manually disabled in the file).
With it they disable unless the user has at least one permission listed.

In addition, made *all* new or active windows get UI updates when changing operators, including updated menu enable/disable.

Will need a check on the permissions from previous commit, and probably a pile more from those who understand what needs what.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19953 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd some permissions for testing
phasefx [Mon, 4 Apr 2011 16:38:37 +0000 (16:38 +0000)]
Add some permissions for testing

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19952 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMove labels/accesskeys back onto menuitem nodes
phasefx [Mon, 4 Apr 2011 16:38:35 +0000 (16:38 +0000)]
Move labels/accesskeys back onto menuitem nodes

Apparently command labels override everything else, rather than the other way around.

Set at location failitates easier labels by context (different menus, shorter labels on toolbar, etc).

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19951 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMove most label/accesskeys to command nodes
phasefx [Mon, 4 Apr 2011 16:38:32 +0000 (16:38 +0000)]
Move most label/accesskeys to command nodes

The following entries had multiple menu items with differing labels.
I picked one for each to be the "default" on the command node.
The others were left on the menuitems.

cmd_edit_copy_buckets (edit/cat)
cmd_edit_volume_buckets (edit/cat, commented out)
cmd_edit_record_buckets (edit/cat)
cmd_circ_checkout (circ/circ/search)
cmd_copy_status (circ/cat/search)
cmd_search_opac (circ/cat/search)
cmd_search_tcn (cat/search)
cmd_search_bib_id (cat/search)

Side note:
cmd_replace_barcode exists on edit, circ, and cat, but used one label for all three.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19950 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRemove key attribute from command nodes
phasefx [Mon, 4 Apr 2011 16:38:29 +0000 (16:38 +0000)]
Remove key attribute from command nodes

They don't appear to do anything, unlike label/accesskey settings.

Menus don't read them for display, keys in the keyset refer in the opposite direction.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19949 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRig command_tab on *everything*
phasefx [Mon, 4 Apr 2011 16:38:25 +0000 (16:38 +0000)]
Rig command_tab on *everything*

Will make attempts to customize the toolbar a lot easier.
Also makes things more consistent.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19948 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoBooking: This should a) make booking interfaces behave better when a staff
senator [Mon, 4 Apr 2011 16:28:17 +0000 (16:28 +0000)]
Booking: This should a) make booking interfaces behave better when a staff
login session times out and is replaced by use of a re-auth dialog, and b)
wrap booking interfaces in a <browser> element with the attendant
back/forward/reload buttons that most similar interfaces already had.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19942 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agopass cvv2 value to CC processor
erickson [Mon, 4 Apr 2011 15:50:01 +0000 (15:50 +0000)]
pass cvv2 value to CC processor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19940 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoBen Ostrowsky pointed out that the alt holds (pull list) printing interface
senator [Mon, 4 Apr 2011 14:23:03 +0000 (14:23 +0000)]
Ben Ostrowsky pointed out that the alt holds (pull list) printing interface
was trying to include AutoIDL.js from an incorrect path.

I don't believe that file should be included at all, so now I've removed the
broken line.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19937 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAnd ... the upgrade script for the previous commit
miker [Sun, 3 Apr 2011 15:24:24 +0000 (15:24 +0000)]
And ... the upgrade script for the previous commit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19935 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoTeach in-db unAPI to avoid redundant xmlns declarations, including those already...
miker [Sun, 3 Apr 2011 15:20:39 +0000 (15:20 +0000)]
Teach in-db unAPI to avoid redundant xmlns declarations, including those already embedded in MARCXML

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19934 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd realistic row estimates to tree-ish functions (default is 1000) so that callers...
miker [Sat, 2 Apr 2011 17:06:41 +0000 (17:06 +0000)]
Add realistic row estimates to tree-ish functions (default is 1000) so that callers can make better plans in complex queries

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19930 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPatch from Thomas Berezansky to address unneccessary fine generation and avoid unchec...
erickson [Fri, 1 Apr 2011 19:29:46 +0000 (19:29 +0000)]
Patch from Thomas Berezansky to address unneccessary fine generation and avoid unchecked division by zero; details and DCO at https://bugs.launchpad.net/evergreen/+bug/747533

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19927 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoBetter search normalization de-duping when 'params' are used
dbwells [Fri, 1 Apr 2011 15:17:51 +0000 (15:17 +0000)]
Better search normalization de-duping when 'params' are used

This patch addresses search normalization deduping at two levels.  We now verify that both the function and the params are the same before excluding a normalization, both when the normalization is first added to the set and when the SQL is being built (since currently multiple sets may be involved).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19924 dcc99617-32d9-48b4-a31d-7c20da2025e4