working/Evergreen.git
2 years agoDocs: updating marc_export options documentation
Jane Sandberg [Tue, 10 Apr 2018 16:07:55 +0000 (09:07 -0700)]
Docs: updating marc_export options documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Update "Acquisitions Admin" for web client
Remington Steed [Tue, 10 Apr 2018 14:43:27 +0000 (10:43 -0400)]
Docs: Update "Acquisitions Admin" for web client

  - Change menu names to match web client ("Admin" to "Administration", and
    "Server Admin -> Acq" becomes "Acq Admin")
  - Fix list formatting where images were breaking a numbered list into
    two lists

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoForward-port 3.1.0 upgrade script
Dan Wells [Mon, 9 Apr 2018 14:50:34 +0000 (10:50 -0400)]
Forward-port 3.1.0 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoDocs: Update "User Activity Types" for web client
Remington Steed [Thu, 29 Mar 2018 21:12:19 +0000 (17:12 -0400)]
Docs: Update "User Activity Types" for web client

  - Update screenshot, provided by Kevin Tran

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "Z39.50 Servers" for web client
Remington Steed [Thu, 29 Mar 2018 20:58:19 +0000 (16:58 -0400)]
Docs: Update "Z39.50 Servers" for web client

  - Switch incorrectly placed screenshots
  - Update first screenshot for web client

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update circulation_limit_groups.adoc for web client
Kevin Tran [Thu, 1 Mar 2018 16:34:10 +0000 (11:34 -0500)]
Docs: Update circulation_limit_groups.adoc for web client

  - Updated menu label to "Circ Limit Sets".

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Add screenshots to "Load MARC Order Records"
Remington Steed [Thu, 29 Mar 2018 13:55:08 +0000 (09:55 -0400)]
Docs: Add screenshots to "Load MARC Order Records"

Thanks to Morkor Quarshie for the screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "User and Group Permissions" for web client
Remington Steed [Wed, 21 Mar 2018 21:01:05 +0000 (17:01 -0400)]
Docs: Update "User and Group Permissions" for web client

  - Update instructions for web client
  - New screenshot shows menu path from patron screen. Thanks to Kevin
    Tran for the screenshot.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update MARC_RAD_MVF_CRA.adoc for web client
Kevin Tran [Thu, 15 Mar 2018 14:48:09 +0000 (10:48 -0400)]
Docs: Update MARC_RAD_MVF_CRA.adoc for web client

  - Updated instructions for web client
  - Narrower screenshot (with arrow) for Coded Value Map section

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: New screenshot for "MARC Import Remove Fields"
Remington Steed [Wed, 21 Mar 2018 20:20:50 +0000 (16:20 -0400)]
Docs: New screenshot for "MARC Import Remove Fields"

  - New screenshot for "MARC Import Remove Fields", which still showed
    small amount of XUL client. Thanks to Kevin Tran for the screenshot.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "Selection Lists" and "Invoices" for web client
Remington Steed [Thu, 29 Mar 2018 12:51:28 +0000 (08:51 -0400)]
Docs: Update "Selection Lists" and "Invoices" for web client

  - Update references to Acq Admin menu
  - Make menu name formatting more consistent (should be bold or
    italics)
  - Remove outdated reference to old Evergreen version under "Activate
    Purchase Order with Zero Copies"

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "Hold-driven recalls" for web client
Remington Steed [Wed, 28 Mar 2018 19:53:18 +0000 (15:53 -0400)]
Docs: Update "Hold-driven recalls" for web client

  - Update reference to "Admin" menu
  - Remove old note about when feature was added to Evergreen

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years ago2.12.11-2.12.12 schema update
Galen Charlton [Wed, 28 Mar 2018 14:40:59 +0000 (10:40 -0400)]
2.12.11-2.12.12 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years ago3.0.5-3.0.6 schema update
Galen Charlton [Wed, 28 Mar 2018 14:38:59 +0000 (10:38 -0400)]
3.0.5-3.0.6 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agorelease notes for Evergreen 3.0.6
Galen Charlton [Wed, 28 Mar 2018 14:29:12 +0000 (10:29 -0400)]
release notes for Evergreen 3.0.6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agorelease notes for Evergreen 2.12.12
Galen Charlton [Wed, 28 Mar 2018 14:14:41 +0000 (10:14 -0400)]
release notes for Evergreen 2.12.12

2 years agoLP#1757526: escape more catalog data (MFHD edition)
Galen Charlton [Tue, 27 Mar 2018 20:30:35 +0000 (16:30 -0400)]
LP#1757526: escape more catalog data (MFHD edition)

This patch ensures that data derived from MFHDs is escaped
for in the issues held tab on the public catalog record display
page.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1757526 Escape displayed catalogue data
Dan Scott [Wed, 21 Mar 2018 21:08:35 +0000 (22:08 +0100)]
LP1757526 Escape displayed catalogue data

Content in content fields (5xx) as well as for the names of locations in copy
count alt text was not being properly escaped, allowing for the possibility of
executing arbitrary JavaScript in the case of a malicious catalogue record
(whether edited in the system, or imported)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: fund tag preservation
Jane Sandberg [Wed, 28 Mar 2018 14:08:04 +0000 (07:08 -0700)]
Docs: fund tag preservation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: small readability changes to 3.1 release notes
Jane Sandberg [Wed, 28 Mar 2018 13:23:28 +0000 (06:23 -0700)]
Docs: small readability changes to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding info about new setting to 3.1 release notes
Jane Sandberg [Wed, 28 Mar 2018 13:04:01 +0000 (06:04 -0700)]
Docs: adding info about new setting to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoSmall fix to release note numbering
Dan Wells [Mon, 26 Mar 2018 16:46:06 +0000 (12:46 -0400)]
Small fix to release note numbering

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoTranslation updates - po files
Dan Wells [Mon, 26 Mar 2018 13:33:49 +0000 (09:33 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoTranslation updates - newpot
Dan Wells [Mon, 26 Mar 2018 13:16:23 +0000 (09:16 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1699838: Stamping upgrade script for default pickup lib YAOUS
Kathy Lussier [Fri, 23 Mar 2018 19:39:49 +0000 (15:39 -0400)]
LP#1699838: Stamping upgrade script for default pickup lib YAOUS

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1699838 Scale back settings for staff-based hold placement
Dan Wells [Fri, 23 Mar 2018 17:07:45 +0000 (13:07 -0400)]
LP#1699838 Scale back settings for staff-based hold placement

For now, we will add just one new setting to optionally restore the old
behavior.  In the absence of a 'preferred pickup location', the staff
form will default to the staff workstation OU.

Also, add setting to seed data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

2 years agoLP1699838 - add YOUSes for defaulting hold pickup locs
Cesar Velez [Wed, 28 Feb 2018 19:08:08 +0000 (14:08 -0500)]
LP1699838 - add YOUSes for defaulting hold pickup locs

Add a YAOUS... err make that two, to control how staff-placed holds
default the pickup library.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1693036: Simplify template, cleanup preview data
Remington Steed [Fri, 23 Mar 2018 14:46:32 +0000 (10:46 -0400)]
LP#1693036: Simplify template, cleanup preview data

This commit corrects a few minor problems, and also attempts to simplify
and cleanup the template. The changes include:

  - Adding the missing "ident_type2" field to the template and JS
  - Adding missing sample data for "county"
  - Moving "postal code" closer to the standard location (at the end of
    the address)
  - Fixing typos, and making "Claims..." labels more consistent
  - Minor cleanup of the sample data
  - Removing template comments that list available variables, because
    this template is simpler than most, intended to print everything

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1693036: follow-up: fix printing of daytime phone number
Galen Charlton [Wed, 14 Mar 2018 14:33:27 +0000 (10:33 -0400)]
LP#1693036: follow-up: fix printing of daytime phone number

This patch corrects how the 'day_phone' field should be referred
to in the print template.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agolp1693036 Patron Editor Print Data
Kyle Huckins [Thu, 15 Feb 2018 23:03:20 +0000 (23:03 +0000)]
lp1693036 Patron Editor Print Data

- Add Print button to Patron Editor.
- Add Patron Data print template.
- Add additional print template dummy data needed for Patron
Data template.
- Implement print functionality for Patron registration/edit
data.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>/
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1758322: Fix lp1731960_test_preserving_bookbag_entries test
Kathy Lussier [Fri, 23 Mar 2018 12:35:56 +0000 (08:35 -0400)]
LP#1758322: Fix  lp1731960_test_preserving_bookbag_entries test

A typo inserted the incorrect record number for the
 lp1731960_test_preserving_bookbag_entries. This patch fixes
the typo.

Thanks to Jason Boyer for spotting the problem!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1758347: ensure that upgrade includes latest asset.merge_record_assets()
Galen Charlton [Fri, 23 Mar 2018 14:23:19 +0000 (10:23 -0400)]
LP#1758347: ensure that upgrade includes latest asset.merge_record_assets()

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1731960: Stamping upgrade script for preserve book bags on bib merge
Kathy Lussier [Thu, 22 Mar 2018 23:36:19 +0000 (19:36 -0400)]
LP#1731960: Stamping upgrade script for preserve book bags on bib merge

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1731960: adding upgrade script for updating the function
Rogan Hamby [Thu, 22 Mar 2018 17:50:52 +0000 (13:50 -0400)]
LP#1731960: adding upgrade script for updating the function

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1731960-preserving book bag entries with new values during bib merge
Rogan Hamby [Tue, 21 Nov 2017 23:50:34 +0000 (18:50 -0500)]
LP#1731960-preserving book bag entries with new values during bib merge

The asset.merge_record_assets() removes bib records from containers when
merging and deleting the record as appropriate but bib containers with
the btype of 'bookbag' (used as reading lists) should instead be updated
to the new bib record. Includes Pgtap test.

Signed-off-by: Rogan Hamby <rhamby@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/999.functions.global.sql

2 years agoForward port 2.12.11 upgrade script
Dan Wells [Thu, 22 Mar 2018 19:36:50 +0000 (15:36 -0400)]
Forward port 2.12.11 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoForward port 3.0.5 upgrade script
Dan Wells [Thu, 22 Mar 2018 18:39:14 +0000 (14:39 -0400)]
Forward port 3.0.5 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1755502 Fix hold user test
Dan Wells [Thu, 22 Mar 2018 14:31:58 +0000 (10:31 -0400)]
LP#1755502 Fix hold user test

Now that we are fleshing this field, we need to dig a little deeper
for the 'id' to test if we are the same user.

To test
-------
[1] Set up a patron with a hold request and with a item
    on the hold shelf that fills the hold.
[2] Check out the item to patron. Note that you
    will get a ITEM_ON_HOLDS_SHELF alert, even though the
    item is on hold for that patron. Cancel the alert.
[3] Apply the patch and repeat step 2. This time, the checkout
    will proceed.
[4] Set up another patron with a hold request and an item
    on the hold shelf, then checkout it at to a _different_ patron.
    Verify that the ITEM_ON_HOLDS_SHELF alert appears.

This patch also fixes test failures caught by the
19-lp1306666-abort-transit-copy-status.t live test.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1728147: more tweaks to grid
Galen Charlton [Thu, 22 Mar 2018 16:51:45 +0000 (12:51 -0400)]
LP#1728147: more tweaks to grid

* Make paths to expire_time and cut_in_line more concise
* Add SMS Carrier column back
* Tweak labels of the patron first and last name columns
* Ensure that the "Call Number" column continues to be sortable
  by normalized call number label. Note that due to a quirk of
  egGrid, which doesn't currently have a way to specify that a column
  always be retrieved by a fielder query but /not/ be directly
  available as a displayable column, we also need a "Call Number Label"
  column at the moment.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1728147: correct fleshing of staff hold column
Galen Charlton [Thu, 22 Mar 2018 16:14:17 +0000 (12:14 -0400)]
LP#1728147: correct fleshing of staff hold column

This patch fixes the test (ahr.usr is fleshed, but not ahr.requestor)
and ensures that the value is cached correctly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1728147: Add patron's first/last name and Alias column
Cesar Velez [Fri, 16 Feb 2018 19:40:17 +0000 (14:40 -0500)]
LP#1728147: Add patron's first/last name and Alias column

These were also missing from the Holds Pull grid.

This patch also corrects the determination of whether a hold
was staff-placed or not.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1728147 - fix some Holds Pull List grid columns
Cesar Velez [Tue, 30 Jan 2018 18:13:52 +0000 (13:13 -0500)]
LP#1728147 - fix some Holds Pull List grid columns

This adds a few missing columns to the Holds Pull List grid,
and addresses a few display issues.

New columns added are Hold Type, Circ Mod, Staff Hold,
Email/Phone/SMS Notify, Copy Status Change Time, ISBN,
Edition, Top of Queue, Total Holds, and Expire Date.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1738488 Optimize Flattener join logic
Dan Wells [Fri, 2 Mar 2018 17:54:46 +0000 (12:54 -0500)]
LP#1738488 Optimize Flattener join logic

The current Flattener.pm autogenerates necessary joins for sorting
and filtering, but in doing so, it gives every intermediate table a
unique alias, even if the path to that table is exactly the same as
another member in the map we are flattening.

Instead, let's reuse joins whenever the path is identical, even for
intermediate tables.  We do so by tracking every path to each core
type, then reusing as much of that join path as we can.  In cases
where we have different paths to the same type, we still necessarily
provide a new unique alias.

This problem was first noticed in the web staff billing history
interface, where the particular stacking of joins resulted (for one
specific library) in 17 joins and 44,575,740,147,225,592,344,870,912
potential rows.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1702557-Make Acq MarcEditor Just Have Save Button
Cesar Velez [Fri, 19 Jan 2018 19:43:38 +0000 (14:43 -0500)]
LP#1702557-Make Acq MarcEditor Just Have Save Button

Like the changes to the z3950 marceditor UI, and serials,
make the Acq marceditor have a simple Save button, instead
of the Modify + Save Edits buttons needed to save a change.
Same change as in 1710405, et al. Note this also fixes a
propagation issue that prevented changes from marceditor's
scope.marcXml from making it to the modal controller scope,
and being saved. Props to miker for helping me debug this!

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1361258 Patron reg repair user settings saving/loading
Bill Erickson [Mon, 19 Mar 2018 19:22:44 +0000 (15:22 -0400)]
LP#1361258 Patron reg repair user settings saving/loading

Avoid caching user setting values at the service (app) level in the user
editor.  In other words, always fetch a fresh copy of the current user's
setting with each instance of the editor page.

This solves a number problems where stale versions of the cached data
were referenced and acted on, both when displaying an updating user
settings.

Additionally, ensure that clone user and stage user data is refreshed
on all page instances as the URL params that affect these values can
change per instance.

Other data that is common to all instances (e.g. the set of profile
groups) is still cached as before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1742779: Distinguish between no statcat values and multiple values in copy editor...
Mike Rylander [Wed, 10 Jan 2018 16:25:27 +0000 (11:25 -0500)]
LP#1742779: Distinguish between no statcat values and multiple values in copy editor to assist staff

WRT stat cats, the copy editor in the web client will display the value of a
stat cat IFF all selected copies both use the stat cat AND use the same value
for that stat cat. Otherwise it displays <NONE>, which is confusing in the
case of some selected copies just not using the stat cat, or all selected
copies using it, but using different values.

This commit provides tracking of the mixed-use stat, and displays <MULTIPLE>
for the value instead of <NONE> in that case.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: adding several bug fixes to 3.0.5
Jane Sandberg [Thu, 22 Mar 2018 14:05:21 +0000 (07:05 -0700)]
Docs: adding several bug fixes to 3.0.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1752983: sort circ modifier list in precat checkout
Jeff Davis [Mon, 12 Mar 2018 18:09:23 +0000 (11:09 -0700)]
LP#1752983: sort circ modifier list in precat checkout

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1755924: show circ modifier in Item Status list view
Jeff Davis [Wed, 14 Mar 2018 21:33:07 +0000 (14:33 -0700)]
LP#1755924: show circ modifier in Item Status list view

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1755892: ensure profile is fleshed in patron search
Jeff Davis [Thu, 15 Mar 2018 21:58:16 +0000 (14:58 -0700)]
LP#1755892: ensure profile is fleshed in patron search

To test
-------
[1] Do a catalog search or retrieve a record in the web staff client.
[2] Click Place Hold.
[3] On the place hold screen, click Patron Search.
[4] Search for patrons (e.g. last name = "smith"). In the results grid,
    the Profile column is empty.
[5] Apply the patch and repeat steps 3 and 4. This time, the Profile
    column should contain the profile name.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1747963 Fix "trim list" feature in web client
Remington Steed [Wed, 7 Feb 2018 19:41:47 +0000 (14:41 -0500)]
LP#1747963 Fix "trim list" feature in web client

The use of splice() here caused buggy behavior and seemed to be a typo,
so I tried using slice() instead. But that still didn't work correctly.
The list stopped adding items after it reached 21 total, so scanning a
new barcode didn't add it to the list but only refreshed the list.

Instead, this commit sets the length of the array to 20, which shortens
the array as described in the MDN documentation for Array.length. Now it
behaves like it did in the XUL client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1743045: skip redundant grid refresh on checkin
Jeff Davis [Wed, 14 Mar 2018 22:10:23 +0000 (15:10 -0700)]
LP#1743045: skip redundant grid refresh on checkin

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1756572: Update to point release notes to include underlined links
Kathy Lussier [Wed, 21 Mar 2018 14:01:01 +0000 (10:01 -0400)]
LP#1756572: Update to point release notes to include underlined links

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1756572: accessibility tweaks to links in webstaff client
Galen Charlton [Sat, 17 Mar 2018 17:38:01 +0000 (13:38 -0400)]
LP#1756572: accessibility tweaks to links in webstaff client

This patch changes the default
text color of text inside egGrid cells to #000; changes the default text
color to #000 (but note that more work would be needed to do this
comprehensively); and adds underlines to links inside grid cells.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: adding 3.0.5 release notes
Jane Sandberg [Tue, 20 Mar 2018 21:49:56 +0000 (14:49 -0700)]
Docs: adding 3.0.5 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding 2.12.11 release notes
Jane Sandberg [Tue, 20 Mar 2018 21:29:07 +0000 (14:29 -0700)]
Docs: adding 2.12.11 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1756110: fix egBasicComboBox drop-down functionality
Galen Charlton [Thu, 15 Mar 2018 15:13:27 +0000 (11:13 -0400)]
LP#1756110: fix egBasicComboBox drop-down functionality

Somehow egBasicComboBox got missed when it became necessary to
switch to the newer way of specifying Bootstrap drop-downs. This
patch rectifies that and fixes the drop-down functionality.

To test
-------
[1] Create a report template in the web staff report editor and
    add a filter field.
[2] Attempt to change the filter operator. Note that nothing happens
    when the drop-down button is clicked.
[3] Apply the patch and repeat step 2. This time, the drop-down
    should work and display the list of available filter operators.

Other places affected include:

- The part selector in the volume/copy editor
- Template selector in the volume/copy editor
- Template selector in the labels interface
- Routing label selector in the subscription manager
- Call number prefix and suffix selectors in the serials batch receiving
  interface

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1721807: fix webstaff report templates that have might_have and has_many joins
Galen Charlton [Tue, 6 Mar 2018 23:00:23 +0000 (18:00 -0500)]
LP#1721807: fix webstaff report templates that have might_have and has_many joins

This patch fixes a bug where using a virtual field in the web staff
report template editor to join another table would result in a syntax
error in the generated SQL.

To test
-------
[1] Apply the patch and verify that the regression test in the previous
    commit passes.
[2] Create new report template in the web staff client that include
    virtual fields and joins and verify that they work. One example
    would be a report that uses ILS User as the base source and joins
    in the patron notes virtual field.
[3] If available, clone a report template originally created in the web
    staff client that had previously failed, then save it. The new
    report should work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1721807: regression test
Galen Charlton [Wed, 7 Mar 2018 19:27:44 +0000 (14:27 -0500)]
LP#1721807: regression test

This adds an automated regression test as well as some additional
unit tests for the web staff reporter app and template service.  This
patch could be applied by itself to verify that the regression
test (run using 'npm run test' for master or 'grunt test' for rel_3_0)
fails.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Adding an affiliation; updating CW MARS name in 3.1 release notes
Jane Sandberg [Sun, 18 Mar 2018 15:20:32 +0000 (08:20 -0700)]
Docs: Adding an affiliation; updating CW MARS name in 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Adding affiliations and documenters to 3.1 release notes
Jane Sandberg [Sun, 18 Mar 2018 15:15:29 +0000 (08:15 -0700)]
Docs: Adding affiliations and documenters to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1746365 Change default staff link colors to provide adequate contrast
Kathy Lussier [Tue, 6 Feb 2018 16:40:11 +0000 (11:40 -0500)]
LP#1746365 Change default staff link colors to provide adequate contrast

The default link color from bootstrap works well on white backgrounds, but
doesn't provide adequate contrast once the background color is changed.
This introduces accessbility problems, particularly in cases where linked
text displays on a selected grid row that uses a light blue background
color. This change provides a darker default link color.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Add aspell wordlist to improve spellchecking
Remington Steed [Fri, 16 Mar 2018 15:18:11 +0000 (11:18 -0400)]
Docs: Add aspell wordlist to improve spellchecking

To spellcheck the docs:

  - Go into the docs/ directory.
  - Copy the wordlist to your home directory (making a backup of your
    existing wordlist, if you have one):
    - cp --backup .aspell.en.pws ~/
  - Run 'aspell' over all AsciiDoc files, except release notes. Don't
    need to create backup files, since we're under version control. This
    runs the interactive spellchecker; use it to fix incorrect words, or
    add new correct words to the wordlist:
    - for f in $(find . -name '*.adoc' -and ! -name 'RELEASE*'); do
      aspell check --ignore-case --dont-backup $f; done
  - Review your changes:
    - git diff
  - Commit spelling corrections in one commit. Noteworthy changes should
    be included in the commit message.
  - Commit changed wordlist in a separate commit.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Spell check corrections
Remington Steed [Fri, 16 Mar 2018 14:58:17 +0000 (10:58 -0400)]
Docs: Spell check corrections

I walked through all the docs (except for release notes) and made a
number of small corrections. Most of them are simple typos, but there
are a few special cases:

  - In cases where the correction required matching with actual code or
    labels in Evergreen, those were checked to make sure the correction
    matched.
  - Changed spelling of "correct" word "Transcendent" to match database
    spelling "transcendant"
  - Changed very informal contractions "it'll" and "that'll" to "it
    will" and "that will". Same for "whatever's" to "whatever is".
  - Changed very informal expressions: "handwaving" to "glossing",
    "modernish" to "modern", "deduping" to "deduplicating".
  - Changed "unclick" to "uncheck" (regarding a checkbox)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoLP#1755917: Fix Acq Admin menu order
Remington Steed [Wed, 14 Mar 2018 20:44:48 +0000 (16:44 -0400)]
LP#1755917: Fix Acq Admin menu order

According to commit cac16285aca, the acq admin menu is supposed to be in
alphabetical order. However, one item remains out of place. This commit
fixes that.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1691263: discourage input of newlines in MARC editor user/kmlussier/lp1691263_marc_editor_wrapping_signoff
Galen Charlton [Mon, 5 Feb 2018 23:04:12 +0000 (18:04 -0500)]
LP#1691263: discourage input of newlines in MARC editor

This patch catches and discards enter keydown events when the
focus is in a contenteditable subfield value div; otherwise, newlines
can infect the MARC record.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1691263: make webstaff MARC editor wrap long fields
Cesar Velez [Mon, 4 Dec 2017 17:45:35 +0000 (12:45 -0500)]
LP#1691263: make webstaff MARC editor wrap long fields

This patch makes the MARC editor wrap long fields (e.g.,
bibliographic 505 fields) so that they fit the width of the enclosing
window or modal. The approach taken is replacing the text input
elements with contenteditable divs, which in turn can be better
styled.

To test
-------
[1] Apply the patch.
[2] Locate a record with a long 505 field and open it in the
    MARC editor. Verify that the contents of the field wrap.
[3] Verify that record editing and saving work as expected.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Fix AsciiDoc list formatting
Remington Steed [Wed, 14 Mar 2018 12:54:52 +0000 (08:54 -0400)]
Docs: Fix AsciiDoc list formatting

AsciiDoc lists (numbered or bulleted) generally need to be preceded by a
blank line. If not, they will be absorbed into the previous paragraph of
text.  This commit fixes two occurrences of this.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update Authorities.adoc
Morkor Quarshie [Wed, 28 Feb 2018 21:27:05 +0000 (16:27 -0500)]
Docs: Update Authorities.adoc

  - Revised instructions to match web client.
  - Added new screenshots.
  - Improved instructions for "Non-filing indicator".
  - Minor line formatting changes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Add directions for configuring columns
Morkor Quarshie [Tue, 6 Feb 2018 21:24:10 +0000 (16:24 -0500)]
Docs: Add directions for configuring columns

Includes screenshots and instructions on how to expand, shrink and move
columns left and right. Also updates some explanation to match how the
web client stores column settings.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoLp 1411422: Fix & rename test file.
Jason Stephenson [Fri, 9 Mar 2018 14:17:34 +0000 (09:17 -0500)]
Lp 1411422: Fix & rename test file.

The tests added for this branch had a bad plan.  It specified 7 tests were
to be run when actually there are 8.

I also renumbered the file to be 26, so that there would be only 1 test
numbered 25.

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLp#1411422: Clean up the code a little bit.
Jason Stephenson [Thu, 8 Mar 2018 19:11:31 +0000 (14:11 -0500)]
Lp#1411422: Clean up the code a little bit.

We don't need to left join when we flesh fields.

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP1411422 Copy details repeated in search results when item/volume moved with parts...
blake [Fri, 1 Sep 2017 20:54:39 +0000 (20:54 +0000)]
LP1411422 Copy details repeated in search results when item/volume moved with parts attached

Added regression test and tweaked the part lookup query to remove deleted parts.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP1411422 Copy details repeated in search results when item/volume moved with parts...
blake [Mon, 13 Jun 2016 20:58:13 +0000 (15:58 -0500)]
LP1411422 Copy details repeated in search results when item/volume moved with parts attached

Added the code in perl to respect the existence of parts. Both "transferring volume"
and "transferring items". "Transferring items" was coded to use
open-ils.cat.asset.copy.fleshed.batch.update which means most of the work was done in js.
The web based staff client is coded to use open-ils.cat.transfer_copies_to_volume.
Decided to use that method for xul as well. Making it more consistent with the "transferring
volume" code. Considered coding it to move the part level holds to the destination part but
it's possible that the source part still has items.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1751318 Remove direct tablesort import
Bill Erickson [Fri, 23 Feb 2018 20:20:48 +0000 (15:20 -0500)]
LP#1751318 Remove direct tablesort import

Avoid attempts to directly import angular-tablesort.js from the offline
interface.  The script is already included in vendor.bundle.js and the
direct import, which refers to a nonexistant file, breaks the Perl live
test for offline dependency checking.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoDocs: Update SMS_messaging.adoc for web client
Kevin Tran [Wed, 7 Mar 2018 15:06:43 +0000 (10:06 -0500)]
Docs: Update SMS_messaging.adoc for web client

  - update instructions to match web client
  - small whitespace change

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update copy_statuses.adoc for web client
Kevin Tran [Thu, 1 Mar 2018 16:41:53 +0000 (11:41 -0500)]
Docs: Update copy_statuses.adoc for web client

  - new screenshots for adding, editing, deleting
  - update instructions to match web client

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "Circulation - Patron Record" for web client
Remington Steed [Tue, 6 Mar 2018 17:24:05 +0000 (12:24 -0500)]
Docs: Update "Circulation - Patron Record" for web client

  - Replace screenshots. Thanks to Kevin Tran for many of the new
    screenshots.
  - Update instructions to match web client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Jane Sandberg [Mon, 12 Mar 2018 20:41:53 +0000 (13:41 -0700)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

2 years agoDocs: correcting funder names for 3.1 release notes
Jane Sandberg [Mon, 12 Mar 2018 20:41:39 +0000 (13:41 -0700)]
Docs: correcting funder names for 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1750912 - Add add_translations.py convenience script to i18n tools.
Chris Sharp [Wed, 21 Feb 2018 21:25:15 +0000 (16:25 -0500)]
LP#1750912 - Add add_translations.py convenience script to i18n tools.

This script was authored by Jason Stephenson, who has kindly
agreed to add it to the Evergreen source tree.  As Jason suggested,
I modified the GPL version number to 2 to be in line with the
Evergreen project's licensing requirements.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: adding more funders to 3.1 release notes
Jane Sandberg [Mon, 12 Mar 2018 18:35:41 +0000 (11:35 -0700)]
Docs: adding more funders to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding translators to 3.1 release notes acknowledgements
Jane Sandberg [Mon, 12 Mar 2018 17:36:35 +0000 (10:36 -0700)]
Docs: adding translators to 3.1 release notes acknowledgements

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding code contributors to 3.1 release notes acknowledgements
Jane Sandberg [Mon, 12 Mar 2018 17:17:18 +0000 (10:17 -0700)]
Docs: adding code contributors to 3.1 release notes acknowledgements

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding some funding orgs to release notes acknowledgements
Jane Sandberg [Mon, 12 Mar 2018 16:47:33 +0000 (09:47 -0700)]
Docs: adding some funding orgs to release notes acknowledgements

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Fix broken include in root.adoc
Remington Steed [Mon, 12 Mar 2018 14:26:05 +0000 (10:26 -0400)]
Docs: Fix broken include in root.adoc

A recent commit added a section to root.adoc and root_cataloging.adoc.
The reference was correct in the second file, but in the first file was
missing the subdirectory. This commit adds it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Remove docs not applicable in web client
Remington Steed [Mon, 12 Mar 2018 14:02:54 +0000 (10:02 -0400)]
Docs: Remove docs not applicable in web client

A few docs chapters relate to features that don't exist (yet) in the web
client, so this commit removes those from the table of contents
(root*.adoc).

Also, duplicate content was found during the web client docs review, so
this commit removes the nearly identical docs file and replaces its
references with references to the slightly better version of the file.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoFix billing / negative balance test cases
Dan Wells [Fri, 9 Mar 2018 16:25:16 +0000 (11:25 -0500)]
Fix billing / negative balance test cases

The test cases are set up manually via SQL, but were not taught about
the new data needed for billings.  This caused two tests to fail.

Let's go ahead and update this whole block to have more realistic data
conforming to the new scheme.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1717593: Missing strings cause serial item delete (and status change) failures
Mike Rylander [Sat, 3 Mar 2018 18:29:17 +0000 (13:29 -0500)]
LP#1717593: Missing strings cause serial item delete (and status change) failures

There are two places in the code that expect a serial-related string to exist,
but neither do.  So, let's correct that.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1753008 Load iframeResizer via script tag
Bill Erickson [Mon, 5 Mar 2018 16:50:19 +0000 (11:50 -0500)]
LP#1753008 Load iframeResizer via script tag

iframeResizer does not currently play nicely with webpack.  Load it
directly via script tag for now.

This resolves a problem where the iframe fails to fill the screen when
loading the reports UI in the browser client.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Update "Alternate Hold Pick up Location" for web client
Remington Steed [Thu, 8 Mar 2018 16:21:10 +0000 (11:21 -0500)]
Docs: Update "Alternate Hold Pick up Location" for web client

  - New screenshot
  - Remove instructions for changing location label (e.g. "Drive-thru")
  - Wrap long lines to 72 characters (if those lines were changed)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Use raw ampersand '&' to fix conversion error
Remington Steed [Wed, 7 Mar 2018 20:03:12 +0000 (15:03 -0500)]
Docs: Use raw ampersand '&' to fix conversion error

The AsciiDoc to DocBook conversion process seems handle raw ampersands
just fine, but sometimes chokes on the special entity forms like {amp}
or &#38; . No more fancy talk. Just simple '&'.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Fix '&' DocBook conversion error
Remington Steed [Wed, 7 Mar 2018 19:21:51 +0000 (14:21 -0500)]
Docs: Fix '&' DocBook conversion error

Using the AsciiDoc named character reference {amp} seems to have
converted to a plain '&' too early, causing the DocBook XML validation
to fail. Let's try a numerical reference: &#38;

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: adding web client screenshot
Jane Sandberg [Wed, 7 Mar 2018 04:22:21 +0000 (20:22 -0800)]
Docs: adding web client screenshot

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: updating return-to-search results for Web client
Jane Sandberg [Wed, 7 Mar 2018 04:20:42 +0000 (20:20 -0800)]
Docs: updating return-to-search results for Web client

2 years agoDocs: adding contributor to 3.0.4 release notes
Jane Sandberg [Sat, 24 Feb 2018 01:36:06 +0000 (17:36 -0800)]
Docs: adding contributor to 3.0.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Update search_interface.adoc for web client
Kevin Tran [Thu, 1 Mar 2018 16:09:30 +0000 (11:09 -0500)]
Docs: Update search_interface.adoc for web client

  - added a screenshot because the instructions seemed to lack a visual
  - changed step 1 from "Search Facet Groups" to "Search Filter Groups"

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "Monograph Parts" for web client
Remington Steed [Fri, 7 Jul 2017 13:26:15 +0000 (09:26 -0400)]
Docs: Update "Monograph Parts" for web client

  - Replace screenshots
  - Reformat long lines to around 72 characters
  - Convert numbered list to automatic numbering
  - Update instructions to match web client

Thanks to Kevin Tran for the screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Update "Circ Triggered Events" for web client
Remington Steed [Fri, 12 May 2017 12:59:51 +0000 (08:59 -0400)]
Docs: Update "Circ Triggered Events" for web client

Added edits for first section "Access and View".

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Edits and images for "Managing Holds"
Remington Steed [Wed, 21 Feb 2018 17:07:36 +0000 (12:07 -0500)]
Docs: Edits and images for "Managing Holds"

Signed-off-by: Remington Steed <rjs7@calvin.edu>