working/Evergreen.git
7 years agoSilence QP warning due to inappropriate cmp op
Dan Scott [Wed, 19 Jun 2013 20:49:14 +0000 (16:49 -0400)]
Silence QP warning due to inappropriate cmp op

In QueryParser, we're comparing two strings, but using the numeric !=
operator. Switching to the 'ne' operator silences a warning that came up
7,000 today in our logs so far...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoSilence uninit var warnings from query normalizer
Dan Scott [Fri, 21 Jun 2013 03:11:20 +0000 (23:11 -0400)]
Silence uninit var warnings from query normalizer

$field_info can return undef from the search for a matching ID from the
list of normalizers, which in turn generates several uninit var warnings
when attempts are made to access members of the undef variable. We saw
6700 occurrences of these warnings during a typical day of operations.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoreturn, not next, from eval BLOCK
Dan Scott [Fri, 21 Jun 2013 03:39:21 +0000 (23:39 -0400)]
return, not next, from eval BLOCK

Per perldoc eval, exiting an eval BLOCK is not allowed. And it generates
warnings - 37,000 of them in one day - on a system on which the fine
generator runs every 15 minutes. Simply returning from the block
achieves the same goal without generating scads of warnings.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoLP1179609 ACQ lineitem identifier inline update
Bill Erickson [Mon, 13 May 2013 17:22:37 +0000 (13:22 -0400)]
LP1179609 ACQ lineitem identifier inline update

When the identifier value for a linetiem is changed, apply the change
and refresh the lineitem in real time instead of requiring users to
click the 'Apply Lineitem Identifier' link.

The 'Apply Lineitem Identifier' link has also been removed, since it is
no longer needed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoAdd (noop) upgrade script for 2.2.10
Lebbeous Fogle-Weekley [Wed, 19 Jun 2013 19:42:07 +0000 (15:42 -0400)]
Add (noop) upgrade script for 2.2.10

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years ago2.3.8 stub upgrade script
Bill Erickson [Wed, 19 Jun 2013 14:47:20 +0000 (10:47 -0400)]
2.3.8 stub upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoSupport script-based circ in nearest_hold()
Dan Scott [Mon, 17 Jun 2013 04:38:43 +0000 (00:38 -0400)]
Support script-based circ in nearest_hold()

The nearest_hold() implementation recently changed to pull in the circ
library ID; however, if circulation runs through scripts, the circ
library on the copy object has been fleshed, and the nearest hold
routine gets very confused.

Check to see if we do, in fact, have an object instead of a plain
scalar, and assign the value to a placeholder variable accordingly.

Thanks to Jeff Godin for his great assistance on debugging this!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm

(Just whitespace. Resolved by hand.  --miker)

7 years agoLP 1177388 'Add to Po' Honors default copy count
Bill Erickson [Tue, 7 May 2013 13:48:05 +0000 (09:48 -0400)]
LP 1177388 'Add to Po' Honors default copy count

Create the requested number of copies for lineitems added to purchase
orders whose provider has a non-zero value for 'default copy count'.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoPrevent uninit var warnings in Search/Biblio.pm
Dan Scott [Tue, 18 Jun 2013 16:17:40 +0000 (12:17 -0400)]
Prevent uninit var warnings in Search/Biblio.pm

The logger messages in Search/Biblio.pm throw _many_ uninitialized
variable warnings. With a little care, we can prevent those warnings and
return our attention to more important log messages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFixes to MARC batch import docs
Kathy Lussier [Fri, 14 Jun 2013 19:51:42 +0000 (15:51 -0400)]
Fixes to MARC batch import docs

Added needed subheadings to the MARC batch update docs. Also shortened
line lengths and modified intro that focused on 2.2 new features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoPost-2.5-m1 whitespace fixup user/dbwells/whitespace_fixup_m1
Dan Wells [Fri, 14 Jun 2013 18:21:10 +0000 (14:21 -0400)]
Post-2.5-m1 whitespace fixup

This is an attempt at an automated whitespace cleanup for the m1
milestone of version 2.5.  It was created using the following
commands (run from Open-ILS/src/perlmods/lib):

find . -name "*.pm" \
-exec sh -c 'sed "/<</s/\t/    /g" < {} \
| expand -t 4 > {}.fixed ; \
cp --no-preserve=mode,ownership {}.fixed {}; \
rm {}.fixed' \;

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
7 years agoRepair fine generator memory leak
Bill Erickson [Mon, 27 Aug 2012 14:38:48 +0000 (10:38 -0400)]
Repair fine generator memory leak

Calling "next" from within a "try" block results in a memory leak,
presumably because "try" is a tangled nest of subs and evals.
Replacing the "try" with a good ol' "eval" avoids the leak.

This can be reproduced with the following:

---------
use Error qw/:try/;

foreach (0..200000) {
    try {
        next;
    } catch Error with {
    };
}
---------

This particular leak in the fine generator is onerous when the fine
generator is run often (e.g. every 15 mins), which means circs that
have already been processed for the day are re-analzyed over and over,
causing the code to continue early (next) to the next loop iteration
for large numbers of circs.  It also happens when a circs are skipped
because they have no fine interval, rate, or max fine.

You know this is happening because you will see something like this in
the storage stderr log:

Exiting eval via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

Exiting subroutine via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

This patch does not avoid the "exiting eval via next" warning, since
we're still next'ing out of the eval.  It just avoids the memory leak
(and the "Exiting subroutine" warning).  More extensive refactoring is
needed to to completely remove the second warning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoUse the centralized initialization method for QP
Mike Rylander [Tue, 11 Jun 2013 20:44:35 +0000 (16:44 -0400)]
Use the centralized initialization method for QP

QueryParser maintains an effective singleton for internal configuration of
the driver in order to avoid going to the database on every search request
to gather configuration parameters.  There is also a centralized sub that
has the task of properly configuring said singleton.  Previous to this commit
we were not using that centralized initializer in one case, and that case
happened to be the most important initialization of QP in all of Evergreen.
The fallout from that was that some configuration was not being gathered
and passed to QueryParser, resulting in incorrect search SQL being generated.

This is rectified by using the centralized initializer everywhere that it
is needed and can be used -- and particularly in the effected case.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoSearch clicked /and/ preceding sf values
Mike Rylander [Tue, 30 Apr 2013 20:45:55 +0000 (16:45 -0400)]
Search clicked /and/ preceding sf values

When looking for authority records to control a bib field, we currently
search using exactly, and only, the subfield that was clicked.  This
commit changes that so that the full field up to and including the clicked
subfield is used in the simple authority heading search we perform to find
the best-match (pivot) authority record.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEdits to documentation
Angela Kilsdonk [Tue, 11 Jun 2013 14:56:01 +0000 (10:56 -0400)]
Edits to documentation

Edits to fit documentation structure.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoDocumentation for Binary MARC21 Feeds and search enhancements
Angela Kilsdonk [Mon, 10 Jun 2013 20:17:08 +0000 (16:17 -0400)]
Documentation for Binary MARC21 Feeds and search enhancements

Documentation for Binary MARC21 Feeds and Bibliographic Search Enhancements added to opac/advanced_features.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoDocumentation for MARC Import Remove Fields
Angela Kilsdonk [Mon, 10 Jun 2013 19:29:20 +0000 (15:29 -0400)]
Documentation for MARC Import Remove Fields

MARC Import Remove Field documentation added to docs/admin

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoStamping upgrade script for making state not required
Ben Shum [Fri, 7 Jun 2013 20:21:07 +0000 (16:21 -0400)]
Stamping upgrade script for making state not required

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1079041 - making state not required (continued)
Ben Shum [Wed, 5 Jun 2013 04:40:53 +0000 (00:40 -0400)]
LP1079041 - making state not required (continued)

The last commit did not add the default YAOUS to the seed data. Also, some
wording tweaks to bring the content in line with the existing entries for
consistency.

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoMake the "state" field in registration a togglable YAOUS
Michael Peters [Thu, 15 Nov 2012 17:49:05 +0000 (12:49 -0500)]
Make the "state" field in registration a togglable YAOUS

Some countries do not use "State" therefore we need to create
a YAOUS to make it non-required/displaying.  This also requires
that we no longer force a "not null" on state in actor.usr_address.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for purge circs fixes
Dan Wells [Fri, 7 Jun 2013 19:58:55 +0000 (15:58 -0400)]
Stamping upgrade script for purge circs fixes

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoAdd srfsh script to call action.purge_circulations().
Jason Stephenson [Mon, 25 Mar 2013 13:10:40 +0000 (09:10 -0400)]
Add srfsh script to call action.purge_circulations().

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoReturn count purged
Thomas Berezansky [Wed, 19 Sep 2012 15:30:40 +0000 (11:30 -0400)]
Return count purged

Because postgres dislikes functions that don't return.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFix rentention typo
Thomas Berezansky [Mon, 10 Sep 2012 16:14:09 +0000 (12:14 -0400)]
Fix rentention typo

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPurge Circulations: Unwrapped Upgrade Script
Thomas Berezansky [Mon, 18 Jun 2012 17:45:21 +0000 (13:45 -0400)]
Purge Circulations: Unwrapped Upgrade Script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPurge Circulations: Allow global age as forced min
Thomas Berezansky [Mon, 18 Jun 2012 17:29:58 +0000 (13:29 -0400)]
Purge Circulations: Allow global age as forced min

This allows a library to keep all circs in the last Y interval, regardless
of user settings that may otherwise cause an earlier purging.

Another global flag that defaults to off controls this behavior.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPurge Circulations: Remove extra delete loop
Thomas Berezansky [Mon, 18 Jun 2012 17:19:18 +0000 (13:19 -0400)]
Purge Circulations: Remove extra delete loop

A trigger on action.circulation purges upwards through the circ chain. Thus
we don't need to do the loop ourselves.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPurge Circulations: Better selection logic
Thomas Berezansky [Mon, 18 Jun 2012 17:07:56 +0000 (13:07 -0400)]
Purge Circulations: Better selection logic

This attempts two things:

1 - Keep the number of circs the library wants based on the most recent
    circulations, regardless of user prefs and such.

    This is accomplished by changing the circ fetching query to use a
    window function in a subquery so we can filter on it easily.

    This also allowed removal of the purge position counter.

2 - Allow removal of circs that are between kept circs if they meet all
    other removal criteria.

    This is accomplished by using CONTINUE instead of EXIT in the loop.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPurge Circulations: Support last xact_finished use
Thomas Berezansky [Mon, 18 Jun 2012 17:00:30 +0000 (13:00 -0400)]
Purge Circulations: Support last xact_finished use

Based on a new (off by default) global flag change between the xact_finish
on the last circ in the chain and the most recent one.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPurge Circulations: Skip partially complete chains
Thomas Berezansky [Mon, 18 Jun 2012 16:52:04 +0000 (12:52 -0400)]
Purge Circulations: Skip partially complete chains

Billings in earlier portions of the chain may leave them open. Thus, look
for any circulations in the chain with a null xact_finish.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoCirc Chain Functions should take BIGINTs
Thomas Berezansky [Mon, 18 Jun 2012 16:49:39 +0000 (12:49 -0400)]
Circ Chain Functions should take BIGINTs

Because INTEGER isn't suitable for circ IDs.

This only requires editing the input definitions.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoStamping upgrade script for purge holds functionality
Dan Wells [Fri, 7 Jun 2013 19:31:37 +0000 (15:31 -0400)]
Stamping upgrade script for purge holds functionality

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoUpdate the purge_holds.txt release notes.
Jason Stephenson [Wed, 10 Apr 2013 21:29:28 +0000 (17:29 -0400)]
Update the purge_holds.txt release notes.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoAdd table, view and trigger for "aging" hold requests on delete.
Jason Stephenson [Thu, 4 Apr 2013 15:30:25 +0000 (11:30 -0400)]
Add table, view and trigger for "aging" hold requests on delete.

This creates the action.aged_hold_request table, the
action.all_hold_request view, the action.age_hold_on_delete
function, and the action_hold_request_aging_tgr on action.hold_request.

Add fieldmapper entries for action.all_hold_request view and
action.aged_hold_request table.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoAdd a purge_holds.srfsh script so it can be run from cron.
Jason Stephenson [Mon, 1 Apr 2013 20:59:59 +0000 (16:59 -0400)]
Add a purge_holds.srfsh script so it can be run from cron.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoFix typo in purge holds function
Thomas Berezansky [Tue, 2 Apr 2013 14:18:55 +0000 (10:18 -0400)]
Fix typo in purge holds function

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoRelease notes for Purge Holds routine
Thomas Berezansky [Wed, 13 Feb 2013 21:08:01 +0000 (16:08 -0500)]
Release notes for Purge Holds routine

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFix seed values and upgrade script
Thomas Berezansky [Wed, 13 Feb 2013 20:41:44 +0000 (15:41 -0500)]
Fix seed values and upgrade script

enabled and label were out of order.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoMake user visible holds based on fill/cancel time
Thomas Berezansky [Thu, 21 Jun 2012 13:55:05 +0000 (09:55 -0400)]
Make user visible holds based on fill/cancel time

Instead of request time. That way holds don't vanish after filling when
keeping history was turned on after hold placement.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoAdd purge_holds DB function
Thomas Berezansky [Thu, 21 Jun 2012 13:44:11 +0000 (09:44 -0400)]
Add purge_holds DB function

This allows removing of holds based on patron and library preferences.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoWe still don't support Z30.59 or Z39.59
Dan Wells [Fri, 7 Jun 2013 19:07:30 +0000 (15:07 -0400)]
We still don't support Z30.59 or Z39.59

Actually, just fix a few typos :)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoStamping upgrade script for batch z39.50 search, match, overlay
Dan Wells [Fri, 7 Jun 2013 18:57:48 +0000 (14:57 -0400)]
Stamping upgrade script for batch z39.50 search, match, overlay

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoZ39.50 Batch Search/Overlay : SQL / IDL
Bill Erickson [Tue, 5 Mar 2013 14:20:43 +0000 (09:20 -0500)]
Z39.50 Batch Search/Overlay : SQL / IDL

Copied some missing pieces from the upgrade scripts into the seed schema
/ data files.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay Release Notes
Bill Erickson [Mon, 25 Feb 2013 16:37:28 +0000 (11:37 -0500)]
Z39.50 Batch Search/Overlay Release Notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay TPAC my-list entry point
Bill Erickson [Mon, 25 Feb 2013 18:17:59 +0000 (13:17 -0500)]
Z39.50 Batch Search/Overlay TPAC my-list entry point

Similar to the staff client bucket UI, this adds a button which allows
staff to access the batch Z39 search-and-queue operation directly from
the TPAC my-lists UI.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay Z-Index Admin UI
Bill Erickson [Mon, 25 Feb 2013 15:37:11 +0000 (10:37 -0500)]
Z39.50 Batch Search/Overlay Z-Index Admin UI

Admin -> Server Admin -> Z-Index Field Maps

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay minor IDL repairs
Bill Erickson [Mon, 25 Feb 2013 15:36:54 +0000 (10:36 -0500)]
Z39.50 Batch Search/Overlay minor IDL repairs

Added some missing reporter:selector attributes and repaired an invalid
link class.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay Z-Search UI
Bill Erickson [Mon, 18 Feb 2013 15:41:01 +0000 (10:41 -0500)]
Z39.50 Batch Search/Overlay Z-Search UI

Adds a new "Find Z39.50 Matches" option to Cataloging -> Manage Record
Buckets.  When selected, the user chooses the Z39 fields, the Z39
sources, the destination queue, and the queue match set.  The user then
submits the search.  Basic progress info is reported to the user.
Once complete, the user can open the destination queue, from which
regular vandelay import, etc. actions may be performed on the newly
found records.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay Seed Data
Bill Erickson [Wed, 13 Feb 2013 19:07:29 +0000 (14:07 -0500)]
Z39.50 Batch Search/Overlay Seed Data

Org unit setting seed data:
* cat.z3950.batch.max_parallel
* cat.z3950.batch.max_parallel

Stock / sample seed data entries for config.z3950_index_field_map, with
room added for future stock data.

Vandelay bib attribute seed data for Z39.50 source (901z), which is
stamped during the Z39.50 batch search-and-queue operation.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoVandelay : sort queued records by matches
Bill Erickson [Wed, 13 Feb 2013 17:16:24 +0000 (12:16 -0500)]
Vandelay : sort queued records by matches

Sort queued records by their matches (based on the first match) so that
like records are grouped in the queue interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoVandelay record bucket-limited matching
Bill Erickson [Thu, 31 Jan 2013 17:37:44 +0000 (12:37 -0500)]
Vandelay record bucket-limited matching

Provides the option to link record buckets to vandelay queues.  When
linked, vandelay imports where a match set is specified will limit
matches to records within the selected bucket.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay API
Bill Erickson [Wed, 30 Jan 2013 22:44:30 +0000 (17:44 -0500)]
Z39.50 Batch Search/Overlay API

New API for performing Z39.50 queries for a set of bib records across a
set of Z39 sources.  Searches are performed in parallel (up to a
configurable maximum number of active searches and maximum results) and
results are stored in a vandelay MARC Import/Export queue.

Search fields and values are determined by Z39 index field maps.  At
search time, the caller provides a set of field maps to use for the
search. Search values for each bib record are found by following the
index maps to the indexed values in metabib.*_field_entry or
metabib.record_attr.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoZ39.50 Batch Search/Overlay : SQL / IDL
Bill Erickson [Wed, 30 Jan 2013 20:08:47 +0000 (15:08 -0500)]
Z39.50 Batch Search/Overlay : SQL / IDL

 * DB table for Z39.50 index field maps, which link Z39 search fields to
   indexed bib data via metabib fields and record attributes (svf)

 * Seed data for Z39.50 batch search org unit settings
  ** cat.z3950.batch.max_parallel
  ** cat.z3950.batch.max_results

 * Stock seed data for config.z3950_index_field_map entries

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoRepair SIP start/end list ranges
Bill Erickson [Fri, 5 Apr 2013 17:28:08 +0000 (13:28 -0400)]
Repair SIP start/end list ranges

SIP supports paging of certain lists (holds, fines, etc.) by allowing
the SIP client to provide start and end points for lists.  This patch
repairs how Evgreen extracts the list ranges from arrays.

When using Perl array ranges, the array variable should be accessed via
'@' and not '$'.  Prior to this change, all ranged lists resulted in
returning the first item in the list instead of the full range.

This change affects lists of holds, overdues, fines, and charges.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
7 years agoMake Force/Recall holds always return as nearest
Thomas Berezansky [Thu, 26 Jul 2012 14:25:32 +0000 (10:25 -0400)]
Make Force/Recall holds always return as nearest

Without even running the hold rules.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm

(Just whitespace conflicts on tab vs space -- repaired by hand.)

7 years agoTPAC - set autofocus to user input when placing holds in staff client
Ben Shum [Sat, 2 Mar 2013 07:21:58 +0000 (02:21 -0500)]
TPAC - set autofocus to user input when placing holds in staff client

When placing holds in TPAC via the staff client, the focus had been on the
basic search field above. Change this to have autofocus on the input field
for the hold user by default.

This can potentially save staff from having to perform an extra click to
select the input field. Now they can immediately begin entering the barcode
of the user they plan to create a hold on behalf of.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoSIP renew-all; reset renewal statuses
Bill Erickson [Mon, 7 Jan 2013 14:35:55 +0000 (09:35 -0500)]
SIP renew-all; reset renewal statuses

Reset the list of renewed and unrenewed items for each instance of the
RenewAll transactions.  Otherwise, items from previous transactions will
bleed into the current transaction.

While we're in there, fix a couple of tabs.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoSIP RenewAll
Bill Erickson [Mon, 26 Nov 2012 19:51:27 +0000 (14:51 -0500)]
SIP RenewAll

Adds SIP plugin support for SIP message types 65/66 (Renew All).  When
requested, the plugin performs a renewal on all items currently checked
out for the user.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP1040147 Return wrong-shelf holds in clearable list
Bill Erickson [Fri, 7 Jun 2013 13:42:57 +0000 (09:42 -0400)]
LP1040147 Return wrong-shelf holds in clearable list

1. Change the staff client "View Shelf-Expired Holds" action label to
"View Clearable Holds".

2.  When "View Clearable Holds" is selected, display both shelf-expired
and wrong-shelf holds.

New API calls:

open-ils.circ.captured_holds.expired_on_shelf_or_wrong_shelf.retrieve
open-ils.circ.captured_holds.id_list.expired_on_shelf_or_wrong_shelf.retrieve

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agochange checkbox label in Browse Hold Shelf
Jason Etheridge [Thu, 6 Jun 2013 23:00:45 +0000 (19:00 -0400)]
change checkbox label in Browse Hold Shelf

from View Shelf-Expired Holds to View Clearable Holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoadd Current Shelf Library column to xul interfaces
Jason Etheridge [Thu, 6 Jun 2013 21:49:46 +0000 (17:49 -0400)]
add Current Shelf Library column to xul interfaces

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoInclude Wrong-Shelf holds in clear-shelf results
Bill Erickson [Tue, 21 Aug 2012 21:19:54 +0000 (17:19 -0400)]
Include Wrong-Shelf holds in clear-shelf results

Include non-expired, Wrong-Shelf holds in the results list of the "Clear
Shelf-Expired Holds" process.  ("Wrong-Shelf" holds are those whose
pickup lib was changed while the hold was on the holds shelf).  The idea
behind this option is that branches may use the clear-shelf process as a
general shelf management report beyond just holds that have expired.
I.e. tell me everything I need to remove from the shelf.

This change includes a label change for the clear-shelf menu options:

"Clear Shelf-Expired Holds" -> "Clear Holds Shelf"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoAsciidoc edit for My Lists documentation
Angela Kilsdonk [Fri, 7 Jun 2013 14:04:27 +0000 (10:04 -0400)]
Asciidoc edit for My Lists documentation

Change to asciidoc structure in opac/my_lists.txt

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoRemove unnecessary TPAC toggle strings on staff client splash page
Ben Shum [Fri, 7 Jun 2013 00:14:08 +0000 (20:14 -0400)]
Remove unnecessary TPAC toggle strings on staff client splash page

Accidentally reintroduced with commit ad86ef5d3c689c9b514cc09bfc93e7f451461dc7,
we can skip adding back TPAC toggle strings to the index.xhtml file since that
toggle action has been removed from the page.

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAcq: Be fuzzy about case when retrieving EDI documents
Lebbeous Fogle-Weekley [Mon, 15 Apr 2013 18:06:54 +0000 (14:06 -0400)]
Acq: Be fuzzy about case when retrieving EDI documents

The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
other things, try to avoid fetching the same EDI document multiple times
when many rows in acq.edi_account refer to the same host and login
credentials.

Since in practice most vendors seem to run FTP servers for EDI on
Windows, not UNIX, and pathnames are therefore case-insensitive, that
test for other occurrences ought also to be case-insensitive.

If I were to look at this as a purist, I could argue that vendor servers
might sometimes by run on UNIX, and that for some reason it is possible
that different vendor-to-buyer EDI documents (order responses or
invoices) could have pathnames that differ only in the case of some
characters.  But that seems wildly unlikely.  If anyone does take this
possibility seriously, perhaps acq.edi_account needs a Boolean column to
indicate the remote host's case [in]sensitivity.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agolp1183525 Edit Item Attributes pop-up dimensions
Jason Etheridge [Thu, 6 Jun 2013 21:39:24 +0000 (17:39 -0400)]
lp1183525 Edit Item Attributes pop-up dimensions

Took Steven Chan's patch from the launchpad bug and added "stickiness" to the
window dimensions.  So by default, it'll come up maximized, but once adjusted,
it will stay adjusted.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years ago"Return to record" after submission of phone number on SMS page fixed
Lebbeous Fogle-Weekley [Thu, 2 May 2013 19:00:31 +0000 (15:00 -0400)]
"Return to record" after submission of phone number on SMS page fixed

Before this, it only worked on the page load *before* form submission.
There's probably a more elegant solution that doesn't involve keeping
track of URIs, but this seems to me to work.

Problem relayed to me by Dale Rigney at Equinox, who helped reproduce
the issue and test a fix.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agofix copy/paste error
Jason Etheridge [Thu, 6 Jun 2013 20:47:13 +0000 (16:47 -0400)]
fix copy/paste error

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoAllow translating more strings in xul-files.
Pasi Kallinen [Tue, 19 Mar 2013 23:21:28 +0000 (01:21 +0200)]
Allow translating more strings in xul-files.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoAdd the copy number to the list of data being pulled for access by the TPAC.
Steven Callender [Mon, 11 Mar 2013 19:48:57 +0000 (15:48 -0400)]
Add the copy number to the list of data being pulled for access by the TPAC.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoAllow translating the staff client tab names
Pasi Kallinen [Thu, 7 Mar 2013 10:17:09 +0000 (12:17 +0200)]
Allow translating the staff client tab names

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoFix Latin-1 encoding that broke doc output
Dan Scott [Thu, 6 Jun 2013 18:01:07 +0000 (14:01 -0400)]
Fix Latin-1 encoding that broke doc output

asciidoc only expects and can only handle utf-8 encoding :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoImprove the db-seed-i18n.py -script to actually grab all strings.
Pasi Kallinen [Thu, 21 Mar 2013 10:01:24 +0000 (12:01 +0200)]
Improve the db-seed-i18n.py -script to actually grab all strings.

Previously the script could only handle oils_i18n_gettext -markers
if the marker and it's parameters were all on one line.

Now it also correctly parses the postgres E'' escaped strings, and
removes sql string concatenations.

Also adds test cases.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd new POT files to git so "make newpo" will work
Dan Scott [Thu, 6 Jun 2013 16:13:36 +0000 (12:13 -0400)]
Add new POT files to git so "make newpo" will work

Running "make newpo" errored out because the po subdirectories didn't
exist for the newly added POT files. This will also enable translators
to access the strings in Launchpad.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd missing dojo nls files to the i18n toolchain, and fix one of the files so they...
Pasi Kallinen [Tue, 4 Jun 2013 09:01:32 +0000 (12:01 +0300)]
Add missing dojo nls files to the i18n toolchain, and fix one of the files so they be built.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoFedora RPM for bzip2 headers is bzip2-devel
Dan Scott [Thu, 6 Jun 2013 13:40:59 +0000 (09:40 -0400)]
Fedora RPM for bzip2 headers is bzip2-devel

There was an attempt to add the right RPM for the bzip2 headers in
Makefile.install, but that failed on Fedora 19. Swap in bzip2-devel
instead to correct that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoTPAC: First part of locg param can be branch shortname
Lebbeous Fogle-Weekley [Mon, 22 Oct 2012 22:02:23 +0000 (18:02 -0400)]
TPAC: First part of locg param can be branch shortname

Addresses LP #1020625.  You can use the locg param, which can set an
an OU for search context (and which has other implications related to
location/scope) by shortname now.

As long as your shortnames are something that work in an HTTP query
string, don't contain colons, and as long as you don't have numeric
shortnames for any orgs that would mask orgs with the sames numbers
as an ID (but that would be a lousy setup anyway), this should work.

Now case insensitive per recommendation by Michael Peters.  In the
event that you have org units with names that are the same except
for case (probably a bad practice), the locg parameter will simply
fail to set your context, rather than try to guess which org unit
you meant.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm

7 years agoAsciidoc fix for documentation
Angela Kilsdonk [Thu, 6 Jun 2013 14:38:42 +0000 (10:38 -0400)]
Asciidoc fix for documentation

Fixed faulty asciidoc in docs/admin/lsa-library_settings_editor.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoMove lost items modification release notes
Ben Shum [Wed, 5 Jun 2013 03:17:17 +0000 (23:17 -0400)]
Move lost items modification release notes

Moved to the Circulation category and small changes to the formatting for
conversion.

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for lost items blocking
Ben Shum [Wed, 5 Jun 2013 03:38:25 +0000 (23:38 -0400)]
Stamping upgrade script for lost items blocking

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoPatron Blocking by lost items and include lost as items out
Kyle Tomita [Thu, 14 Mar 2013 22:01:14 +0000 (15:01 -0700)]
Patron Blocking by lost items and include lost as items out

This feature has two main parts, patron blocking by number
of lost items and include lost items as items out.  A group penalty
threshold will be added for lost items.  This will restrict patrons
who have lost too many items. The inclusion of lost items as items
out will be an optional setting, like claimed returned items. This
will allow libraries to set what type of item statuses count toward
the total items out.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Justin Douma <jdouma@catalystitservices.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdded release note for standalone mode shortcuts
Ben Shum [Wed, 5 Jun 2013 02:57:00 +0000 (22:57 -0400)]
Added release note for standalone mode shortcuts

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStandalone Mode Staff Client Shortcuts
Pranjal Prabhash [Mon, 9 Apr 2012 14:55:08 +0000 (10:55 -0400)]
Standalone Mode Staff Client Shortcuts

This commit addresses LP#955283, which requested the creation
of a Windows shortcut for Evergreen's standalone staff client
mode.

Signed-off-by: Pranjal Prabhash <pranjal.prabhash@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record
Simon Hieu Mai [Mon, 3 Jun 2013 21:45:08 +0000 (17:45 -0400)]
LP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record

Put the cursor back to the current fixed field after reload
the MARC record table.

Signed-off-by: Simon Hieu Mai <hieu.mai@mnsu.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1183340 selectivly apply editable funds sorting
Bill Erickson [Thu, 23 May 2013 13:11:25 +0000 (09:11 -0400)]
LP1183340 selectivly apply editable funds sorting

Avoid sorting editable funds to the front of the fund list when there
are no org units at which the user has the ADMIN_ACQ_FUND permission.
Otherwise, we are sorting on an empty 'IN' list in pcrud, which results
in an error.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoDocumentation for preset tabs and auto login
Tracy Swaim [Sat, 1 Jun 2013 05:13:13 +0000 (01:13 -0400)]
Documentation for preset tabs and auto login

Missed the actual documentation in the last commit for preset tabs and
auto login docs. Here it is.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoPre-set tabs and auto login
Tracy Swaim [Sat, 1 Jun 2013 05:00:26 +0000 (01:00 -0400)]
Pre-set tabs and auto login

Adding staff client documentation for pre-set tabs and auto login.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoDocumentation for Org Unit Hiding in TPAC
Angela Kilsdonk [Fri, 31 May 2013 19:09:11 +0000 (15:09 -0400)]
Documentation for Org Unit Hiding in TPAC

Added Org Unit Hiding in TPAC documentation to admin/lsa-library_settings_editor.txt.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Angela Kilsdonk [Fri, 31 May 2013 18:46:50 +0000 (14:46 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

7 years agoWhen delivering MARC21 via SuperCat, OpenSearch, offer filename w/ extension
Lebbeous Fogle-Weekley [Fri, 10 May 2013 16:32:51 +0000 (12:32 -0400)]
When delivering MARC21 via SuperCat, OpenSearch, offer filename w/ extension

If you want a record feed in MARC21, without this commit a web browser
just suggests "marc21" as the filename for saving to your local system.

Although many consumers of these feeds will be custom scripts and other
non-interactive software components that won't care about filename, for
the web browser case it's helpful if the server suggests a filename that
ends in .mrc.

So here we go.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1081576 - fix utf8 characters in searches using portal page
Ben Shum [Thu, 23 May 2013 20:32:49 +0000 (16:32 -0400)]
LP1081576 - fix utf8 characters in searches using portal page

Replace escape() with encodeURIComponent() on the portal page to allow utf8
characters to be passed more appropriately to the subsequent search in catalog.

Thanks Dan Scott for pointing this out.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
7 years agoFix reference to image that broke epub build
Dan Scott [Fri, 31 May 2013 16:27:13 +0000 (12:27 -0400)]
Fix reference to image that broke epub build

The path pointing to the desired image was incorrect, which resulted in
a broken epub build and probably just a missing image in other formats.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAcquisitions Admin updates
Kathy Lussier [Sat, 25 May 2013 00:52:01 +0000 (20:52 -0400)]
Acquisitions Admin updates

Updates to the chapter on acquisitions administration, including 1) the
reintroduction of the Providers section, which appears to have dropped out
of the docs after 2.1 2) the new default # copies and improvements to
distributions formulas introduced in 2.4 and 3) minor copy editing.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agodon't let function keys lock the MARC editor
Jason Etheridge [Mon, 2 Apr 2012 21:07:55 +0000 (17:07 -0400)]
don't let function keys lock the MARC editor

lock = put the interface into a state where it prompts with an unsaved data
warning before closing the interface

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Conflicts:
Open-ILS/xul/staff_client/server/cat/marcedit.js
Open-ILS/xul/staff_client/server/cat/marcedit.xul

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoDocumentation updates for acquisitions invoices
Kathy Lussier [Thu, 30 May 2013 17:01:38 +0000 (13:01 -0400)]
Documentation updates for acquisitions invoices

Updates to acquisitions invoices documentation, including new 2.4
features. Also moves up some 2.1 documentation that is still relevant.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoDocumentation for Call Numbers in My Lists
Angela Kilsdonk [Thu, 30 May 2013 15:12:40 +0000 (11:12 -0400)]
Documentation for Call Numbers in My Lists

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoChange autoconf required version for libmar's configure.ac
Ben Shum [Wed, 29 May 2013 22:06:09 +0000 (18:06 -0400)]
Change autoconf required version for libmar's configure.ac

Having it set to 2.68 (current for Ubuntu Precise) broke autoreconf for other
distributions. Notably Debian Squeeze/Wheezy have 2.67 and Ubuntu Lucid has
2.65 for their autoconf version.

Set a minimum requirement of 2.61 that we use in the existing options.

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd new dependency on libbz2-dev(el).
Jason Stephenson [Tue, 26 Mar 2013 15:01:50 +0000 (11:01 -0400)]
Add new dependency on libbz2-dev(el).

Our own mar tools add a build dependency on libbz2.  The easiest way to
make sure this is there seems to be to install libbz2-dev(el).

Also, update the release notes to reflect the new dependency.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd release notes for the new updates tools.
Jason Stephenson [Wed, 20 Mar 2013 14:45:03 +0000 (10:45 -0400)]
Add release notes for the new updates tools.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix segmentation fault in mbsdiff and fix crc by linking with libbz2.
Jason Stephenson [Tue, 19 Mar 2013 12:38:31 +0000 (08:38 -0400)]
Fix segmentation fault in mbsdiff and fix crc by linking with libbz2.

Doh! I typed memcpy when I really wanted memset.

This does not actually introduce any new dependencies.  Evergreen
updates/installation already requires bzip2.  If bzip2 is present,
then libbz2 is present.  We don't need libbz2 headers, just the
library itself for a single data structure used in crc32 calculation.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>