Adds a new global flag 'ingest.disable_authority_auto_update_bib_meta',
which is disabled by default.
When disabled, the 'editor' and 'edit_date' columns on bib records
updated via authority field propagation are updated to the value of the
editor on the authority record and NOW(), respectively.
When enabled, editor and edit_date are not modified.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
It also normalizes how 'fail_part' is set in the renewal response,
as the payload of an event returned when a renewal fails can
be either a hash or an acp Fieldmapper object depending on the
type of event. In the former case, attempting to access an
nonexistent ->fail_part method is what causes the crash.
To test
-------
[1] Create an item that requires a deposit or a rental fee
and check it out.
[2] Attempt to renew the loan in the public catalog. Note
that an internal server error is returned.
[3] Apply the patch and attept step 2 again. This time, the
public catalog should display a notification to the patron
that the renewal cannot take place, rather than crashing.
[4] Set up other situations where a renewal should fail for
reasons other than a deposit/rental fee being required. Verify
that appropriate error messages are displayed in the public
catalog.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Utility function for removing all activity entries by activity type,
except for the most recent entry per user. This is primarily useful
when cleaning up rows prior to setting the transient flag on an
activity type to true. It allows for immediate cleanup of data (e.g.
for patron privacy) and lets admins control when the data is deleted,
which could be useful for huge activity tables.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Only retain the most recent user activity entry (per activity type) by
default.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 3 Jun 2015 23:30:40 +0000 (19:30 -0400)]
LP#1464709 Seamless non-standard copy status checkout
Add a new boolean configuration option to copy statuses which allow such
copies to be checked out without requiring an alert or override.
New column is config.copy_status.checkout_ok. Any status with this
boolean enabled will be treated the same as Available, Reshelving, and
Holds Shelf status copies in that the status will be considered
checkout-able.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 10 May 2016 19:41:54 +0000 (15:41 -0400)]
LP#1315552 Don't use circ_lib name in ranked_volumes
ranked_volumes() is supposed to return only volume info, but the name
returned was from copy.circ_lib, not acn.owning_lib, so it could result
in duplicate rows if circ_lib's varied across a single acn.
Let's just use the owning_lib name instead. Note: the circ_lib join
is left undisturbed to keep the current sorting behavior
(necessary?).
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Boyer [Fri, 6 May 2016 18:08:48 +0000 (14:08 -0400)]
LP1259196: Use Location as Workstation on Login
When using a SIPServer with LP1579144 applied, use the
Location (CP) field of the Login (93) message as a
workstation name. This allows you to determine which
selfcheck performed which circulation.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Thu, 11 Aug 2016 17:24:00 +0000 (13:24 -0400)]
LP#1612274: Add distinct classes for hold statuses
With more data in the My Account hold status field, libraries may want to
style some statuses or dates differently so that they pop out to the user. Each
hold status and date now has its own class for more flexible styling.
The available status also now has a green, bold font and the suspended status
has a red, bold font.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Thu, 11 Aug 2016 03:41:51 +0000 (23:41 -0400)]
LP#1612274: Improve display of holds status in My Account
Collapse the data contained in the Activate, Active, and Date Fulfilled columns
into the status filed on the My Account holds and holds history interfaces.
This change cleans up the display and removes extraneous information that the
user doesn't need to see.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Some format icons had a white background instead of a transparent one. The
transparent ones will look better in the My Account screens, where the icons
site on a gray background.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
When retrieving the holds history page on a mobile device, re-orient the table
as we do with other My Account screens.
Test plan
Pre-patch, retrieve the holds history screen for a patron that has enabled
holds history. Resize the screen to a width of 600 pixels or smaller. No
adjustments will be made to the table, and horizontal scrolling is required to
see some data.
Post-patch, after resizing this screen, the table should reorient itself with
the headers displaying in the left column, as is done on the other My Account
screens.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Sat, 20 Aug 2016 04:54:40 +0000 (00:54 -0400)]
LP#1614807: Fix spacing issues in responsive design for My Account screens
This commit fixes the following spacing issues that are found in the My Account
screens when loaded on a small-screen device:
* When a field has no value, the text in the table header, which displays along
the left, is cut off at the bottom. The Notes field on the Holds page is one
place where this issue is commonly seen. With the fix, the headers are slightly
out of alignment with the field data, but this is still an improvement over
cutting off text on the screen.
* If the only title(s) listed on the screen are short, requiring little width
in a table cell, the text in the table header runs into field data. A good
example in the Concerto data is if the user only has a check out for record ID
2 (Le concerto) on their account.
* The checkboxes in the Check Out History and Items on Hold screen were pushed
to the right. We fix it by giving the cells with a checkbox a "checkbox_column"
class, which was already in use by the checkbox on the Items Out screen.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Fri, 19 Aug 2016 17:41:14 +0000 (13:41 -0400)]
LP#1614807: Holds history should look like other My Account screens
The Holds History My Account interface looks entirely different than the Items
Out, Check Out History, and Items On Holds interfaces. This commit adds a new
acct_holds_hist_header CSS class that shares the same styles as the CSS classes
used for the other three interfaces. Inline styles are removed from this table.
Test plan
Pre-patch: Go to the My Account Items Out, Check Out History, Items on Hold,
and Holds History interfaces. While the first three interfaces use a table with
a white background for the headers and a gray background for the body, the Holds
History interface is the opposite.
Post patch: All four interfaces should show a similar style to each other.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Fri, 19 Aug 2016 15:59:27 +0000 (11:59 -0400)]
LP#1614807: Fix Circ History table header display on small screens
Because the table in circs.tt2 and circ_history.tt2 shared the same CSS class,
circ_history.tt2 was displaying circs.tt2's column headers on mobile devices
and other small screens. The two tables now have distinct classes, and
styles.css.tt2 has been updated to provide the correct table headers for the
circ history page.
Test plan
Pre-patch, pull up a user account that has a circ history in My Account, go to
the Check Out History tab, then resize the screen to a width of 600 pixels or
smaller. The table headers will now display along the side, but the headers
will be the ones that typically display in the Items Out screen. The Barcode
will display in the Date Returned row and the Call number will display in the
Barcode row.
Post-patch, after resizing the screen, the headers that display along the side
should match the ones from the Checkout History interface. All data should
display in its appropriate row.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Boyer [Mon, 20 Jun 2016 16:38:00 +0000 (12:38 -0400)]
LP1593834: Add Date Header to A/T Email Examples
RFCs 822 and 2822 specify that a Date: header has to be sent
indicating when an email was sent. Without this, clients that
default to displaying the Sent Date may end up using a "NULL"
date, or 1970-01-01 00:00:00 UTC, which is not ideal. This
adds the header to the example A/T templates for email and
SMS messages, and includes instructions on correcting
existing tempalates.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
These tests check that the copy status is correct after aborting
transits dependent upon the status of the copy. More tests could be
added to cover more situations, but these tests cover the basics.
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Fri, 18 Mar 2016 20:38:33 +0000 (16:38 -0400)]
LP 1306666: Abort Transit Only Change Copy Status if In Transit
When aborting a transit, the copy status is presently changed, either
to the status stored in action.transit_copy or to Reshelving if the
transit was for a hold. This causes problems with "hanging" transits
where something was not handled properly before. We've had cases
where a transit sticks around on a copy that is later checked out, and
while that copy is checked out, the transit is aborted, thus setting
the copy status to Reshelving when it should be Checked Out.
The code change in this branch only changes the copy's status if it is
In Transit. A copy in any other status has its status left untouched.
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Chris Sharp [Sat, 20 Aug 2016 18:52:15 +0000 (14:52 -0400)]
LP#1586221 - Remove "no spaces" message from login form.
Since the fix to bug 1086064 removes any spaces entered into
the login form, it is now inaccurate to require the user to type
their cards with no spaces (since most library cards have spaces
in the number on the physical card).
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Fix TPAC circ history retrieval code thinko so that history rows are
retrieved one at a time instead of in a batch (.atomic) to avoid
overwhelming Ejabberd.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Mon, 15 Aug 2016 18:07:21 +0000 (14:07 -0400)]
LP#1613381: combine two tables in patron notification preferences
This patch consolidates the two tables in the public catalog
notification preferences page into one table, as patrons have
no reason to care about the distinction between A/T opt-in
settings and the hold, phone, and SMS user settings.
This patch also adds a <label> element for opt-in setting
names.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Wed, 17 Aug 2016 14:53:19 +0000 (10:53 -0400)]
LP#1476049: disable serve-cgi-bin Apache config on Jessie and Xenial
This patch ensures that the stock Apache configuration
"serve-cgi-bin" is disabled when installing on Debian Jessie
and Ubuntu Xenial, as otherwise the default cgi-bin location
can override what Evergreen specifies for offline.pl.
To test:
[1] Run the Makefile.install step on Jessie or Xenial; verify
that there is no /etc/apache2/conf-enabled/serve-cgi-bin.conf
symlink.
[2] Proceed with the rest of the Evergreen installation; verify
that the Apache error log doesn't contain a warning like this:
"The Alias directive in /etc/apache2/sites-enabled/eg.conf ...
will probably never match because it overlaps an earlier
ScriptAlias."
[3] For extra credit, verify that one can access offline circulation
sessions.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Adds support for a class of cached value (AKA "LoginSession" items)
that are cleared when either the user logs out or the browser is closed.
Values are stored as cookies.
Authentication tokens and "retrieve last patron" data are now stored as
"LoginSession" items.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Store most recent patron ID via cookie instead of localStorage so the
value can expire when then browser is closed.
Adds angular-cookies (ngCookies) dependency.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/bower.json
Bill Erickson [Thu, 4 Aug 2016 21:56:32 +0000 (17:56 -0400)]
LP#1522635 Webstaff lost (etc.) checkout completes
Resolves an issue in the browser client where checkout of LOST
(and other non status='checked out' copies) failed to show the
open-circ-exists dialog. In short, when searching for an existing
open circulation, look for any open circulation linked to the copy,
regardless of the status of the copy.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 10 Jun 2016 22:21:31 +0000 (18:21 -0400)]
webstaff: add admin interface for MARC tag tables
This is a simple interface using eg-edit-fm-record to start;
more work will be required to better deal with the semantics
for overriding tag definitions at various levels of the OU
hierarchy.
It seems Angular 1.5 is either less flexible or less forgiving in its
ng-repeat implementation, and does not like an orderBy filter on object
iterators. Removing that, and the track by clause, allows the holdings
editor to render properly.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Sun, 15 May 2016 16:51:24 +0000 (12:51 -0400)]
webstaff: egAudio HTML5 audio service
egCore.audio.play('audio.event.dot.path');
Service to look up audio URL's by key name. Supports fall-thru behavior
where 'foo.bar.baz' will fall-thru to 'foo.bar' and 'foo' depending on
whether an audio file is avaialable.
Galen Charlton [Thu, 12 May 2016 16:27:11 +0000 (12:27 -0400)]
LP#1581126: webstaff: make egDateInput respect format.date OUS
This patch makes the egDateInput directive fetch the
date format from the format.date library setting. The
directive also now accepts a dateFormat attribute for cases
where there is a reason to override the library setting.
If no format is set via library setting or in how the
directive is invoked, the format defaults to "mediumDate",
e.g., "May 2, 1999".
To test:
[1] Open the webstaff patron registration form. Verify that
date widgets display the date in the format that
corresponds to the value of the format.date library setting
for the current work station, or (if the library setting
is not set, "Month day, year".
Galen Charlton [Wed, 11 May 2016 17:17:55 +0000 (13:17 -0400)]
webstaff: add server administration page
This patch adds a landing page for Server Administration and
code to embed all of the admin pages available under Serer
Administration in the XUL staff client.
TODO:
* fix the permission groups editor so that it works
when embedded in the web staff client
* refactor admin/local/app.js and admin/server/app.js to
unify some of the copy and pasting
* replace the embedded legacy OU editor with a new
angular one
* fixes some CSS issues that make text hard to read in
a few places
Galen Charlton [Wed, 4 May 2016 19:04:23 +0000 (15:04 -0400)]
webstaff: work log: various improvements
* Don't use $location.path() to generate a URL for when opening
a new window, as that can cause the parent window to reset
itself.
* Fix the refresh button
* Add support for paging through worklog entries
* Don't prematurely resolve the promise that is
feeding rows to the grid
* Ensure that entries are displayed in timestamp order
Jim Keenan [Fri, 12 Aug 2016 18:51:28 +0000 (14:51 -0400)]
lp1592934 removed lines referencing edition fields 534 and 775. These fields refer to other, different editions of the work and not to the work actually being returned.
Signed-off-by: Jim Keenan <jkeenan@cwmars.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Thu, 11 Aug 2016 12:20:34 +0000 (08:20 -0400)]
LP#1612054: unbreak test case now that SSN is no longer an ID type
The patch for bug 1566016 broke the live_t/17-lp1579225_new_patron_passwords.t
test, as it used a patron ID type that is no longer in the seed
data. This patch fixes the test.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Dan Wells [Tue, 9 Aug 2016 19:50:50 +0000 (15:50 -0400)]
LP#1611495 Don't use .xml for MARC21 files in Vandelay Export
The new 'Export Non-imported Records' feature in Vandelay (see bug
LP#1548147) was tweaked before merge to export MARC21 files by default
(rather than MARC-XML). However, the file save dialog still defaults to
(and filters by) ".xml" for the file extension. This is confusing and
otherwise problematic.
Let's go ahead and save the export using a ".mrc" extension instead.
While not an official extension (as far as I know), it is widely used,
easy to understand, and far less likely to cause issues with other
software.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
The previous patch had a side-effect of changing the 852$d
value from the circ library's shortname to its long name. This
patch restores the previous behavior.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Wed, 26 Aug 2015 17:59:37 +0000 (17:59 +0000)]
LP#1037553: bibliographic record source now copied to 901$s
If a bibliographic record has a source set, the name of that source
is now copied to the 901$s whenever the record is created or updated.
This allows the source to be used for record matching and MARC
field queries.
To test:
[1] Create or import a bibliographic record and ensure that its
source is set to a non-null value.
[2] Inspect the record in MARC format view and verify that its
901 field now has a subfield $s containing the name of the
source.
[3] Use pg_prove to run the pgTAP test added by this patch
and verify that the test passes.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP 1503867: Use ws_ou in open-ils.circ.copy_transit.receive.
After putting NCIPServer into production, we discovered that a staff
user cannot receive a transit destined for their work org. unit if
the actor.usr.home_ou is not the same as their current work_ou.
This occurred because transit_receive in OpenILS::Application::
Circ::Transit uses the requestor's home_ou and not the ws_ou.
If you want to trigger this bug, write a little script to receive
transits, then login with a staff account at a location other than
their home_ou and try to receive a transit destined for the work_ou.
It will fail.
This small commit replaces home_ou in two places with ws_ou in order
to make the above work.
NOTE: This bug affects an API call not used in Evergreen except in
one test script. It used in two ILL add-ons for Evergreen: issa and
NCIPServer. Receiving transits by checking copies in via the staff
client, the typical workflow, is not affected by this bug or its fix.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / working / Evergreen.git / log