working/Evergreen.git
12 months agoLP#1635737 Use new OpenSRF interval_to_seconds() context
Dan Wells [Fri, 21 Jul 2017 18:28:16 +0000 (14:28 -0400)]
LP#1635737 Use new OpenSRF interval_to_seconds() context

Use the optional context for interval_to_seconds() to account for the
variable length of duration components.  For example, "1 day" may be
shorter or longer than 24 hours during a time change event, "1 month"
may be shorter or longer depending on which month it is currently, etc.

Also, remove some timestamp munging, as that happens within
interval_to_seconds() already.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
12 months agoLP#1635737: Unit tests for DST and date math
Mike Rylander [Tue, 6 Nov 2018 20:27:23 +0000 (15:27 -0500)]
LP#1635737: Unit tests for DST and date math

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
12 months agoLP#1635737 Add optional context to interval_to_seconds
Dan Wells [Tue, 6 Nov 2018 20:13:47 +0000 (15:13 -0500)]
LP#1635737 Add optional context to interval_to_seconds

Any given interval (e.g. "1 month") can be a different amount of
seconds depending on the context (i.e. "1 month" after February 1 is
March 1, but "1 month" after March 1 is April 1, yet March is longer
than February).  This affects months all the time, but also can
affect days, hours, and even seconds once you consider DST and "leap"
times.

By giving an optional context to interval_to_seconds, you can find
the true number of seconds in, for example, "1 month", when starting
from "February 1" (the context).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
12 months agoAdd eg_startup back to .gitignore
Ben Shum [Tue, 6 Nov 2018 20:35:49 +0000 (15:35 -0500)]
Add eg_startup back to .gitignore

Since we moved eg_startup to apache_24, we also need to ignore there.

Signed-off-by: Ben Shum <ben@evergreener.net>
12 months agoLP#1783602: Remove copy counts from mr search results page
Kathy Lussier [Wed, 25 Jul 2018 15:51:06 +0000 (11:51 -0400)]
LP#1783602: Remove copy counts from mr search results page

The copy counts on the mr search results page can be wrong if a limiter was
applied to the metarecord search. Rather than supply inaccurate information to
the user, let's remove the counts from that page until a long-term solution can
be developed.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1755543: Change placement of help popovers
Kathy Lussier [Mon, 5 Nov 2018 20:50:24 +0000 (15:50 -0500)]
LP#1755543: Change placement of help popovers

Set the placement of help tip popovers so that they automatically position
to a visible place on the screen.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1755543: Add help tips to Print Item Labels Settings tab
Kathy Lussier [Tue, 13 Mar 2018 16:54:42 +0000 (12:54 -0400)]
LP#1755543: Add help tips to Print Item Labels Settings tab

Instead of providing lengthy settings descriptions, which result in a lot of
scrolling on the Print Item Template page, let's use help tips that can
provide guidance to new users without adding clutter to the interface.

This commit also turns the field labels into HTML labels for improved
accessibility and removes borders on the page. The borders were helpful
when we displayed the help text on the page, but are no longer needed.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1755896: Web Client mobile menu font color contrast.
Garry Collum [Thu, 7 Jun 2018 18:54:45 +0000 (14:54 -0400)]
LP#1755896: Web Client mobile menu font color contrast.

When viewing the main menu in the web client in a small device or in a
browser with a width that is resized to less than 800px the menu
collapses and the submenu choices are difficult to read because of lack
of contrast.  This patch adds some contrast.

To test:
1. View the web client in a browser and lessen the width until the menu
   collapses, or view it in a small device.
2. Open some of the menu options to observe the submenus.
3. Apply the patch.
4. Refresh the browser and repeat steps 1-2 to view the more readable
   submenus.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1789747: tweak disabling the offline circulation link
Galen Charlton [Mon, 5 Nov 2018 21:40:34 +0000 (16:40 -0500)]
LP#1789747: tweak disabling the offline circulation link

This patch ensures that the menu link can be fully disabled by
giving the "disabled" CSS class to the anchor as well as the
li that contains it. It also adds a CSS rule to the disabled
class to force the cursor to not-allowed; due to a quirk, an
anchor with "pointer-events: none" will not respect "cursor: not-allowed",
but the containing element can have that cursor rule.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1789747 More SharedWorker sanity checks for egLovefield
Bill Erickson [Tue, 4 Sep 2018 19:09:31 +0000 (15:09 -0400)]
LP#1789747 More SharedWorker sanity checks for egLovefield

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rhamby@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1789747 SharedWorker sanity checks
Bill Erickson [Thu, 30 Aug 2018 17:19:03 +0000 (13:19 -0400)]
LP#1789747 SharedWorker sanity checks

Avoid page load failures when SharedWorkers (for offline mode) are
not supported.  Additionally, disable the Offline Circulation menu
option when SharedWorkers are not supported.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1798170 Load grid data after settings are applied
Bill Erickson [Tue, 16 Oct 2018 18:15:53 +0000 (14:15 -0400)]
LP#1798170 Load grid data after settings are applied

Ensure the initial grid data fetching code does not fire until after the
grid configuration has been retrieved and applied.  This fixes an issue
where custom columns would contain no values on initial grid load.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1801759: enable mod_remoteip by default
Galen Charlton [Mon, 5 Nov 2018 17:54:24 +0000 (12:54 -0500)]
LP#1801759: enable mod_remoteip by default

Use of mod_remoteip is technically optional, since it's not
required that Evergreen run with a proxy such as NGINX. However, since
use of proxies is common, enablig mod_remoteip just in case could
be useful with minimal cost.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
12 months agoLP#1801759: add mod_remoteip configuration to example Apache config
Galen Charlton [Mon, 5 Nov 2018 17:49:35 +0000 (12:49 -0500)]
LP#1801759: add mod_remoteip configuration to example Apache config

Text taken from an OpenSRF patch added by Bill Erickson per bug 1684970.

This patch adds an Apache configuration stanza that uses mod_remoteip
to pass the user agent's IP address to the HTTP translator. It is meant
for when Apache is being run behind a proxy such as NGINX.

To test
-------
[1] Set up Evergreen with Apache and the WebSockets server running
    behind a proxy such as NGINX.
[2] Enable mod_remoteip (e.g., sudo a2enmod remoteip).
[3] Apply the Apache configuration change in this patch, uncommenting
    out the directives and (if necessary) updating the internal IP
    address of the proxy.
[4] Reload Apache.
[5] Perform an action that uses the HTTP translator, e.g., adding a
    vendor record using the Dojo interface.
[6] Verify that the client IP logged is that of the user agent, not
    the proxy.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
12 months agoDocs: updating holding, item, call number terminology
Jane Sandberg [Sun, 4 Nov 2018 23:25:44 +0000 (15:25 -0800)]
Docs: updating holding, item, call number terminology

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
12 months agoDocs: Update old command osrf_ctl.sh to osrf_control
Remington Steed [Fri, 2 Nov 2018 19:00:55 +0000 (15:00 -0400)]
Docs: Update old command osrf_ctl.sh to osrf_control

Thanks to Rosie Le Faive for catching this problem, and providing the
solution!

Signed-off-by: Remington Steed <rjs7@calvin.edu>
12 months agoLP1796988: Fix Saving Last Copy Template
Jason Boyer [Fri, 26 Oct 2018 13:16:14 +0000 (09:16 -0400)]
LP1796988: Fix Saving Last Copy Template

A line that belongs within a forEach loop escaped
its bounds and caused a reference error that prevented
the applyTemplate function from saving the last used
template. This branch ushers this line back to its
pen where it can trouble us no more.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
12 months agoDocs: Emergency Closing Handler
abneiman [Thu, 1 Nov 2018 20:59:02 +0000 (13:59 -0700)]
Docs: Emergency Closing Handler

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
12 months agoDocs: Fix minor release notes formatting bug
Remington Steed [Wed, 31 Oct 2018 20:53:17 +0000 (16:53 -0400)]
Docs: Fix minor release notes formatting bug

Signed-off-by: Remington Steed <rjs7@calvin.edu>
12 months agoForward Port Release Notes for 3.0.13.
Jason Stephenson [Thu, 25 Oct 2018 13:35:37 +0000 (09:35 -0400)]
Forward Port Release Notes for 3.0.13.

Signed-off-by: Jason Stephenson <jason@sigio.com>
12 months agoForward-port 3.1.7 upgrade script
Dan Wells [Wed, 24 Oct 2018 22:18:48 +0000 (18:18 -0400)]
Forward-port 3.1.7 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 months agoForward-port 3.2.1 upgrade script
Dan Wells [Wed, 24 Oct 2018 22:14:28 +0000 (18:14 -0400)]
Forward-port 3.2.1 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 months agoDocs: adding another entry to 3.2.1 release notes
Jane Sandberg [Wed, 24 Oct 2018 16:35:50 +0000 (09:35 -0700)]
Docs: adding another entry to 3.2.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
12 months agoDocs: adding another entry to 3.1.7 release notes
Jane Sandberg [Wed, 24 Oct 2018 16:33:23 +0000 (09:33 -0700)]
Docs: adding another entry to 3.1.7 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
12 months agoLP#1797923 Browser client iframe initial loading page
Bill Erickson [Mon, 15 Oct 2018 15:43:33 +0000 (11:43 -0400)]
LP#1797923 Browser client iframe initial loading page

Apply a default value to the browser client iframe URL so the iframe
does not attempt to load a copy of the current page.  The default value
points to a simple loading page, displying "Loading..." plus our
standard spinny gif.

Progress gif copied from web/opac/images/ to web/images/ to avoid
dependence on the old opac directory.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoDocs: Adding release notes for 3.2.1
Jane Sandberg [Wed, 24 Oct 2018 16:15:44 +0000 (09:15 -0700)]
Docs: Adding release notes for 3.2.1

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
12 months agoDocs: adding release notes for 3.1.7
Jane Sandberg [Wed, 24 Oct 2018 16:02:37 +0000 (09:02 -0700)]
Docs: adding release notes for 3.1.7

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
12 months agoForward port 3.1.5-3.2.0-upgrade-db.sql.
Jason Stephenson [Tue, 23 Oct 2018 20:32:17 +0000 (16:32 -0400)]
Forward port 3.1.5-3.2.0-upgrade-db.sql.

Signed-off-by: Jason Stephenson <jason@sigio.com>
12 months agoLP#1746536: Remove input-group-addon class from Add Call Number button
Kathy Lussier [Wed, 26 Sep 2018 18:45:26 +0000 (14:45 -0400)]
LP#1746536: Remove input-group-addon class from Add Call Number button

The button no longer looks like a button with this class in place.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1746536: Restrict CN addition but allow CN edits...
Mike Rylander [Wed, 26 Sep 2018 16:57:04 +0000 (12:57 -0400)]
LP#1746536: Restrict CN addition but allow CN edits...

... in the top half of the Vol/Copy editor when there are multiple bib records
represented in the UI.

Also, restrict the size of the org selector using a bootstrap row.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/cat/volcopy/t_edit.tt2
Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1746536: Allow batch-apply to volume fields in multi-record context
Mike Rylander [Wed, 19 Sep 2018 14:38:42 +0000 (10:38 -0400)]
LP#1746536: Allow batch-apply to volume fields in multi-record context

I can't see a reason to restrict Batch Apply for volume fields in a multi-
record context, as all the data is gathered based on the volume owners, not
record information.  This commit removes that restriction.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP#1746536 - enable volcopy editor for multi-bib but only volumes
Cesar Velez [Wed, 12 Sep 2018 09:37:28 +0000 (05:37 -0400)]
LP#1746536 - enable volcopy editor for multi-bib but only volumes

This removes the disabling of the volcopy editor caused by
passing it a record id of 0. Allowing the Item Status grid's
Edit>Volumes to function as a way to batch edit volumes of
more than 1 bib record.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
12 months agoLP1746536: cannot edit vol/call number in item status
a. bellenir [Wed, 27 Jun 2018 18:48:56 +0000 (14:48 -0400)]
LP1746536: cannot edit vol/call number in item status

spawnHoldingsEdit was disabling record summary by passing record_id: 0
this change will provided the record_id if exactly one record is selected.
behavior is unchanged if multiple records are selected.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: cesar velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1796978 Realign working copy refresh with proper condition
Dan Wells [Wed, 10 Oct 2018 20:07:24 +0000 (16:07 -0400)]
LP#1796978 Realign working copy refresh with proper condition

The "working copy" grid needs to update whenever the copy data above
updates.  I *believe* this aligns the refresh with its intended
condition.

This appears to have come about via bug #1732761, so retesting of
that fix may be in order.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
13 months agoLP#1796971 Wait for call number and copy before loading locations
Dan Wells [Thu, 11 Oct 2018 13:21:05 +0000 (09:21 -0400)]
LP#1796971 Wait for call number and copy before loading locations

In cases where add a copy to a call number, we fetch the original
call number via async, then attach the new copy to it.  Before this
commit, however, we were not waiting for the call number fetch
promise to resolve, so the copy wasn't there to use for limiting the
location load.

Since the async request is internal to a loop, one way out is to
capture that promise, then make sure it resolves before loading the
locations.

(We previously returned the copies from the internal function, but that
value wasn't being used anyway, so we don't worry about unwrapping the
$q.all() when it resolves.)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
13 months agoDocs: correcting inaccurate statement in action trigger docs
Jane Sandberg [Thu, 11 Oct 2018 01:37:59 +0000 (18:37 -0700)]
Docs: correcting inaccurate statement in action trigger docs

13 months agoDocs: Update release notes version in consolidated manual
Remington Steed [Tue, 9 Oct 2018 14:35:00 +0000 (10:35 -0400)]
Docs: Update release notes version in consolidated manual

Signed-off-by: Remington Steed <rjs7@calvin.edu>
13 months agoDocs: adding info about testing action triggers
Jane Sandberg [Mon, 8 Oct 2018 21:42:30 +0000 (14:42 -0700)]
Docs: adding info about testing action triggers

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoDocs: adding action/triggers to staff client admin docs
Jane Sandberg [Mon, 8 Oct 2018 21:37:30 +0000 (14:37 -0700)]
Docs: adding action/triggers to staff client admin docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoDocs: re-adding missing anchor to install instructions
Jane Sandberg [Mon, 8 Oct 2018 21:36:48 +0000 (14:36 -0700)]
Docs: re-adding missing anchor to install instructions

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoLP#1792658 Angular Evergreen favicon
Bill Erickson [Mon, 17 Sep 2018 14:18:30 +0000 (10:18 -0400)]
LP#1792658 Angular Evergreen favicon

Use the Evergreen favicon.ico in the Angular(6) application.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1785681 Patron address copy to clipboard
Bill Erickson [Mon, 6 Aug 2018 19:18:35 +0000 (15:18 -0400)]
LP#1785681 Patron address copy to clipboard

Support copying formatted addresses to the clipboard in the browser
staff client, similar to the XUL client.  Action is performed via a new
link in the addresses section (next to "print") in the patron summary
sidebar.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1721139: apply proper date format in certain places
Galen Charlton [Tue, 11 Sep 2018 18:58:29 +0000 (14:58 -0400)]
LP#1721139: apply proper date format in certain places

This patch ensures that the correct date format is used
to display dates in certain contexts in the web staff
client:

- patron bucket summary
- record bucket summary
- patron bucket 'View batch edits'

This has the side effect of fixing a problem where the batch
edit timestamps were not wrapped correctly in Firefox.

To test
-------
1. Using user buckets, make some batch changes on some patrons and roll
   back some of those changes.
2. Using Firefox, click on the 'View Batch Edits' button.
3. Note that the times dispayed are formatted as raw
   database timestamps
4. Note that the summary for the user bucket displays the
   create time as a raw database timestamp.
5. Navigate to a record bucket and note that its create
   time is displayed as a raw timestamp as well.
3. Apply patch.
4. Repeat steps 2-5; this time, the times should be displayed
   using the correct date and time format.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1778083 Location, Floating, and Age Protect missing from Items Out
Garry Collum [Thu, 21 Jun 2018 23:41:48 +0000 (19:41 -0400)]
LP#1778083 Location, Floating, and Age Protect missing from Items Out

Adds columns for Location (Copy), Floating Group, and Age-based Hold
Protection to the items out grid.

To test.
1. View an items out screen to see that the Location, Floating Group,
   and Age-based Hold protection columns are not available as options.
2. Apply the patch.
3. Edit some items and add definitions for Floating Group, and
   Age-based hold protection.
4. Check out these items and other items that do not have a floating
   group or age-based protection.
5. Display the Location, Floating Group, and Age-based Hold Protection
   columns.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1770246: (follow-up) display the open-in-new-window/tab icon
Galen Charlton [Fri, 5 Oct 2018 20:41:04 +0000 (16:41 -0400)]
LP#1770246: (follow-up) display the open-in-new-window/tab icon

Since the title links added by the previous patch intentionally open
the record in a new tab, display the corresponding icon to be
consistent with other interfaces.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1770246 Catalog linked title column in query and pending buckets
Garry Collum [Fri, 1 Jun 2018 01:22:35 +0000 (21:22 -0400)]
LP#1770246 Catalog linked title column in query and pending buckets

To mirror the Record Bucket View grid, this patch adds a title column
in the query and pending bucket tabs that links to the catalog record
of the title displayed. The catalog record is opened in a new tab, so
the query and pending data is not lost.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoDocs: adding basic info about printing spine labels
Jane Sandberg [Thu, 4 Oct 2018 18:53:59 +0000 (11:53 -0700)]
Docs: adding basic info about printing spine labels

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoDocs: Adding info about copy number
Jane Sandberg [Tue, 2 Oct 2018 02:48:32 +0000 (19:48 -0700)]
Docs: Adding info about copy number

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoForward-port 3.1.6 upgrade script
Dan Wells [Thu, 27 Sep 2018 21:56:00 +0000 (17:56 -0400)]
Forward-port 3.1.6 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 months agoForward-port 3.0.12 upgrade script
Dan Wells [Thu, 27 Sep 2018 21:55:09 +0000 (17:55 -0400)]
Forward-port 3.0.12 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 months agoDocs: adding another fix to the 3.1.6 release notes
Jane Sandberg [Wed, 26 Sep 2018 23:21:07 +0000 (16:21 -0700)]
Docs: adding another fix to the 3.1.6 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoDocs: adding another fix to the 3.0.12 release notes
Jane Sandberg [Wed, 26 Sep 2018 23:20:05 +0000 (16:20 -0700)]
Docs: adding another fix to the 3.0.12 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoLP#1786987: Locale-less org tree cache object becomes stale
Mike Rylander [Mon, 27 Aug 2018 16:08:37 +0000 (12:08 -0400)]
LP#1786987: Locale-less org tree cache object becomes stale

The autogen.sh script calls a function that flushes all org tree objects
cached by locale, but does not flush the one used when the locale is
unkown.  This commit forces that flushing to occur.

berick: Definition of my $cache pushed up above first use.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
13 months agoDocs: Adding 3.1.6 release notes
Jane Sandberg [Wed, 26 Sep 2018 16:10:22 +0000 (09:10 -0700)]
Docs: Adding 3.1.6 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoDocs: Adding release notes for 3.0.12
Jane Sandberg [Wed, 26 Sep 2018 16:05:54 +0000 (09:05 -0700)]
Docs: Adding release notes for 3.0.12

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 months agoDocs: Clean up installation docs
Remington Steed [Tue, 25 Sep 2018 18:54:20 +0000 (14:54 -0400)]
Docs: Clean up installation docs

- Remove redundant NodeJS section
- Relabel sections to distinguish between AngularJS and Angular steps
- Fix a few typos

Signed-off-by: Remington Steed <rjs7@calvin.edu>
13 months agoTranslation updates - newpot
Dan Wells [Tue, 25 Sep 2018 17:04:11 +0000 (13:04 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 months agoTranslation updates - po files
Dan Wells [Mon, 24 Sep 2018 21:33:12 +0000 (17:33 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 months agoDocs: Remove old release notes files
Remington Steed [Mon, 24 Sep 2018 21:23:45 +0000 (17:23 -0400)]
Docs: Remove old release notes files

Signed-off-by: Remington Steed <rjs7@calvin.edu>
13 months agoDocs: Add Upgrade Notes to release notes
Remington Steed [Mon, 24 Sep 2018 21:14:39 +0000 (17:14 -0400)]
Docs: Add Upgrade Notes to release notes

This commit copies relevant sections of the release notes into the
Upgrade Notes section.

A few paragraphs are also reformatted into lines of appropriate length.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
13 months agoUpdate Release Notes for 3.2-rc
Remington Steed [Mon, 24 Sep 2018 19:53:04 +0000 (15:53 -0400)]
Update Release Notes for 3.2-rc

Add new release notes. Also, slight reorganization to the
acknowledgements section (move organizations to appropriate section, fix
sorting of COOL, use consistent name for BC Libraries).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
13 months agoDocs: Fix two minor errors in docs
Remington Steed [Mon, 24 Sep 2018 19:15:46 +0000 (15:15 -0400)]
Docs: Fix two minor errors in docs

  - Fix an AsciiDoc heading syntax error
  - Fix a grammatical error (repeated "the")

Signed-off-by: Remington Steed <rjs7@calvin.edu>
13 months agoLP#1794176 Avoid capturing grid cell tooltip/display values
Bill Erickson [Mon, 24 Sep 2018 20:19:33 +0000 (16:19 -0400)]
LP#1794176 Avoid capturing grid cell tooltip/display values

Remove the grid-tooltip logic that captured the cell content into a
template-level variable so the content only needed to be generated once
for both the tooltip and cell display.  This logic fails to handle cases
where the cell content is dynamic, typically the result of row
attributes being modified via external process.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 months agoLP#1789442: turn of Perl taint-checking on 14-OpenILS-Utils.t
Galen Charlton [Mon, 24 Sep 2018 17:56:09 +0000 (13:56 -0400)]
LP#1789442: turn of Perl taint-checking on 14-OpenILS-Utils.t

This works around a bug in DateTime::TimeZone 1.63
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737265> that
causes one of the new tests to spuriously fail on Ubuntu 14.04 LTS.

As the comment indicates, taint checking is not typically enabled
when running Evergreen, but we may want to consider changing
that should tuits arise.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1789442: restore column allocation for barcode input
Galen Charlton [Mon, 24 Sep 2018 17:55:39 +0000 (13:55 -0400)]
LP#1789442: restore column allocation for barcode input

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1789442: fix editing due date of hourly loans in web staff
Galen Charlton [Fri, 21 Sep 2018 19:23:11 +0000 (15:23 -0400)]
LP#1789442: fix editing due date of hourly loans in web staff

This patch fixes a bug where editing the due date of an hourly
loan would result in the time portion always getting set to 00:00.

To test
-------
[1] Set up some daily and hourly loans in your database.
[2] Apply the patch.
[3] From the items out page, edit the due date for one or
    more hourly loans. Verify that the resulting due date
    is set correctly.
[4] From the items out page, edit the due date for some
    daily loans and verify correctness. In particular,
    verify that the resulting due date is /not/ the
    following day if testing in time zones in the Americas.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1552778: add timepicker to webstaff checkout page
Galen Charlton [Fri, 21 Sep 2018 18:58:47 +0000 (14:58 -0400)]
LP#1552778: add timepicker to webstaff checkout page

This patch adds a timepicker to go along with the datepicker
if the operator invokes the option to set a specific due
date.

To test
-------
[1] Arrange circ policies to have both hourly and daily loans.
[2] Apply the patch.
[3] Check out an item for an hourly loan. Verify that the
    due date and time is per policy.
[4] Check out an item for a daily loan. Verify that the
    due date is per policy.
[5] Check out an item for an hourly loan, but set a specific
    due date and time. Verify that the due date and time matches
    the selected value.
[6] Check out an item for a daily loan, but set a specific
    due date. Verify that the due date matches the selected
    value; note that any time component is ignored since
    for daily loans the time gets normalized to 23:59.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1552778: make clean_ISO8601 recognize 'Z' as a timezone specifier
Galen Charlton [Fri, 21 Sep 2018 18:30:01 +0000 (14:30 -0400)]
LP#1552778: make clean_ISO8601 recognize 'Z' as a timezone specifier

Prior to this patch, clean_ISO8601 would ignore 'Z' as a timezone
specifier (e.g., '2018-09-21T15:34:21Z') and treat it as if the
timestamp were in the server's time zone, leading to incorrect
results (e.g., '2018-09-21T15:34:21-04:00') unless user, client,
and server all happen to be in UTC+0.  In particular, this allows
date strings emitted by the JavaScript Date object's toISOString()
method to be correctly parsed, as those strings invariably use
'Z' as the timezone specifier.

To test
-------
[1] Apply patch.
[2] Verify that regression test in t/14-OpenILS-Utils.t passes.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1552778: add perldoc and unit tests for clean_ISO8601
Galen Charlton [Fri, 21 Sep 2018 18:04:24 +0000 (14:04 -0400)]
LP#1552778: add perldoc and unit tests for clean_ISO8601

To test
-------
[1] Apply patch.
[2] Verify new tests in t/14-OpenILS-Utils.t pass.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1552778: copy some date/time utils from OpenSRF
Galen Charlton [Fri, 21 Sep 2018 15:00:25 +0000 (11:00 -0400)]
LP#1552778: copy some date/time utils from OpenSRF

As preparation for subsequent bugfixes, this patch
copies several date/time routines from OpenSRF::Utils
to a new module, OpenILS::Utils::DateTime. Specifically,
the routines copied over are:

* clean_ISO8601() (renaming of the OpenSRF cleanse_ISO8601)
* gmtime_ISO8601()
* interval_to_seconds()
* seconds_to_interval()

This move will allow us to fix bugs in this core routines
without requiring a mandatory OpenSRF upgrade. Furthermore,
with the exception of interval_to_seconds() (and in only one
place), none of those routines are used by OpenSRF itself.

To test
-------
[1] Apply the patch.
[2] Verify that unit tests pass.
[3] Verify that all Perl services start correctly.
[4] Verify that date/time and interval calculations continue
    to work as expected, particularly in circulation.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1793857: Restore Copy Current Row
Kathy Lussier [Sun, 23 Sep 2018 03:08:28 +0000 (23:08 -0400)]
LP#1793857: Restore Copy Current Row

In our effort to consistently call items/copies items, we accidentally replaced
the action "Copy Current Row" with "Item Current Row." This branch restores
the correct language.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
13 months agoLP#1791335: Retain stat cats on item transfer
Mike Rylander [Wed, 19 Sep 2018 15:16:39 +0000 (11:16 -0400)]
LP#1791335: Retain stat cats on item transfer

For some reason, parts were protected during item transfer, but stat cats were
not.  This commit protects them by fleshing stat cat entries in the outer
item transfer method.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
13 months agoLP#1791340: expand on comment about backdated checkin times
Galen Charlton [Fri, 21 Sep 2018 20:46:17 +0000 (16:46 -0400)]
LP#1791340: expand on comment about backdated checkin times

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1791340 Webstaff: Don't backdate when we're not
Dan Wells [Fri, 21 Sep 2018 14:45:59 +0000 (10:45 -0400)]
LP#1791340 Webstaff: Don't backdate when we're not

There was code in the webstaff checkin interface which attempted to
remove the backdate parameter when it wasn't needed, as its mere
presence has a negative effect on the checkin process.  This fail-safe
was not working, however.

Instead, let's build on the same check function used for the display,
so we can be more sure that if the user doesn't see that they are
backdating, the interface will not treat it as a backdate, and
vice-versa.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
13 months agoLP#1745427: account for change in prediction patterns
Galen Charlton [Thu, 20 Sep 2018 22:26:47 +0000 (18:26 -0400)]
LP#1745427: account for change in prediction patterns

This patch fixes a bug in the web staff client where changing
the active prediction pattern for a subscription would not
reset the base issue when predicting the next run of issues.

To test
-------
1. Set up a subscription in the web staff client with a prediction
   pattern (e.g., monthly).  Predict some issues.
2. Create/select a new prediction pattern for a new publishing schedule,
   e.g., quarterly.
3. Activate the new pattern and deactivate the old pattern.
4. Click Predict New Issues.
5. Enter in the new publication date/enumerations/chronology as needed.
6. Enter a prediction count and select Save. Note that new issues
   appear to be based on the previous pattern.
7. Apply the patch, delete the issues created in step 6, then repeat
   steps 4-6.  This time, new issues should be created using the new
   prediction pattern.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 months agoLP#1781480: Include group owner ancestor badges
Mike Rylander [Wed, 19 Sep 2018 14:26:04 +0000 (10:26 -0400)]
LP#1781480: Include group owner ancestor badges

This commit lightly refactors the badge org logic and includes the ancestors
of location group owners in the list of badge orgs, instead of only the direct
owners.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
13 months agoLP#1781480: Closures remeber values in subtle ways...
Mike Rylander [Mon, 17 Sep 2018 15:33:29 +0000 (11:33 -0400)]
LP#1781480: Closures remeber values in subtle ways...

... and we must take care to avoid that.  This commit forces a state variable
to be statically assigned an empty list rather than depending on the idiomatic
undef to vivicate an empty list.  This is important for all OpenSRF methods,
and manifests here as a search "remembering" a previously chosen location
group.  A comment to that point is included for our future selves.

The core probably arises from the fact that, in the end, OpenSRF methods are
generated closures.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
13 months agoLP#1732761: Chain the promises to avoid races
Mike Rylander [Fri, 3 Aug 2018 21:25:33 +0000 (17:25 -0400)]
LP#1732761: Chain the promises to avoid races

It looks like there's a race condition gathering locations for larger copy
sets.  Here we chain the promises to remove the race by serialization.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1732761: Fetch locations immediately for display
Mike Rylander [Mon, 9 Jul 2018 20:31:50 +0000 (16:31 -0400)]
LP#1732761: Fetch locations immediately for display

This commit closes a race condition where location labels cannot be rendered
for the "multiple locations" widget because fetching them takes longer than
the initial render of the attribute editor.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1732761: Batch item edit and multiple values per field
Mike Rylander [Tue, 3 Jul 2018 20:57:27 +0000 (16:57 -0400)]
LP#1732761: Batch item edit and multiple values per field

Previous to this commit, the display of multiple different values for a field
in the item attribute editor was simply to display no value.  Here we add a UI
component that presents the list of unique values, the number of selected
copies that use each value, and the ability to select just those copies using
a particular value by clicking on the desired value.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/cat/volcopy/index.tt2
Open-ILS/src/templates/staff/cat/volcopy/t_attr_edit.tt2

13 months agoLP1792371: Fix De-select Whole Page Action
Jason Boyer [Thu, 13 Sep 2018 11:39:06 +0000 (07:39 -0400)]
LP1792371: Fix De-select Whole Page Action

When using the checkbox to select or de-select the
entire page of results, the de-select action changes
the check and highlight states of the items on page
but doesn't actually remove the records from the
basket. This branch corrects that so that you can
select and de-select the entire page of results
and your basket contents are what you would expect.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoLP#1783345: Make one more change in case
Kathy Lussier [Thu, 20 Sep 2018 14:05:28 +0000 (10:05 -0400)]
LP#1783345: Make one more change in case

One button was missed when normalizing case in the add to bucket modal.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 months agoBug #1783345 - Normalized add to bucket modal
Sam Link [Tue, 31 Jul 2018 14:35:34 +0000 (10:35 -0400)]
Bug #1783345 - Normalized add to bucket modal

The text cases in the add to bucket modal have been normalized to
sentence case.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoLP#1792484 Patron preferred name in hold shelf dialog
Bill Erickson [Sun, 16 Sep 2018 22:48:59 +0000 (18:48 -0400)]
LP#1792484 Patron preferred name in hold shelf dialog

Display the patron preferred name in addition to the primary name in the
route-to-holds-shelf dialog.  As with primary name, preferred name is
hidden when an alias is applied.

To test
[1] Add a primary first, middle, and/or last name value to a patron.
[2] Place a hold for the patron with the pickup library matching the
    login library.
[2] Capgture the hold via the Checkin interface (instead of the hold
    capture interface) and note the preferred name display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoTranslation updates - newpot
Library Tech [Tue, 18 Sep 2018 20:12:57 +0000 (16:12 -0400)]
Translation updates - newpot

Signed-off-by: Library Tech <libsysadmin@calvin.edu>
14 months agoLP#1538691: Release notes entry for consistent terminology
Kathy Lussier [Wed, 22 Aug 2018 23:46:10 +0000 (19:46 -0400)]
LP#1538691: Release notes entry for consistent terminology

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
14 months agoLP#1538691: More changes to terminology
Kathy Lussier [Wed, 22 Aug 2018 20:48:43 +0000 (16:48 -0400)]
LP#1538691: More changes to terminology

For more consistency: Changing all staff client instances of Copy Location to
Shelving Location. We also replace Volume with Call Number and use Holdings
for a combination of copies/volumes. Also replacing the 'Add Copies' option
on the bib record page with 'Add Holdings' as was previously discussed on
the open-ils-general list.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
14 months agoLP#1538691: Use items instead of copies
Kathy Lussier [Wed, 1 Aug 2018 17:14:32 +0000 (13:14 -0400)]
LP#1538691: Use items instead of copies

For better consistency for the terms used in the client, let's use items instead
of copies, which was the preference of most people who provided feedback on bug
1538691.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
        Open-ILS/src/templates/staff/cat/catalog/t_holds.tt2
        Open-ILS/src/templates/staff/cat/item/t_list.tt2
        Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2
        Open-ILS/src/templates/staff/circ/holds/t_shelf_list.tt2

Signed-off-by: Dan Wells <dbw2@calvin.edu>
14 months agoLP#1792482 My OPAC settings preferred name field
Bill Erickson [Sun, 16 Sep 2018 23:28:11 +0000 (19:28 -0400)]
LP#1792482 My OPAC settings preferred name field

Adds a new row to the patron account preferences page for Preferred
Name.  The field only displays when a preferred first, middle, or last
value is present and follows the same display logic as preferred names
in the staff client, where first and last fall-through to the primary
name.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoLP#1792482 Only require first/last in pref name display
Bill Erickson [Sun, 16 Sep 2018 23:25:44 +0000 (19:25 -0400)]
LP#1792482 Only require first/last in pref name display

When displaying a patrons preferred name, always show a value for first
and last name, starting with the preferred name and defaulting to the
primary name, but only show values for prefix, middle name, and suffix
when a preferred variant is applied.

This avoids scenarios where patrons use their middle name as their first
name, with no preferred middle name applied, resulting duplicate
first/middle names displaying.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoLP#1787274: Stamping upgrade script for no dupe transits
Kathy Lussier [Tue, 18 Sep 2018 18:53:47 +0000 (14:53 -0400)]
LP#1787274: Stamping upgrade script for no dupe transits

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoLP#1787274 One active transit pgtap tests
Bill Erickson [Tue, 18 Sep 2018 15:21:26 +0000 (11:21 -0400)]
LP#1787274 One active transit pgtap tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoLP#1787274 Active copy transit unique constraint
Bill Erickson [Mon, 17 Sep 2018 22:16:42 +0000 (18:16 -0400)]
LP#1787274 Active copy transit unique constraint

Adds constraint triggers to action.*transit_copy tables to prevent
creation of new transits for a copies when an existing transit of any
type exists for the copy with a NULL dest_recv_time and cancel_time
values (i.e. an open transit).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoLP#1787274 Prevent multiple active copy checkins
Bill Erickson [Mon, 17 Sep 2018 22:16:28 +0000 (18:16 -0400)]
LP#1787274 Prevent multiple active copy checkins

In the staff client checkin service, track which copies are currently
in-flight to the checkin API call and prevent additional checkin API
calls for any copy that is currently in flight.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
14 months agoDocs: LP1793184 adding to the 3.2 release notes
Jane Sandberg [Tue, 18 Sep 2018 18:28:55 +0000 (11:28 -0700)]
Docs: LP1793184 adding to the 3.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
14 months agoLP1735816: Delete Copy Notes in the Web Client
Jason Boyer [Thu, 21 Jun 2018 19:57:41 +0000 (15:57 -0400)]
LP1735816: Delete Copy Notes in the Web Client

A combination of calling convention errors and
template picky-ness prevented the deletion of
copy notes in the web client. This patch returns
that ability.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Amy Constantino <aconstantino@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
14 months agoLP#1745610 - Add release notes for hold targeter script change.
Chris Sharp [Thu, 13 Sep 2018 19:26:46 +0000 (15:26 -0400)]
LP#1745610 - Add release notes for hold targeter script change.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
14 months agoLP#1745610 - Update Makefile.am to reflect filename changes.
Chris Sharp [Thu, 13 Sep 2018 19:25:21 +0000 (15:25 -0400)]
LP#1745610 - Update Makefile.am to reflect filename changes.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
14 months agoLP#1745610 - Deprecate original hold_targeter.pl
Chris Sharp [Fri, 26 Jan 2018 12:58:58 +0000 (07:58 -0500)]
LP#1745610 - Deprecate original hold_targeter.pl

With the new hold targeter battle-tested for over a year,
it's now time to promote it to default, deprecating the
older version.  This commit renames the old targeter to
"hold_targeter_legacy.pl" and the new to "hold_targeter.pl",
and adapts the example crontab to use the new targeter's
parameter syntax.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
14 months agoLP#1642344: XUL report cloning
Galen Charlton [Fri, 29 Jun 2018 18:45:27 +0000 (14:45 -0400)]
LP#1642344: XUL report cloning

This patch allows report templates of version 4 and earlier
(which would have been created by the XUL staff client) to
be upgraded to template version 5 (used by the web staff
client) when the user clones a report. This closes a limitation
introduced in the reporter module for the web staff client.

Note that during the conversion, inner joins are used by
default when IDL classes have a 'has_a' relation rather than
defaulting to left outer joins, improving correctness of the
generated SQL query.

To test
-------
[0] Apply the patch.
[1] In a test database that has reporter templates created
    by (or for) the XUL staff client, create clones of
    those templates.
[2] Verify that the output of reports created using the new
    templates matches output of reports from the original
    templates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>