miker [Fri, 13 May 2011 17:30:47 +0000 (17:30 +0000)]
Patch from Ben Ostrowsky (LP#782268) to simplify seed/example permission setup and move one step towards being able to rid ourselves of permission.perm_list.id
dbwells [Fri, 13 May 2011 16:01:04 +0000 (16:01 +0000)]
A bevy of MFHD bug fixes (and test cases)
1) Remove hard-coded 'gap' text from format_part()
2) Honor $ypm## for chron_to_date() for annuals
3) Removed overly simple check on $w as digit
4) Allow for combined chronologies other than 2nd level
5) Make calendar changes trump $u counts
6) Honor issue restarts at calendar changes
7) Rudimentary support of $u counts for non-restarting issue numbering
8) Special interpretation of $yps for early winters (i.e. winter is the first season of the calendar year)
9) Teach chron_to_date() about early winters
The last two points deserve some special attention. A large number of journals consider 'Winter' to be the first season of the year, so Winter 2011 means (roughly) January 2011, not December 2011. However, there is no explicit way to indicate this in the standard, and also the code relies in many ways on the fact that 24 (chronology code for winter) is greater than 21 (code for spring). To work around this, we are interpreting a certain ambiguous pattern in a particular way. Specifically, if you set $w to a digit, then set $y to 'ps24,21,22,23' (or some variation with '24' as the first value), you will get this winter-first behavior. Also, the season is treated internally as '20' then converted to '24' when processing is completed.
senator [Thu, 12 May 2011 14:15:41 +0000 (10:15 -0400)]
remove in-template fine-totaling: mod_perl code was already doing the same
also:
make that fine-totaling not use floating point math.
don't provide payment form for <= 0 totals (we're not issuing refunds)
last copyright date in footer always current year, not hardcoded
senator [Tue, 10 May 2011 14:28:55 +0000 (10:28 -0400)]
Better redirect from place_hold
Before this, if you click place hold on something while not logged in,
you are redirected to the login page, which is good, and redirected
thence to the place hold page, which is good. But after actually
placing the hold you got redirected to the login page again, which is
not good. Now you get sent back to the home page.
This may not be the ideal choice. myopac/main may make more sense.
Also, there is still not any clear visual feedback for the user that
their hold placement succeeded. That'll need to be addressed too.
erickson [Mon, 9 May 2011 18:27:42 +0000 (18:27 +0000)]
Invoice from LI seeds invoice data
* When creating a new invoice from a lineitem, seed the invoice with
provider data from the lineitem.
* Make money textbox's a little larger to accommodate larger sums
without scrolling
* Truncate long titles in lineitem summary view
Author: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20446 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Thu, 5 May 2011 18:38:36 +0000 (18:38 +0000)]
Use valid JSON in Dojo i18n for Searcher.js
Dojo i18n processing scripts require valid JSON (quoted keys in hashes),
even though Dojo itself is more relaxed and accepts unquoted keys. So,
do the i18n dance here.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20437 dcc99617-32d9-48b4-a31d-7c20da2025e4
senator [Thu, 5 May 2011 16:40:08 +0000 (16:40 +0000)]
Patch from Niles Ingalls to make patron phone number searching more matchy.
With assistance from Mike Rylander on pointing out the needed indexes to keep
search fast, and from Mike Peters on arranging a last minute DCO :-)
Type numbers into a patron phone number field and get a match regardless of
the punctuation actually used in the database.
senator [Thu, 5 May 2011 15:42:00 +0000 (15:42 +0000)]
Add a feature authored by Joscha Filius for the International Institue of
Social History: a diacritical palette for the MARC editor!
Afelonne Doek of IISH wants the community to benefit from this code. To try
it out, press control S in the marc editor (reguarly non-flat-text view).
You can insert the characters you see, and you can right click on entries in
your palette to customize. Customizations /should/ persist through staff client
restart (untested by me so far).
This should make cataloging in multiple (Western-ish) languages at once easier.
Below I copy and paste some of Joscha's message to the list where he introduced
this code:
> *Bugs:*
> A known bug is that is you switch marc edit styles back and forth the
> listener trigger won't work anymore. Also for a far as I know there is at
> least another bug concerning layout which is as far as I know not the result
> of my doing.
>
> *Here comes a possibly nasty part*, to ensure that the diacriticals remain
> intact throughout the persist I've changed global_util.js to URL encode and
> URL decode all stored values. This might cause backwards incompatibility
> with values that are already stored for other purposes without encoding.
> This needs to be checked.
dbs [Thu, 5 May 2011 04:39:44 +0000 (04:39 +0000)]
Remove redundant plpgsql install step from README
PostgreSQL 9.0 includes plpgsql by default, and running the
createlang plpgsql step throws an error that could concern
the installer. Drop the step from the README.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20423 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Wed, 4 May 2011 04:43:06 +0000 (04:43 +0000)]
Change an ERROR to a DEBUG log message in mod_idlchunk
Reported by James Fournie at Sitka, this message was logged
as an error when it is simply a debug message; we drop the
level accordingly so that it will not appear in the Apache
logs during the normal course of operations.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20397 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Wed, 4 May 2011 03:46:27 +0000 (03:46 +0000)]
Prevent uninitialized var warnings in OpenILS::WWW::SuperCat::unapi
Given a tag URI like tag:localhost,2011:biblio-record_entry/1 with
no format, Evergreen was throwing uninitialized variable warnings
and attempting to invoke "open-ils.supercat..formats" due to the
unitialized $type variable, which resulted in an Apache error.
On the TT OPAC, this enables Zotero to successfully offer import
of all entries on the search results page. On the AjaxPAC, it seems
that Zotero parses the page before the unAPI hrefs have been supplied
by JavaScript.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20390 dcc99617-32d9-48b4-a31d-7c20da2025e4
Dan Scott [Wed, 4 May 2011 00:51:44 +0000 (20:51 -0400)]
Avoid empty ID attribute in SELECT element
The current code appears to always generate an empty id="" attribute,
as the "id" variable never gets populated. For now, protect against
the empty ID attribute.
Dan Scott [Wed, 4 May 2011 00:42:16 +0000 (20:42 -0400)]
HTML compliance in result table
Convert & to & in URLs, and change a SPAN element to a DIV
(because SPAN elements are not allowed to contain block-level
elements like DIV and TABLE).
Dan Scott [Tue, 3 May 2011 21:08:59 +0000 (17:08 -0400)]
Less aggressive URL encoding
We were double-encoding URIs, as the url and uri filters in
TT happily encode % - which is fine the first time around,
but after you've already escaped everything as %nn the propagator
was serving it back to url to be escaped again on the following
page request.
The right way to do this might be to unescape the incoming query
string, then pass it on to url for escaping again - but for now,
using the entity version of & is good enough to begin with.
By passing the incoming query string through the TT url filter and
then replacing "&" with "&" we avoid this problem at the source.
From there, we have to address the other locations in the code in
which we are manually appending GET variables.
dbs [Tue, 3 May 2011 16:29:16 +0000 (16:29 +0000)]
Avoid data loss by setting MARC::Charset->assume_unicode(1)
When using MARC::File::XML, MARC::Charset is used to perform character
conversions; however, MARC::File::XML does not tell MARC::Charset that it is
handling Unicode data. If we do not tell MARC::Charset that it is handling
Unicode data, it can return an error which results in the loss of data
(typically a subfield containing one or more characters which MARC::Charset
does not have an equivalent mapping outside of Unicode).
This problem could be reproduced in authority_control_fields.pl with a
subfield like "von Hans-Christian Müơller" - when this subfield was encountered
without assume_unicode(1), a null string was returned for that subfield, and
if the record was written back to the database due to an authority match being
found in a different field, the only recourse was to restore the record from
auditor.biblio_record_entry_history. The same sort of problems could occur
for any other script or function that modifies the data being handed to it
using MARC::File::XML and BinaryEncoding => UTF8.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20385 dcc99617-32d9-48b4-a31d-7c20da2025e4
miker [Tue, 3 May 2011 14:55:37 +0000 (14:55 +0000)]
Patch from Jason Stephenson ( LP#770261, https://bugs.launchpad.net/evergreen/+bug/770261 ) adding support for bibliographic level inspection in the hold and circ matrix matchpoint tests.
dbwells [Mon, 2 May 2011 20:57:01 +0000 (20:57 +0000)]
Add support for sre/distribution summary methods (including merge), advanced receiving, and unit-less receiving in the serial control items tab
This commit includes three new minor features for the Serial Control interface. First, you are now able to set the latent 'summary_method' field on distributions, with the most significant new setting being 'merge with sre'. This setting effectively combines the sre marc with the generated holdings to form a single unified statement. Second, the previous 'receive' functionality has been renamed to 'advanced receive', and 'receive' will now show items from an entire subscription, but not allow you to receive directly into a specific unit (you can still receive into new/auto units). Third, a basic menu entry has been added for receving into 'no unit', allowing items to be received not forcing them to be unitized.
phasefx [Mon, 2 May 2011 15:04:54 +0000 (15:04 +0000)]
flesh stat_cat_entries in the call number tree method used by Holdings Maintenance, since those copies get shoved into the copy editor and we want stat cat entries to show up there
phasefx [Mon, 2 May 2011 14:05:56 +0000 (14:05 +0000)]
Fix bug and typo in stat cat editor
Specifically, disabling the ability to select a stat cat type on no permissions on current type.
If you don't have permissions on ASSET you could never get to ACTOR.
If you picked ACTOR without rights you couldn't get back to ASSET.
Also, re-enable the library selector and new buttons when you do change to one you can add for.
Author: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20371 dcc99617-32d9-48b4-a31d-7c20da2025e4
phasefx [Mon, 2 May 2011 13:20:40 +0000 (13:20 +0000)]
fix "undefined is in transit"
https://bugs.launchpad.net/evergreen/+bug/773528
---
Fix bug squashing of params in checkin_via_barcode2 in circ/util.js.
Author: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20368 dcc99617-32d9-48b4-a31d-7c20da2025e4
Dan Scott [Mon, 2 May 2011 12:33:54 +0000 (08:33 -0400)]
Make refund policy for lost items a branding option
Different sites will have different policies for refunds
on lost items (and might not even provide refunds for lost
items, for that matter), so break out that policy description
into its own template and provide a KCLS-specific version of
it.
Dan Scott [Mon, 2 May 2011 12:23:34 +0000 (08:23 -0400)]
Debrand lowhits purchase request reference to KCLS
While we break this out to a separate template, perhaps we
could pull the library name from context instead of having
it hardcoded. It will probably depend on each instance, ergo
hardcoding the generic "your library" for now should be fine.
Dan Scott [Mon, 2 May 2011 02:06:50 +0000 (22:06 -0400)]
Pull call number from XML holdings, not MARC record
KCLS uses call numbers in the MARC record, but most other sites
use the call numbers from asset.call_number. For now, just display
the first returned call number; eventually the display will probably
need to be adjusted to handle call number / shelving location / library
/ status like the current AjaxPAC does.
Also note that ##URI## call numbers should be filtered out but are
not yet.
Dan Scott [Mon, 2 May 2011 01:25:38 +0000 (21:25 -0400)]
Debrand the login form
Breaking the password hint and login help sections out into
separate templates enables sites to adjust the hint and
login help links without touching the rest of the interface.
Dan Scott [Sun, 1 May 2011 20:57:01 +0000 (16:57 -0400)]
Create a templates_kcls to hold KCLS branding of TT OPAC
The debranding of the TT OPAC begins with the top navigation.
* Replace the KCLS logo with the Evergreen logo (even though
white background on black doesn't look great, it's something)
* Replace the KCLS specific top links with example links.
* Split the logo and the links sections out into separate
templates so that we can maximize commonality of the
topnav.tt2 template.
For now, all files containing the string 'kcls' have been
copied into the templates_kcls directory. As we move through
the templates, we may refactor them in similar to how we just
refactored topnav.tt2.
Dan Scott [Sun, 1 May 2011 17:05:06 +0000 (13:05 -0400)]
Internationalize more of the TT OPAC (records and results)
There are a number of hardcoded strings remaining in the TT OPAC.
This is just some of the lowhanging fruit; more work needs to be
done on the more complex cases involving HTML and placeholders.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: berick <berick@esilibrary.com>
Dan Scott [Sun, 1 May 2011 15:55:11 +0000 (11:55 -0400)]
Enable unAPI support in TT OPAC
We have enough information available from the context and date
plugin to construct valid unAPI IDs - so let's do it and take
one more XXX off the table. (This is good for Zotero support!)
Sadly, Zotero doesn't seem to recognize more than one unAPI
ID on the search results page; in theory it should give the
user the ability to add all of the search results at once,
but in practice it doesn't display anything.
At the same time, we can remove the duplicate unAPI placeholders
and remove unnecessary <span> elements.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: berick <berick@esilibrary.com>
erickson [Sun, 1 May 2011 15:29:39 +0000 (15:29 +0000)]
ContentCafe summary of avaible item content
Added "available_json" support for Content Cafe. Returns and array of
available content for a given item, where the content type is mapped to
one of the Evergreen standard added content types, e.g. "summary",
"anotes", "reviews", ...
erickson [Sun, 1 May 2011 15:29:39 +0000 (15:29 +0000)]
ContentCafe summary of avaible item content
Added "available_json" support for Content Cafe. Returns and array of
available content for a given item, where the content type is mapped to
one of the Evergreen standard added content types, e.g. "summary",
"anotes", "reviews", ...
projects / working / Evergreen.git / log