working/Evergreen.git
10 years agoAdd fund column to acq.invoice_item.
scottmk [Wed, 7 Apr 2010 19:40:36 +0000 (19:40 +0000)]
Add fund column to acq.invoice_item.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0229.schema.acq-inv-item-fund.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16160 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: in acquistions unified search, make timestamp fields searchable
senator [Wed, 7 Apr 2010 19:36:51 +0000 (19:36 +0000)]
Acq: in acquistions unified search, make timestamp fields searchable

Even if only at whole-day precision

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16159 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix Admin->For Developers->Fieldmapper; global.css is mandatory for <messagecatalog...
phasefx [Wed, 7 Apr 2010 18:16:54 +0000 (18:16 +0000)]
fix Admin->For Developers->Fieldmapper; global.css is mandatory for <messagecatalog>.  The fieldmapper method here is dangerous, however, and can exhaust memory

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16158 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoLog more actions for Admin -> Local Administration -> Work Log
phasefx [Wed, 7 Apr 2010 18:15:52 +0000 (18:15 +0000)]
Log more actions for Admin -> Local Administration -> Work Log

* work log entries for checkin attempts
* tweaked wording to be more truthful
* work log entries for patron edit and registration

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16157 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: fix a problem when searching by user-linked fields
senator [Wed, 7 Apr 2010 15:09:50 +0000 (15:09 +0000)]
Acq: fix a problem when searching by user-linked fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16156 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosafer still metarecord constituent type/form matching
miker [Wed, 7 Apr 2010 14:55:14 +0000 (14:55 +0000)]
safer still metarecord constituent type/form matching

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16155 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMore Invoice UI work. This covers:
erickson [Wed, 7 Apr 2010 14:52:12 +0000 (14:52 +0000)]
More Invoice UI work.  This covers:
New view interface
Creating new invoices directly in the view UI
Creating invices from PO/LI
Attaching PO/LI data to an existing invoice
UI for handling of prorated item types
Support for creating a new invoice fromt the po view page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16154 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd boolean column "prorate" to acq.invoice_item_type.
scottmk [Wed, 7 Apr 2010 14:35:09 +0000 (14:35 +0000)]
Add boolean column "prorate" to acq.invoice_item_type.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0228.schema.acq-invoice-item-type-prorate.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16153 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoimprove metarecord constituent type/form matching
miker [Wed, 7 Apr 2010 14:08:43 +0000 (14:08 +0000)]
improve metarecord constituent type/form matching

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16152 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothis snunk in. should not have
miker [Wed, 7 Apr 2010 07:11:23 +0000 (07:11 +0000)]
this snunk in. should not have

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16151 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agostored proc param ordering
miker [Wed, 7 Apr 2010 07:10:11 +0000 (07:10 +0000)]
stored proc param ordering

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16150 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoforward port of r16146: proper support for in-db renewal of precats
miker [Wed, 7 Apr 2010 03:24:20 +0000 (03:24 +0000)]
forward port of r16146: proper support for in-db renewal of precats

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16148 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: bug fix. Thinko let to unintended search term negation in unified search.
senator [Tue, 6 Apr 2010 19:19:55 +0000 (19:19 +0000)]
Acq: bug fix. Thinko let to unintended search term negation in unified search.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16144 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoflesh fund debit in the default invoice fleshing in invoice fetching method
erickson [Tue, 6 Apr 2010 18:23:29 +0000 (18:23 +0000)]
flesh fund debit in the default invoice fleshing in invoice fetching method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16143 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded entries and items virtaul fields off of invoice. more column name repairs
erickson [Tue, 6 Apr 2010 18:20:04 +0000 (18:20 +0000)]
added entries and items virtaul fields off of invoice.  more column name repairs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16142 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomove the browser progress meter next to the network progress meter and provide a...
phasefx [Tue, 6 Apr 2010 16:47:24 +0000 (16:47 +0000)]
move the browser progress meter next to the network progress meter and provide a toggle in the Admin menu.  The org unit setting isn't wired up in trunk, but that's probably a good thing.  still experimental

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16141 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: unified search interface for LI, PO, and PL. Usable but not 100% finished
senator [Tue, 6 Apr 2010 16:40:33 +0000 (16:40 +0000)]
Acq: unified search interface for LI, PO, and PL. Usable but not 100% finished

Still to come:
    Paging results (very important with large result sets)
    Searchable timestamp fields (those don't work yet)
    Search terms interpreted from URI (to enable returning to search later)
    Misc PO and PL controls to enable acting on search results
    ** Bib record searching

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16140 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSome polish for Item Details/Quick Summary tab (the Alternate View in Item Status)
phasefx [Tue, 6 Apr 2010 15:33:17 +0000 (15:33 +0000)]
Some polish for Item Details/Quick Summary tab (the Alternate View in Item Status)

* localize more bools
* disambiguate Copy Status, Transit Copy Status, and Hold Status.  Flesh copy statuses for display and provide a tooltip for Holdable/OPAC visible
* textual labels for fine_level and loan_duration
* show the Fine Level
* fix display of circ modifier and reference flag
* Removed Hold Shelf Location and Rolling Counter for now since those aren't implemented yet (left in the DTD entities, however)
* display Circulate flag
* remove some old commented out code
* flesh and render the call number
* fix display of Remaining Renewals
* Use open-ils.circ.renewal_chain.retrieve_by_circ.summary for simpler rendering of Checkout Workstation with circ chains

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16139 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMoved lineitem actions into drop-down widget to prevent horizontal crowding
erickson [Tue, 6 Apr 2010 14:10:52 +0000 (14:10 +0000)]
Moved lineitem actions into drop-down widget to prevent horizontal crowding

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16138 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomerging MR holds topic branch
miker [Mon, 5 Apr 2010 20:23:54 +0000 (20:23 +0000)]
merging MR holds topic branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16137 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUI for creating a new invoice and attaching a lineitem.
erickson [Mon, 5 Apr 2010 18:58:48 +0000 (18:58 +0000)]
UI for creating a new invoice and attaching a lineitem.
Stub invoice viewing interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16136 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprovided ability to append the table rows from one edit pane to an existing table...
erickson [Mon, 5 Apr 2010 18:58:47 +0000 (18:58 +0000)]
provided ability to append the table rows from one edit pane to an existing table.  this is useful for inserting edit panes for different objects into a single, consistently formatted table

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16135 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired some mis-named fields; added an ADMIN_* version of invoice method pcrud...
erickson [Mon, 5 Apr 2010 18:58:46 +0000 (18:58 +0000)]
repaired some mis-named fields; added an ADMIN_* version of invoice method pcrud perms

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16134 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoinitial invoice sub-module
erickson [Mon, 5 Apr 2010 18:58:45 +0000 (18:58 +0000)]
initial invoice sub-module

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16133 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded ability to flesh PO and PL in lineitem retrieve
erickson [Mon, 5 Apr 2010 18:58:44 +0000 (18:58 +0000)]
added ability to flesh PO and PL in lineitem retrieve

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16132 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobe smarter about holdings fleshing, particularly where only URIs are requested
miker [Mon, 5 Apr 2010 04:14:03 +0000 (04:14 +0000)]
be smarter about holdings fleshing, particularly where only URIs are requested

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16131 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agostumbled upon an incorrect sequence
miker [Mon, 5 Apr 2010 03:42:15 +0000 (03:42 +0000)]
stumbled upon an incorrect sequence

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16130 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobetter regexp with new paging functionallity
miker [Mon, 5 Apr 2010 00:18:07 +0000 (00:18 +0000)]
better regexp with new paging functionallity

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16127 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremoved call to removed function
erickson [Sun, 4 Apr 2010 16:18:16 +0000 (16:18 +0000)]
removed call to removed function

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16124 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoin related viewer mode, go ahead and show the li attrs in the detail page since we...
erickson [Sun, 4 Apr 2010 16:18:15 +0000 (16:18 +0000)]
in related viewer mode, go ahead and show the li attrs in the detail page since we're using the bib-level attrs for the summary display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16123 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd embedded holdings paging support to biblio-record_entry type unAPI tag URIs ...
miker [Sun, 4 Apr 2010 05:19:03 +0000 (05:19 +0000)]
add embedded holdings paging support to biblio-record_entry type unAPI tag URIs -- also works for holdings_xml format directly -- and teach the local call number BibTemplate opac slot how to use this (show first 10 local call numbers, instead of all of them)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16122 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd metarecord support to BibTemplate
miker [Sun, 4 Apr 2010 01:01:08 +0000 (01:01 +0000)]
add metarecord support to BibTemplate

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16120 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorelated items now returns LI's that may be attached to a selection lists only (no po)
erickson [Sat, 3 Apr 2010 20:46:54 +0000 (20:46 +0000)]
related items now returns LI's that may be attached to a selection lists only (no po)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16119 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agode-dupe li ids in picklist li fetcher. if an LI has multiple attrs for the sort...
erickson [Sat, 3 Apr 2010 20:46:54 +0000 (20:46 +0000)]
de-dupe li ids in picklist li fetcher.  if an LI has multiple attrs for the sort field, the join collects 1 row per attr, resulting in duplicate attrs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16118 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdded a "View / Place Orders" option to the exta actions drop-down for a
erickson [Sat, 3 Apr 2010 20:46:53 +0000 (20:46 +0000)]
Added a "View / Place Orders" option to the exta actions drop-down for a
bib record in the OPAC.  Lineitem related LI's page can now take a
bib ID as the param (instead of lineitem).  For consistency, show
title, author, etc. from the catalog record (via BibTemplate) instead
of the selected lineitem.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16117 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agopatch from Ben Ostrowski to address a i18n-affecting typo in stock group creation
miker [Sat, 3 Apr 2010 14:13:51 +0000 (14:13 +0000)]
patch from Ben Ostrowski to address a i18n-affecting typo in stock group creation

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16116 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCreate a separate function for adding datatype information
scottmk [Sat, 3 Apr 2010 05:48:39 +0000 (05:48 +0000)]
Create a separate function for adding datatype information
from the database to the IDL information.  That way we can
call it in other contexts, e.g. the forthcoming
query set server.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16115 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoReplace almost all remaining reference to the MODULENAME macro
scottmk [Sat, 3 Apr 2010 03:16:35 +0000 (03:16 +0000)]
Replace almost all remaining reference to the MODULENAME macro
with references to a corresponding variable name.

This change is part of a project to split up the oils_cstore module
into an interface module (consisting mostly of osrfAppChildInit(),
osrfAppInitialize(), and osrfAppChildExit()) and an implementation
module (consisting of pretty much everything else).  The implementation
module will then be available for reuse in other contexts.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16114 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoflesh the copy location and set a tooltip for its flags
phasefx [Fri, 2 Apr 2010 20:21:21 +0000 (20:21 +0000)]
flesh the copy location and set a tooltip for its flags

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16113 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agolocalized bool values for display
phasefx [Fri, 2 Apr 2010 20:21:20 +0000 (20:21 +0000)]
localized bool values for display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16112 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodisplay the shortnames for orgs in the Item Details interface (and set the full names...
phasefx [Fri, 2 Apr 2010 20:21:20 +0000 (20:21 +0000)]
display the shortnames for orgs in the Item Details interface (and set the full names as tooltips)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16111 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotypo
phasefx [Fri, 2 Apr 2010 20:21:19 +0000 (20:21 +0000)]
typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16110 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agolocalized date/time values for Item Details interface
phasefx [Fri, 2 Apr 2010 20:21:18 +0000 (20:21 +0000)]
localized date/time values for Item Details interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16109 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoReduce dispatchCRUDMethod() to little more than a case structure,
scottmk [Fri, 2 Apr 2010 18:50:19 +0000 (18:50 +0000)]
Reduce dispatchCRUDMethod() to little more than a case structure,
which delegates all work to other functions (instead of doing some
of the work itself).  Besides making the code arguably tidier, this
change will make it easier to isolate much of the logic to a separate
module.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16108 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd format selector for e-books
miker [Fri, 2 Apr 2010 18:38:59 +0000 (18:38 +0000)]
add format selector for e-books

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16107 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocopy-n-paste-o on variable name
miker [Fri, 2 Apr 2010 18:10:58 +0000 (18:10 +0000)]
copy-n-paste-o on variable name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16106 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowhen auth session times out with embedded catalog, launch the xul login dialog (inste...
erickson [Fri, 2 Apr 2010 16:28:59 +0000 (16:28 +0000)]
when auth session times out with embedded catalog, launch the xul login dialog (instead of flopping back to the home page)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16105 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFlesh and show cancel_reason in the user request rejected template. I'm just correct...
phasefx [Fri, 2 Apr 2010 15:58:12 +0000 (15:58 +0000)]
Flesh and show cancel_reason in the user request rejected template.  I'm just correcting the existing upgrade script and seed data rather than roll a new one.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16104 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoaugment the xulG that the OPAC wrapper gives its content
phasefx [Fri, 2 Apr 2010 15:48:02 +0000 (15:48 +0000)]
augment the xulG that the OPAC wrapper gives its content

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16103 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoOr unit setting acq.holds.allow_holds_from_purchase_request: Allows patrons to create...
phasefx [Fri, 2 Apr 2010 15:17:37 +0000 (15:17 +0000)]
Or unit setting acq.holds.allow_holds_from_purchase_request: Allows patrons to create automatic holds from purchase requests

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16102 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded wrapper to new XUL get_new_session call. when embedded ui's lose their session...
erickson [Fri, 2 Apr 2010 15:15:58 +0000 (15:15 +0000)]
added wrapper to new XUL get_new_session call.  when embedded ui's lose their session, launch the staff client's login dialog instead of the local web-only dialog

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16101 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorespond_complete before processing a/t events to the caller does not have to wait
erickson [Fri, 2 Apr 2010 13:25:26 +0000 (13:25 +0000)]
respond_complete before processing a/t events to the caller does not have to wait

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16100 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdds a xulG.get_new_session() convenience function that can be called by embedded...
phasefx [Thu, 1 Apr 2010 21:25:38 +0000 (21:25 +0000)]
Adds a xulG.get_new_session() convenience function that can be called by embedded dojo interfaces, etc.

Side effect: Sets a session cookie and updates the global OpenILS.data store with the newly acquired authtoken.

Return Value: True if a new authtoken was acquired, otherwise False.

Optional Param: Object with optional keys 'callback' and 'operator_change'.

If 'operator_change' is passed in with a value of true, then the dialog will resemble the Admin->Operator Change dialog, but it is not yet completely implemented (doesn't preserve the existing authtoken).  Otherwise, we get the normal Session Expired dialog.

Callback may be a function that resembles this:

    function( success, authtoken, authtime ) {
        return success; // whatever gets returned here will also be returned by xulG.get_new_session()
    }

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16099 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger: Last batch of method reg docs and perltidy.
erickson [Thu, 1 Apr 2010 21:00:12 +0000 (21:00 +0000)]
Patch from Joe Atzberger: Last batch of method reg docs and perltidy.

Note spellcheck now returns [] immediately if no term is given.
No point initalizing and fetching stuff with no term.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16098 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadjust stored proc to use the appropriate STABLE or IMMUTABLE flag for speed
miker [Thu, 1 Apr 2010 19:56:17 +0000 (19:56 +0000)]
adjust stored proc to use the appropriate STABLE or IMMUTABLE flag for speed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16097 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUse the AssetCommon version of update_fleshed_copies so we can stay within the same...
phasefx [Thu, 1 Apr 2010 19:54:32 +0000 (19:54 +0000)]
Use the AssetCommon version of update_fleshed_copies so we can stay within the same transaction.  However, no more magic hold retargeting.  The CRON job can take care of any holds that do not get cancelled

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16096 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUse utility method for firing events
phasefx [Thu, 1 Apr 2010 19:54:19 +0000 (19:54 +0000)]
Use utility method for firing events

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16095 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofields for supporting bib record ownership and sharing
miker [Thu, 1 Apr 2010 19:21:01 +0000 (19:21 +0000)]
fields for supporting bib record ownership and sharing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16094 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger: Large overhaul of misleading and erroneous method reg...
erickson [Thu, 1 Apr 2010 19:09:34 +0000 (19:09 +0000)]
Patch from Joe Atzberger:  Large overhaul of misleading and erroneous method reg notes.

Including one deprecated method and its current replacement.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16093 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger: Cleanup subs in Actor
erickson [Thu, 1 Apr 2010 19:09:33 +0000 (19:09 +0000)]
Patch from Joe Atzberger:  Cleanup subs in Actor

For the first, @xact was never used.
The 3 part conditional only had two different outcomes.
There is still a problem with user_transactions reproducing a lot
of the functionality of user_transaction_history, which it already
calls to do the real query.  But it doesn't reproduce all of it.
Recommend relying on user_transaction_history as much as possible,
but that kind of work is out of scope for this review.

For the other, remove unused var and unnecessary array.
You don't need to build an array when all you do at the end is count its elements.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16092 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger: A great blast of perltidy
erickson [Thu, 1 Apr 2010 19:09:32 +0000 (19:09 +0000)]
Patch from Joe Atzberger:  A great blast of perltidy

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16091 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger: More method reg docs in Biblio.pm and Actor
erickson [Thu, 1 Apr 2010 19:09:32 +0000 (19:09 +0000)]
Patch from Joe Atzberger:  More method reg docs in Biblio.pm and Actor

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16090 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded claim sub-module. Added API call to retrieve claim-ready items. Added API...
erickson [Thu, 1 Apr 2010 18:48:06 +0000 (18:48 +0000)]
added claim sub-module.  Added API call to retrieve claim-ready items.  Added API call to initiate a claim for a given lineitem_detail or add a claim event to an existing claim

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16089 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosome stubs for future facet UI support
miker [Thu, 1 Apr 2010 17:19:11 +0000 (17:19 +0000)]
some stubs for future facet UI support

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16088 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: ML logic to support the "not" operator in unified acq search queries
senator [Thu, 1 Apr 2010 16:18:19 +0000 (16:18 +0000)]
Acq: ML logic to support the "not" operator in unified acq search queries

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16087 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofixed function name in lineitem price setting code. update local copy of lineitem...
erickson [Thu, 1 Apr 2010 15:29:40 +0000 (15:29 +0000)]
fixed function name in lineitem price setting code.  update local copy of lineitem after price changes to prevent clobbering of value

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16086 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded a view which returns all lineitem details that are ready to be claimed. return...
erickson [Thu, 1 Apr 2010 15:29:39 +0000 (15:29 +0000)]
added a view which returns all lineitem details that are ready to be claimed.  returns po, lineitem, lineitem_detail, and claim policy action data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16085 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomissed the environment when upgradeing the worksheet before. added copy location...
erickson [Thu, 1 Apr 2010 15:12:47 +0000 (15:12 +0000)]
missed the environment when upgradeing the worksheet before.  added copy location to lineitem worksheet template

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16084 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agogive the trigger autocreate wrapper a clearer name
erickson [Thu, 1 Apr 2010 13:09:18 +0000 (13:09 +0000)]
give the trigger autocreate wrapper a clearer name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16083 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofire hold_request.cancel.cancelled_order events for any cancelled holds after transac...
phasefx [Thu, 1 Apr 2010 05:15:33 +0000 (05:15 +0000)]
fire hold_request.cancel.cancelled_order events for any cancelled holds after transaction commit

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16082 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCancel holds targeting the bib associated with a lineitem if it has become deleted...
phasefx [Thu, 1 Apr 2010 05:15:25 +0000 (05:15 +0000)]
Cancel holds targeting the bib associated with a lineitem if it has become deleted.  Note concerns about rolling back transactions and using open-ils.cat

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16081 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodon't make the call to open-ils.cat if there are no real copies to delete. I'm assum...
phasefx [Thu, 1 Apr 2010 05:15:19 +0000 (05:15 +0000)]
don't make the call to open-ils.cat if there are no real copies to delete.  I'm assuming we want to be able to call this method against lineitems that might not even be associated with a purchase order, much less have copies, etc.  Need to think about that permission check at the beginning which is using purchase order -> ordering agency as a context org

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16080 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoparam tweak to get copies to flesh on lineitem details, and yes, open-ils.cat will...
phasefx [Thu, 1 Apr 2010 05:15:13 +0000 (05:15 +0000)]
param tweak to get copies to flesh on lineitem details, and yes, open-ils.cat will handle volume and bib deletion, as well as hold retargeting.  But we still need to cancel holds in the case where the bib gets deleted.  If the bib isn't deleted (because other copies were added outside of acq), holds that came from acq may or may not target those non-acq copies.  If they don't and any holds become unfulfillable (say due to hold permit policies), we'll just let them lay for now rather than try to figure that out.

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16079 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoresults are fancier in perl; adjust the result test from open-ils.cat
phasefx [Thu, 1 Apr 2010 05:15:07 +0000 (05:15 +0000)]
results are fancier in perl; adjust the result test from open-ils.cat

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16078 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHar, I looked in Lineitem.pm for an existing lineitem cancel method before I started...
phasefx [Thu, 1 Apr 2010 05:15:00 +0000 (05:15 +0000)]
Har, I looked in Lineitem.pm for an existing lineitem cancel method before I started, but not Order.pm.  Remove the one from Lineitem.pm and tweak the one in Order.pm.  Still need smoketest, etc.

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16077 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRough cut of 'open-ils.acq.lineitem.cancel', which "Cancels a lineitem, any of its...
phasefx [Thu, 1 Apr 2010 05:14:47 +0000 (05:14 +0000)]
Rough cut of 'open-ils.acq.lineitem.cancel', which "Cancels a lineitem, any of its detail entries and corresponding copies and call numbers, and potentially related holds (if the bib becomes empty)."  Need to smoke test it, add hold deletion if the bib becomes empty (and add an org unit setting for optionally deleting the bib as well), and check to see if volume deletion is being handled automatically by open-ils.cat.asset.copy.fleshed.batch.update

From my open-ils.acq.lineitem.cancel branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16076 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoshow progress dialog while waiting for the lineitem worksheet to load
erickson [Wed, 31 Mar 2010 20:46:59 +0000 (20:46 +0000)]
show progress dialog while waiting for the lineitem worksheet to load

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16075 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded support for progress dialog messages in the markup
erickson [Wed, 31 Mar 2010 20:46:58 +0000 (20:46 +0000)]
added support for progress dialog messages in the markup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16074 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSeed data for org settings and override permissions for managing the
erickson [Wed, 31 Mar 2010 19:44:19 +0000 (19:44 +0000)]
Seed data for org settings and override permissions for managing the
behavior when the systems finds a copy that could be used to fulfill a
hold at the requesting branch before the hold is placed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16073 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofleshed out the docs for the open-ils.circ.hold.has_copy_at method
erickson [Wed, 31 Mar 2010 19:44:18 +0000 (19:44 +0000)]
fleshed out the docs for the open-ils.circ.hold.has_copy_at method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16072 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: Indicate funds at stop/warning balance level with color and warnings
senator [Wed, 31 Mar 2010 19:38:02 +0000 (19:38 +0000)]
Acq: Indicate funds at stop/warning balance level with color and warnings

Specifically, in the lineitem detail (copy) interface,
where there are fund dropdowns.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16071 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded API docs for open-ils.actor.user.stage.create. Added support for passing in...
erickson [Wed, 31 Mar 2010 17:26:09 +0000 (17:26 +0000)]
added API docs for open-ils.actor.user.stage.create.  Added support for passing in staged statcats

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16070 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded pcrud entries for claim_policy and claim_policy_action
erickson [Wed, 31 Mar 2010 13:58:45 +0000 (13:58 +0000)]
added pcrud entries for claim_policy and claim_policy_action

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16069 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger to add additional code docs and more code cleanup
erickson [Wed, 31 Mar 2010 13:31:28 +0000 (13:31 +0000)]
Patch from Joe Atzberger to add additional code docs and more code cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16068 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocorrect paging behavior with new staged search stored proc and results
miker [Wed, 31 Mar 2010 07:43:46 +0000 (07:43 +0000)]
correct paging behavior with new staged search stored proc and results

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16067 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosyntax
phasefx [Tue, 30 Mar 2010 20:48:02 +0000 (20:48 +0000)]
syntax

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16066 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosyntax. this time I broke the file :)
phasefx [Tue, 30 Mar 2010 20:46:00 +0000 (20:46 +0000)]
syntax.  this time I broke the file :)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16065 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoreturn the whole blob for an undefined field key
miker [Tue, 30 Mar 2010 20:28:21 +0000 (20:28 +0000)]
return the whole blob for an undefined field key

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16064 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoindex is already there, do not recreate it
miker [Tue, 30 Mar 2010 18:52:05 +0000 (18:52 +0000)]
index is already there, do not recreate it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16063 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: PO interface now tells you if activating a PO would breach fund limits.
senator [Tue, 30 Mar 2010 17:50:25 +0000 (17:50 +0000)]
Acq: PO interface now tells you if activating a PO would breach fund limits.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16062 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd makefile and autogen support for the facet definition bits; more minor bug fixing...
miker [Tue, 30 Mar 2010 17:05:22 +0000 (17:05 +0000)]
add makefile and autogen support for the facet definition bits; more minor bug fixing of facet definition JS generator

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16061 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomoved to auto-grid for view funding-source UI (for paging, etc.). added pcrud entrie...
erickson [Tue, 30 Mar 2010 16:41:18 +0000 (16:41 +0000)]
moved to auto-grid for view funding-source UI (for paging, etc.).  added pcrud entries for funding_source credits

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16060 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoarg, typos
miker [Tue, 30 Mar 2010 16:24:28 +0000 (16:24 +0000)]
arg, typos

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16059 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd initial cut of slim facet structure autogen script
miker [Tue, 30 Mar 2010 16:16:31 +0000 (16:16 +0000)]
add initial cut of slim facet structure autogen script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16058 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoreinstated the links for funding_source code in the fund allocations grid
erickson [Tue, 30 Mar 2010 16:15:47 +0000 (16:15 +0000)]
reinstated the links for funding_source code in the fund allocations grid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16057 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomoved to auto-grid for allocations and debits for paging support, etc. hiding percen...
erickson [Tue, 30 Mar 2010 15:50:41 +0000 (15:50 +0000)]
moved to auto-grid for allocations and debits for paging support, etc.  hiding percent-based allocation option for now since they are not supported by the back-end

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16056 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded pcrud entries for fund allocations and fund debits
erickson [Tue, 30 Mar 2010 14:51:10 +0000 (14:51 +0000)]
added pcrud entries for fund allocations and fund debits

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16055 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Lee Dickens and Galen Charlton to correct a thinko in the recent change...
miker [Tue, 30 Mar 2010 14:34:53 +0000 (14:34 +0000)]
Patch from Lee Dickens and Galen Charlton to correct a thinko in the recent change to pg_loader -- ignore auto-pkey tables, as those have had their sequences adjusted, um, automatically

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16054 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoconsolidated the bib and authority record import logic to get the new functionality...
erickson [Tue, 30 Mar 2010 02:00:26 +0000 (02:00 +0000)]
consolidated the bib and authority record import logic to get the new functionality into the authority import process.  1match is possible if all matches point to the same record, not just if there is only 1 match.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16053 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremoved some unnecessary intermediate code that snuck into the commit
erickson [Mon, 29 Mar 2010 21:12:30 +0000 (21:12 +0000)]
removed some unnecessary intermediate code that snuck into the commit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16052 dcc99617-32d9-48b4-a31d-7c20da2025e4