Kathy Lussier [Wed, 17 May 2017 16:11:33 +0000 (12:11 -0400)]
LP#1677902: Remove search formats from advanced search limiter block
The original behavior of the advanced search limiter block was to remove
search formats from the display because it is available for limiting in the
search bar. Other code broke this behavior, and I've now restored it by
adding the ignore search format code to the searchbar.tt2 file. It also fixes
a problem where the search format limiters were incorrectly displaying on the
low hits page.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Jeff Davis [Thu, 18 May 2017 22:43:53 +0000 (15:43 -0700)]
LP#1690468: fix Exclude Electronic Resources checkbox with advanced search limiters
When advanced search limiters are applied, you cannot successfully
uncheck the Exclude Electronic Resources checkbox. When you uncheck it,
your current search is reloaded, but e-resources are still excluded
(and the box remains checked).
When you use the checkbox to exclude e-resources, the search form on the
results page contains a hidden input element:
This commit uses Javascript to remove that element from the search form
when the box is unchecked, before submitting the search.
Test plan:
[1] Enable the "Exclude Electronic Resources" checkbox in config.tt2.
[2] Do an advanced search, applying at least one search filter (e.g.
Language = "English").
[3] On the search results page, check the Exclude Electronic Resources
checkbox. This repeats your search, excluding e-resources.
[4] Uncheck the Exclude Electronic Resources box. Your search is
repeated, but e-resources are still excluded and the box remains
checked on your new results page.
[5] Apply this fix.
[6] Refresh the page or clear your browser cache, and try to uncheck the
Exclude Electronic Resources box again. This time, it should work:
e-resources will no longer be excluded, and the box is unchecked
when your new results page loads.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Technical documentation and sample stored queries for
the open-ils.qstore service, written by Scott McKellar
and copyright 2010 by the Equinox Open Library Initiative.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 19 May 2017 13:37:49 +0000 (09:37 -0400)]
LP#1564508: disable selecting Hatch status menu item
Add the "disabled" class to the <li> for the navbar menu
item that displays Hatch's status, to avoid making users
think that there's an action available to them by selecting
that menu item.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 17 Nov 2016 20:33:02 +0000 (15:33 -0500)]
LP#1564508 Hatch status in hamburger, remove statusbar
* Move the Hatch connectivity status indicator into the upper-right
hamburger menu.
* Removes the long-hidden hatch/websockets statusbar.
* Since the Hamburger forces a re-digest of the interface when opened,
the code no longer attempts to force the page to re-$apply() when
the Hatch connection opens or closes. It's no longer necesssary
(and was buggy).
* The WebSockets connectivity status is not added to the hamburger. The
websockets connection will go up and down regularly as connections
expire and reset. Having the indicator flash could lead to
unneccesary panic. Plus, if websockets are down, staff can't log in
anyway.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Add a --descendants option to marc_export to get records for an
org. unit and its descendants.
To test
-------
[1] Run marc_export with -i --library FOO. Verify that the resulting
records have 852 fields only from FOO.
[2] Run marc_export with -i --descendants FOO. Verify that the resulting
records have 852 fields from FOO *and* all descendants of FOO.
[3] Run marc_export using various combinations of --library and --descendants;
verify that items from the expected libraries show up as 852 fields.
The reporter.classic_current_circ view, which is available via
Open-ILS/src/sql/Pg/example.reporter-extension.sql, was excluding
circulations because it was assuming all users have a billing address
This branch corrects that with a LEFT JOIN.
No upgrade script will be included since these views are not assumed
to be installed by all Evergreen instances. Please re-run the
example.reporter-extension.sql file to apply this change for your
instance.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jason Etheridge [Wed, 26 Apr 2017 21:23:26 +0000 (17:23 -0400)]
LP#1491875: avoid erroneous "unsaved data" popup during MARC record creation
Test plan
---------
[1] Navigate to Cataloging -> Create New MARC Record.
[2] Choose a template, click Load
[3] Enter data in a fixed field, for example, Date1
[4] Enter data in a MARC field such as 100
[5] Click Create Record:
The "This tab may have unsaved data. ..." pop up will appear.
Clicking OK will save the record and take the user to their default
view of the record.
Clicking Cancel will save the record and return the user to the MARC
Edit screen.
The behavior when clicking Cancel can lead to confusion as to
whether the record has actually been saved.
[6] Apply the patch and repeats steps #1-#5.
[7] This time, no extraneous unsaved data warning should appear.
Note that this patch's kludge doesn't fix all possible instances
of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6
for details.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> SIgned-off-by: Andrea Neiman <abneiman@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Teach the hold targeter live tests to call the open-ils.hold.targeter
API instead of calling the now-defunct Utils::HoldTargeter batch
targeter function. Apart from the loss of this function, calling the
API allows the live tests to exercise more of the targeting code.
Teach the live tests to test --soft-retarget-interval instead of the
deprecated --skip-viable option.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com>
Remove the unusued batch target() function from Utils::HoldTargeter to
avoid code duplication. The same (but more resilient) batch targeting
construct exists in the open-ils.hold-targeter API.
Move API docs from Utils::HoldTargeter to the open-ils.hold-targeter API
docs for added visbility / findability.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Wed, 22 Mar 2017 15:47:21 +0000 (11:47 -0400)]
LP#1677661 Hold Targeter V2 Repairs & Improvements
* Make the batch targeter more resilient to a single-hold failure.
* Additional batch targeter info logging.
* Set OSRF_LOG_CLIENT in hold_targeter_v2.pl for log tracing
* Removes the confusingly name --target-all option
* Adds a new --next-check-interval option for specifying when the
targeter will next affect the currently processed holds, which may be
different that now + retarget-interval in cases where the targeter is
not constantly running.
* Replaces the --skip-viable option with a new --soft-retarget-interval
option, allowing for time-based soft-targeting.
* Soft-targeting now updates hold_copy_maps for all affected holds, not
just those requiring a full retarget.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Boyer [Tue, 21 Feb 2017 21:31:31 +0000 (16:31 -0500)]
LP1274999: Next Link Appears at "End" of Copy List
The total number of copies wasn't checked against the
copy_limit and copy_offset, so anytime that the
number of copies per page mod copy_limit == 0 the
Next link would appear, even if there were only
copy_limit copies total. Now the offset and limit are
compared to the total number of copies available at
the current depth to determine if the Next link
should appear.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Gracefully handle cases where a checkin results in a transit to a branch
with no holds address. Route dialog and print templates now display "We
do not have a holds address for this library. "
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP1244354 Unnecessary user refresh after deletion can cause permission error
obj.refresh_all() was being called no matter what. It needs to be called only when
there is an issue deleting the patron. On success, this patch will simply present an
informational message to the user.
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Galen Charlton [Fri, 11 Nov 2016 19:52:11 +0000 (14:52 -0500)]
LP#1641208: util.file no longer mangles UTF8 when writing JSON
This patch ensures that JSON strings are converted to UTF8
before they are writing to XUL profile files by util.file. Doing this
fixes a bug where by OU names like "ბიზნესისა" can get mangled
in certain XUL client interfaces.
To test
-------
[1] Set an OU name to ბიზნესისა
[2] In the transit list, note that the OU selector displays
the name as ÑØÖÜÔáØáÐ.
[3] Apply the patch (note that it's not necessary to rebuild
the staff client to test this).
[4] Restart the staff client, clearing cache beforehand.
[5] Note that the OU name is now displayed correctly in the transit
list.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Galen Charlton [Fri, 17 Mar 2017 15:47:46 +0000 (11:47 -0400)]
LP#1673799: new acqedim index to speed up duplicate file check
This patch adds a new index on acq.edi_message to speed up
the check for duplicate EDI messages that edi_fetcher.pl runs,
replacing use of "ilike" with invocations of the evergreen.lowercase()
stored procedure.
To test
-------
[1] Arrange to create or simulate an EDI message that failed
processing.
[2] Run edi_fetcher.pl to have it attempt to download the
failed message in step #1; verify that the file is
/not/ downloaded again and that no additonal acq.edi_message
rows are created for it.
[3] (Extra credit) Try steps 1 and 2 in a database that has a
very large number of rows in acq.edi_message.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Josh Stompro [Wed, 21 Dec 2016 19:57:32 +0000 (13:57 -0600)]
LP#1650807: fix rollover_phone_to_print.pl to ack failed calls
This patch fixes a bug in rollover_phone_to_print.pl that kept
failed callfiles from being moved.
The list of new event ID's that the script created was being sent to the
mediator, which couldn't do anything with them. The original event ID's
need to be sent to have those call files moved.
Chris Sharp [Sat, 20 Aug 2016 14:36:57 +0000 (10:36 -0400)]
LP#1177794 - remove "Keep" field from Vandelay Import Item Attributes.
The "Keep" field in Vandelay Import Item Attributes is not
currently implemented, so remove from all user interfaces.
However, I didn't change the vandelay.import_item_attr_definition
table, leaving the option for this to be implemented in the future.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
build/i18n/po/fm_IDL.dtd/fm_IDL.dtd.pot
Jason Boyer [Tue, 9 May 2017 15:07:46 +0000 (11:07 -0400)]
LP1689576: Fix ALARM -> ALRM Typo
In Biblio.pm, when trying to set a timeout handler for $SIG{ALARM}
when retrieving cached facets as part of a catalog search,
a warning is dropped in the logs to this effect:
"No such signal: SIGALARM at
/usr/local/share/perl/5.18.2/OpenILS/Application/Search/Biblio.pm
line 1411"
When using $SIG{ALRM} instead the handler is set as expected.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
[1] Set the vandelay.default_match_set setting for several
org units. In at least one case, set it to the ID
of a valid vandelay.match_set entry; in another case,
set it to a numeric ID that doesn't match any existing
vms rows; and finally, in another case set it to the
name of a match set.
[2] Apply the patch and run the database update. Verify that
the update script will indicate that there are invalid
settings, then delete.
[3] Open the library settings editor and verify that in the
case where a valid match set was used, the editor provides
a drop-down with possible vms values with the correct
one selected.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Thu, 3 Mar 2016 18:55:34 +0000 (10:55 -0800)]
LP#1552861: use correct datatype for vandelay.default_match_set org setting
Values for this setting should be links to vandelay.match_set, not strings.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Chris Sharp [Tue, 11 Apr 2017 14:20:30 +0000 (10:20 -0400)]
LP#1170514 - Upgrade script for vandelay.auto_overlay_bib_record
This script got missed in the 2.1-2.2 era and finally makes it
in nearly six years later. Not necessary for sites that began using
Evergreen since then, but harmless to run.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Leave the myopac.xml redirect in eg_vhost.conf since of all the
redirects it's the most likely to be used. This version of the redirect
is proxy-proofed.
Additionally keep all of the original myopac redirects in
Open-ILS/examples/jspac_redirects.conf for reference.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
IP-based redirection now redirects the client to the same port number
originally requsted by the client, instead of using the port that the
Apache server is listening on. This prevents internal Apache from
leaking to the caller when a proxy is used.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Certain Apache redirects now send the browser to standard 80/443 ports
instead of defaulting to the internally configured Apache ports,
which may be non-standard, particularly in a proxied environment.
Leaking the non-standard ports to the browser causes the browser to
bypass the proxy and could cause the browser to request inaccessible
pages.
1. Configure Apache to use non-standard ports for port 80/443 (e.g. 7080
and 7443).
2. Confirm the issue by navigatigating to http://HOST/
3. This should redirect to http://HOST:7080/eg/opac/home
4. Apply the Apache config changes and reload/restart Apache.
5. Clear the browser cache to reset any redirects
6. Navigate to http://HOST/
7. Confirm it redirects the browser to http://HOST/eg/opac/home
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Scott [Thu, 1 Dec 2016 22:24:01 +0000 (17:24 -0500)]
LP#1646638 - Fix SIP timeouts due to invalid sessions
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Mon, 1 May 2017 18:47:58 +0000 (14:47 -0400)]
LP#1667221: (follow-up) remove comment that is now a lie
Also, here's a test plan:
[1] Edit /openils/conf/oils_sip.xml and set the currency
defined in the implementation section to be something
other than USD.
[2] Start the SIP server and perform a patron information
request; note that the BH field in the response contains
'USD'.
[3] Apply the patch and restart the SIP server.
[4] Repeat step 2; this time, the currency should be whatever
is specified in oils_sip.xml.
[5] Comment out the currency section in oils_sip.xml and restart
the SIP server.
[6] Repeat step 2; this time, the currency should be back to 'USD'.
Fix override permission used when checking in a copy that is "long
overdue".
The existing permission was incorrectly created with a code of
COPY_STATUS_LONGOVERDUE.override, while the event thrown requires a
permission with a code of COPY_STATUS_LONG_OVERDUE.override
This commit updates the seed data and a few references to the
old/incorrect permission in documentation, and also includes an
upgrade script designed to accommodate the various likely ways in
which sites may have already locally addressed this issue.
A simple pgtap test is also included.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Kathy Lussier [Fri, 5 May 2017 16:14:19 +0000 (12:14 -0400)]
Docs: Add files to the list of tpac files that should be customized
We have a list of tpac files that should be customized on an Evergreen system.
There are a couple of files related to password formats that should be included
here.
Dan Scott [Tue, 2 May 2017 04:37:17 +0000 (00:37 -0400)]
LP#1685840 Activate Google Preview "extras" bar on load
Thanks to Ben Shum for pointing out that users might expect the Google Preview
extras bar near the bottom of the screen to trigger loading the preview as
well. Another event listener handles this accordingly.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Scott [Mon, 24 Apr 2017 16:18:12 +0000 (12:18 -0400)]
LP#1685840: Dojoless Google Books Preview as external script
Rather than including the JavaScript inline in each page, load the
JavaScript as a regular external JavaScript file so that browsers
can take advantage of caching, reduce network bandwidth, and reduce the
amount of TT2 processing required. Every little bit helps.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Scott [Mon, 24 Apr 2017 15:53:24 +0000 (11:53 -0400)]
LP#1685840: Dojoless Google Books Preview: remove TT2 dependency
Rather than process the template with TT2 to specify the language in
which the Google Books Preview should be displayed, use the @lang
attribute on the <html> element--and fall back to 'en' if for some
reason that attribute has been removed from the template.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Scott [Mon, 24 Apr 2017 15:29:37 +0000 (11:29 -0400)]
LP#1685840: Google Books Preview: responsive sizing
Use the viewport's actual height and width to display the book preview,
rather than hard-coding 600px x 800px. On a very wide screen, the book
will be centred; on a small screen such as a mobile device, the book
will not scroll indiscriminately off to the side, but instead stays
within the bounds of the viewport.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Scott [Mon, 17 Apr 2017 22:42:11 +0000 (18:42 -0400)]
LP#1685840: Dojoless Google Books Preview does not need want_dojo
Now that Dojo is no longer needed for Google Books Preview, we can load
the associated JavaScript without having to enable want_dojo.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Avoid polluting the global namespace by wrapping the code in (function() {})().
Add event listeners to the DOM elements rather than the crufty
href=javascript:function approach.
Optimization: do not load the Google Books JSAPI unless there is a matching
embedded ISBN.
Use display style directly, rather than munging class names with hide_me
Supports IE 10/11, which does not handle responseType = 'json', through
the fallback to XHR responseText.
IE9 for now; it seems the new Google Books Loader wipes out the DOM in
IE9 instead of loading nicely in the <head>. Could go back to the old
Google JS loader, which still works, but is deprecated, so could
disappear at any point.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Michele Morgan [Wed, 15 Mar 2017 20:31:06 +0000 (16:31 -0400)]
LP#1427392 - Allow deletion of Hard Due Date Values.
Also, don't update hard due dates to ceiling dates that have passed.
Fixes two related issues with hard due dates.
- Exposes the selector in the Hard Due Date Values interface so past
entries that are no longer valid can be deleted via the client.
- Prevents the current ceiling date from being updated to a past date
based on an old hard due date value.
Testing plan:
To reproduce the issue:
- Create a Hard Due Date with a Current Ceiling Date in the future
- Create an associated Hard Due Date Value with an active date earlier
than the current date and a ceiling date earlier than the current date.
- Run the hard due date updater
Note that:
- The Current Ceiling Date is updated to an earlier date based on
the Hard Due Date Value entry.
- It is not possible to select and delete the Hard Due Date Value
entry.
Apply the patch and retest
Note that:
- The Current Ceiling Date has not been updated to the past date.
- Past Hard Due Date Values can now be selected and deleted.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Kathy Lussier [Tue, 2 May 2017 17:33:54 +0000 (13:33 -0400)]
Docs: Documentation for default metarecord search
Adding documentation on how to configure a default metarecord search in the
admin section. The catalog section also containts a tip about this option with
a link to the admin section for further details on how to configure it.
[1] Create a purchase order with, say, 3 lineitems and 2
copies on each of these.
[2] Receive the first two lineitems outright.
[3] Receive one of the copies on the last lineitem and cancel
the other with a cancellation reason that's permanent (e.g.,
bad ISBN) rather than temporary (e.g., backordered).
[4] Note that the purchase order's state remains 'on-order'
[5] Apply the patch.
[6] Repeat steps #1-4. This time, the PO's state should be
'received'.
[7] Repeat steps #1-4, but this time, choose backordered as
the cancellation reason. This time, the PO's state should
remain 'on-order'.
It should be noted that the patches for this bug do *not*
retrospectively mark purchase orders as being received.
Repaire the json_query used to determine if a PO is ready to be marked
received.
A PO is non-receiveable if it has any lineitems that are not in the
received/cancelled [sic] state OR any that are canceled with a
keep_debits=true cancel reason.
Prior to this change, simply having a state of "cancelled" was enough to
prevent receiving.
* Replace tabs w/ spaces
* Remove unnecessary "or return 0" clause which was causing Perl
precedence warnings.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Chris Sharp [Wed, 5 Apr 2017 13:52:50 +0000 (09:52 -0400)]
LP#1257915 - Mark POs received when all lineitems are received or canceled.
Previously, Evergreen only considered lineitems not in a "received" status
when deciding whether to consider a purchase order to be "received". Now
items with cancel reasons that do not keep debits (e.g. not backordered)
are considered "done".
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Chris Sharp [Wed, 10 Feb 2016 00:12:11 +0000 (19:12 -0500)]
LP#1230301 - Add User/Working Location Map Link to the ILS User reports source.
For certain reports it is desirable to display or filter on staff Working Location.
This adds a link to the permission.usr_work_ou_map table/source in fm_IDL.xml.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Per discussion in IRC, the ingest.disable_metabib_field_entry internal
flag was obsoleted by the addition of the ingest.skip_browse_indexing,
ingest.skip_search_indexing, and ingest.skip_facet_indexing
flags. Since ingest.disable_metabib_field_entry is not used anywhere
in the database, this branch removes it.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Josh Stompro [Mon, 29 Aug 2016 02:23:01 +0000 (21:23 -0500)]
LP#1616220 Fixes for css errors that show up in the xul staff client console.
To test
-------
[1] In the XUL client, try various interfaces including acquisitions,
the patron editor, the reporter, the library settings editor,
serials management and patron surveys. Using the error console,
verify that applying this patch slightly reduces the number of
CSS warnings reported.
[2] Repeat step 1 using the web staff client, in particular while
looking at the embedded acquisitions interfaces.
Linda Jansova [Tue, 29 Nov 2016 13:49:52 +0000 (08:49 -0500)]
LP#1628655: Do not show Patron Reviews if Chilifresh is not in use
The Patron reviews header used for Chilifresh content displays in the catalog
even for Evergreen sites that do not use Chilifresh. This patch hides it if
a site is not using Chilifresh.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1680142: Fix responsive design issue with ebook display
Fixes the following responsive design issues:
* Removes the e-book dashboard display when the screen size is reduced.
* Changes the table display for e-items currently checked out, e-items on hold,
and e-iterms ready for checkout interfaces to mimic the responsive behavior of
other My Account screens.
* Fixes a couple of Holds History CSS problems discovered while I was here.
Test Plan:
Enable ebook services. Log into your account and resize the screen to the size
of a mobile device. The ebook dashboard will display while the main account
dashboard disappears. Go into My Account, click Items checked out and then
click E-Items Currently Checked Out. The table has not reformatted itself for
responsive design view.
Post-patch: When you log in and resize the screen, the e-items dashboard
display will disappear along with the main account dashboard. When you access
the E-Items Currently Checked Out interface, the table will reformat itself
with column headers along the left side.
To allow browsers to cache the correct version of the stylesheet, append a GET
param indicating the direction.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Ben Shum [Thu, 27 Apr 2017 15:43:55 +0000 (11:43 -0400)]
LP#1681009 Merge the RTL style with the LTR style (part2)
Finishing up the rest of the file and removing the RTL specific one
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Rather than adding the right-to-left stylesheet
Open-ILS/src/templates/opac/css/style-rtl.css.tt2 as something that
gets included in addition to the LTR style.css.tt2 when a RTL language is in
play, merge the logic directly into the stylesheet so that we save bytes over
the network, browser rendering time, and reduce the possibility that RTL will
be forgotten about when new features are added or styles are optimized.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1681466: move text to body of confirm dialog and add title
This patch tweaks the opt-in confirm dialog to add a
title and move the text to the body of the dialog, making it
consistent with other dialogs that ask long questions.
Test case for the entire bug fix
--------------------------------
[1] Ensure that <opt_in> is set to true in opensrf.xml.
[2] In the web staff client, open the checkout page
and do a barcode search for a patron is *not* the
same system as the workstation that the staff user
is registered to.
[3] Verify that a dialog box is presented asking the
staff user to confirm that personal information can be
shared with the workstation's library.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Kathy Lussier [Fri, 3 Mar 2017 12:33:37 +0000 (07:33 -0500)]
LP#1621178: Tweaks to item status column picker option
This commit:
* Removes the copy status column from the Checkout page. The expectation is
that items will not appear in this grid unless they have a Checked out status.
This commit fixes the following kinds of warnings given by asciidoc when
building the docs HTML:
- Incorrect header level
- Incorrect list numbering
- List numbering interrupted by an image (needs '+' on blank lines)
- In one case, a list used '1)' style numbering, which AsciiDoc
doesn't recognize. This commit corrects that, even though it caused
no errors.
These are minor issues, but fixing them is easy and prevents future
confusion and errors.
projects / working / Evergreen.git / log