working/Evergreen.git
3 years agoLP#1534787 Patron Message Center port
Kyle Huckins [Wed, 4 Jan 2017 17:36:21 +0000 (09:36 -0800)]
LP#1534787 Patron Message Center port

Port patron message center from XUL client to
web client.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1537217 Precat Checkout Circ Modifier
Kyle Huckins [Tue, 4 Oct 2016 22:55:23 +0000 (15:55 -0700)]
LP#1537217 Precat Checkout Circ Modifier

Precat checkout in the browser client no longer
requires the use of a circ modifier(when circ
modifiers exist).  Similarly, no circ modifier
is chosen by default.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoDocs: Updating to reflect Web staff client
Clare Sobotka [Sun, 5 Feb 2017 16:37:46 +0000 (08:37 -0800)]
Docs: Updating to reflect Web staff client

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1660059: Protect against null value in group field
Mike Rylander [Tue, 31 Jan 2017 17:35:05 +0000 (12:35 -0500)]
LP#1660059: Protect against null value in group field

If a nullable event grouping field is configured, and a null value is indeed
encountered when pulling together events, the Action/Trigger code will exit
unceremoniously.  To prevent this, we will now collect events with either
a null grouping object or grouping field, and use a new batch invalidation
API call to get rid of them as quickly as possible after group sorting is
complete.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1659892: Remove page from URL in metarecord navigation
blake [Fri, 27 Jan 2017 16:57:12 +0000 (10:57 -0600)]
LP1659892: Remove page from URL in metarecord navigation

Scrubs the 'page' URI value from the "Return to Grouped Search Results"
preventing the resulting page from showing the currently selected page.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1657466 - Edit Due Date Doesn't Submit
Kyle Huckins [Thu, 19 Jan 2017 20:35:00 +0000 (12:35 -0800)]
LP#1657466 - Edit Due Date Doesn't Submit

Change references of nonexistant scope variable args.date
to args.due_date, enabling edit due date to correctly
submit.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1621947: webstaff address alert functionality
Kyle Huckins [Wed, 19 Oct 2016 21:57:02 +0000 (14:57 -0700)]
LP#1621947: webstaff address alert functionality

Add Address Alert to the alerts pane when address alert
is detected in the patron editor. This implements functionality
that was originally added tot he XUL patron editor in LP#898248.

To test:

[1] Define an address alert.
[2] Open a patron record in the webstaff patron editor and
    create or update an address that would match the alert
    set up in step 1. Verify, upon blur of street 1, street 2,
    or the city inputs that an alert is displayed.

Note that the feature does not call for the presence of an
address alert to prevent the operator from saving the record;
the alert is purely advisory.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1655399 webstaff: User perm editor grantable fix
Bill Erickson [Tue, 10 Jan 2017 17:19:35 +0000 (12:19 -0500)]
LP#1655399 webstaff: User perm editor grantable fix

Correctly handle the boolean grantable flag in the user permission
editor.  In some cases, the boolean 0/1 values returned from storage are
returned as strings.  Cast them to numbers before checking truthiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1485374: Add missing comma on line 667 of oils_auth.c.
Jason Stephenson [Sat, 20 Aug 2016 17:42:31 +0000 (13:42 -0400)]
LP#1485374: Add missing comma on line 667 of oils_auth.c.

Fixes the following compiler error:
oils_auth.c: In function ‘oilsAuthComplete’:
oils_auth.c:668:9: error: expected ‘)’ before string constant
         "open-ils.auth_internal",
         ^

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1485374: Add release notes
Mike Rylander [Tue, 23 Feb 2016 17:35:07 +0000 (12:35 -0500)]
LP#1485374: Add release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1485374: Adjust TZ scope in mod_perl
Mike Rylander [Tue, 23 Feb 2016 17:32:57 +0000 (12:32 -0500)]
LP#1485374: Adjust TZ scope in mod_perl

Use of a 'local' variable causes the TZ to be dropped prematurely. So,
instead, we set $ENV{TZ} globally and reset it when the mod_perl handler
object is destroyed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1485374: add way for C code to make TZ-aware subrequests
Galen Charlton [Tue, 23 Feb 2016 17:09:15 +0000 (12:09 -0500)]
LP#1485374: add way for C code to make TZ-aware subrequests

This patch adds a helper routine to allow C
methods to make subrequests that pass the client
time zone along. This helper is in turn used during
authentication to ensure that the user object
that is returned has timestamps that are in the
time zone of the client that makes the original
authentication request.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/c-apps/oils_auth.c

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1485374: call tzset() after setting timezone
Galen Charlton [Wed, 3 Feb 2016 22:50:58 +0000 (17:50 -0500)]
LP#1485374: call tzset() after setting timezone

Testing shows this to be needed to make strftime()
return the time in the client's time zone.

This is a bit confusing, however, as strftime per
POSIX should be acting as if it always calls tzset()
when doing formatting that involves the local timezone.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1485374: Allow server timezone via CStoreEditor
Mike Rylander [Fri, 11 Sep 2015 15:19:34 +0000 (11:19 -0400)]
LP#1485374: Allow server timezone via CStoreEditor

In rare cases, the server's timezone may be preferable to the client's.
To plan for such cases we provide a way to signal that we want to use the
server's timezone.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1485374: Use client TZ in the database when supplied to the server
Mike Rylander [Mon, 3 Aug 2015 17:27:56 +0000 (13:27 -0400)]
LP#1485374: Use client TZ in the database when supplied to the server

In LP#1485371 we teach OpenSRF how to discover and pass the client timezone
to the server.  Now we can use that information to temporarily put the server
into that timezone, including database sessions, so that dates and times
are calculated and reported based on the timezone of the client.

To do that we:

 * Teach CStore and friends to use the client-supplied time zone
 * Teach Storage to use $ENV{TZ} for the db timezone inside transactions,
   and by default except for search-y methods
 * Teach the TPAC to set the client TZ at login

This requires javascript to be enabled in the TPAC, and investigates the
client timezone at patron login time.  No times are displayed in TPAC
interfaces before the patron logs in, so there is no point in detecting
the timezone before this point.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoDocs: authority_control_field script --days-back feature
Jane Sandberg [Fri, 27 Jan 2017 02:07:55 +0000 (18:07 -0800)]
Docs: authority_control_field script --days-back feature

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years ago2.10.8-2.10.9 schema upgrade script
Galen Charlton [Wed, 25 Jan 2017 21:12:36 +0000 (16:12 -0500)]
2.10.8-2.10.9 schema upgrade script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: Adding release notes for 2.11.2 point release
Kathy Lussier [Thu, 22 Dec 2016 19:20:33 +0000 (14:20 -0500)]
Docs: Adding release notes for 2.11.2 point release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoDocs: Adding release notes for 2.10.9 point release
Kathy Lussier [Thu, 22 Dec 2016 19:20:33 +0000 (14:20 -0500)]
Docs: Adding release notes for 2.10.9 point release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1657885: Inform Vandelay of new chunking/bundling logic, part deux
Mike Rylander [Wed, 25 Jan 2017 17:33:24 +0000 (12:33 -0500)]
LP#1657885: Inform Vandelay of new chunking/bundling logic, part deux

Here we conditionally use the old "max_chunk_count" method provided by OpenSRF
when Evergreen is running atop a version that doesn't know about the bundling
rename.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1657885: Inform Vandelay of new chunking/bundling logic
Mike Rylander [Wed, 25 Jan 2017 15:56:23 +0000 (10:56 -0500)]
LP#1657885: Inform Vandelay of new chunking/bundling logic

There is a naive attempt to force immediate streaming of results in Vandelay
for certain processes, but it both only helps a little, and breaks under the
new OpenSRF bundling/chunking logic.  So, we'll drop it where it's not
directly configurable, and test for the appropriate features where we can.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1657885: Account for new bundling/chunking logic in OpenSRF 2.5+
Mike Rylander [Thu, 19 Jan 2017 20:54:53 +0000 (15:54 -0500)]
LP#1657885: Account for new bundling/chunking logic in OpenSRF 2.5+

When chunking was renamed bundling and actually chunking added in OpenSRF 2.5,
the few places in Evergreen that tried to make use of the old mechanism
directly now break. The most obvious breakage is in the alternate printable
hold pull list, which we fix here.  Evidence of other broken code should
be fixed as needed, though spots to look our for are z39.50 results and
Vandelay processing.

To test:

 1) In Evergreen 2.11 running on top of OpenSRF 2.5+, attempt to use the
    alt pull list printing interface at a location with many holds on their
    pull list.  The progress bar will spin forever.
 2) After applying this patch, do the same.  The interface should work
    quickly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1657237: Rewrite the hold target cache
Mike Rylander [Wed, 18 Jan 2017 19:38:00 +0000 (14:38 -0500)]
LP#1657237: Rewrite the hold target cache

We fixed the trigger that caused the problem in bug 167237, but now we need
to rewrite reporter.hold_request_record because T-holds are probably all
wrong.  No data was lost, we're just addressing the contents of a materialized
view.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
3 years agoLP#1659006: Treat the Cost field like the other money fields in the copy editor,
Michele Morgan [Tue, 24 Jan 2017 14:17:58 +0000 (09:17 -0500)]
LP#1659006: Treat the Cost field like the other money fields in the copy editor,
reverting to null if blanked.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoDocs: Add browser requirements for running the web client
Kathy Lussier [Mon, 23 Jan 2017 16:18:12 +0000 (11:18 -0500)]
Docs: Add browser requirements for running the web client

Adding initial browser requirements for running the web client to the system
requirements file. For now, keeping XUL client requirements.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1494362 Docs: oversized screenshot
Jeanette Lundgren [Wed, 18 Jan 2017 19:22:58 +0000 (14:22 -0500)]
LP#1494362 Docs: oversized screenshot

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 years agoLP#1657282: fix redirect of one-hit metarecord searches
Galen Charlton [Tue, 17 Jan 2017 21:58:39 +0000 (16:58 -0500)]
LP#1657282: fix redirect of one-hit metarecord searches

This patches fixes a bug where, when performing a metarecord
("Group Formats and Editions") search, one-hit result sets
get redirected to a "/eg/opac/record/0.0..." page, which
results in a "Bad Request" error being shown to the user.

To test:

[1] Perform a metarecord search that would result in exactly
    one metarecord search. Observe that the browser displays
    a "Bad Request" error page.
[2] Apply the patch and perform step 1 again. This time, the
    search should succeed. Note that if the metarecord contains
    more than one component, a results page with one grouped
    hit is displayed; if the metarecord has exactly one component,
    that bib's record page is displayed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1657241 Stamping aged circ parent_circ index
Bill Erickson [Tue, 17 Jan 2017 20:24:53 +0000 (15:24 -0500)]
LP#1657241 Stamping aged circ parent_circ index

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1657241 - Add parent_circ index to action.aged_circulation
Chris Sharp [Tue, 17 Jan 2017 20:09:15 +0000 (15:09 -0500)]
LP#1657241 - Add parent_circ index to action.aged_circulation

The lack of a parent_circ index on the aged_circulation table
was causing very long-running queries.  This solves the problem.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1657237 Stamping rhrr mat view trigger repair
Bill Erickson [Tue, 17 Jan 2017 20:08:58 +0000 (15:08 -0500)]
LP#1657237 Stamping rhrr mat view trigger repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1657237: Properly constrain matview trigger function
Mike Rylander [Tue, 17 Jan 2017 19:46:36 +0000 (14:46 -0500)]
LP#1657237: Properly constrain matview trigger function

The function maintaining the reporter.hold_request_record table
was performing an unconstrained update when a hold was moved.  This
fixes that.

To test:

[1] Apply the patch, the perform an asset merge that would
    change the target of a hold request.  Verify that
    reporter.hold_request_record is properly update.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoDocs: adding section about circulating items in the Web client
Michelle Purcell [Sat, 14 Jan 2017 13:46:56 +0000 (10:46 -0300)]
Docs: adding section about circulating items in the Web client

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1655149: Badges need CDBI support for location groups
Mike Rylander [Wed, 28 Dec 2016 19:43:34 +0000 (14:43 -0500)]
LP#1655149: Badges need CDBI support for location groups

The badge code needs to inspect copy location groups, and tries to do so using
Class::DBI classes. But we haven't told CDBI about aclg and friends.  Here we
tell Class::DBI about asset.copy_location_group so that storage can retrieve
directly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoUpdated link syntax to fix broken section link.
Jeanette Lundgren [Mon, 9 Jan 2017 17:10:12 +0000 (12:10 -0500)]
Updated link syntax to fix broken section link.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 years agoLP#1635407 webstaff: show patron alert pane once
Bill Erickson [Wed, 28 Dec 2016 21:15:24 +0000 (16:15 -0500)]
LP#1635407 webstaff: show patron alert pane once

Display the patron alerts pane only once per patron instance per
browser tab.  This is done by setting a new session storage value which
tracks the last alerted patron.  This value is replaced each time a new
patron is loaded into the main patron app (e.g. double-clicking the
patron row in patron search) and is maintained separately per browser
tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1502292 Add Volumes from Bib Record
Kyle Huckins [Thu, 17 Nov 2016 19:47:31 +0000 (11:47 -0800)]
LP#1502292 Add Volumes from Bib Record

Add 'Add Volumes' button to record summary pane to
add a new volume for a record.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
modified:   Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/catalog/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: booking options from Patron interface
Jason Etheridge [Tue, 3 Jan 2017 11:58:25 +0000 (06:58 -0500)]
webstaff: booking options from Patron interface

Includes some workarounds for xulG errors, and lets the booking interfaces
receive the patron barcode via a query param instead of xulG.  The XUL client
spawns a new tab for these interfaces, but we stick with web norms and load in
the current tab (control+click will open a new tab).  This does, however, blow
away the patron interface; it doesn't embed like most of the options from the
Other menu.  One other change: we don't have support for nested drop-down menus
in the web client, so I've flattened the entries like so:

* Booking: Create or Cancel Reservations
* Booking: Pick Up Reservations
* Booking: Return Reservations

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: workaround a xulG undefined bug in Admin -> Booking -> Resources
Jason Etheridge [Mon, 19 Dec 2016 21:00:13 +0000 (16:00 -0500)]
webstaff: workaround a xulG undefined bug in Admin -> Booking -> Resources

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: broader CSS tweak for Chrome for disabled text widgets
Jason Etheridge [Mon, 19 Dec 2016 20:44:48 +0000 (15:44 -0500)]
webstaff: broader CSS tweak for Chrome for disabled text widgets

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: error sounds instead of warning sounds for some events
Jason Etheridge [Mon, 12 Dec 2016 19:55:42 +0000 (14:55 -0500)]
webstaff: error sounds instead of warning sounds for some events

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add sounds related to checkout
Jason Etheridge [Mon, 12 Dec 2016 19:42:54 +0000 (14:42 -0500)]
webstaff: add sounds related to checkout

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: sound for batch hold edit
Jason Etheridge [Mon, 12 Dec 2016 20:20:36 +0000 (15:20 -0500)]
webstaff: sound for batch hold edit

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: Add sounds for in house use and patron lookup
Mike Rylander [Mon, 12 Dec 2016 15:36:27 +0000 (10:36 -0500)]
webstaff: Add sounds for in house use and patron lookup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: use ng-show rather than ng-if for showIframe
Galen Charlton [Wed, 30 Nov 2016 10:54:22 +0000 (05:54 -0500)]
webstaff: use ng-show rather than ng-if for showIframe

This avoids an issue with ng-if creating a separate
scope.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix bower.json to bring in iframe-resizer
Galen Charlton [Tue, 6 Dec 2016 22:31:04 +0000 (17:31 -0500)]
webstaff: fix bower.json to bring in iframe-resizer

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: throw a kitchen sink at double-scrollbar issues
Galen Charlton [Wed, 30 Nov 2016 10:25:52 +0000 (05:25 -0500)]
webstaff: throw a kitchen sink at double-scrollbar issues

This patch ameliorates, but does not eliminate, a bunch
of cases where double-scrollbars could appear.

[1] Adds iframe-resizer (https://github.com/davidjbradshaw/iframe-resizer, MIT license)
    as an option for automatically adjusting the height of an iframe
    to fit the contents.  This can be enabled by ensuring that
    the page to be embedded brings in

    /js/ui/default/staff/build/js/iframeResizer.contentWindow.min.j

    and adding an 'autoresize' attribute to the egEmbedFrame directive.

    This is now used by the legacy reports page.

[2] Gives a 'min-height' attribute to egEmbedFrame and sets a
    value for Dojo grid interfaces embedded by local and server admistration.
[3] Adds a 'allow-escape' attribute to egEmbedFrame; when set to
    true, adds buttons to allow the user to open the embedded page
    in a new tab.
[4] Removes some extraneous <div>s that were interferring with resizing
    for some grids.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: tweaks to transit list
Galen Charlton [Wed, 30 Nov 2016 02:45:10 +0000 (21:45 -0500)]
webstaff: tweaks to transit list

- make call number column sortable
- add shelving location column

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: Booking Admininstration
Jason Etheridge [Fri, 2 Dec 2016 21:24:26 +0000 (16:24 -0500)]
webstaff: Booking Admininstration

  * Resource Attribute Maps
  * Resource Attribute Values
  * Resource Attributes
  * Resource Types
  * Resources

and a xulG load timing issue workaround

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: final Booking menu entry
Jason Etheridge [Fri, 2 Dec 2016 21:04:44 +0000 (16:04 -0500)]
webstaff: final Booking menu entry

  * Return Reservations

and xulG load timing issue workaround

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: more Booking menu entries
Jason Etheridge [Fri, 2 Dec 2016 20:58:17 +0000 (15:58 -0500)]
webstaff: more Booking menu entries

  * Pull List
  * Capture Resources
  * Pick Up Reservations

plus another xulG load timing issue workaround

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: first ported Booking interface
Jason Etheridge [Fri, 2 Dec 2016 20:43:10 +0000 (15:43 -0500)]
webstaff: first ported Booking interface

  * Create Reservations

with a xulG timing issue workaround :-/

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add seed data for item status receipt template
Galen Charlton [Wed, 30 Nov 2016 20:11:10 +0000 (15:11 -0500)]
webstaff: add seed data for item status receipt template

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: link to item status print template
Galen Charlton [Wed, 30 Nov 2016 20:06:08 +0000 (15:06 -0500)]
webstaff: link to item status print template

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add printing to transit list page
Galen Charlton [Tue, 29 Nov 2016 21:34:14 +0000 (16:34 -0500)]
webstaff: add printing to transit list page

Adds a 'Print Transits' button and a transit_list print template. Using
the button prints _all_ transits that match the filter criteria, not just
the ones that happen to be displayed on the table.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: Allow persistent op change
Mike Rylander [Tue, 29 Nov 2016 21:29:48 +0000 (16:29 -0500)]
webstaff: Allow persistent op change

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: We need the md5 functions everywhere now, move the <script> up to base_js
Mike Rylander [Tue, 29 Nov 2016 21:20:33 +0000 (16:20 -0500)]
webstaff: We need the md5 functions everywhere now, move the <script> up to base_js

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: Display issue with operator change
Mike Rylander [Tue, 29 Nov 2016 21:08:17 +0000 (16:08 -0500)]
webstaff: Display issue with operator change

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: improve default search lib/preferred lib selectors
Galen Charlton [Wed, 16 Nov 2016 11:39:56 +0000 (06:39 -0500)]
webstaff: improve default search lib/preferred lib selectors

These selectors now better indicate when a value has not
been set yet.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix "nodefault" attribute for egOrgSelector
Galen Charlton [Wed, 16 Nov 2016 11:34:54 +0000 (06:34 -0500)]
webstaff: fix "nodefault" attribute for egOrgSelector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add print action and template for item status page
Galen Charlton [Wed, 16 Nov 2016 10:54:25 +0000 (05:54 -0500)]
webstaff: add print action and template for item status page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: move print button for in-house use page
Galen Charlton [Wed, 16 Nov 2016 10:31:06 +0000 (05:31 -0500)]
webstaff: move print button for in-house use page

Move it to the lower-right-hand corner to be consistent
with other circulation interfaces.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: another addition to seed data for print template previews
Galen Charlton [Wed, 16 Nov 2016 10:26:39 +0000 (05:26 -0500)]
webstaff: another addition to seed data for print template previews

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add more seed data for print template previews
Galen Charlton [Wed, 16 Nov 2016 10:21:10 +0000 (05:21 -0500)]
webstaff: add more seed data for print template previews

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix some thinkos in print templates
Galen Charlton [Wed, 16 Nov 2016 10:20:41 +0000 (05:20 -0500)]
webstaff: fix some thinkos in print templates

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: teach print templates admin about three existing templates
Galen Charlton [Wed, 16 Nov 2016 08:18:53 +0000 (03:18 -0500)]
webstaff: teach print templates admin about three existing templates

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add print template and action for in-house uses list
Galen Charlton [Wed, 16 Nov 2016 08:07:22 +0000 (03:07 -0500)]
webstaff: add print template and action for in-house uses list

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add support for per-template printer contexts
Galen Charlton [Wed, 16 Nov 2016 06:53:45 +0000 (01:53 -0500)]
webstaff: add support for per-template printer contexts

Per-template printer contexts can now be set, imported, exported,
and passed along to Hatch during printing.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix support of the disabled automatic print attempt type list
Galen Charlton [Wed, 16 Nov 2016 05:34:06 +0000 (00:34 -0500)]
webstaff: fix support of the disabled automatic print attempt type list

This patch ensures that the disabled automatic print attempt type list
setting is now honored. In addition, if bill payment receipts are
disabled via the setting, the "Receipt on Pay" and "# Copies" widgets
are not displayed on the bill payment page.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix misalignment of ‡ in MARC editor
Galen Charlton [Mon, 28 Nov 2016 16:55:24 +0000 (11:55 -0500)]
webstaff: fix misalignment of ‡ in MARC editor

This patch sets the font used to display the "‡" character in the
MARC editor to the same font used for input fields, fixing a
vertical misalginment that displayed in Chrome and Firefox
on some platforms.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: Clean up dojo idiom use for chome happiness
Mike Rylander [Mon, 28 Nov 2016 16:31:03 +0000 (11:31 -0500)]
webstaff: Clean up dojo idiom use for chome happiness

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: honor sticky-setting org by calling onchange handler; have newer holdings...
Mike Rylander [Wed, 23 Nov 2016 17:37:39 +0000 (12:37 -0500)]
webstaff: honor sticky-setting org by calling onchange handler; have newer holdings service requests cancel ongoing older ones

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoDocs: 2.11 Release Note corrections and clarifications.
Kathy Lussier [Thu, 5 Jan 2017 18:55:49 +0000 (13:55 -0500)]
Docs: 2.11 Release Note corrections and clarifications.

Fixes several typos in the 2.11 Release Notes and in the template for release
notes acknowledgements. Also resets the acknowledgements as TODOs for the
next release. Added clarification to the email checkout receipts to let users
know that email receipts are not available in the XUL client, but only in the
web client.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoDocs: Add "export non-imported records"
Remington Steed [Thu, 5 Jan 2017 15:03:48 +0000 (10:03 -0500)]
Docs: Add "export non-imported records"

This commit briefly describes the queue actions, summary and filter
sections of the Inspect Queue page in Vandelay, as well as explaining
the new "Export Non-Imported Records" action. This commit includes
updated screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 years agoLP#1651808: avoid a class of intermittent search failures
Galen Charlton [Wed, 21 Dec 2016 21:32:26 +0000 (16:32 -0500)]
LP#1651808: avoid a class of intermittent search failures

This patch fixes a bug where catalog searches can sometimes fail
with a PostgreSQL error that looks like this:

ERROR: type of parameter 56 (double precision) does not match that when preparing the plan (numeric)
CONTEXT: PL/pgSQL function search.query_parser_fts(integer,integer,text,integer[],integer[],integer,integer,integer,boolean,boolean,boolean,integer) line 319 at assignment

In particular, it ensures that the relevance values are coerced
to the Pg NUMERIC data type regardless of how the core query is
constructed; otherwise, it can sometimes end up as a double
precision value.  Because of how Pg backends cache query plans,
that change of type can result in the error above.

To test
-------
[1] (Optional) Configure the max_children values for open-ils.storage
    to permit only one drone, which in turn forces all catalog
    search requests to go through a single Pg backend.
[2] Set the default_preferred_language_weight opensrf.xml setting
    to 0.
[3] Perform a catalog search that has just a filter, e.g.,
    item_lang(eng).
[4] Perform a catalog search that includes search term, e.g.,
    cats
[5] The second search should fail.
[6] Apply the patch and try steps 3 and 4 again; this time, both
    searches should work.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agofixing formatting in supercat docs
Jane Sandberg [Tue, 20 Dec 2016 18:07:46 +0000 (10:07 -0800)]
fixing formatting in supercat docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoDocs: Adding information about Supercat and UnAPI
Jane Sandberg [Tue, 20 Dec 2016 17:32:34 +0000 (09:32 -0800)]
Docs: Adding information about Supercat and UnAPI

3 years agoLP#1586509 Bug fix to LP#1352542 caused extraneous blank line to appear in
Dan Pearl [Thu, 2 Jun 2016 19:17:44 +0000 (15:17 -0400)]
LP#1586509 Bug fix to LP#1352542 caused extraneous blank line to appear in
spine label.  This affected LC call numbers that had only one cutter number
plus additional text following.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1594937 Fix off-by-one display of closed dates
Dan Scott [Mon, 12 Dec 2016 21:13:00 +0000 (16:13 -0500)]
LP#1594937 Fix off-by-one display of closed dates

The switch to toISOString() to format dates introduced an off-by-one error in
the closed dates display, showing one extra day of closure due to the timezone
being ignored in toISOString().

toLocaleDateString() is the future of locale-sensitive date formats. In XUL,
because it is an old version of Firefox, it lacks locale sensitivity, but for
the purposes of the web staff client it's a good base to build on as even
Internet Explorer supports the locale and options arguments as of IE 11.

And for the immediate purposes of showing the right dates in the closed dates
editor, it works.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP#1432753 Restore "All day" verbiage to Closed Dates editor
Dan Scott [Mon, 12 Dec 2016 20:39:08 +0000 (15:39 -0500)]
LP#1432753 Restore "All day" verbiage to Closed Dates editor

Commit ede7e78925 replaced the JSAN calls to util.date.formatted_date() with
inline date/time handling, in the process returning times with granularity to
the minute instead of to the second. This resulted in the test for "all day"
closings always failing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoDocs: LP1268054 add patron purchase request doc
Jane Sandberg [Fri, 9 Dec 2016 05:31:25 +0000 (21:31 -0800)]
Docs: LP1268054 add patron purchase request doc

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoDocs: Making sure that image filenames don't include . character, as this can cause...
Jane Sandberg [Thu, 1 Dec 2016 18:47:20 +0000 (10:47 -0800)]
Docs: Making sure that image filenames don't include . character, as this can cause some versions of a2x to fail

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoDocs: fixing missing anchor
Jane Sandberg [Thu, 1 Dec 2016 18:32:41 +0000 (10:32 -0800)]
Docs: fixing missing anchor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1522599 add visual indicator for an expired patron
Billy Horn [Wed, 5 Oct 2016 17:41:33 +0000 (10:41 -0700)]
LP#1522599 add visual indicator for an expired patron

Add checkAlerts to getPrimary
Add alert styling to index patron for any active alert
Add alert styling to expire date in patron summary

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: Allow ACQ catalog and link-to-record, er, links to work in a browser
Mike Rylander [Tue, 22 Nov 2016 15:03:16 +0000 (10:03 -0500)]
webstaff: Allow ACQ catalog and link-to-record, er, links to work in a browser

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: language tweak in Bill History receipt
Jason Etheridge [Tue, 22 Nov 2016 12:41:25 +0000 (07:41 -0500)]
webstaff: language tweak in Bill History receipt

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: add import and export of print templates
Galen Charlton [Wed, 16 Nov 2016 02:36:15 +0000 (21:36 -0500)]
webstaff: add import and export of print templates

The workstation print template page now has Import
and Export buttons to import or export any customized
templates from/to JSON files. Toasts are emitted
on import success or failure and export failure (if
there are no customized templates to export).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: teach egJsonExporter about generators
Galen Charlton [Wed, 16 Nov 2016 02:20:24 +0000 (21:20 -0500)]
webstaff: teach egJsonExporter about generators

This patch adds an attribute called 'generator' to the eg-json-exporter
directive as an alternative to using 'container' to pass a JavaScript
object. 'generator' should be a function that returns a promise with
the data to be exported.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: tweak default Hold Shelf List print template
Jason Etheridge [Mon, 21 Nov 2016 13:57:58 +0000 (08:57 -0500)]
webstaff: tweak default Hold Shelf List print template

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix template ref for Holds for Bib Record
Jason Etheridge [Mon, 21 Nov 2016 13:09:19 +0000 (08:09 -0500)]
webstaff: fix template ref for Holds for Bib Record

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: alphabetize entries on acq admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:43:53 +0000 (18:43 -0500)]
webstaff: alphabetize entries on acq admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: improve column collapse on acq admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:42:15 +0000 (18:42 -0500)]
webstaff: improve column collapse on acq admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: improve column collapse on server admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:38:39 +0000 (18:38 -0500)]
webstaff: improve column collapse on server admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: improve column collapse on local admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:30:33 +0000 (18:30 -0500)]
webstaff: improve column collapse on local admin splash page

With this patch, when the local admin splash page is displayed
on small screens, the three columns are stacked better. E.g.,

A  D  G
B  E  H
C  F

becomes

A
B
C
D
E
F
G
H

rather than

A
D
G
B
E
H
C
F

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoadd Print Bills to Bill History
Jason Etheridge [Thu, 17 Nov 2016 20:38:17 +0000 (15:38 -0500)]
add Print Bills to Bill History

FIXME: duplicated a code chunk, should probably refactor into a shared printBills
FIXME: disable actions or make otherwise obvious that they only work on selected rows

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix Payment Method in receipt
Jason Etheridge [Thu, 17 Nov 2016 19:39:22 +0000 (14:39 -0500)]
webstaff: fix Payment Method in receipt

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: toast on volume/copy template save and delete
Galen Charlton [Tue, 15 Nov 2016 22:14:54 +0000 (17:14 -0500)]
webstaff: toast on volume/copy template save and delete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: fix a couple thinkos is vol/copy template editor
Galen Charlton [Tue, 15 Nov 2016 21:59:21 +0000 (16:59 -0500)]
webstaff: fix a couple thinkos is vol/copy template editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff: tweaks to egPrint
Galen Charlton [Tue, 15 Nov 2016 20:40:39 +0000 (15:40 -0500)]
webstaff: tweaks to egPrint

This patch attempts to unbreak receipt and CSV printing
by fetching and injecting the print CSS into a style element,
as a link element in the print div doesn't seem to get
processed.  It also automatically clears the content
of the print div so that after you print a receipt, the
browser print command will print the page, not the receipt.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agowebstaff transit list: switch to egGridFlatDataProvider
Galen Charlton [Tue, 15 Nov 2016 19:27:20 +0000 (14:27 -0500)]
webstaff transit list: switch to egGridFlatDataProvider

This gets us sorting "for free", or at least more easily than
with a custom-written data provider.  The following fields
are marked sortable for now:

- barcode
- title
- source library
- destination library
- send date/time

Because egGridFlatDataProvider gives us flattened hashes, not
fieldmapper objects, various tweaks were required to compensate.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agobetter idea with Check Number
Jason Etheridge [Mon, 14 Nov 2016 21:44:25 +0000 (16:44 -0500)]
better idea with Check Number

unset default Check Number, disable widget if not Check Payment,
and disable Apply Payment button if Check Payment with invalid Check Number

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>