By default some of the perm groups do not have their
application_perm in the perm_list. This adds them.
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Jason Etheridge [Fri, 8 Nov 2013 19:12:43 +0000 (14:12 -0500)]
remove XUL @persist from list column definitions
We moved away from @persist a long time ago, but some cruft remained. This
would cause a local file, localstore.rdf, to balloon in size as columns were
adjusted in XUL-based lists. Since this is an XML file, writing and parsing
it can get very expensive if the file grows too large, which it has done for
some people.
This change keeps that file from growing further based on these list columns,
but it may be worth deleting the localstore.rdf file or creating a new staff
client profile (uninstalling and reinstalling the staff client DOES NOT
accomplish this).
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Mon, 17 Mar 2014 17:03:49 +0000 (13:03 -0400)]
LP#1253163: Make authority functions more truthful
One discovery we made on this bug was that PG can break if we
conveniently label functions as IMMUTABLE when they are now. Let's
go ahead and reclass some authority functions as STABLE STRICT to
better fit reality.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
There seems to be a bug in Postgres 9.3+ that does not like the
circuitous route we take to indexing authority headings. So, we
get around this by storing the actual heading values instead of
indexing a function over the MARC.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Mike Rylander [Mon, 3 Mar 2014 19:07:42 +0000 (14:07 -0500)]
LP#1243023: Teach oils_xpath() to decode specific enties in text nodes
Because of a behavioral change in Postgres' XML code (specifically, when
casting XML as TEXT, the Famous Five XML entities are not decoded), we
are seeing doubled encodings in XML and HTML output, as well as in indexed
data. To combat this, we will now check the first character of each
array element returned by XPATH() and, if it is not '<', we will decode
the entities ourselves.
Also included in this commit is some cleanup of the surrounding file
content, which was just confusing and useless in the modern era.
The contents of his commit, followed by:
=# drop function evergreen.oils_xpath(text,text,anyarray)
are enough to address the OP's complaint about browse data.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Thu, 6 Mar 2014 22:46:30 +0000 (17:46 -0500)]
LP1287967 - drop reporter.classic_current_circ view as part of 0864 upgrade
As noted in the bug description, attempts to run 0864.MVF_CRA-upgrade.sql will
fail on a database where the reporter.classic_current_circ view is present.
Add a DROP VIEW IF EXISTS and then include a note that administrators will need
to recreate the VIEW afterwards if desired.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
This patch replaces references to osrf_ctl.sh, which is deprecated
as of OpenSRF 2.3.0, with opensrf_control. It also names
2.3.0 as the minimum required version of OpenSRF.
brick_ctl.sh gets the most changes as a consequence. In particular:
* the stop_{c,perl}/[re]start_{c,perl} actions are removed, as
osrf_control behaves exactly the same when stopping or starting
services.
* the -s option for working with a single service is now documented,
and is restricted to the stop_osrf/[re]start_osrf actions
It should be noted that for brick-based setups (and other kinds of
multi-server setups) better control can be had by using opensrf_control
directly.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Back in the 2.2 days, Evergreen had code which set the
'general.useragent.override' to something like 'Mozilla/5.0 (Windows; U;
Windows NT 6.1; en-US; rv:1.9.2.25) Gecko/20111212 oils_xulrunner
/xul/rel_2_2_0/server/'. For anyone who once had a 2.2 client installed
and upgraded from it, this setting persists (this is the situation for
most stations in our library).
Since this string does not match the new test for 'open_ils_staff_client'
in the useragent, these clients are not properly streaming requests. This
problem was most easily noticed in Vandelay progress bars (they always
jumped from 0% to 100%).
This commit adds the code provided by Bill Erickson in the LP bug
comments. To test it, you can add the 'general.useragent.override'
setting to your staff client with any value (using the 'about:config'
interface), then run this code and check that your setting is gone.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Due to slightly different and more strict disabiguation rules
for parameters and column names in PLPGSQL in modern versions
of Postgres, our hold matrix functions were failing in 9.3.
This commit attempts to address that by declaring and using
aliases for parameters that share names with columns used in
in-line SQL.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Fri, 7 Mar 2014 20:48:35 +0000 (15:48 -0500)]
LP#1284864: Don't leak deleted constituent records
There were times when deleted constituent records were leaking into
the display of metarecord results. In particular, when a metarecord's
lead record was deleted, the lead was not recalculated. We address
this situation directly now in the remapper.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 4 Mar 2014 15:42:22 +0000 (10:42 -0500)]
LP#1284864 repair MR hold possibilty depth calculation
Fixes a bug where the hold possibility checks for metarecords used the
depth of the selection OU instead of depth 0 when no depth was defined.
This prevented holds from being placed in some instances, particularly
when no hold boundaries were defined (or equaled zero).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The number of constituent records for a metarecord during searching is
now consitently based on the presence of an opac visible copy and not a
holdable copy. This affects the constituent record counts in MR results
lists and the records displayed in the constituent records list. (Icons
were already checking visibility instead of holdability).
Holdable formats are still derived from records with holdable copies.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Remove unnecessary code to fetch the MR master when compiling MR
constituent records lists, since the master record was slipping into the
results set, where it should not have been. This code is unneeded and
is a holdover from an earlier experiment.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
* Repair format icons for MR and non-MR holds
* Allow all filters to be cleared from a MR hold (w/o resulting in a
server error).
* during editing, if a hold has a selection_depth, use that to further
limit the available formats and languages in the edit selectors.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 27 Feb 2014 21:27:55 +0000 (16:27 -0500)]
LP#1284864 metarecord filtered constituent record counts
Ensure the count of constiuent records in the MR results lists is
derived from the filtered record set (search org, depth, holdable, etc.)
and not all records.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 26 Feb 2014 15:35:25 +0000 (10:35 -0500)]
LP#1284864 TPAC format selector attribute / values
Creates a new search_format record attribute, which is responsible for
driving the catalog search format selector. The values are derived from
the icon_format attriute, with a few notable changes (for starters).
1. The 'book' search_format contains large print and has the label "All
Books".
2. The 'music' search_format contains all music, regardless of sound
record format (or other attributes) and has the label "All Music"
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 25 Feb 2014 21:47:03 +0000 (16:47 -0500)]
LP#1284864 TPAC metarecord display record count in results
Next to each metarecord containing more than one record, display the
count of constituent records next to the record title in parentheses.
This allows the user to see at a glance if a record is really grouped or
simply a single-record "group".
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 25 Feb 2014 20:33:32 +0000 (15:33 -0500)]
LP#1284864 display code value code in composite def builder
When selected code values to add to a composite definition in the coded
value map composite def. editor, display both the label and the code, as
many people or more familiar w/ the codes than the labels.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The preamble to the installation instructions, intended for
developers, is a bit unclear. The instructions describe actions
that should take place at two different points in the installation.
This commit moves the instructions to download and install the Dojo
Toolkit until after the opensrf Linux user already owns the
/openils directory. It also adds the appropriate note for non-devs
to skip this section.
Signed-off-by: Elliot V <evoris@slcconline.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
Mike Rylander [Fri, 14 Feb 2014 17:01:37 +0000 (12:01 -0500)]
LP1272316 - Calculate proximity in the DB for speed
We need to calculate and store a (potenially adjusted) proxmity for
each hold and copy for use in targetting and optimization of op
capture. Before this commit, we do that within the hold target
code itself. Now we'll do it when the hold-copy map is inserted,
because we have the same information available at that time as we
have in the targeter. This will both speed up the apparent cost of
the calculation, because it avoids the cost of a network round-trip,
and the total number of SELECTs we must issue, because the proximity
value will now be cached for use by the proximity map function.
Backward compatability is retained for the create_prox_map() function
in case any other code is depending on that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Thu, 6 Jun 2013 15:13:35 +0000 (11:13 -0400)]
LP#1179660: remove call to undefined initialize func
Remove call to nonexistant function Search::Z3950->initialize. Prior to
now, this would have quietly failed, but with AUTOLOAD to be removed
from OpenSRF, it would fail with full shock and awe.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Search.pm
* Adds a new blu-ray format for icon and metarecord holds
* Remove large-print items from the generic "book" attribute for icons
and holds.
For icons, this means we will no longer see two icons displayed for a
single large-print book.
For holds, this means that to receive a large-print book, one has to
select the large-print book format. "book" alone will not result in
a large-print item being targted.
Note that when building a data set for the format selector drop-down,
it might make sense to keep large-print items in the generic "book"
format. That'll come later.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
When selecting a record from the list of metarecord constituents, the
paging controls (start/previous/next/end) within the staff client should
page through the constiuents, not the original search.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Wed, 19 Feb 2014 22:11:29 +0000 (17:11 -0500)]
LP#1053397: Use the new data structures for looking up language indexing configuration
Also, from Dan Wells:
First, we don't want to fully exclude records which don't have a
metabib.record_attr_vector_list entry, so we do a LEFT JOIN instead
for that table. Otherwise, some records error out when ingesting
(see placeholder record -1 in the stock data set).
Second, let's add a check for 'active' which appears to have been
always missing.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
We were leaking memory in a PLPGSQL function that compiles the
query_int from a ccraed value. Stop doing that!
Also, implement a self-invalidating (upon table update) cache
for compiled composite attr defs. This brings concerto reingest
down from 50+ seconds to under 10.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Mon, 17 Feb 2014 20:08:11 +0000 (15:08 -0500)]
LP#1053397 catch-all 'music' icon_format attribute value
Many records in the Evergreen sample data have item_type=j and no sound
recording format. This seems likely to happen in the wild, as well.
The new coded value captures everying with item_type=j and no sr_format.
Also included is a "music.png" icon, which looks like a pair of happy
eigth notes.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Only limit the scope of the MR attributes in the presence of a hard hold
boundary when searching for which attributes to display in the hold
placement form.
In other words, don't limit the attributes based on search parameters,
since searching at Branch 1 does not necesssarily meany you only want to
place holds on formats available at branch 1.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 14 Feb 2014 19:34:02 +0000 (14:34 -0500)]
LP#1053397 apply org scope to metarecord attributes
When loading record attributes (cra, ccvm, etc.) for constituent
records, limit the attributes to those contained by records which have
holdings within the provided (search) scope.
With this, for example, a search at Branch 1 for metarecords will only
show format icons for constituent records that have holdings at BR1.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remove the item_form != d component of the "book" composite definition.
I think this more closely matches how humans would interpret it.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql
API, TPAC backend, and UI bits for TPAC metarecord searching and holds.
* Group Formats and Editions options in advanced search / searchbar
* MR holds placement form, allowing selected formats and languages
* MR holds targeting updated to work w/ new holdable formats composite
definitions
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
The UI for a coded value map is accessed from an existing coded value
via a new "Manage" link column in the CCVM table. The UI allows staff
to build tree-shaped boolean composite definitions for CCVMs in terms
of existing CCVMs.
Additionally, the record attribute definition UI now has a link from
each definition to the coded value map page for the attribute.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
QP Needs to be made aware of several new structures in the database.
First, we have added a new sort-supporting table called metabib.record_sorter
which holds values extracted by crad.sorter=true attrs. This is used instead
of the mrd.attrs->"something" hstore composite.
Next, we teach QP how to convert from a list of user-supplied values across
many dynamic filters (based on crad) into an intarray query of ids extracted
from config.coded_value_map (in the case of controlled attributes) or
metabib.uncontrolled_record_attr_value (in the case of, you guessed it,
uncontrolled attributes). This query is applied against the vlist column
of metabib.record_attr_vector_list, which is GIN indexed for speed.
Finally, metabib.record_attr is now a view over metabib.record_attr_vector_list
and is consequently going to be slow for general use. We restrict
its inclusion in the core query to only the case of a during() filter
which requires access to the value of a bib's Date2 field. For the
other common case, requiring access to the Date1 field, we instead
use the pubdate sort value now stored in metabib.record_sorter. We
might consider making the specific sorter attribute used configurable
so that we can change the definition of pubdate down the road, but it
starts out (and generally stays) defined as equivalent to Date1.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Wed, 15 Jan 2014 18:17:39 +0000 (13:17 -0500)]
LP#1269911: Teach the IDL about MVF- and CRA-related structures
IDL link from ccvm => ccraed via composite_def field
IDL selector attribute for ccvm class
ccraed gets CUD actions
In conify/global/config/coded_value_map, if the selected attr type is
composite=true, show a link from each coded value to manage the
composite definition.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
* Teach vandelay.marc21_physical_characteristics() to see all 007's
We use vandelay.marc21_physical_characteristics() to extract fixed
field data that lives in the 007. Before this change, it would
only look at the first 007 in the record. Now it will look at
all of them in turn, supporting configurations such as DVD+BluRay.
* Add intarray extension
We need intarray for GIN index support of integer arrays, which is
how we'll be storing the in-use record attribute value identifiers.
* Hidy hole in which to stick "uncontrolled" values
In order to make use of the massive speed increases provided by
intarray indexing, we need to use (you guessed it) integers. But
uncontrolled record attributes are not necessarily (or even very
often) numbers. We will store them in a table of unique (per
attribute) values, and use the id from that table in our intarray
indexing. That id comes from a DECREMENTING serial that starts
at -1 and counts downward. This avoids collision with the other
set of integers (the id from config.coded_value_map) that we will
use for controlled record attribute values.
* Add a multi flag for record attrs
We pre-coordinate which record attrs are allowed to be multi-valued
with this new bool. Most can be, we set the default to true and
adjust the seed data for those that should be false (sorters and
fields in the leader).
* New intarray-focused attribute extraction
We rewrite the record attribute extraction to capture all the
record-supplied values for each attribute (where multi is true)
and store that list in the new (fkey-corrected) metabib.record_attr_vector_list
table. Only filters make it into this table.
We also insert a parameter after the record id to accept a list of
record attributes we want to rewrite. This defaults to NULL to rewrite
all of them.
Sorters are stored in a new, separate table built specifically for them.
metabib.record_attr becomes a vew atop metabib.record_attr_vector_list
which expands the intarray stored therein into an hstore. For
multi=true attributes, only one will be returned through this view,
as is HSTORE's way, and which will be returned is undefined. However
this view is only provided for the purpose of backward compat with
reports or other locally defined logic.
And, finally, baseline seed data
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Support Stripe payments with some new code and some rearranged code ...
... behind the open-ils.circ.money.payment method.
- Also add Business::Stripe as a CPAN module to the pre-reqs installers.
- If payment processor is Stripe, only show form if Javascript enabled.
Our implementation of payments via Stripe doesn't work without Javascript.
That's part of the point. Using Stripe really limits a site's worries
about PCI compliance because users' credit card number and security
codes are never transmitted to the [Evergreen] server at all. That data
goes to Stripe instead (using Javascript) and from that we get back a
one-time token from Stripe to give to our server instead.
Thanks to Jason Boyer at the Indiana State Library for recognizing the
value of supporting approaches like that in Evergreen and for starting
the work.
projects / working / Evergreen.git / log