10 years agoMerge branch 'master' of git+ssh://
berick [Fri, 18 Feb 2011 14:38:53 +0000 (09:38 -0500)]
Merge branch 'master' of git+ssh:// into opac-tt-poc

10 years agows_ou may be null in an opac context, fall back to home org
erickson [Fri, 18 Feb 2011 14:35:06 +0000 (14:35 +0000)]
ws_ou may be null in an opac context, fall back to home org

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoallow users to see their own payments w/o perm
erickson [Fri, 18 Feb 2011 14:35:05 +0000 (14:35 +0000)]
allow users to see their own payments w/o perm

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoretain ability for a user to see his/her own payments and open transactions
erickson [Fri, 18 Feb 2011 14:35:04 +0000 (14:35 +0000)]
retain ability for a user to see his/her own payments and open transactions

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMore user transaction retrieval API cleanup
erickson [Fri, 18 Feb 2011 14:35:03 +0000 (14:35 +0000)]
More user transaction retrieval API cleanup

Use consistent xact fleshing mechanism for circulations both for
less/cleaner code and to consistently take advantage of CSToreEditor for
authoritative support.

Added .flesh option to transaction history api calls, consistent with
non-history version.

Added a have_payments history call so we can limit retrieval to xacts
that had at least 1 payment

When making sub-req calls to payment API calls, call .authoritative as

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowhile we're at it, condense the js/css/images deflat and cache control into 1 block
berick [Fri, 18 Feb 2011 14:14:18 +0000 (09:14 -0500)]
while we're at it, condense the js/css/images deflat and cache control into 1 block

10 years agounder /eg/opac, expire html immediately to pick up dynamic data; set public cache...
berick [Fri, 18 Feb 2011 14:08:51 +0000 (09:08 -0500)]
under /eg/opac, expire html immediately to pick up dynamic data;  set public cache-control on general images/css/js content

10 years agoafter auth expire time, redirect to logout page (which ultimately redirects home...
berick [Fri, 18 Feb 2011 14:04:32 +0000 (09:04 -0500)]
after auth expire time, redirect to logout page (which ultimately redirects home) to force removal of the stale auth cookie

10 years agoBolster SendEmail Reactor's handling of UTF-8 content
dbs [Fri, 18 Feb 2011 05:44:11 +0000 (05:44 +0000)]
Bolster SendEmail Reactor's handling of UTF-8 content

Use the Encode module and encode_utf8() instead of utf8 and utf8::encode.
The utf8 module is meant for enabling UTF-8 content in source code.

Also, add the MIME-Version / Content-type / charset headers that
some mail user agents need to know that they're dealing with Unicode

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBooking: fix the targeter in the I'm-reserving-this-exact-resource-with-this-
senator [Thu, 17 Feb 2011 20:53:36 +0000 (20:53 +0000)]
Booking: fix the targeter in the I'm-reserving-this-exact-resource-with-this-
exact-barcode case.

It should have always worked like this. This should better mirror the behavior
in the holds targeter when placing a copy-level hold.  Basically don't fail
to target a resource for a reservation later just because it's not in an
available status right at this moment.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobasic search classes work (except cn)
senator [Thu, 17 Feb 2011 20:15:33 +0000 (15:15 -0500)]
basic search classes work (except cn)

Not sure what would happen on a KCLS environment. Need to test.
bibcn nor cn do what I mean in my dev environment.

10 years agoAvoid mixed-content warnings due to HTTP link for Google Chrome Frame
dbs [Thu, 17 Feb 2011 18:55:31 +0000 (18:55 +0000)]
Avoid mixed-content warnings due to HTTP link for Google Chrome Frame

We're hardcoding this to HTTPS for now to avoid the mixed-content warnings that
occur when content location is https:// and the linked script is at http:// but
a config-aware patch probably wouldn't be a bad idea.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agovestigial 2nd param to session.retrieve from opac now actually changes the behavior...
erickson [Thu, 17 Feb 2011 18:35:06 +0000 (18:35 +0000)]
vestigial 2nd param to session.retrieve from opac now actually changes the behavior (see r19447) in an unexpected way, remove

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoforce new layout changes into advanced search page
senator [Thu, 17 Feb 2011 18:24:35 +0000 (13:24 -0500)]
force new layout changes into advanced search page

The advanced search page doesn't yet work, but should soon.

10 years agomake the zero-hits case work for search results
senator [Thu, 17 Feb 2011 14:18:53 +0000 (09:18 -0500)]
make the zero-hits case work for search results

10 years agoCSS hook for check-in failures with selfcheck
phasefx [Thu, 17 Feb 2011 04:18:27 +0000 (04:18 +0000)]
CSS hook for check-in failures with selfcheck

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoTeach maintain_901 trigger to respect the "Use record ID for TCN" global flag
dbs [Thu, 17 Feb 2011 03:27:53 +0000 (03:27 +0000)]
Teach maintain_901 trigger to respect the "Use record ID for TCN" global flag

Rather than relying on the Perl layer to set the correct TCN on the way in,
do it as part of the in-database indexing to ensure that we have consistent
results no matter how the record gets into the database.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocrummy paging in the record pages' copy listing
senator [Wed, 16 Feb 2011 22:23:16 +0000 (17:23 -0500)]
crummy paging in the record pages' copy listing

10 years agoPatch based on work by Dan Wells to improve Opera BibTemplate support
miker [Wed, 16 Feb 2011 22:20:53 +0000 (22:20 +0000)]
Patch based on work by Dan Wells to improve Opera BibTemplate support

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocopy details in the right place in the layout; some hide_me's sprinkled
senator [Wed, 16 Feb 2011 22:04:02 +0000 (17:04 -0500)]
copy details in the right place in the layout; some hide_me's sprinkled
around for now

10 years agoPatch from Thomas Berezansky to implement circulation matchpoint value fallthrough...
miker [Wed, 16 Feb 2011 20:47:11 +0000 (20:47 +0000)]
Patch from Thomas Berezansky to implement circulation matchpoint value fallthrough, whereby specific rules can inherit values from generic rules.

Background, taken from

Make the things returned (circulate, duration_rule, recurring_fine_rule, max_fine_rule, hard_due_date, total_copy_hold_ratio, available_copy_hold_ratio and renewals) "fall through" when set to NULL.

The circ matrix edit screen has had some changes too, partially for showing "Inherited" in some places where appropriate, partially for field ordering and editing display and consistency. The fields that show up earlier contribute to tests that will be applied to the circulation attempt, while the "results" that do not change what rows are considered are grouped at the end.


You can override a subset of those fields with a specific rule while allowing broader rules to fill in the holes.
This may result in less duplication of information across rules, making things easier to maintain.
Thus, this may result in less rules in general, and thus less processing time on sorting them overall.


Manually figuring out the specifics of what will happen will take more time/effort.
Changing a single rule may have a greater unintended effect on other rules.
Staff would need training for when to have a rule fall through and when to set it specifically.
More time to return from the DB for any rule that is "falling through" to broader rules.

Examples for the following org tree:


Implementing the following "business" rules:

At the CONS level:
By default, everything circulates, uses DFLT_DUR duration, DFLT_RFINE recurring fine, and DFLT_MFINE max fine.
Circ Modifier "book" uses the duration BOOK_DUR
Reference flagged materials don't circulate

At the SYSA level there are no special rules.

At the SYSB level the max fine should be SYSB_MFINE.

At the LIBC level the recurring fine is LIBC_RFINE

At the LIBD level circ modifier "book" uses the DFLT_DUR duration instead of "BOOK_DUR"

At the LIBE level reference flagged materials circulate.

At the LIBF level there are no special rules.

The current method would require the following circ rules to implement those business rules:


16 circ rules total.

The new method would require the following circ rules to implement those business rules:


7 circ rules total.

Starting with the above, lets assume that SYSA wants to change their recurring fine to SYSA_RFINE.
LIBC's recurring fine is to be unchanged.

The current method requires the following changes:

ADD the following entries:

UPDATE the LIBD entries:

4 rules added, 2 changed, total is now 20 rules.

The new method would require the following changes:

ADD the following entry:

1 rule added, 0 changed, total is now 8 rules.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Thomas Berezansky to make many older OU setting types i18n friendly
miker [Wed, 16 Feb 2011 20:21:17 +0000 (20:21 +0000)]
Patch from Thomas Berezansky to make many older OU setting types i18n friendly

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorealign trunk permission numbering with 2.0
miker [Wed, 16 Feb 2011 19:52:20 +0000 (19:52 +0000)]
realign trunk permission numbering with 2.0

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomore i18n, minor cleanup
berick [Wed, 16 Feb 2011 17:13:59 +0000 (12:13 -0500)]
more i18n, minor cleanup

10 years agoMerge branch 'opac-tt-poc' of git+ssh://
berick [Wed, 16 Feb 2011 16:26:56 +0000 (11:26 -0500)]
Merge branch 'opac-tt-poc' of git+ssh:// into opac-tt-poc

10 years agoadded option to open-ils.auth.session.retrieve to return the full cached object,...
erickson [Wed, 16 Feb 2011 15:07:04 +0000 (15:07 +0000)]
added option to open-ils.auth.session.retrieve to return the full cached object, which includes the auth time (cache timeout) of the cached user object

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd a note for future work for full hold count coverage
miker [Tue, 15 Feb 2011 20:49:37 +0000 (20:49 +0000)]
Add a note for future work for full hold count coverage

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowho needs this much noise in the javascript console? javascript.options.strict =...
phasefx [Tue, 15 Feb 2011 19:00:47 +0000 (19:00 +0000)]
who needs this much noise in the javascript console? javascript.options.strict = false

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocapture credit card order_number
erickson [Mon, 14 Feb 2011 21:06:51 +0000 (21:06 +0000)]
capture credit card order_number

Uunique payment transaction ID for online payments

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomore i18n goodness
Bill Erickson [Mon, 14 Feb 2011 18:56:35 +0000 (13:56 -0500)]
more i18n goodness

10 years agoavoid undef warnings
Bill Erickson [Mon, 14 Feb 2011 18:32:22 +0000 (13:32 -0500)]
avoid undef warnings

10 years agowhen authenticated, force the page to redirect the home page after the auth time...
Bill Erickson [Mon, 14 Feb 2011 18:31:50 +0000 (13:31 -0500)]
when authenticated, force the page to redirect the home page after the auth time has expired to protect patron data and  prevent potentially confusing post-search-submit redirects

10 years agoMerge branch 'master' of git+ssh://
Bill Erickson [Mon, 14 Feb 2011 18:05:23 +0000 (13:05 -0500)]
Merge branch 'master' of git+ssh:// into opac-tt-poc

10 years agoupdated cstoreditor to fetch full cached object to get the authtime; capturing authti...
Bill Erickson [Mon, 14 Feb 2011 18:03:24 +0000 (13:03 -0500)]
updated cstoreditor to fetch full cached object to get the authtime; capturing authtime in the web context

10 years agoadded option to open-ils.auth.session.retrieve to return the full cached object,...
Bill Erickson [Mon, 14 Feb 2011 17:36:25 +0000 (12:36 -0500)]
added option to open-ils.auth.session.retrieve to return the full cached object, which includes the auth time (cache timeout) of the cached user object

10 years agoadded sub to collect the HTML version of a record for display
Bill Erickson [Mon, 14 Feb 2011 16:47:57 +0000 (11:47 -0500)]
added sub to collect the HTML version of a record for display

10 years agohold actions work
senator [Tue, 15 Feb 2011 22:45:46 +0000 (17:45 -0500)]
hold actions work

10 years agoRenewals working, with feedback displayed
senator [Tue, 15 Feb 2011 21:10:25 +0000 (16:10 -0500)]
Renewals working, with feedback displayed

10 years agomake date format localize-able
Bill Erickson [Mon, 14 Feb 2011 11:45:55 +0000 (06:45 -0500)]
make date format localize-able

10 years agopulling in more copy fields for display; added sample code
Bill Erickson [Mon, 14 Feb 2011 11:45:40 +0000 (06:45 -0500)]
pulling in more copy fields for display; added sample code

10 years agoMerge branch 'opac-tt-poc' of git+ssh://
Bill Erickson [Mon, 14 Feb 2011 11:28:58 +0000 (06:28 -0500)]
Merge branch 'opac-tt-poc' of git+ssh:// into opac-tt-poc

10 years ago"Items Ready For Pickup" works
senator [Tue, 15 Feb 2011 18:37:47 +0000 (13:37 -0500)]
"Items Ready For Pickup" works

This uses the holds page of myopac with a special param.
Also, tiny bit of JS just to focus the username field on the login page.
Couldn't resist.

10 years agoMerge branch 'opac-tt-poc' of ssh://
senator [Tue, 15 Feb 2011 17:19:47 +0000 (12:19 -0500)]
Merge branch 'opac-tt-poc' of ssh:// into opac-tt-poc

10 years ago"format" aka item_type (?) search working, I think
senator [Tue, 15 Feb 2011 17:19:11 +0000 (12:19 -0500)]
"format" aka item_type (?) search working, I think

10 years agoJudgment call. I think this just looks better.
senator [Tue, 15 Feb 2011 15:39:16 +0000 (10:39 -0500)]
Judgment call. I think this just looks better.

10 years agomake money string localizable
berick [Tue, 15 Feb 2011 15:32:04 +0000 (10:32 -0500)]
make money string localizable

10 years agoshow grocery fines; define date format in a single location
senator [Tue, 15 Feb 2011 15:31:44 +0000 (10:31 -0500)]
show grocery fines; define date format in a single location

10 years agoheh, rolling bcak unintended addition of test code
berick [Tue, 15 Feb 2011 15:19:40 +0000 (10:19 -0500)]
heh, rolling bcak unintended addition of test code

10 years agoadded support for copy paging/sorting
Bill Erickson [Mon, 14 Feb 2011 11:28:50 +0000 (06:28 -0500)]
added support for copy paging/sorting

10 years agowhen a secure page is requested insecurely, direct to login page, then redirect to...
Bill Erickson [Mon, 14 Feb 2011 10:24:57 +0000 (05:24 -0500)]
when a secure page is requested insecurely, direct to login page, then redirect to the originally requested page after successful login.  This removes the need for explicit redirect_to and https:// in secure links

10 years agofixed holds sorting; my-account link redirects to my-account; i18n cleanup
Bill Erickson [Mon, 14 Feb 2011 09:23:46 +0000 (04:23 -0500)]
fixed holds sorting; my-account link redirects to my-account; i18n cleanup

10 years agowork on myopac fines, displayed in account summary (myopac/main)
senator [Mon, 14 Feb 2011 22:40:27 +0000 (17:40 -0500)]
work on myopac fines, displayed in account summary (myopac/main)

10 years agoMerge branch 'opac-tt-poc' of ssh://
senator [Mon, 14 Feb 2011 18:34:20 +0000 (13:34 -0500)]
Merge branch 'opac-tt-poc' of ssh:// into opac-tt-poc

10 years agomyopac: more complete display of circs, holds, and fines
senator [Mon, 14 Feb 2011 18:33:40 +0000 (13:33 -0500)]
myopac: more complete display of circs, holds, and fines

not completely complete. still developing.

10 years agoMove USE * from topnav.tt2 to new header.tt2; also some myopac work
senator [Mon, 14 Feb 2011 16:36:50 +0000 (11:36 -0500)]
Move USE * from topnav.tt2 to new header.tt2; also some myopac work

Minor progress in myopac/main and myopac/circs

10 years agoEnable MFHD tests to find their testdata
dbs [Mon, 14 Feb 2011 07:22:11 +0000 (07:22 +0000)]
Enable MFHD tests to find their testdata

When the MFHD tests wrapped in mfhd.t are invoked from outside of the directory,
they tests failed to find the mfhddata.txt file. Judicious use of the __FILE__
special literal and File::Basename::dirname() avoids that problem. Now we just
need to munge @INC to ensure that can be resolved (and hope that
no conflicts ever turn up).

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agolocalization fixed for plac hold UI
Bill Erickson [Mon, 14 Feb 2011 00:06:21 +0000 (19:06 -0500)]
localization fixed for plac hold UI

10 years agoMerge branch 'opac-tt-poc' of git+ssh://
Bill Erickson [Sun, 13 Feb 2011 23:34:10 +0000 (18:34 -0500)]
Merge branch 'opac-tt-poc' of git+ssh:// into opac-tt-poc

10 years agotemplate cleanup; localizing strings and mild style tweaks; more to come
Bill Erickson [Sun, 13 Feb 2011 23:34:02 +0000 (18:34 -0500)]
template cleanup;  localizing strings and mild style tweaks; more to come

10 years agorepiared merge conflict
Bill Erickson [Sun, 13 Feb 2011 22:49:09 +0000 (17:49 -0500)]
repiared merge conflict

10 years agohold placement works better
senator [Mon, 14 Feb 2011 15:39:54 +0000 (10:39 -0500)]
hold placement works better

10 years agomoved some code out of the main catloader module into function-specific sub-modules...
Bill Erickson [Sun, 13 Feb 2011 22:44:04 +0000 (17:44 -0500)]
moved some code out of the main catloader module into function-specific sub-modules.  Note, sub-modules still retain the OpenILS::WWW::EGCatLoader package name to ease subclassing of the top-level loader object

10 years agoTeach about record ranges
dbs [Sun, 13 Feb 2011 03:14:21 +0000 (03:14 +0000)]
Teach about record ranges

Passing --record 10,000 times at the command line sucks, and
--all is not particularly realistic for large databases. Adding
--start_id and --end_id makes this script more usable.

Also provide reasonably full POD documentation, and rely on
Pod::Usage to provide help based on it when help is requested
or passed in options don't make sense.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoNormalize ISBNs by stripping hyphens in search methods and in reporter.materialized_s...
dbs [Fri, 11 Feb 2011 21:39:48 +0000 (21:39 +0000)]
Normalize ISBNs by stripping hyphens in search methods and in reporter.materialized_simple_record

We weren't normalizing ISBNs in search or in reporter.materialized_simple_record
which required users to exactly match the form of the ISBN as entered in the
MARC record to get a successful search result - pretty hit or miss.

The longer term fix in 2.0 and above is to make the ISBN search search against
the identifier|isbn index, which also gets ISBN10/ISBN13 equivalence goodness.
But this patch will be relatively easy to backport through to 1.6.1 and plugs
some of the holes in our exposed APIs and search points in the short term.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoA start with record detail page
senator [Fri, 11 Feb 2011 20:12:52 +0000 (15:12 -0500)]
A start with record detail page

10 years agobump xulrunner version
phasefx [Fri, 11 Feb 2011 02:38:45 +0000 (02:38 +0000)]
bump xulrunner version

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPostgres 9.0 is more strict about variable names in functions. We will probably hit...
miker [Fri, 11 Feb 2011 00:49:40 +0000 (00:49 +0000)]
Postgres 9.0 is more strict about variable names in functions. We will probably hit more of these, but these in particular break the OPAC.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadvanced page doesn't need login first
senator [Thu, 10 Feb 2011 22:24:05 +0000 (17:24 -0500)]
advanced page doesn't need login first

10 years agorepaired topnav merge conflict
berick [Thu, 10 Feb 2011 16:59:50 +0000 (11:59 -0500)]
repaired topnav merge conflict

10 years agostart using a centrally hard-coded ctx.opac_root
senator [Thu, 10 Feb 2011 21:51:19 +0000 (16:51 -0500)]
start using a centrally hard-coded ctx.opac_root

10 years agothe user account "dashboard"/mini-myopac works on every page now
senator [Thu, 10 Feb 2011 21:11:37 +0000 (16:11 -0500)]
the user account "dashboard"/mini-myopac works on every page now

10 years agowhitespace and minor stuff
senator [Thu, 10 Feb 2011 19:04:56 +0000 (14:04 -0500)]
whitespace and minor stuff

10 years agoMerge branch 'opac-tt-poc' of ssh://
senator [Thu, 10 Feb 2011 18:16:00 +0000 (13:16 -0500)]
Merge branch 'opac-tt-poc' of ssh:// into opac-tt-poc

10 years agosome progress on the place_hold page; ou selector improvements, etc
senator [Thu, 10 Feb 2011 18:15:19 +0000 (13:15 -0500)]
some progress on the place_hold page; ou selector improvements, etc

10 years agologin form cleanup and implementation of login-failure handling; more to come
Bill Erickson [Thu, 10 Feb 2011 17:25:29 +0000 (12:25 -0500)]
login form cleanup and implementation of login-failure handling; more to come

10 years agoadded i18n filter support for translating text blocks via filters; more login form...
berick [Thu, 10 Feb 2011 16:56:59 +0000 (11:56 -0500)]
added i18n filter support for translating text blocks via filters; more login form cleanup; moved some global USE's into topnav

10 years agoadded support for login via barcode and persistent logins; capturing login failures...
Bill Erickson [Thu, 10 Feb 2011 16:14:41 +0000 (11:14 -0500)]
added support for login via barcode and persistent logins; capturing login failures; use cache infrastructure for fetching/caching cmf objects

10 years agoPatch from Thomas Berezansky addressing his recent dynamic circ/hold field weighting...
miker [Thu, 10 Feb 2011 14:56:01 +0000 (14:56 +0000)]
Patch from Thomas Berezansky addressing his recent dynamic circ/hold field weighting patch.

Due to an oversight of auto-casting on my part dynamic weighting may incorrectly order similar rows that differ only in org unit or permission group.

Bad me for not testing for that case before now.

The attached patch should fix this. All it does is replace two functions, and in them replaces one INT variable with a NUMERIC(6,2) and a pile of integer constants with numeric constants (by virtue of adding .0 to them).

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMerge branch 'opac-tt-poc' of ssh://
senator [Wed, 9 Feb 2011 22:59:44 +0000 (17:59 -0500)]
Merge branch 'opac-tt-poc' of ssh:// into opac-tt-poc

10 years agoMerge branch 'master' of ssh://
senator [Wed, 9 Feb 2011 22:15:09 +0000 (17:15 -0500)]
Merge branch 'master' of ssh:// into opac-tt-poc

10 years agomisc work on the results page, including:
senator [Wed, 9 Feb 2011 21:11:28 +0000 (16:11 -0500)]
misc work on the results page, including:

hold placement link,
result prev/next page links on top and bottom,
edition and physical description,
add in previously missing filtersort template

10 years agoMerge branch 'opac-tt-poc' of git+ssh://
Bill Erickson [Wed, 9 Feb 2011 21:01:01 +0000 (16:01 -0500)]
Merge branch 'opac-tt-poc' of git+ssh:// into opac-tt-poc

10 years agoReduce hard-coded strings in Serial Control interfaces
dbwells [Wed, 9 Feb 2011 18:57:50 +0000 (18:57 +0000)]
Reduce hard-coded strings in Serial Control interfaces

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoallow item status update if either status-specific perm is allowed or UPDATE_COPY...
erickson [Wed, 9 Feb 2011 18:22:14 +0000 (18:22 +0000)]
allow item status update if either status-specific perm is allowed or UPDATE_COPY is allowed.  fire off related A/T events after the initial transaction has been committed

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremove duplicate variable def
Bill Erickson [Wed, 9 Feb 2011 18:14:51 +0000 (13:14 -0500)]
remove duplicate variable def

10 years agoMerge branch 'master' of git+ssh://
berick [Wed, 9 Feb 2011 17:29:59 +0000 (12:29 -0500)]
Merge branch 'master' of git+ssh:// into opac-tt-poc

10 years agoif no locale config is present in oils_web, assume en_US exists and is valid
berick [Wed, 9 Feb 2011 17:29:26 +0000 (12:29 -0500)]
if no locale config is present in oils_web, assume en_US exists and is valid

10 years agohey, maybe I should commit sometime today
senator [Tue, 8 Feb 2011 23:12:05 +0000 (18:12 -0500)]
hey, maybe I should commit sometime today

results page partly working. woof.

10 years agotweak selector used for font_helper() CSS classes
phasefx [Tue, 8 Feb 2011 22:52:31 +0000 (22:52 +0000)]
tweak selector used for font_helper() CSS classes

Makes the flat-text MARC editor respect the global font settings,
resolving bug

Signed-off-by: Galen Charlton <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Robert Soulliere to update
miker [Tue, 8 Feb 2011 17:56:08 +0000 (17:56 +0000)]
Patch from Robert Soulliere to update

Changes include:

- Use Test::More perl module to replace eval/die tests for initial tests (as indicated in FIXME comment)
Note/question: should I add an install of the Test::More perl module in Makefile.install for Evergreen prerequisites?

- Add a statement to print postgresql version.

- Add an elsif during "driver" testing to say OK to SIP driver since this is used in telephony section. -- remove scary ERROR

- Add UUID::Tiny to perl module list of checks.
question: More perl module checks needed?

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Thomas Berezansky addressing circ/hold config constraints, and their lack...
miker [Tue, 8 Feb 2011 17:22:00 +0000 (17:22 +0000)]
Patch from Thomas Berezansky addressing circ/hold config constraints, and their lack of usefulness.

The config.circ_matrix_matchpoint and config.hold_matrix_matchpoint tables have unique constraints that are intended to ensure that you have at most one entry in the table for each set of input conditions.

These constraints operate over a set of fields that can (in whole or part) be set to null, and thus don't do what they are intended to in most (if not basically all) cases.

[This patch] replaces the unique constraints with unique indexes. Nullable fields are coalesced into empty strings so that they can be matched against, and the index only applies to those rows set as active.

The included upgrade script cleans up the tables by taking each set of non-unique rows the unique index would fail on and setting all but the first (in id order) to active=false. If an administrator determines that the wrong row was left active they can toggle active off on the one that was left and back on for the correct one.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove syntax error from O:A:Storage:Publisher:authority and add strict pragma
dbs [Tue, 8 Feb 2011 06:20:36 +0000 (06:20 +0000)]
Remove syntax error from O:A:Storage:Publisher:authority and add strict pragma

Came across a line of dead code while debugging a related problem, and
noticed that strict/warnings wasn't in place, so I culled the dead code
and added use strict/use warnings accordingly (now that we no longer
have the syntax error caused by the dead code).

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCreate authorities that only contain controlled subfields (LP 712496)
dbs [Tue, 8 Feb 2011 06:12:24 +0000 (06:12 +0000)]
Create authorities that only contain controlled subfields (LP 712496)

Selecting "Create authority" on a field containing uncontrolled subfields
would generate an authority record that contained those uncontrolled
subfields. This would, in turn, prevent the "Validate" button from operating
correctly - if you added a 700 with $a and $c subfields, clicked "Create
authority", and then immediately clicked "Validate", the field would show
up as red.

Now we filter out the uncontrolled subfields before they get sent to
the "Create authority" function, avoiding this validation problem.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoEnsure new authority ID subfield is inserted in the correct XUL DOM location
dbs [Tue, 8 Feb 2011 05:11:47 +0000 (05:11 +0000)]
Ensure new authority ID subfield is inserted in the correct XUL DOM location

Addresses LP 712499. After creating an authority via the context menu
in the MARC editor, the new ID subfield ($0) would be created right after
the subfield on which the context menu was invoked. It turns out that it
was being placed in the wrong location, and one symptom was that the
Validate button would not validate the controlled field against the newly
created authority.

Now we hunt through the parent DOM nodes until we find the 'sf_box' element
and then we append the ID subfield to that node. We also eliminate some
duplicate code by defining a common function so that the problem can be
fixed in one stroke...

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPrevent authority context menu on whitespace content
dbs [Tue, 8 Feb 2011 03:49:36 +0000 (03:49 +0000)]
Prevent authority context menu on whitespace content

Continuing the refinement of LP 712538, if the subfield contains
only whitespace, treat it as though it were empty for the purposes
of the context menu.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPrevent authority context menu from being displayed on empty content (LP 712538)
dbs [Tue, 8 Feb 2011 03:43:08 +0000 (03:43 +0000)]
Prevent authority context menu from being displayed on empty content (LP 712538)

It's confusing to have the authority context menu - particularly the
"Create authority" options - appear for empty content. Check to ensure
that the subfield being clicked on actually has some content before
displaying the authority context menu.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMerge branch 'master' of ssh://
senator [Mon, 7 Feb 2011 22:45:29 +0000 (17:45 -0500)]
Merge branch 'master' of ssh:// into opac-tt-poc

10 years agohome page looks like kcls prod version now rather than dev
senator [Mon, 7 Feb 2011 22:44:46 +0000 (17:44 -0500)]
home page looks like kcls prod version now rather than dev

10 years agobasic search "works" inasmuch as it leads to a GET request against the
senator [Mon, 7 Feb 2011 22:10:38 +0000 (17:10 -0500)]
basic search "works" inasmuch as it leads to a GET request against the
results page as it should. not that the results page itself works yet.

10 years agologin page working (just for login, not the extras like "remember me")
senator [Mon, 7 Feb 2011 21:53:28 +0000 (16:53 -0500)]
login page working (just for login, not the extras like "remember me")