scottmk [Thu, 4 Mar 2010 21:31:55 +0000 (21:31 +0000)]
Create new table acq.cancel_reason.
Create new columns pointing to it in acq.purchase_order and
acq.lineitem.
See KCLS ticket #3015.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0177.schema.cancel_reason.sql
M Open-ILS/examples/fm_IDL.xml
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0176.schema.acq.claim_interval.sql
M Open-ILS/examples/fm_IDL.xml
phasefx [Thu, 4 Mar 2010 15:27:56 +0000 (15:27 +0000)]
When the patron search interface is spawned from the patron registration interface for listing potential duplicate patrons, correctly handle the horizontal patron summary setting.
scottmk [Thu, 4 Mar 2010 05:04:58 +0000 (05:04 +0000)]
Slightly rearranged the treatment of transaction ids so as to avoid
repeated calls to getXactId(). Also: when committing or rolling back,
return the transaction id from getXactId() instead of referencing the
session_id of the application session.
In dispatchCRUDMethod: Added comments. Renamed meta to method_meta
to distinguish it from class metadata. Avoid unnecessary lookups of
the class metadata. Rearrange things a bit for clarity.
scottmk [Tue, 2 Mar 2010 00:49:43 +0000 (00:49 +0000)]
1. Renamed getSourceDefinition() to getRelation(), since "SourceDefinition"
could be taken to refer to a subquery defined in the IDL.
2. In getRelation(): when returning a source_definition instead of a table name
or view name, build it in a single allocated buffer instead of a growing_buffer,
in order to save a malloc() and free().
3. In osrfAppChildInit(): Use and reuse a single growing_buffer to build the
SELECT statements, instead of allocating and freeing one repeatedly.
4. In osrfAppChildInit(): if getRelation() returns NULL, skip the class and go
on to the next one, since any attempt to SELECT from it is doomed anyway.
5. In osrfAppChildInit(): eliminate several unnecessary casts.
phasefx [Mon, 1 Mar 2010 22:18:16 +0000 (22:18 +0000)]
In PO Events UI, change Target ID column into a Purchase Order column linking to the PO View. Change deprecated dojo .getValue and .setValue to .attr in places
scottmk [Mon, 1 Mar 2010 16:21:08 +0000 (16:21 +0000)]
1. Fixed a bug in osrfAppInitialize(). After loading the method name into the
method metadata, we were deleting it. Any subsequent access of it invoked
undefined behavior. It was just our dumb luck that cstore didn't crash and
burn long ago.
2. Tidied up some of the white space.
3. Added doxygen-style comments to three of the functions.
These views are similar to the correspondingly named views without the
"all_" prefix (i.e. acq.fund_allocation_total, etc) except that the
return a row for every fund in acq.fund, even if the fund is not
represented in acq.fund_debit or acq.fund_allocation.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0173.schema.acq.all-fund-views.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Wed, 24 Feb 2010 21:23:37 +0000 (21:23 +0000)]
Created a new table acq.provider_note, similar to acq.po_note, but tied
to acq.provider instead of to acq.purchase_order.
Also: modified actor.usr_purge_data() to touch the foreign keys to
actor.usr when a user is purged.
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0172.schema.acq.provider-notes.sql
M Open-ILS/examples/fm_IDL.xml
senator [Wed, 24 Feb 2010 19:36:17 +0000 (19:36 +0000)]
Acq: separate LI note creation from LI alert creation; improve notes iface
Since adding LI notes or alerts takes place immediately, so does deleting
them now, so there's no more need for a Save Changes button on that interface.
erickson [Wed, 24 Feb 2010 19:30:44 +0000 (19:30 +0000)]
fetch user groups non-async to prevent clobbering expire date when group dijit updates with async data. set required var before it's used. don't require values in the password field for existing users
scottmk [Wed, 24 Feb 2010 14:34:32 +0000 (14:34 +0000)]
Add fax number, phone, url, email to certain provider-related tables.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0171.schema.acq.provider-phone-email.sql
M Open-ILS/examples/fm_IDL.xml
phasefx [Mon, 22 Feb 2010 16:41:52 +0000 (16:41 +0000)]
Net::uFTP dependency (which on Debian-based systems appears to need libssh2-1-dev and libssl-dev installed). Any volunteers for shaking this out on other distros and OS's?
erickson [Mon, 22 Feb 2010 02:59:34 +0000 (02:59 +0000)]
Patch from Joe Atzberger to implement much of the plumbing for EDI support. It includes
fixes for remote account handling, EDI JEDI event_def, an edi_message table, CstoreEditor
init fixes
senator [Fri, 19 Feb 2010 23:58:31 +0000 (23:58 +0000)]
Acq: when receiving items, require user to acknowledge any related alerts
Alerts are, in this context, lineitem notes (acqlin) that have a non-null
alert_text value pointing to a lineitem alert text (acqliat).
Users will be prompted to acknowledge all related alerts whether attempting
the receive operation against the whole purchase order, lineitems, or
individual copies. Users will not be prompted to acknowledge the same alert
more than once per "use" of the purchase order viewing interface.
senator [Fri, 19 Feb 2010 20:00:35 +0000 (20:00 +0000)]
Acq: complete improvements of receive/unreceive for lineitems and copies
When viewing a purchase order, you can now recieve and un-receive individual
lineitems or even individual copies, and the PO viewing interface will
properly reflect all changes (to the states of the PO, the lineitems, and the
copies; to the amounts spent and encumbered; and to the state of widgets that
should appear or disappear based on PO/LI/copy state).
erickson [Fri, 19 Feb 2010 04:05:00 +0000 (04:05 +0000)]
treat virtual fields and non-IDL fields different in the auto-widget universe. as a result, autogrid can sort non-IDL fields in with IDL fields based on explicit sort order
senator [Fri, 19 Feb 2010 00:41:38 +0000 (00:41 +0000)]
Acq: Towards slick integration of granular un-receive in the PO interface.
This adds good UI support for lineitem unreceive. The bulk of this commit,
however, is in middle-layer rearrangements to make it easier to keep track
of changing lineitems and the POs that they belong to in a long-lived client
side interface. In other words, when you receive an LI in a PO, the LI table
doesn't only hide the receive button, but keeps track of the LI's state
(received or something else) and shows you the proper controls in any case.
Same for unreceive.
Similar thing coming very soon for lineitem details (copies).
senator [Thu, 18 Feb 2010 17:05:11 +0000 (17:05 +0000)]
Acq: Minor bugfixes to PO search interface
1) Avoid a problem with floating point math when summing
amount_{encumbered,spent} in the combined PO view.
2) When redirected to the combined PO view after using the "split PO" function,
check the "show results as a virtual combined PO" checkbox for
interface consistency's sake.
miker [Thu, 18 Feb 2010 15:56:51 +0000 (15:56 +0000)]
forward-porting r15578: Patch from Warren Layton to escape "s in hand-built JSON ... should probably build an object and call js2json against it, but this gets the job done for now
miker [Thu, 18 Feb 2010 02:43:08 +0000 (02:43 +0000)]
Patch from Galen Charlton which:
Fixes bad call to array_upper() that causes ingest to fail if the record
contains one or more 856 fields. Credit to Lee Dickens for discovering the
bug and subsequently testing the fix.